From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D35C71130 for ; Mon, 7 Jul 2025 23:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F41F56B03CE; Mon, 7 Jul 2025 19:59:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1F776B03CF; Mon, 7 Jul 2025 19:59:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2FAA6B03D0; Mon, 7 Jul 2025 19:59:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D414D6B03CE for ; Mon, 7 Jul 2025 19:59:31 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 794B9803C5 for ; Mon, 7 Jul 2025 23:59:31 +0000 (UTC) X-FDA: 83639138142.08.CE62F75 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf18.hostedemail.com (Postfix) with ESMTP id 207091C0005 for ; Mon, 7 Jul 2025 23:59:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; spf=pass (imf18.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751932769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=bFalgedpEkjPW8NSCvwib174vChkNgn5SJrh9W7+Bvk=; b=PwNRhphuZ0bzZ/BAsDNez3k5ukpRrkt5nzcMaCaWoVOtOTOU/6kWvCUP2XX0h108EvzKpj VGrBb1hWTI3MNH2IzYwkgoQZLO4vhU4XXBOCPm59huzfqvoGsa8rmsDd1Ca6sDGEvX6DVG O5pq7JMasrTzbE1Rk3qQsCvEJ7tYNPM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751932769; a=rsa-sha256; cv=none; b=a3IL7lNTSvoq2cklJuGn80ikQM/rc+UklooxjnU+j4K6jGwyGFfOdsGqlHxJN9Ml4PaiMf AnDDrPFgOR7ZNvYPvkGBdludmrTV7y/wOfXTxS5JOv0sfmTzhx65Ogz2RVtJjOYN8Hwe+P eRPRaTPGZy5hSVeSUntBkh2wGLSf5t0= X-AuditID: a67dfc5b-681ff7000002311f-c0-686c5f599e4b From: Yunjeong Mun To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, honggyu.kim@sk.com Subject: [PATCH v4] samples/damon: support automatic node address detection Date: Tue, 8 Jul 2025 08:59:18 +0900 Message-ID: <20250707235919.513-1-yunjeong.mun@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLLMWRmVeSWpSXmKPExsXC9ZZnoW5MfE6Gwe8zhhZz1q9hs3jy/zer xeVdc9gs7q35z2px+OsbJgdWj02rOtk8Nn2axO5xYsZvFo8Xm2cyenzeJBfAGsVlk5Kak1mW WqRvl8CV8WPfCeaCdsmK5g7+BsYm0S5GDg4JAROJHR8tuxg5wcxTZ14yg9hsAhoSBw+dBLNF BAQl+h/PYO1i5OJgFpjLKHHkzHtGkISwgLfEwb+32UBsFgFViZ5Js1lBbF4BM4krRzYzQwzV lGi4dI8JIi4ocXLmExYQm1lAXqJ562xmkKESAn9ZJeZMfsoG0SApcXDFDZYJjLyzkPTMQtKz gJFpFaNQZl5ZbmJmjoleRmVeZoVecn7uJkZgoC2r/RO9g/HTheBDjAIcjEo8vAe2ZWcIsSaW FVfmHmKU4GBWEuH9EZGTIcSbklhZlVqUH19UmpNafIhRmoNFSZzX6Ft5ipBAemJJanZqakFq EUyWiYNTqoFRM2a3ykpJpRsbnrzdtjD5+P6TbxZ71orPW3zydFq853WOLc3vvY7NqX1w/lMS 1085hz1LLiU9mVVaFFW7x/r3ja7N0mfuaTA3PIrXXvfB4qdy5e5jtzOc4vtTDz59tT571q6m Jpa//78bb6ue+CGgXydJzuDLVL22BWkPHxnarm6M/vd5uu/uYCWW4oxEQy3mouJEAALfdpAw AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42LhmiGroxsZn5Nh0DPPyGLO+jVsFk/+/2a1 +PzsNbPF4bknWS0u75rDZnFvzX9Wi8Nf3zA5sHtsWtXJ5rHp0yR2jxMzfrN4vNg8k9Hj220P j8UvPjB5fN4kF8AexWWTkpqTWZZapG+XwJXxY98J5oJ2yYrmDv4GxibRLkZODgkBE4lTZ14y g9hsAhoSBw+dBLNFBAQl+h/PYO1i5OJgFpjLKHHkzHtGkISwgLfEwb+32UBsFgFViZ5Js1lB bF4BM4krRzYzQwzVlGi4dI8JIi4ocXLmExYQm1lAXqJ562zmCYxcs5CkZiFJLWBkWsUokplX lpuYmWOqV5ydUZmXWaGXnJ+7iREYSstq/0zcwfjlsvshRgEORiUe3gPbsjOEWBPLiitzDzFK cDArifD+iMjJEOJNSaysSi3Kjy8qzUktPsQozcGiJM7rFZ6aICSQnliSmp2aWpBaBJNl4uCU amA8uNWsNVD1pq3UBF6Dnd0tKWodFlsMpacfXZCl+8rG2KrisOG+0AluEwLenXdV0/6zNuVv DrPLimaZ6tkGudX9GUtfNE23YU2265RT+yrocmWOyJT/lyaKr1yozKn09dRqh9MCJptP758r 8zSHse2qlhTT4t16Gx88XrJh04LmGtkpCRNP1scqsRRnJBpqMRcVJwIAT1G90SECAAA= X-CFilter-Loop: Reflected X-Stat-Signature: 9ja1w94uczs5bw1yncwf6a8snm9teuyc X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 207091C0005 X-HE-Tag: 1751932768-140457 X-HE-Meta: U2FsdGVkX1+s/18q33YRDsUljYXWoQMJIRHadCHwTL/0jpMPU06ImXnrfdu9EjAnL+j7cNdTlMEduBW+Abs+qBNNfnzEjfo6QyP7bBFDoNcVcz8E5C4/+kM1dRA57uIgiaF4KzA+Z44mkN2O3F2JgY+ygiKr/Q7Fbvyw3LiBsO4xiYssSVF6Dy5ATQ/mZIIhQQ0j3aW3yFjS5d0aviCvOuhY9nFVMWtT62aeJbZVeJuw8rfDX/kpe6elxzfFMTYLPneYhhs1WLZraIrWJIOI1lf7kGek9ll1sx2Jw1Y0qCnTAPw/x+oabiI63KstZI53DvbdxC/gu8QTBxcyCXVpN2mx4e8KxgtusA6H7+pLgmd8+xWlynmEDd5knDUdn14n35c043ZEbJ2bc0I2O+YIZzRi4nW/FYPsGO91TjGGhHVTedqyMB6CM8tNL2hhPQ+zzt7sTGit9WNAxFMxQkc9/Z4XbJWeh3iQ+Ivo+qxIpXdmLLTy1DL+KuX5fblUUUi2fl0NSt3SBSAYn1xk4cNoK4uxlvn289Xbx4TZYQPyE8eBp8mn+3ypf4W3ZekoRLwK4NHD/I0gk80MaD+YJM4XAlkLMarqTxB+pu7xbKwC/gdGqjvA54PD3eh3O1jTtTfoWxOAvuum6JmrJButNC2IKm4t/dq6nOlPMkIv6CnxTKTXoepRLe0YKHAR2yDLL4+lIaVkIMutKcjeyRVKRuuqHMUdCRocSIc0bH7Jlup0xv5m4eewz5OPuF+PbNXkwdfbsBDZwXZMX9WoWhLCZJ4bk3QMzOljPilJ0nZ4113hg+1FKBVUxp9IrHkNRjGQ0WtKc0FTpNkwSvuPiO78e6vAkUJTgT/zZO5xvrCXRg7x9Mj3wNlra95yREm346Q71HNcdYxyvLwbYTOn538AKkrOoWyLo+DNaf0c4teewJjBk5bMl/WS8e+zqRatHkJiLIpGxYE67XmZcrs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch adds a new knob `detect_node_addresses`, which determines whether the physical address range is set manually using the existing knobs or automatically by the mtier module. When `detect_node_addresses` set to 'Y', mtier automatically converts node0 and node1 to their physical addresses. If set to 'N', it uses the existing 'node#_start_addr' and 'node#_end_addr' to define regions as before. Suggested-by: Honggyu Kim Signed-off-by: Yunjeong Mun --- v3 -> v4: Cleand up the 'nid_to_phys' function code RFC v2 -> v3: removed an unusable comment RFC v1 -> RFC v2 - dropped the second patch as the newly added knob is no longer needed. - added a new knob 'detect_node_addresses' - renamed the function for clarity: numa_info_init -> nid_to_phys - cleaned up code v3: https://lore.kernel.org/all/20250707023135.453-1-yunjeong.mun@sk.com RFC v2: https://lore.kernel.org/20250703074423.1771-1-yunjeong.mun@sk.com RFC v1: https://lore.kernel.org/20250701085417.1734-1-yunjeong.mun@sk.com --- samples/damon/mtier.c | 37 ++++++++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index f3220d6e6739..2513f0707986 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -42,8 +42,29 @@ static bool enable __read_mostly; module_param_cb(enable, &enable_param_ops, &enable, 0600); MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); +static bool detect_node_addresses __read_mostly; +module_param(detect_node_addresses, bool, 0600); + static struct damon_ctx *ctxs[2]; +struct region_range { + phys_addr_t start; + phys_addr_t end; +}; + +static int nid_to_phys(int target_node, struct region_range *range) +{ + if (!node_online(target_node)) { + pr_err("NUMA node %d is not online\n", target_node); + return -EINVAL; + } + + range->start = PFN_PHYS(node_start_pfn(target_node)); + range->end = PFN_PHYS(node_end_pfn(target_node)); + + return 0; +} + static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) { struct damon_ctx *ctx; @@ -53,6 +74,8 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) struct damos *scheme; struct damos_quota_goal *quota_goal; struct damos_filter *filter; + struct region_range addr; + int ret; ctx = damon_new_ctx(); if (!ctx) @@ -82,9 +105,17 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) if (!target) goto free_out; damon_add_target(ctx, target); - region = damon_new_region( - promote ? node1_start_addr : node0_start_addr, - promote ? node1_end_addr : node0_end_addr); + + if (detect_node_addresses) { + ret = promote ? nid_to_phys(1, &addr) : nid_to_phys(0, &addr); + if (ret) + goto free_out; + } else { + addr.start = promote ? node1_start_addr : node0_start_addr; + addr.end = promote ? node1_end_addr : node0_end_addr; + } + + region = damon_new_region(addr.start, addr.end); if (!region) goto free_out; damon_add_region(region, target); base-commit: db16fe88cdf83a1e7fdf75de282025b6ad61d08f -- 2.34.1