From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC07C83030 for ; Mon, 7 Jul 2025 22:06:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71AEE8D0002; Mon, 7 Jul 2025 18:06:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2C56B0135; Mon, 7 Jul 2025 18:06:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F898D0002; Mon, 7 Jul 2025 18:06:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 517736B0132 for ; Mon, 7 Jul 2025 18:06:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5CFDC03A6 for ; Mon, 7 Jul 2025 22:06:23 +0000 (UTC) X-FDA: 83638853046.17.F24DE6B Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 0935FA0002 for ; Mon, 7 Jul 2025 22:06:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Ja1XJnJ2; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751925982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=24ui3t+rwKJxfbKwDpGvCDr0arQyBRc+57B4RFBPe/I=; b=yPvCMMh5hQwhZ/FKpImllCxlpWUj/8Aa+kOh4QDnzxZc3qIm9OyqOpIMLWVTG09qk8oVuO +LRTzrWF/4RhGSLW6r8lQGkX0MM7TQIXIS36lOjCm8+QhZqLHAzHjs5kTcsXUHWTm9E6fS oDrn7FRmEhwbbrZWlLnhCo0SvB257ig= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751925982; a=rsa-sha256; cv=none; b=IVGNGJqUW3jws8DNfqdXWNIhI1cW2XrOPKt9YI0iUc9d5GKtjeRGuSWkUvy8bLob77Gewg bqGjC+0/dh9AS3ESCZnUVkj8zilVFGilSKL6aEQflZqk2D4+Bblgr7apZv7velfXFXY4td 7GaU80lKqPel5suAH+vC2aQJVZRO+KY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Ja1XJnJ2; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=24ui3t+rwKJxfbKwDpGvCDr0arQyBRc+57B4RFBPe/I=; b=Ja1XJnJ2vgxfuDJnWCze+C7vVN XyzH1yg4YjS0a0urFlR8LVUnvAmeq2y6NQ+ap2EdGeqkpqc9aGbcj1TFzT8qakjZIiFq/pdKmExOa XvZThPHGLTMWJNElJIpK7OJO0Ka1EgbosIju/yfnKUAINHGpB+2l7QJYLicC6XJi02QXjX2kNmPlp FC3BXhZgPoF7N/t1CVMUFS8WJQw5KHzWz3IdnR4UPTajah2j5zgIoEifeFaIz9Zr2RdyB8WH1yh1P DIV2KCDs0bk5V3/T+RwyrKl07P2JnQc5Zdlw0CRaOqTjeVPWp1k/+6og3xcikX8mZO4xYvKlyskwZ 1oJRF9CQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYtya-00000004AhP-1kZQ; Mon, 07 Jul 2025 22:06:16 +0000 Date: Mon, 7 Jul 2025 23:06:16 +0100 From: Al Viro To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v1 1/2] mm: zswap: Per-CPU acomp_ctx resources exist from pool creation to deletion. Message-ID: <20250707220616.GN1880847@ZenIV> References: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> <20250707201315.9497-2-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250707201315.9497-2-kanchana.p.sridhar@intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0935FA0002 X-Stat-Signature: mcy3qtg5xr3gds1r1erqebf6hsr63dqs X-HE-Tag: 1751925981-147724 X-HE-Meta: U2FsdGVkX1+pA6RQx1c8RIajz+CqIWeZ1+CCgToyUZ3myZNekCnHibisbuMa0kSRJm2s8MsD8RW7GCT1OENJ4AZo89oxA2VwfTxTkM74rEMck2ewoXzGyu092KsOa2GfgcZdtuBGVqLDt9aB6qxcAl2hnXtxHSG9hBiFupe0HhkyMNdLJUh9jP5IEF1UawWQZOSZxWlSvT/I5m58wXPkEXVcZKvW2TsRTg647eILrz/+wWN29s5BeTCquvvaNF21LFRto40kSCpQiEIc66RjyC5j9x9bDnkLAxfL04MThBPxtEd5QMh3M4FdLTvfdXUNVKu24XViGPfmkcrgwXTdEdDdEcbB3I+cOV4nw2zmqnDarJXuSCdjcwkfTh0tp4wbTiJ1pS1AUAGwoGKdlBtrepdtD20IMig4cUeIKeKGlZGKudZem38F/iGanI/OWLpBjtCcyaZVVdQ4V+b12n8w96ghRg+Dbya+qgmAxToupLd/xWVOAIrrV26TP/ksTv0hc61UUNiZMJdLEAwkm1T98S5e8izKt7vtzCNUHPt8onjp24bq3cTjV51zJCS9rEu5nRlN8uXVG1z80fy2Bm/I7ksS5bOeZfcjNG9xAz2vVbiWNATf6YNGTxnxk/apGJ22reOF0RdXBVO8Bv8E9HQ/vqT8IBVVQsSD7aYZWgC/B83pxIOFCYHM2oDd8HkBWmgptwWzZvxw1AOn/WvBjA3VrdxVXkJUX/GnAL27RWzm0tFb+6Ugb6EJGMEzxd8kYOqfEOdak6iZ2go2Ij1PIbEKX6kh4FTXTMM+YqyKzJKtaIzJXMvH53UGXCeGx52sa35txlWCVIWhAPAtUvcrJ79oyspCQnrCHvIhGO+tkKgkjha81FMCUROVZn0B2ww0WgcDf77nKUjPCUDa71gZ/ECRfYA9pT3ql0l1rLFJK0Qa6zN4mKf+24isaNjCyv4mO7SUXurFeFMiMS4dIUAVKax HStwECCN HqKg8Tk9HTIkr1hb2EaiQrlC9PUDMwuMiJHYHhfEXLuC2gpC8mAcIGN9Yp5yjNzYpCnSp4/JnaMu7mezN1CaeydHhzfAWQiZB20OpNFtwwDVJB++AzwVyum7b2wOEa8TS7B+u287SplqYcDjCksL3RgsoBLqMZkpofVirBpJRabOng440xAMF3tMTW4KMUUJCjl+7J4fsXbEoKwoQyETm5jQ0wXb589uYnFdTeSAjqKdruGE78K7p4xRIfuCYMfvkvN6iJHiFOInlnus3RoTr1SOrc7cQjimIcvA4gXrMpXSAlksDtisVcejgaG5rAxhPBCIYfT0tgwclSFEMJTDzh4/D2a09mEUfnNKqgc5Kv9IV4OdfZUGN+nsxQ7j/1i+60a5r3C5TY1hcSHS071ZMOG8/d/WbX8JIgwoYh7tCVC0KGg9DYAne6KBriIRDLpCcxrjtCj0/BqGuMkYC8T1DaJBjl6VDimzMzZ2xBanSspDZ5Zo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 01:13:14PM -0700, Kanchana P Sridhar wrote: > +static void acomp_ctx_dealloc(struct crypto_acomp_ctx *acomp_ctx) > +{ > + if (IS_ERR_OR_NULL(acomp_ctx)) Ugh. > + return; > + > + if (!IS_ERR_OR_NULL(acomp_ctx->req)) Ugh. > + acomp_request_free(acomp_ctx->req); > + > + if (!IS_ERR_OR_NULL(acomp_ctx->acomp)) Ugh. > + crypto_free_acomp(acomp_ctx->acomp); > + > + kfree(acomp_ctx->buffer); Just what are those IS_ERR_OR_NULL about? Is it IS_ERR() or is it NULL? Either has valid uses, but mixing them is not something you do without a good reason; there are valid calling conventions that allow all three of "address of an object", NULL and ERR_PTR(-E...), but that's not something you do just in case - there should be an explanation of what's going on.