From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24839C71130 for ; Mon, 7 Jul 2025 21:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9402E6B03DB; Mon, 7 Jul 2025 17:26:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 918116B03DC; Mon, 7 Jul 2025 17:26:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82E1E6B03DD; Mon, 7 Jul 2025 17:26:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 749726B03DB for ; Mon, 7 Jul 2025 17:26:08 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 10C2A14038D for ; Mon, 7 Jul 2025 21:26:08 +0000 (UTC) X-FDA: 83638751616.09.00B138D Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 1F3E9180005 for ; Mon, 7 Jul 2025 21:26:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=exVrMKRi; spf=pass (imf24.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751923566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SbbSL2gnYP1ZOYPT+NaWp7SxmNH2oSTM3KI/P52qhN4=; b=LojRF1k/RcY5xkGveuXhq8nJ7Q8D+ljT5FkK4LYeDMBK3Rg8Xa8Nix1uAvwk/GBG6jn2ng 6WMX2lx582Qr8nzo5h2ALks8EGfe434wCtdOJ89lp4WWHL3+X7lcYS7CGimOa9lYE9mTT8 j0XWhXdS92NfkzszKP4VWblsPxy/ya4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=exVrMKRi; spf=pass (imf24.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751923566; a=rsa-sha256; cv=none; b=MgLyWm0FLHkWjbufEZTEXpj8eV8BXmFCjCnmAX2TiHnAvfpeixJ4dQWoVRYGDP5+2Sslge +e2EhvD+CDJYZBhp5pc72JYLgZre8pYxdItkDcvRmaVCoRNxWBN9++jfnWlw+tnAKFYmlF yogki2tFo1PdR27Y5qlziYV8dc+ZTFE= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-e7db5c13088so2902549276.1 for ; Mon, 07 Jul 2025 14:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751923565; x=1752528365; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SbbSL2gnYP1ZOYPT+NaWp7SxmNH2oSTM3KI/P52qhN4=; b=exVrMKRi11Ighe/lGiuDt9k/YwkKc7zIj9+9vaVIug2cPNL/gXd/x/Qx2xHwT8Co0h XNR4uTxj2txny0OFe8JLrO1ldqHgBxmJbvmil2Ft1DOu5vuHbKAlOFxwD9NhJINbaFL4 GaPVkkb8BnSEa8r+G8gD5yQqTptqgy7ivmSOEqBvxFaIU+OQL2ZH0Q9jEoG6e8Znzj4r YyK14rZIhdPyJ+/j6WQhFtKBnbX+jmpHm1NYmfJejovYFKqvQ7c1WqOxbjOzGwtS+emg 9n1zn6vTekBzlPxpBBhPtztDCqH9rDK8SIX3lHXRlsdb6daqSekb292UUqOXGDrQKbMv o8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751923565; x=1752528365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SbbSL2gnYP1ZOYPT+NaWp7SxmNH2oSTM3KI/P52qhN4=; b=JXIGa16RQoKyw5I1xIV15OyfKbO75P4FE/+BZBHA6edlbRYbX4y6pQ47qLOKzrTN6H JxaZ7iBcBhndAI2o+NFxnqFgNMOSs0pGV/dXtp6jsboQ/vA9eeBhAdrplbYYSA7tVHhk 8NGkK/VdRO3sSOn1MGDZScRPooSqXbJ+NmjfkDBHTlkGsfs1a1nVY5/gWqOQFoXKMM4K 6TGevGY3+lorOBAzHl+9ioiQ3EG56ilUFwUjrtUpXpW8m/g256NMeDPJoGGp8MwbCpP2 U0RwQuW4lh7xd0wPwBNX0IILp12ay8skmrTQQk2Zv9exmyuo+OxzhqcwiLC9XFy8yuxY e8XQ== X-Forwarded-Encrypted: i=1; AJvYcCUPgr5ArJleujrHDvgDXwJXcIRhugLn2sqD/uGAuCPnOhxyxpk9qQnXDDgmBDKSmLh+o0bCuWkDnw==@kvack.org X-Gm-Message-State: AOJu0YylJ2lbDgUd6gI4OibaRRVxtvZ3X9F5KawGrWwhcr1Jy/TWG7Fd r12V5o/qL5+V1Omf3Vr2gW6jW8TB6u34kw+/WRAu/jmqUZVL4c3vrOPR X-Gm-Gg: ASbGncvRAcvkkKmx4PNMk/AK5tnst6BndYqDK3O8wtLEDQn6TbiLSCXBCYYkIqHYA/h Wp5A0AwzZ5TiMGTvjOPFF7Bnza2aoVSZEMuaUbz7cE/sd0Kf668dgCSWgH73KgDsKPYXUf8BvIJ yyofpNKjQKeA2Pjqkn3A/662LH65OWckZw8xRKYPyjZD/gCyTO+QRMrpLcBShc1FN38Z58/NsBQ k0E2I5mcYqnq14GZP47hISzjneEc9vz89jFl66A9LceYQJYEHUVecqVgOJatQizQR3jJwmyjk7t 9sF4Oe3ttfF4ay1xfm+6se9tmIyy/TMmS3ujXAGO1qjylR8TFhBse2GUmD0+EQ== X-Google-Smtp-Source: AGHT+IE1rRBv9SKsXDVizGCcX/MQw3UTZ5ltGVPismkBhKYtdERManKJQ/zdQSzimtEoGONGeK3DIw== X-Received: by 2002:a05:6902:c06:b0:e82:3cdb:7e9e with SMTP id 3f1490d57ef6-e8b62a13970mr319297276.3.1751923564967; Mon, 07 Jul 2025 14:26:04 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:54::]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e899c4b782dsm2890852276.57.2025.07.07.14.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 14:26:04 -0700 (PDT) From: Joshua Hahn To: Suresh K C Cc: nphamcs@gmail.com, hannes@cmpxchg.org, joshua.hahnjy@gmail.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] selftests: cachestat: add tests for mmap Date: Mon, 7 Jul 2025 14:26:02 -0700 Message-ID: <20250707212603.992104-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250707152557.49877-1-suresh.k.chandrappa@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ott44coyqw54qzsie1kp5ujjxjfhi4fy X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1F3E9180005 X-HE-Tag: 1751923565-956671 X-HE-Meta: U2FsdGVkX19yIBVZU6v+cHGjnAQ8im9EgZQ0gWbJtAh4mLV228qgznpJfYM7lVOhMRQvgTlAPzU4V3TB4Sz7/+IF6Rmc1N3s/6uoSv/uhcE21AUELMQ/SKmRSvMFOaTaYAnSC+xEo116ksrfIJaSHAX4QD4XSVKYHJnazik7/pColV5k2I4CgYA5BwWFTGMxIkhXBrwJUagC51QX+4kCeSCpcUtMM3qxURcP9mi58XBMzN6zHOQEbfyUxKbIehd6o2c4upFL6zKk+FM2I4QAvYe8cf2gq0wqI1Fu/wEOYwp5WXDwWGSztYsmA5E2Uw9sNTPJXr8tJ2mzA7twDFYs4b1obeSG2iZtPVxg4267KDvDryQyCdJI7km66htlvzNLrdTNQJvfVdmBYVTwKJrziTRbJV4yJOpVs7vfNakztjxwh1ECC3zUIMWX+hS+TODb/eHQN63NGjdu4zMnQly5boUb8WGC2vMp23UK8bkP1TZdj+3DV3nkdM7GgZNN4COkVLqzbQhAc+ysvi5xvkWjZWyW7WY6BWx79lR0/JnoGgKlaTVlUCIlJb9A+5MTV+Ug9eXOn42CsBCyOOrlm45B5IVVkATGyK6P7VFkvS9EfGfOyaCTzXH4CJYJTnSonpHY7l0ig5E6EoAAsg2mjUCT2DC+Bb2hEH8xSX0ojEbaAaxiBKYgI4uma2FmG3WApArfzurMZHFVx4FLRtdtTdCdzpKy6XvpLr1rpLM/XyQ4myNJX3nFWlt+oSujyMWnUTS4AOiUqnc6f7FbCDWlLcQwO0vZnYamTXepC/b61B68m2KS5FFnP6xQ38Fz7qsMuJA+ODuPr/KlSmpgdJc1+MJ0xiPhGE3cCPy78CiL3QyRuYMC3tvWn//teDQN9bads2kAIcH8syP6eu0YaAfwn5ZPMzWnWGncI0q39WtaG8fUtSeqUaT7Im3K/ptCP56iMQxnXbI5kWqLPYsty6XKRqs 0J8Jwpm+ L9VLmvdO7d2HC81KBbzoSCusqAOts4eiALJ8Bt8AJ6RchCQnHmDfbXHJAzWddLA5ryquzRJiChs2pggQj7CJAK8Ki0CPe45/XzJpDtqW4KKM5YUxJF7aQQLxqncseO4+yH35Kgib4rrugqyzDlb15KcF1vSAgNrbnheLagV8+zYwELGh8+bRTS+FYfC9WHtYwynRxfmgyIz80A0uCmWz0TCMvG66ukqacGVCakmulTcY5qCsLT7Sj2aK6Vg0pn/ElVWYCfagQZ3z0FK6eLaMAyauXuzsvnZ2hL6mhkpYn17UCdyYlvXin1B+TxKd1cm6g0SKJkNt8nhpE/jhh0stZu5o5fTuZMiUvUC0gRsdlzkFpOR3BmzI9P5tHdYoZ1EvnRXIzcQ4N1fIRHTJK/mGKAnmcYL69P80OmxjuzqRS8bmQ8OUpJRrYuJ+rL+1icBephC94eoydFZNhnVnyCmM3+kNaL5Y+p7SDFp9biio12ySI8p5ebpzyvfKJmrykar4IKaPOEXBd9fXXnAPhDegZy//DO22pPfO4KoS5SE0H6dV+saE49SwlyWU+8U8xKYpXMpmnngZJE9PeCfGofSV2Wyzw0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Jul 2025 20:55:56 +0530 Suresh K C wrote: > From: Suresh K C > > Add a test case to verify cachestat behavior with memory-mapped files > using mmap(). This ensures that pages accessed via mmap are correctly > accounted for in the page cache. > > Tested on x86_64 with default kernel config Hey Suresh, Thanks for the second version with the updates, sorry that I missed the first time you sent this patch. [...snip...] > if (fd < 0) { > - ksft_print_msg("Unable to create shmem file.\n"); > + ksft_print_msg("Unable to create file.\n"); NIT: I saw that you change this in the second part of the patch. However, why not just include it in this patch? I feel that it would be good practice to keep the kerenl in a "correct" state, even in between patches belonging to the same series. If someone were to just apply this patch but not the next (however unlikely that is), then they will not see the description of what file type they failed to create. Just my 2c, no need to change this if you don't think this is important. [...snip...] > + if (type == FILE_MMAP){ > + char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > + if (map == MAP_FAILED) { > + ksft_print_msg("mmap failed.\n"); > + ret = false; > + goto close_fd; > + } > + for (int i = 0; i < filesize; i++) { > + map[i] = 'A'; > + } > + map[filesize - 1] = 'X'; NIT: Likewise, I don't know if there is a good reason to include this, only to remove it in the second patch. Perhaps it would be best to just remove it in this patch, so you don't have to delete it later? Please let me know what you think. Have a great day! Joshua Sent using hkml (https://github.com/sjp38/hackermail)