From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5E3C83030 for ; Mon, 7 Jul 2025 20:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9B406B03FB; Mon, 7 Jul 2025 16:13:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFC856B03FC; Mon, 7 Jul 2025 16:13:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D986B03FD; Mon, 7 Jul 2025 16:13:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A18106B03FB for ; Mon, 7 Jul 2025 16:13:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 195AB1A0333 for ; Mon, 7 Jul 2025 20:13:23 +0000 (UTC) X-FDA: 83638568286.04.024A436 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf14.hostedemail.com (Postfix) with ESMTP id DD90910000A for ; Mon, 7 Jul 2025 20:13:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IbjqeePn; spf=pass (imf14.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751919201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdSRS/jI9tTiS6RsXx8UMW8q3siZrMOFPCPyRSBav4w=; b=3bt6vRExrlB8vwSQg0ahO7KyTeqkwNYx/GWBT0NjE0yVlICnxBdkJ/dNaRm0incMKzOTqt QQemM7DOEI1TZboizNYWafEoivQYARXAuZ8V2b6j3BZfNvqTUCdU4RR5h7CH6IXdfdC556 U54t33fnqdRWU+JWpshhpqmhcjNTIFk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IbjqeePn; spf=pass (imf14.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751919201; a=rsa-sha256; cv=none; b=7v1xy6l7KPMsk4YZN6nMBfW43lECSsXWajxzAa4e7FnqTONoi8p3QqprXNkjiI1Rjdeg83 qXKi0NT8o4TUnfP+lppre1LrjALz7C76vytOEgo+8an16Ne1pWKvkdyabsQ8IeXCmUTesI OPsu++8UV71JlU/jHZDTUPLwE9005OA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751919201; x=1783455201; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ny6c289FN8Mu76v5QsWEeh4OjqoLdbJ0bsZ28vVAQ60=; b=IbjqeePnrXfHMMZY/R6dLlRHACowdfonOs8VShDDp3l34w65rS+uNHcU wdZ1VVSAv7AtEEYF+1zCZcKTsWvNKxkUcZ/onhoWSyFb0jfSsTPR2FRKV USxezbbpXtnpYWTyzJ1DdAq7aiba3/dayjhj/NWBnydrAlRFBydjNHE+/ FCDsl/ht82Su/uVt0uRExn3Bw1FlRhgmOdQlT2uW9s6EmXQNRdkPxekGH Lfn3/VwErEqnEwhGMq7NCHsykHe/IlRky6PKYMcGABA450yH6Qs3PQ/ne eaKP6fzpnyY1jvDRxIiKl+cxQqY/u6zHCTC6Rn48jPIZUZCARoXqiNxPx g==; X-CSE-ConnectionGUID: 5z//xs/kTfK2GTomjnA1lQ== X-CSE-MsgGUID: DTnCrid/Sh+TD/69VTGg8g== X-IronPort-AV: E=McAfee;i="6800,10657,11487"; a="71729819" X-IronPort-AV: E=Sophos;i="6.16,295,1744095600"; d="scan'208";a="71729819" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 13:13:17 -0700 X-CSE-ConnectionGUID: kBtRISmtQyulWJFFL+fdlw== X-CSE-MsgGUID: NXeuO4r/Q/SzvBJwMUsyMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,295,1744095600"; d="scan'208";a="159343033" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by fmviesa003.fm.intel.com with ESMTP; 07 Jul 2025 13:13:17 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v1 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. Date: Mon, 7 Jul 2025 13:13:15 -0700 Message-Id: <20250707201315.9497-3-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> References: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DD90910000A X-Stat-Signature: ou7wca8k499hsk31jizcbus734r413cj X-Rspam-User: X-HE-Tag: 1751919200-953599 X-HE-Meta: U2FsdGVkX18LFY9Nn9X419FjuqbymMX7e2TOn9OhjDjhdUup9eqHacuP7syQqpTyc6wCsdpZ3WBtJ3p4cH/EeS7uaUU8uyMTa5ikbUiYwAwIDgPVi7nV65zecQUGt1j3O/OnCJImi5NGbAeuzXch/0v/p4uy5uNdjbZN7yYsGDCLfXemnnEZuTIIU9vJYAdsmw3qaWB16GKP1WEoKQYTw1rtTGAfqmUdSTWl2e47szUuaxuNZDolZKePKmrCRRjnta0ojbqhpfPO6VecCydJG0DILLe5K1iLIBNXvTFqP2FNLyrMA7QMkxyBuSBC6z8u67M9zkVd6LC/wHxRn+8NKN3K/Xl+5ewscKSTAZsKzJSN35KXJklWmLP5ZfKzlrMzLX3tS95aI4EAqsQHWaALYJZFBSI5oxUNixPH+RKjpVjOzNVsHPqeHgxdto7WYZtoXkry9LhL1MsuqQgCp5w3UN9nVDDiseZrM1OK6OfJ1pdNFJ6gEbG+n7+BovArWe56lYanmOV7m7D7N6aqZy06eMSZVFzs05Bzuc420p9Agdb02hEetPgrhA7ZMk5xYDX/VyS/80erO2FpWvzSQw2gNtCH+QJTiB6egQ7bk/+MTf3w45M3sPujPthlhTs8WuoBZSDY3mrtXPk4o44pn52nMv9+h/U8oNKaXYPDB2BgM9+Z0yC89xuG8SIsicSoCy25qy46EcMT91S8bISmBjMZw/rS/Y/o7qrRDPjnUke3gO9tlkQmuhXhk4HcAhwVIub2/cNjLKd/iLRm9EPBiA6Vlv68p+MryfHjTmTDjumsN9OJTbQcRknAHE/cBPkfPWYNNJnCQdjVGrWjMPF4VifusHPIsz+Z7WdmsczSUw6o+/89JlKRf6NJ9gL+yMXYW07WSm0lVX709XRIAiXvgR3rXDsAqG6Shc6qshrhxiQ0wVTtGmgNhQyJDgoAIzVgNnCIZKwBnP9gQDE9Ej+Rc+v 09YAOS+G epK4PWVakPvAwwEZ5G2VQXasANk1A6eU18cJfv/ytrvHsQJ75ls6kqN2efuCNt5IIgPnQ74Nc86OY9rG4eGr4z5STYx13nLJN/z+uVGXgxOaoHPtRHH0I/mIKOwSbiEG5QecOvvKQ5rvn/lQu1QdLSgE8cTA5xRZQ71Ekr22DA3JujcI20SFI+JlRZr3Xr0em63By X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch uses IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check for valid acomp/req, thereby making it consistent with acomp_ctx_dealloc(). Signed-off-by: Kanchana P Sridhar --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 7970bd67f010..efd501a7fe29 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -893,7 +893,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) return ret; acomp_ctx->acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); - if (IS_ERR(acomp_ctx->acomp)) { + if (IS_ERR_OR_NULL(acomp_ctx->acomp)) { pr_err("could not alloc crypto acomp %s : %ld\n", pool->tfm_name, PTR_ERR(acomp_ctx->acomp)); ret = PTR_ERR(acomp_ctx->acomp); @@ -902,7 +902,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) acomp_ctx->is_sleepable = acomp_is_async(acomp_ctx->acomp); acomp_ctx->req = acomp_request_alloc(acomp_ctx->acomp); - if (!acomp_ctx->req) { + if (IS_ERR_OR_NULL(acomp_ctx->req)) { pr_err("could not alloc crypto acomp_request %s\n", pool->tfm_name); goto fail; -- 2.27.0