From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146D5C71130 for ; Mon, 7 Jul 2025 17:17:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71FFF6B0402; Mon, 7 Jul 2025 13:17:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7CE6B0403; Mon, 7 Jul 2025 13:17:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60DEA6B0404; Mon, 7 Jul 2025 13:17:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 517EF6B0402 for ; Mon, 7 Jul 2025 13:17:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0E0F16024A for ; Mon, 7 Jul 2025 17:17:41 +0000 (UTC) X-FDA: 83638125522.21.F6F91F6 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf22.hostedemail.com (Postfix) with ESMTP id C8D51C0017 for ; Mon, 7 Jul 2025 17:17:39 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=i8jVQ4YV; spf=none (imf22.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751908660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KlMSQW5CMg3CMcgvZxr8OnxCx9OPgSqTzOTGBORN/Do=; b=Z5di2mrbGk0v8x3y7nN/j/xzkRxolrKgbqWUmvRdRRhFFAOH0NtYJHs+YN/v7CLpcS9ire K4uE3B0POeGtytBPxx5zEH7oBqkhV63j35LRZ+TIqSQx1f1LbQ47IbLhHej9eMJMGFBnOq 1V4eqbd/H/rB1Dl94UL78703Iz4ders= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751908660; a=rsa-sha256; cv=none; b=52hqaSb6oZ89WeQsf66n/RJ+sbr997gGKQTyDfJNMcrb0kmCLS0vlIoWXW5DPV1lwyJ8kG Xk/IWti/l3GkjaoggwUMKzyMphclp2nOeg8q2syX2Av1fHNlA8xHvEBwAllxaEyuDBelHM DcerDLi73r2947l2TuyfGJkPCMGp3hU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=i8jVQ4YV; spf=none (imf22.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KlMSQW5CMg3CMcgvZxr8OnxCx9OPgSqTzOTGBORN/Do=; b=i8jVQ4YVsbaQsvVtjFiunwTVjl EPJYqjOb3e9RPn/UJBKWrwzf15hhHxpHjBTkebB/VclPyBa8d3ZBsZ5z+nbWbV2ysb+9SKmL6pEW+ 9eT6RGCOSkKMITkP7CK/O5db+nrvzuK6BnwxmecNWdN+r2u2CuywAWQIkERlKVwov5grtUdnAxlLe b+TxpwCwAgtV04bAmz+iA5a+pvTCAJCo3w3F14j58VDCH4CV7O1tFGXfukZrQQDtczTPzD87yDW3S Od2zxiPJCLCjvkbU8yxzFrX+Xuq+RNZ30ipWLu8zdYNyfSnaCX5qGpAN6U/Hp2iIrEDG2R52Q/MaT X2YSfrFg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYpTD-00000002MeO-0qFw; Mon, 07 Jul 2025 17:17:35 +0000 Date: Mon, 7 Jul 2025 18:17:35 +0100 From: Al Viro To: Christian Brauner Cc: Jens Axboe , syzbot , jack@suse.cz, kees@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Mike Rapoport Subject: Re: [PATCH] secretmem: use SB_I_NOEXEC Message-ID: <20250707171735.GE1880847@ZenIV> References: <20250707-tusche-umlaufen-6e96566552d6@brauner> <20250707-heimlaufen-hebamme-d6164bdc5f30@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250707-heimlaufen-hebamme-d6164bdc5f30@brauner> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C8D51C0017 X-Stat-Signature: 156zuowxg5pcmo1yizat9thugacwajon X-HE-Tag: 1751908659-865048 X-HE-Meta: U2FsdGVkX1/xjkZh13oJ6gcRXyIPYzotJyjcn0Fi6AcI6tKNjieEjHtWy3egyjSmNLzs34jHpti06Kw7FJdeMlHIVH7vpXA4kApY4XmWXAFAKs/H5x+qPBexrzY6o9CMbp+Pzd4UuH+5KNsfrj2XCEA38YJSuO6IIFS6+VYPIT3wlQUVui8VzsyFkbpVetP9zQbWUc89+m8APqxHX/5iMC2dcp4K9PtF4j/ZL+Jkg57ZZmsfGb7kW+/wpgvxQF6RYGz0HBH+0E9nWrtsTTtEtvUPX4SQPu9rQThH3LaUw+lAnSwTS29ffMs2HX+mtWOU6AROVp2rdJkz0eNNEHPKX1A/N/cR0LTDKV/avcPtdFZ0PWjh/ct6dawUD1n3iOpLDiQgyS8JDnIG/i6k1cCcVZHCVu20adX64PzJ+bh3LGP8gzqCxeNA/rvvspSrhAyIkaZj5eXzZbqR+FVFLBPkhFqO4a4meCn0q3ZlLISDjpLQAJCclRPpuTbmmiYQx+R9GR4m2fSfTzQboi7tmJZLbLGUane38JcovOUgBOCNMhuAtp2em8kBRn8ldr6Xzn9/zVvgWT/sLJmTKhX6BrAdKVpoFUnyX7aGtDVqEvjbzZVobdh/4uhtKJy70eLdatdH5WQf2TVbymwJp1nFPGDUrStKtSvW30rEMAG422tk86St539h+5OJ0TslaqIiItwlwTjtGOTH1fOowjVSi8SuB4lkWgcwJ3nEKFhJIiJ4HKUqU7odAKH8JDEY2wXpJt1LDnqhBDPSq9l6YS/Rh1L8IgbrOvh1vn0mNZZqD1X0AVDevFSnIPEwqhAPKrsmFUBT1rYmaPb3C74cfc3Qfg5fLDBp8w4n4lWXTH4KRQYvf6gUalSR/ejTCWAX/qv7NtRv4gTem8M4a8HWcheb5Q4U2WElQYeU+x6DOlq9lkbNyNkMok5EW5HAGUuul9DoJ6U9sou+g0GYnbh0nIS+Co0 cuRN2PPM fqRHJo2eRkDw/B+RR4a7kAakqR9K5zawhGq2l6ZY+pkB36x6m5A8on9ZpMokzeTFiF0maVouqhFglNnuB1Jp/uWWbSvmrV35fGmMwrprW4UlSQf4W5ClVZGL9IgpMPCluW6OUZs90e+JYaIr3l1IQ1GlDC0IXEWcGvXPsyGDDocZGqCYmvtuGQvLbfo3uojnbrcL7fvLOgO7440UD3/NS5xWBi7AOx0BW20oThz5hGkXy/zaEtZWPovE8LmQOf1BGu6RqWzDMAFWJPZ8l40nPCNzTcOZ9tqJgFh3xZGPJUcE1qwlk806BdazV0TI5JzxF7g+lCBgfCvPHzm4CNeZ/W7FzG3XnixasRHWdeMcDmcFJ9mfsbYskT0JyhEChcp22x6mk/OkMjZ8nTPrv05+G6QrrQn7tmVL/4G+yo2KIebdE7Y9bSLcZEj13RxM3Td6NnNC3OQyqWJvklSpur63wP6EF4OzNbxhwgWjBzK9ziPw9VhGHM547RkvMrOjtlAB/1zHLtq6NAH9mYEypE9GSUTgdCgojgBWXpyqQyJsRomNKHPA0DYv9tGbMoh/tSy+qF/icJS2Rn6YbJJI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 02:10:36PM +0200, Christian Brauner wrote: > static int secretmem_init_fs_context(struct fs_context *fc) > { > - return init_pseudo(fc, SECRETMEM_MAGIC) ? 0 : -ENOMEM; > + struct pseudo_fs_context *ctx; > + > + ctx = init_pseudo(fc, SECRETMEM_MAGIC); > + if (!ctx) > + return -ENOMEM; > + > + fc->s_iflags |= SB_I_NOEXEC; > + fc->s_iflags |= SB_I_NODEV; > + return 0; > } What's the point of doing that *after* init_pseudo()? IOW, why not simply static int secretmem_init_fs_context(struct fs_context *fc) { fc->s_iflags |= SB_I_NOEXEC; fc->s_iflags |= SB_I_NODEV; return init_pseudo(fc, SECRETMEM_MAGIC) ? 0 : -ENOMEM; } seeing that init_pseudo() won't undo those?