From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D71C8303C for ; Mon, 7 Jul 2025 16:15:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8809F8D000C; Mon, 7 Jul 2025 12:15:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8311C8D0002; Mon, 7 Jul 2025 12:15:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 747508D000C; Mon, 7 Jul 2025 12:15:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6615A8D0002 for ; Mon, 7 Jul 2025 12:15:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1E1851A01BF for ; Mon, 7 Jul 2025 16:15:43 +0000 (UTC) X-FDA: 83637969366.17.F2B0DCE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 76D472000F for ; Mon, 7 Jul 2025 16:15:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mqD1DHpZ; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751904941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/R5Frs8GEcFwt9RM/zV5uL6cmw3TfWvu9alc0Y077Do=; b=KAr2QqnELsjWQRz1XPI73LC0bNhQF10aH43bt34y+H7kuy6mIfIsmKVKDEQU6MAEo6PeJb /c0iU7Ces11+F1jTZl+nTQaEHa4Y5r4JFtpLYYbSbxSQfUsyS5J6cX/kpN6/C3PYBWXA/i Xn1WhJetluIFeXFpgxzE+l3VautH1qE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mqD1DHpZ; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751904941; a=rsa-sha256; cv=none; b=p3CgeUqFIB+OPm4KG+qTeLg9c9zqXNJaJQm+IkyoNONoBLB4KiVezIvpbcJNWanZG1+oO3 Nq6tRbQMeJUkXtXtaU5CtS3jXoAaZKehIsygdUah6YCnlsZrYHZzq5suICs4h8zmmkBBN2 XTnnZggBpWquO5uEcOD3UrdDkUU+y8s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 554B25C3BA6; Mon, 7 Jul 2025 16:15:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D63BAC4CEE3; Mon, 7 Jul 2025 16:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751904940; bh=7yLfRRZIuWWLkhAeslLkA5j4KcZb4nkaXOKL3vU1+pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mqD1DHpZ5CBoO/g2CSzNfYGNMMMYeP4rBSittZV5+TGxFOiAL171Anngt0jcGhhgS 8YjGL/U0h+1Sc6wTRi/snES9C4oWNhoFLC6ia6T63eF86gZsFwDc1ez+CkYJURRId7 xPv47/YVm2XQWhRZOae5s9ZzvvEgrN5nsp5A1yUVeLPeZBpWJUvh9NW/sIURDPVnWH TGhBRNWocgq2ErEPPPf+CbrXla2ynVksBNNU5wJp8ByLa/BHu5UD8kzjvn76ux2Peh U8A3yfzzN0g9Ga759VAOxH7OoRoLmVVHIJnwLO75v3EUU1nTO89qWtb6ADjTAU8Y/n SCoSfJHg9O4qQ== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , damon@lists.linux.dev, Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com Subject: Re: [PATCH mm-new] samples/damon: change enable parameters to enabled Date: Mon, 7 Jul 2025 09:15:36 -0700 Message-Id: <20250707161536.85426-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250707024548.1964-1-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 76D472000F X-Rspamd-Server: rspam09 X-Stat-Signature: rtom3y9rpyjgd5csf1j83amuuqa74unk X-HE-Tag: 1751904941-497394 X-HE-Meta: U2FsdGVkX1891zs5r1O3E7/qrmMWD+QWPPhfT+XlzKwD4JMnLlvcbaz3AGnZMQQQ8to/YuH5yBkTxKGbOuAr18QjWFRK5KhZW3/rJ024Xs9sfM2knGNDt5rmjRbSp5+l6mqSUjARa6NHNKzEjBEvIagfUwWVEKWxDV0DfU9J2x1flJwzEXuR5IN9HLSNDUG8qMIGU9z9g1h044fN+0yhmfoFrp+mkELGGEqrchR63gsSMtZMKMD6Vj99jV17NQLSyDKi4FXX2RmxCelBvnQ4M5x1SLPeB+n/VccDMAV/KSJX9OHELI1Y/tT+ZmqYqhUAIYgJtSheC9lCVJAHUsngmezQZBTadE0E91nyKWn94Nw3u5d5LV+UBRc74mY3v/94uXu4z3mmJ23AgmwT3NOMJeOjpYEelk+iA87CtUxxI3EExWPXRULB3mrzxlQ3ds406V8IDc5lh+m9534+rjF4Cz98hItqvr8PnKD0j0KRfju4OGJK9As1rDtk49DyQbBElcYyfF+ou8pf+DvgHqvSGrJvoNhgm/Nov7eaQPRp5xB9cJO5GFKpldvEzAQrFLErLn7hwEwCI2wW7ibICy8xJunASJncMn47EAvmke1P1KEggue+O0Y4ZuQymc28/9IdhQKeLZzefZDJ2wqc1KghE1bw7CSS/LsBRobURo5rUhW7i6Q7PY8qnGn05ZfwckrQLh0qu3Jh8ivhdddYcjwIOn3KCFmVe5SoUoN9CtEbPUHOIvxld6uFburvX5NCY9R08nO3MRFud5A42ESXsDTAHcflekd/2JyhcIQr4EPn5hNMoPhRU3Fna63dYQx/kASlsaIQMx4kNAg6X7EuFaEYlvsEMU5u5wPajf5zCPaaIsQRn6/HCSnL+Yn4fviuj0DkzO0zkHKtts4WO8H9Go+XOw9YIFO9o0sFZLnOfw9T+fl0dQjUf4pKSnCZSctqDI1IfzUd5/7/v8YfDlnP8y2 W+CsWqYi uSaYAg4sEV2nFjkZ5jYuOk2D6jx0j7owOsn6llFYRXVea3RiSm70yxNMeW2xaB7/ONZGD1m8NEqmrJA2//ybDiLtzb8DJ20q8R9jPg9GCoUuk2t0DgBfnuNraIm9cUeKrZlh1AEvYYHavuwDr/4zFghKtUWxnCdXJFEfWLenEGz0lVGW9fVq9iWed7TKss3jW5KV49Ho+e8xcBp9CPmExbFLjqWz2NISQLBpmBTYDj1NoK7+2Q3XsOOypuW+J4CqZV7hFBhPTy2VozZOCJ3OT51ncmo4qs1u4uoxm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Jul 2025 11:45:47 +0900 Honggyu Kim wrote: > The damon_{lru_sort,reclaim,stat} kernel modules use "enabled" > parameter knobs as follows. > > /sys/module/damon_lru_sort/parameters/enabled > /sys/module/damon_reclaim/parameters/enabled > /sys/module/damon_stat/parameters/enabled > > However, other sample modules of damon use "enable" parameter knobs so > it'd be better to rename them from "enable" to "enabled" to keep the > consistency with other damon modules. > > Before: > /sys/module/damon_sample_wsse/parameters/enable > /sys/module/damon_sample_prcl/parameters/enable > /sys/module/damon_sample_mtier/parameters/enable > > After: > /sys/module/damon_sample_wsse/parameters/enabled > /sys/module/damon_sample_prcl/parameters/enabled > /sys/module/damon_sample_mtier/parameters/enabled > > There is no functional changes in this patch. Looks good to me. But, I cannot apply this on latest mm-new. Could you please rebase and repost? > > Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park Thanks, SJ [...]