From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D738C83F07 for ; Mon, 7 Jul 2025 14:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B80226B03F7; Mon, 7 Jul 2025 10:24:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B57916B0404; Mon, 7 Jul 2025 10:24:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94416B0405; Mon, 7 Jul 2025 10:24:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 996DC6B03F7 for ; Mon, 7 Jul 2025 10:24:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4F4F6127979 for ; Mon, 7 Jul 2025 14:24:06 +0000 (UTC) X-FDA: 83637688092.06.A5E3088 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 8B9C4C000E for ; Mon, 7 Jul 2025 14:24:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=a4rIafs7; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751898244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=24KDo3KRXZxzAB+MpsSNoPOtleVCAJRJx+y6hk41NC4=; b=Gr+mBSCNLCsDslJqjLGixdGEf09qSa7PKUGxv2RZSSYTxcbZH+6094qte7PNJ9OTb11gw4 auJvRoxw9kOhQCvlWLF6GSV+GRL9KxtlURcdmZTow4LPFa4g7ItpPHF0fJcerbS9tap7vU MB5RkaYK0BPEcUpbwC+si/QtYd8IVhM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=a4rIafs7; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751898244; a=rsa-sha256; cv=none; b=2bogP7OSxQ9NxujCgEQRbczzep8+ZUOUEttWHaExbpucKVGYxvGoBM5TfZUMQY3wcgu0bw dLGfdw6d5PRYwc7WhRoCqNRSLf5u+IwyViJbFi99hVnArH7/RkRNFI1cKgHkIymzxE70Ie bqMyQ1JokcDxMlBBWzpKZd+wXXs5o1c= Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4bbRLn36V0z9sqV; Mon, 7 Jul 2025 16:24:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1751898241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24KDo3KRXZxzAB+MpsSNoPOtleVCAJRJx+y6hk41NC4=; b=a4rIafs7ejMCL/CNvTdRuBlYOowXAqIKjXtP4LS8rmCWE0hVIYMqBPxATAFWTzPY7eKHhY vOZHuibUJbYTQF5RkUjg95/WDGjODG+LS2eqsuQTluKkzxuNuGgFY4JdPIusFIDrranKjQ +Flk3LB7JQlfmkzTS8eQkssBRm22SB28a+4UNq+HVGloMpqEQrg84FH5bJu/xRCLtcMQMQ EES7IR7CXKkDkdUeuygNJ7xJ/LWFp9gvhxgm9lO0YIYFIPDEqZvXY7zXpBqHVScIJMQBEK UKInRCqeEpexdwcfpcP1KLRuPlsBXssNB4gpHZpZRpM/92Mill8wrk8sY7dRFg== From: "Pankaj Raghav (Samsung)" To: Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de, Pankaj Raghav Subject: [PATCH v2 5/5] block: use largest_zero_folio in __blkdev_issue_zero_pages() Date: Mon, 7 Jul 2025 16:23:19 +0200 Message-ID: <20250707142319.319642-6-kernel@pankajraghav.com> In-Reply-To: <20250707142319.319642-1-kernel@pankajraghav.com> References: <20250707142319.319642-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8B9C4C000E X-Rspamd-Server: rspam09 X-Stat-Signature: zqz7j1ahuk3t8j69ruyjzt58aa4yr3xh X-HE-Tag: 1751898244-767067 X-HE-Meta: U2FsdGVkX190VmdDrsnRkXDNp22ZFVdjArvGWyVC0LuZ5myCkTPuCwx1rM9XI1mXY0dDbVbS4+Kwub5eekZXIyAwakT9/75wn44+7OhQ1MjjYr26f1A17oA9ukJO+YZcYrZOZHyny5Ku0JuhJjhgPFUxrBQgQsUqYwLmei8pXJX+eOHEtbK7IvnxipzmnhXtGi3AUnlwssAkbWMtnSVncRrFPFepDtVzscOSICSCqnkRV+GQ4HVQs1uuAMUaf7DYSPa0J+tp/FQ+1CqyPqV0jKe1WZfrSAiVkXxHu5EcICroDRwxfZrGm41Kyake0O8NaRNPrWXkkGt/668STP3ejaeo5R/JN80FlNk0M1TEqt+HKNlKqnifDBxQ6/KVNmAAU2/Wp58tBb7iZDauPP/YTxFm1VK/R17cbCOK6kmR7KhVJGUZEooYa1mg9vZ4NCCVip/pF11L8MMwFo9fwvrVRtTwMkhJ1y+VPVcobcn37C4+nqtv64fRxtKTCRNVidvlR26SBZSkX+mstlDHMvTEcWmL6OBAJP5h/x7ozRRADrCTlnZrDDI3MhyolJZY4A1RYWos6yw873a1aJITJhwjw4BJrpM0SVeQ0b5YGALeE44dOZAk7+5k79WnzCSO85RAAskFp62tLO8LGLdec9mRRdsorig0H4bz4VPPfd9iDOVCX7r+MD9+Lgj84S3cFiTqtHHjdPjWpDM5MctlTySnCjBoPvnCMfgR3Lj42uW3UhhZLb8yuaQgWUqcobIgQJ0gPgw7r+mL/ngolaS2cH0Gk1wKKBuD1Lu5Tgno0pykcz0xVamJWpUBKyOOlj4FL05Nly5BIYufHwVWMH02NUHyy3XODTC1nlXbZzmJTe60erzgHbmPmzLqWagOw7+OM3ed679hiT6Q56VKrrUjZ56YxKVIpjnJZ5kLUlyiLTP0hfJ0ZmY5earMohJvUtwVqhY456zMY5knqyYa5JfN5P7 AzZ3nNrt ShH0yr0sTj/tb+ZYLrAi3hXkCm9kGCs/CsUkdN7kBerlKWXbiOULjK1bw0wvf2FcRLHgeohUyCF0KanejLSi4RfAuxz1pRBRDFhBBKun3KzSs1Jqgcn7YxAKWeEinP7u4laQrmm05wwNRi780dSD6/PvwEEGsh8O4B7ih/nkyENYQgm7Lifw1q0sQrYfz8epr7hnCm/ef2YeAHXXg9Ebf/Akas2UMKMXKj9Qn3DZc1j0RsPRxDu3tMSJAWXZ5PiCAt3mfsJDcpQZKZ07M5OfcgSsTjGMVXHpdWaEx/b7MSUiSLKAe+xI1bXjWccMPQqazaSfG0zsA2fRh5oA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pankaj Raghav Use largest_zero_folio() in __blkdev_issue_zero_pages(). On systems with CONFIG_STATIC_PMD_ZERO_PAGE enabled, we will end up sending larger bvecs instead of multiple small ones. Noticed a 4% increase in performance on a commercial NVMe SSD which does not support OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS. Signed-off-by: Pankaj Raghav --- block/blk-lib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 4c9f20a689f7..70a5700b6717 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -196,6 +196,10 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, struct bio **biop, unsigned int flags) { + struct folio *zero_folio; + + zero_folio = largest_zero_folio(); + while (nr_sects) { unsigned int nr_vecs = __blkdev_sectors_to_bio_pages(nr_sects); struct bio *bio; @@ -208,15 +212,14 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, break; do { - unsigned int len, added; + unsigned int len; - len = min_t(sector_t, - PAGE_SIZE, nr_sects << SECTOR_SHIFT); - added = bio_add_page(bio, ZERO_PAGE(0), len, 0); - if (added < len) + len = min_t(sector_t, folio_size(zero_folio), + nr_sects << SECTOR_SHIFT); + if (!bio_add_folio(bio, zero_folio, len, 0)) break; - nr_sects -= added >> SECTOR_SHIFT; - sector += added >> SECTOR_SHIFT; + nr_sects -= len >> SECTOR_SHIFT; + sector += len >> SECTOR_SHIFT; } while (nr_sects); *biop = bio_chain_and_submit(*biop, bio); -- 2.49.0