From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF04C8303C for ; Mon, 7 Jul 2025 13:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29B328D0003; Mon, 7 Jul 2025 09:57:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 273398D0002; Mon, 7 Jul 2025 09:57:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 162778D0003; Mon, 7 Jul 2025 09:57:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 04FFE8D0002 for ; Mon, 7 Jul 2025 09:57:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ACE151D2DC4 for ; Mon, 7 Jul 2025 13:57:34 +0000 (UTC) X-FDA: 83637621228.16.D3370EF Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf16.hostedemail.com (Postfix) with ESMTP id A8EE7180008 for ; Mon, 7 Jul 2025 13:57:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="IB/Z67TS"; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751896652; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=72cORmQIFmCc7V/TRKuy0z1WYaJeaqVL0rT78Ct8W8w=; b=IktxNdvbj501k3VY7THocXVHCsbq+Z9WfX7kZTWxmoE3YIXazaO5Tgo2LtoULqyb4hrB6K CQjE/SLzBXWcdcsWl1JKtNjFaEnOc7Dp8Tt4VTq4Dz0okLV8WsK7wEs9vT/KB8pXb848Bd j/ZBPPgKoPv2GowejE/8WOfY5lZ3bM0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="IB/Z67TS"; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751896652; a=rsa-sha256; cv=none; b=R2rTfe18b+PJj0RKWoMfnZAanFt6qxDUst47Z6+VQNNoFQhE0/warckPy91Dm7dRKQd4r8 CrSJOo44ohV7s0WsSc3Fx33BeI64uXIu9u5IpXcSvm8aYoBwB+0Gov3TNayScjGmbbVfT9 MwjkPrvH0/uAC8Mb66Gr4u+xzjYJ8mI= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-60c9d8a169bso5178884a12.1 for ; Mon, 07 Jul 2025 06:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751896651; x=1752501451; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=72cORmQIFmCc7V/TRKuy0z1WYaJeaqVL0rT78Ct8W8w=; b=IB/Z67TSJEUj2C0MQiN8+2n8zesITL3EYtmYdxlv/t5zt71oIQ0VJPi3iPccaXdkva GbTjL7GcV0mM2+AdYCFx3RhZ7Wc2OmJBh1W7bAwsOqv36J3Y5oyx+vpKACdxp6QK6gOO qHyyt/EYFZKR3OBM9FhwSMACDUkwLj8iZMaHivSTJWXm7rfMrWXQDxl03yQDp6eOWAON nQh2dsuOHFvWZAlu6pEIaCgr7ywhJ/eV4qIkLlZFw4135O15/ryOQrXZ4Cs4sZ5pjktj fWqR81//lKlv1t5K4RBl+UMniCNBeSdqxgVjv274BHA6CPWjmy6rDcugGObNhdG5E2sn 6ccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751896651; x=1752501451; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=72cORmQIFmCc7V/TRKuy0z1WYaJeaqVL0rT78Ct8W8w=; b=mq9ZbEBqZ5ILWcWuj96RsiaX17mZnIBzyAbM+oFjCHwsz56S9nEwnGKUyYXR7t24oE i/8btcmFOjWPj9+cIFMWbNC0wmNuB2XcZjPTAqd7kavfoQQrFZa96zz8+OZfsSu6W2wt ZbLwjOyibQgEvFk7smbkof4lqa1PlSti0+C8u9e/Bbdeai3GwHslh+9K/wLX70kDQ9g/ 8xNY+g0+MncIKii0r0Idjs1N7iI1yfEkHdKQDdRH6toHSpcd7aQZJWptfcP9cnXB4asb rYP8SKNY5cJSz4lamIPScTERF61kGciUFWq6BK6ywKiWNZpyVJOBKhErrEtNOESft5tk +oeQ== X-Forwarded-Encrypted: i=1; AJvYcCUgkVySTFnyv/xAf84aK+gYkYJs6yrifPwB2kY2g9wWlti59kOdb8oWIxyO8y4KWJYeuU86I/dmBg==@kvack.org X-Gm-Message-State: AOJu0YxuvaviEqWgDQtba09SIAmYALR+yVVcM7ocj3ZsUFdVt+z3/lXp XwegjNxbvAdNIDLoiXYsn55ovARi6KVQr/UhVZMC0gxeN7vMlJ4+2v3/ X-Gm-Gg: ASbGncv0vP0IciaDtlB/KSegm+i+X20eBDQQNV5qjEKfGMlooSQympP91TNXGOJObyn 6+P/Y5mmWx19pWanitXg24t6s3YROPdGmdhV09Q4sulgdYvU1bJ0dS/jEMAYXw25MkNby23UggP Nxbkri3Uq/5/mApFZ/WciS48zp0XJ+JJgm8Oxtg2bwg2+Tt4BV/jacM52SAn82ZiKv0Dg2wmbRH Bh/OXlOG6bGXNLOqiA2CUMNmjIIvRqFkiYSLbLYGnKtxkMAZWFQeU+GtLDADdMckS8uJhRXipUX e7tyw37PD7pkbgJE+WEd11zB33vnPqRvqPNQZwBjGSlfWQWKaCNHyeb1NBGQDg== X-Google-Smtp-Source: AGHT+IEO0cCfUBS9xEpE3qHSkoazWC6crgwsbh4yMHj6e81EeHuqTDLZN2uGCde5N0XIx3JyzgvlrA== X-Received: by 2002:a05:6402:d0b:b0:602:3e3:dada with SMTP id 4fb4d7f45d1cf-60fd6d98502mr10340156a12.25.1751896650522; Mon, 07 Jul 2025 06:57:30 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60fcb0c79dasm5671936a12.51.2025.07.07.06.57.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jul 2025 06:57:30 -0700 (PDT) Date: Mon, 7 Jul 2025 13:57:29 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, John Hubbard , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple Subject: Re: [PATCH] mm/migrate: remove the -EEXIST conversion for move_pages() Message-ID: <20250707135729.ckrwl3aicig7kmez@master> Reply-To: Wei Yang References: <20250707065711.18056-1-richard.weiyang@gmail.com> <0936d663-8de3-40d1-97e0-927edbbb47f6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0936d663-8de3-40d1-97e0-927edbbb47f6@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: hyhc33uks3bso5dr849ufp5gqkwediwn X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A8EE7180008 X-HE-Tag: 1751896652-194257 X-HE-Meta: U2FsdGVkX1/XG+B9U8PYE4nxnCcvHOvkCaUmRwCzPOXE6kqdYIbwdnZOePG9WAvmAIQRTr2A8/DoCMc5eovbfFN6b/1ADI59Jd+iAQSmfM9GN/3xeK4bNuTD8HKEv3CIh2tbgdq9J8i4e29B75tRrlM5+5weTf0ZeePrv54eV2bfzjLFLHhdBkYio0f5zqzFZ6TtgJQbCt+8WO2kAtAwB7R9OESSRP4HNePjtMCXheOKsm/Iir4w8Jvvfd0Kbfl473rDQqGXynFXNsw5L94++nTlaitD6WPpl0jdnU0IQPLbBFYfg/jEqvhc/p4vUTz8WuL4eDIJw9W2Uvyi+h+IMnqZUohttsYscd7dQ/9/ZtxXqGVUCFYJwwiBO6UuhfW/i8Hf7qlISgsHznpdxbl/iYCljh5VOvlKVSzC3ugHcWDZBXHLGr8SeV8bOn9rX4Qp3MMMLD5gPBafSRnjx2ukU24/0CpgC+ZqoD0acgBMwyDL+XTfODWCU+EGc4ZilMhm22au81v+Mt1sQucq/48pX6/Dar1Op17T8t5AmPTBaj4UuDRJH/aaRdox9fZXhImc6Yk3JMqGJUEIABwfx4uGKX41hMk1O/Z3M2XMBbRayuhJCvL7KpadJy/HtqA9qI+wltC8aAsU5xeccAutJkIzcRNkK9vCv8PkPbtMzTDiHXwj6VrD5kXqMU9agorahvhNu81X6AnnBMW1cCJrk8PhAyAXmxaawWEVjujxeKLnBzoIAGyrQItaa+N8kx5xOiEOJx1lufybmTqzsFvgqyrgKlPjxh3YMC8aQxDnQWjCIlVj3DJKYxaC9A4WA3sw+klgdT/7qTBKEF+Prl01+uR2TWEUiofMq/EUETYqxmtqjaV9pmyo1c9ciV7C6xjRS660ncNaiDgigl/yQwH/btLoRDmd0TePY0SGFwWrOthYRIyKVn9m0p3Zwdf53H2vQPmpidsL0pJjSmLfn4dzE/x y52HaHDM K9C41qLQ58sj/Y/ORcbXbio3Mdga+DnRblxOw4VkP5xBgq+E7WZqV8vDwgeNfVAlKx+sdBhuyQtiAZJuwhxcv9wA+h6qj8xnIEWSB5mskqGTJhp0rxndciFGU2wOfVuk+lp+KuyZ6raK88xPVOuBmUeIlfWCu2yN7Gl06dlbwnIiNNqBjMlMSyMNKnA3ddB7woVdww44FE+MzvnzmWXWaFPvlfCTgISMoF65+Vsd4XsVgFs7pS7FUWCW70fVUF+1yGDt5aj5AwxLK3l6Bx0SzyWeMn3S2x23AQh1bcuIWX6yvsbmc8QJ/qsleMubebC5SRcpRZ7iO9vxDQH9bRIW3JHdcluRZ4DW+q1/oalbgjlMqq10tHiQ+0ycsqPArCpng7UzMl/t4IrUbnmTTu9nw4lEjGI9uKTlO2J7/JUuQZJEcqTyIEDKirDzrfEm/NT0ooPAX/RnjrUjFYmR/txikuK7VXREgaJ2nJ0yUsvLMW8OqpJXnXMhsLF053TlIpLx9DOdFm/bKr5ihlDm5XFdEd5+WKXMnp3j7GDsiJLI5xc5uYvYf7+LFO00/DV9Yt4DnPsHPKEp7XFeUIrlL5ZWXYzILhA91wrN1ALwsynM/kHQ/Lo+93Xr2SjdKFrmYdQ+dRN2whJgxxDG+ivtj1Ekwflvpo0YOUr2r2ASbUgDtGIxUvXmhnrIF+MbvqHETxxmME2AeUy4+MY2lsJyYgS8T1UhM0btzDOh4GBguv0Q29SO6YYLPVvj04L2VBhuUXDSh1s4dW3zRJgE4A75JLQMftfyfWf0D9r+HUxbkBoZaZXvsS3kozfZzOIXKM6mzAnDNAGwfB00qEEhdQNQMVHWb1mpzaUaVGQGtX/SlboC7sO32dV+BrW2sCKxy5mimpbiyRdChlut11RSL1G0konbrOMxD/MggGCMfV+MMJalJZCylL40s7+hoWW5wLW1I2AKANMFftmoUnEeGpdvl7INRUgRMHcZo x34TiCMa XeFQbrfntWw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 09:25:12AM +0200, David Hildenbrand wrote: >On 07.07.25 08:57, Wei Yang wrote: >> The -EEXIST conversion is introduced in commit 65462462ffb2 ("mm/gup: >> follow_pfn_pte(): -EEXIST cleanup"), since follow_page() may call >> follow_pfn_pte() which may return -EEXIST. >> >> But after commit 7dff875c9436 ("mm/migrate: convert >> add_page_for_migration() from follow_page() to folio_walk"), it use >> folio_walk instead. This limit the error code and won't return -EEXIST. >> >> Remove the error code conversion here. >> >> Signed-off-by: Wei Yang >> Cc: John Hubbard >> Cc: David Hildenbrand >> Cc: Zi Yan >> Cc: Matthew Brost >> Cc: Joshua Hahn >> Cc: Rakie Kim >> Cc: Byungchul Park >> Cc: Gregory Price >> Cc: Ying Huang >> Cc: Alistair Popple >> --- > >Acked-by: David Hildenbrand > Thanks >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me