From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 739CCC83030 for ; Mon, 7 Jul 2025 03:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E812D8D0003; Sun, 6 Jul 2025 23:53:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E32498D0002; Sun, 6 Jul 2025 23:53:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D48718D0003; Sun, 6 Jul 2025 23:53:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C27188D0002 for ; Sun, 6 Jul 2025 23:53:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 66CE758773 for ; Mon, 7 Jul 2025 03:53:11 +0000 (UTC) X-FDA: 83636098182.28.3D19CEC Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf09.hostedemail.com (Postfix) with ESMTP id 3B0DF140012 for ; Mon, 7 Jul 2025 03:53:08 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=SfdPU2yf; spf=pass (imf09.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751860389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mub7PjK+ZQMm18cy8qNtEOXQgRqk+RrTOpKNrinRMis=; b=e+3ZnahaenwHRHcPwPOkfkZoIKjBesQoHoLhJBBg2nr/Y9Cc2TjwLcne/hWvu9eFG7PaZb Peqtu3G14aSAA48P5C8xGwNMBJwJVodI912Y2LBxpbzJl5j7ycCkjSLbNIzDI3k7RrWoJq 9duD2GRTtA7b9fwG0O7MhUAcqnEojpg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=SfdPU2yf; spf=pass (imf09.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751860389; a=rsa-sha256; cv=none; b=FMYjjfLUyGE/z2AC0EPzTINm3GhwvRJ376mBhmYalhwRT+Jb6rkbNE4nwzakoOynUDbfVy m2zHAAKXcVchMmIGNT0oL0UefADvCqLP2LWTy/iG40BGBWbbPPsWaLqAdGBinSjjR2KmMO hY3Q9kzNiopj+u70+JMatAtWy+910VQ= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-747e41d5469so2977284b3a.3 for ; Sun, 06 Jul 2025 20:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1751860387; x=1752465187; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mub7PjK+ZQMm18cy8qNtEOXQgRqk+RrTOpKNrinRMis=; b=SfdPU2yfdCPFdErvWpLMHVIlFWHNjoSOgahFph191Wlz6SblM7iRPMH1dUm6ure9p4 /rbaIoBsRy13mluz5Yi+BbLjXRK0TWgLLYRjH5wcdVP7hnUXS33nkjy3Bu2rdD7mb3bs C9kmRTAFTBUu/cBE1c5fQo8j7jDuFH8u0RfTa1n/eWj/2MxFtUOj7XIz1tfc8LtAUs5a xWFIv5tYdcqfi0HdJBykoZ80VuYLW+x2GPzhIuXE6TNh6pVrhD/Lr9iAx0Ap7R6h8wYv 0cBhgvZFiqKAmhpV4sPGi/JV/Gq3Cl9erPLtqsljpRzmglgD77L4MsjzhfcUZZTVOsjE B9/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751860387; x=1752465187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mub7PjK+ZQMm18cy8qNtEOXQgRqk+RrTOpKNrinRMis=; b=gMEejid6Ubyo2kiiqcGvsCY9BpbzvuK4ZM54F+Y9Qx4oGjUptOXektxO4ltLJk+mAP 7TuZfIziMxYPt85qHkCLpjNzc7cWRvggMiiBtsl7ifBAKXfmkj8toRsyj+A4REsw8ENv F0OJB/KIlNOhi5COuEG/pnwMen2pNNLKa66r+Y3WbUk6kMIK/C9Is6EM/TWUHvm5jkGu YR6HOXnBLAEcmZPg2n00xfCjiSnO13+77Ui8GCWAJl/UD2oVFs01vXPJ/cEApyRWr2j+ FA1b/zjXssEZI3FrcsoQfhpINyj/phEy8l+1rxykekxr9Hv2f+/YKfwZiYOVsSCdxpTr Xqyg== X-Forwarded-Encrypted: i=1; AJvYcCX4T9EAH1AzFw9gFHORPULc4QlBj+oU/wNVpfF3NzFdc3BgSH4uCiuXk0FyiR/3AMW4wxxWLPImWw==@kvack.org X-Gm-Message-State: AOJu0Yznwy68sZo9u2yiYvjt2WZgjRHgdhNMFydgA2MaVOTib4PjhJtK 62VNX6aGvfpsg3ppLwjqanIiHVMYOfM3oUTryOMeF7HHo+KiNs7X/KlWwhpmn87Awto= X-Gm-Gg: ASbGncspkwvMN9RU/V/A+6xbzeeVT4FjFcaEkPfDIsNh2t+9DHvgwYzKlob8by/aKz+ V5UHBvNWTpRTP2gNyQSm5ZiNmkNgGyvKMJiiSzQuQ+rTLKOymz44k4bMWgw5W8e4fdNkWjLIOJC bv1NsraNaPGLXOJfXE4MxAeF/5sgOfS5LeJVZR3MAwBd9LAXROdX6/4xupR2egKqc34GxfUo/5u FUgN7McX16CUNCnEHOigOUBYEp/XA1VqzQy18unRLu1T3/mCYOx4dRhfivm1jywWafF3iFinYii JEy3o28u6qU7MhZnYSpQEv3ADJ0WdJCdZ3MSh0cIPAsY+guEzcJfzCASOX+RlF7oXkeanCvtgK8 UTR0T7vO49GXFvxOUxTH2qg8= X-Google-Smtp-Source: AGHT+IFtHyTBc6qEYu6hdCH6cigb35sVn8qLgWaMfVrg0MupVPG7/z/yW4uRvdyfX28do9yc+RvdzQ== X-Received: by 2002:a05:6a20:6a0d:b0:225:defd:26f0 with SMTP id adf61e73a8af0-2260c92da99mr18422851637.32.1751860387103; Sun, 06 Jul 2025 20:53:07 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee74cf48sm7538658a12.77.2025.07.06.20.53.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 06 Jul 2025 20:53:06 -0700 (PDT) From: lizhe.67@bytedance.com To: lkp@intel.com Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, david@redhat.com, jgg@ziepe.ca, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, oe-kbuild-all@lists.linux.dev, peterx@redhat.com Subject: Re: [PATCH v2 1/5] mm: introduce num_pages_contiguous() Date: Mon, 7 Jul 2025 11:52:59 +0800 Message-ID: <20250707035259.61640-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <202507050529.EoMuEtd8-lkp@intel.com> References: <202507050529.EoMuEtd8-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 3B0DF140012 X-Rspamd-Server: rspam09 X-Stat-Signature: unqwse7d1w65ty3xnmkf4xno5f783jhp X-HE-Tag: 1751860388-44001 X-HE-Meta: U2FsdGVkX1+bYjN4N57nk+eZyi55av7aepQ7/4QWUHfa1xOS/YxFSBNSbm69ihY2Q2+K/T71ZVlSHgtv+mALJrdOiFFVei6sMy1LVtnGwdoITqm8R0TmdMMAo/Ib5IBYejcSGb2h0TerqvEQLzYqhlmTITaDmWFR6I3sk6iePY5SJ1UJTIgtKrUr6uDfkEh++0mAUSiS5rNM7iohXPBNLqZw1OxvvL/Y8A0GzHm/tPgzvK7iSyBR6J0N19p3jrsgT8mX5xsUDP9tbDccfjKaRITwPlGzHmtUp8b9IcfJV30w1PvOR//Fz/9MduDTCmODAZXZpwkoREM9uGrklQ3bltK2OrTpK6APjbju1CAyEZGbBjyFQWtiRwnLXp07H5dsFmX8A86rfEmR6AsX7+5bjctizrULQvYua1Ut6k2Ksi0uW25SM5riW7fAY7r+2V8wh47i5sAA9irtmr8ozQhAAxTkerg6j/HfySmrqPqVQYdHhYnNON2BNgeSghFk/sMGCCbr5Q/l9EkxMBNtwP1mbA1UW54DmQxEIxXsYfl7RzmUwOHmDJgDUwYF8+ushObaoyviLq9df1ScimETrD0Mj/BQVc7DgFPaEx1V0iBBilWpF2X2vSeqaIHfTEHV/ghPead5lJhjGK74Cn5L9YxYozYPzioolmgLQpWoOfAtQrv+6pqET9Jl/CzD5G8iukv6Fq9qWORS9zVqqjfQrelfCH6B8rZBXGnSSpCodkYqlCfuAEKwigCu5LfQ1H+knJdFo++CTr1MlDRXzbOrlRTTc/z6KbEUaTqwEPmJo+lIAszrl+kNY14+8rC4lbi2h0xuSJr7i5oiSwJPH8xbkoKxl8zxJ5bMz+Jk8Sk3guYQ5SUD8u+VmBcCnDPJLrKs57lV0mpZVSyZNn2deph9Ds7cckyc8rxPOCPeZ/SS4RPxMA1UL+VNO2cBWU33yFGyPWJclYLLFDQEK/eCP9dRNze dEhKyrux ZzQqRUGnztUXcBGTC9rgLtdom2vBzZ+cs5lbf2xePQV951EEUOOzQs4scgM5PWomn6sGJ20dLpuxYME4RMUcENukZQ5h/sGWFl8+ZZrIlWaQUP0VyL8MClhlKssk7qeR91dJkwPLL6ELkeZiQm4nfFprBTW9tCG/l/DIyt7fxtAW7OwVXCCW9syxQr7th8MXBTkjIDvrUEsXzF4ufN/xzO183OFbzyig9q0MxESwpYyq0ECQM/mQkpRAK4fW9Qw6KWyDTaNsogUQ3RGq8cgs5vNZf4MmYxlOGZmEZ9orNfYgNul74zPD2OH3ZTFllzDS8d9sjXh0KHzB/3gH+4rmtI2anzUyGKuoPsPYnuI9imHCOMVE1cVspyX5AJrSc6BZQOarTdtE9P7vzIS4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 5 Jul 2025 05:19:34 +0800, lkp@intel.com wrote: > All errors (new ones prefixed by >>): > > In file included from arch/sh/include/asm/page.h:160, > from arch/sh/include/asm/thread_info.h:13, > from include/linux/thread_info.h:60, > from include/asm-generic/preempt.h:5, > from ./arch/sh/include/generated/asm/preempt.h:1, > from include/linux/preempt.h:79, > from include/linux/spinlock.h:56, > from include/linux/mmzone.h:8, > from include/linux/gfp.h:7, > from include/linux/mm.h:7, > from arch/sh/kernel/asm-offsets.c:14: > include/linux/mm.h: In function 'num_pages_contiguous': > >> include/asm-generic/memory_model.h:48:21: error: implicit declaration of function 'page_to_section'; did you mean 'present_section'? [-Wimplicit-function-declaration] > 48 | int __sec = page_to_section(__pg); \ > | ^~~~~~~~~~~~~~~ > include/asm-generic/memory_model.h:53:32: note: in definition of macro '__pfn_to_page' > 53 | ({ unsigned long __pfn = (pfn); \ > | ^~~ > include/asm-generic/memory_model.h:65:21: note: in expansion of macro '__page_to_pfn' > 65 | #define page_to_pfn __page_to_pfn > | ^~~~~~~~~~~~~ > include/linux/mm.h:200:38: note: in expansion of macro 'page_to_pfn' > 200 | #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) > | ^~~~~~~~~~~ > include/linux/mm.h:221:33: note: in expansion of macro 'nth_page' > 221 | if (pages[i] != nth_page(first_page, i)) > | ^~~~~~~~ > include/linux/mm.h: At top level: > >> include/linux/mm.h:2002:29: error: conflicting types for 'page_to_section'; have 'long unsigned int(const struct page *)' > 2002 | static inline unsigned long page_to_section(const struct page *page) > | ^~~~~~~~~~~~~~~ > include/asm-generic/memory_model.h:48:21: note: previous implicit declaration of 'page_to_section' with type 'int()' > 48 | int __sec = page_to_section(__pg); \ > | ^~~~~~~~~~~~~~~ > include/asm-generic/memory_model.h:53:32: note: in definition of macro '__pfn_to_page' > 53 | ({ unsigned long __pfn = (pfn); \ > | ^~~ > include/asm-generic/memory_model.h:65:21: note: in expansion of macro '__page_to_pfn' > 65 | #define page_to_pfn __page_to_pfn > | ^~~~~~~~~~~~~ > include/linux/mm.h:200:38: note: in expansion of macro 'page_to_pfn' > 200 | #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) > | ^~~~~~~~~~~ > include/linux/mm.h:221:33: note: in expansion of macro 'nth_page' > 221 | if (pages[i] != nth_page(first_page, i)) > | ^~~~~~~~ > make[3]: *** [scripts/Makefile.build:98: arch/sh/kernel/asm-offsets.s] Error 1 > make[3]: Target 'prepare' not remade because of errors. > make[2]: *** [Makefile:1274: prepare0] Error 2 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:248: __sub-make] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:248: __sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > > vim +2002 include/linux/mm.h > > bf4e8902ee5080 Daniel Kiper 2011-05-24 2001 > aa462abe8aaf21 Ian Campbell 2011-08-17 @2002 static inline unsigned long page_to_section(const struct page *page) > d41dee369bff3b Andy Whitcroft 2005-06-23 2003 { > d41dee369bff3b Andy Whitcroft 2005-06-23 2004 return (page->flags >> SECTIONS_PGSHIFT) & SECTIONS_MASK; > d41dee369bff3b Andy Whitcroft 2005-06-23 2005 } > 308c05e35e3517 Christoph Lameter 2008-04-28 2006 #endif > d41dee369bff3b Andy Whitcroft 2005-06-23 2007 Thank you. Let's move function num_pages_contiguous() below the definition of page_to_section() to resolve this compilation error. Thanks, Zhe