From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E77C83F03 for ; Mon, 7 Jul 2025 02:45:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4181C6B03F9; Sun, 6 Jul 2025 22:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32C776B03FA; Sun, 6 Jul 2025 22:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 158526B03FB; Sun, 6 Jul 2025 22:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 03FB46B03F9 for ; Sun, 6 Jul 2025 22:45:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AF0191602D0 for ; Mon, 7 Jul 2025 02:45:57 +0000 (UTC) X-FDA: 83635928754.17.E5F1B41 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf10.hostedemail.com (Postfix) with ESMTP id 4ABB9C0008 for ; Mon, 7 Jul 2025 02:45:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; spf=pass (imf10.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751856356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=ihmzfDA81mH3lnVqhnTyBLmsdQ3rP5v8VsWRIg9gxHw=; b=3mPAWoVMYVyxxdBTyeXste7rO/tG/QGq/CQ31pVjVZg4zdzzpOchvVf7engXBupYR6oVDP ynso2aQIX8CFMyfswpnQ9TBi2fC0aIgTHV0NENTpdboexo8i5kkG2pYz8x2VU7eB7T1d0X OPFdHFtOeMIU9lYSUXC7z0b95v/BffQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751856356; a=rsa-sha256; cv=none; b=UMk+Qfu38ipAIPz/3ZQPzsRopJqT+8MVkKzBL5ZV8jD7+Sd6LIXMuVnrT6lp+rOSaz6FsT ugP7RIJ2jO/NaVOuvOKXpRaDkzVbNVuk4w8RSyXtSBT2G1p93sdPAuJFM6n/BLfeFX57pU qMs1MJX6pbqEqMLOFobSvcvs3KSdAzE= X-AuditID: a67dfc5b-681ff7000002311f-64-686b34dfb6b1 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim Subject: [PATCH mm-new] samples/damon: change enable parameters to enabled Date: Mon, 7 Jul 2025 11:45:47 +0900 Message-ID: <20250707024548.1964-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsXC9ZZnoe4Dk+wMg53vmS3mrF/DZvHk/29W i3tr/rNaHP76hsmBxWPTqk42j02fJrF7nJjxm8XjxeaZjAEsUVw2Kak5mWWpRfp2CVwZndN3 sBfcN6pY2CjewDhTs4uRk0NCwETi+YytbDD2iR/nwWw2ATWJKy8nMXUxcnCICFhJTNsR28XI xcEs0MQosfFXJ1iNsICXxPx9S5hBbBYBVYmNDWuZQGxeATOJX31voGZqSjze/pMdIi4ocXLm ExYQm1lAXqJ562xmiJqPrBLPHxlA2JISB1fcYJnAyDsLScssJC0LGJlWMQpl5pXlJmbmmOhl VOZlVugl5+duYgQG1bLaP9E7GD9dCD7EKMDBqMTDaxCelSHEmlhWXJl7iFGCg1lJhLeNLTtD iDclsbIqtSg/vqg0J7X4EKM0B4uSOK/Rt/IUIYH0xJLU7NTUgtQimCwTB6dUA6NfzNEXFfYT V++03LyzqU9UmPfitP2f7TnUZh2z/rKyK4Pt/QTXPf2Oig21fdtKzSfemLXdu1Hs0AWTFm0f 8zul6dKy+npdfD/D19wO05j467xFyPI/04+vvrMhLH7Jo/cL686uC8rgmigRoDn7Y7rSDyHp XTfXaHde1b2i90tCS9Phwv7auZxKLMUZiYZazEXFiQBvinqVJgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42LhmqGlp3vfJDvDYMNDE4s569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YHNg8Nq3qBBKfJrF7nJjxm8XjxeaZjB7fbnt4LH7xgSmA LYrLJiU1J7MstUjfLoEro3P6DvaC+0YVCxvFGxhnanYxcnJICJhInPhxng3EZhNQk7jychJT FyMHh4iAlcS0HbFdjFwczAJNjBIbf3WC1QgLeEnM37eEGcRmEVCV2NiwlgnE5hUwk/jV94YN YqamxOPtP9kh4oISJ2c+YQGxmQXkJZq3zmaewMg1C0lqFpLUAkamVYwimXlluYmZOaZ6xdkZ lXmZFXrJ+bmbGIFhs6z2z8QdjF8uux9iFOBgVOLhNQjPyhBiTSwrrsw9xCjBwawkwtvGlp0h xJuSWFmVWpQfX1Sak1p8iFGag0VJnNcrPDVBSCA9sSQ1OzW1ILUIJsvEwSnVwPgwde4B7fnZ 1g/04vO+OKl85wwsTtZj2Xjedwq/2Mp6E0cz3c4prxdPXm2w6NXZ8osFMe8tF4U25uzd0xLy weOPzWrdu/8KQ+b1OZS7veL9sM0gguP3rc9d51L73i0XCohZ+eH0g6luYovvCafLzNaNFAj/ dFY/wmX91M9fzWun1Ww0l+ntZFFiKc5INNRiLipOBACXPqd1FwIAAA== X-CFilter-Loop: Reflected X-Stat-Signature: rsibgoncqg3irs7zstmqw78nsth454wj X-Rspamd-Queue-Id: 4ABB9C0008 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751856355-989083 X-HE-Meta: U2FsdGVkX1/9v/h45HYm88Zsrhv25Bz2AcOFHJWqOj9zOOjtV8Ob6UJlRVYmyo6/Uaaq+oP00wwFdgk+GWUAqkmFyVNfDAj3vVyAwMzwv2pF1auDHlTa92ooqnCKpzNqdk+6/B2KE1BxobPBU2IW0q4gAzGGboq63Cw726FRkNDH79SpZevLXY7fiz/liNl6pT+jlZhAH1pcuB8evNooaCK7iBNpZ03Tg+MFBW4DD3hqdkG0MTfGW8xGv+guPxkiVumoPd6mL2dt6FdoXOJimVxNlz3jrJ4ar9vSxM8l/7QafTbLStzrbGnhvvP4Nev43n2KGHed38Cgl8rDpFDE9Y984lm266/TuBJPbSNRBiJkRaKFS/HxJdTNO/cH+gnJA+YeSV1vf5Og9MnzfntSsmA+tik/s5aKS4/2A9RsnWKtvYQzdb2jrclF0tTniyR31foD+x9GYf88FHzOEs3ZLFCPQxD3LnZNognHq/E6HUTjZOzZFIyUrwuhI7RMjmUBkAAyp4XluEuAcxHyEZ+7zNrWOKRa+k5TCaAPlChIlkUqEY92T7OLhfmsNJFi+1dYdRU4AQpxYLEATxm0FdIY22IISBCn7eEgfNgXijjf6wPJAqPAvY+KCm6Tv17O8RWuv6YapsfIvDPBd5cqzvGY1fg23e+LQYcgbsy75iqaIUv9OUbqhDSzvODpI4P+swXCIUTxEK6g5+8s8IN8/bqQQeNNCZJsK9uaMehFpr2FYFRzUvHeK97satl2iZ9CcMmw9rBMlWahoJ02lzPcnAojKDQiNXepoqCRz9Vsu6VBZXGI7Mfcta8zIQrPzwZXIrRQUgvK2WsCu2G7i1HHbVBs/zgik8qQmwir9YfUziCYQcjv7zAYZwfIZEsKs9la2MUXzonawsdeUGuWGFtbxKvIgSRhIyj9Bd4wpUefGblPdMkCoyo0fV8fCWeeVpvPkBtWH8FWp9388QtUmazd3ZC L1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_{lru_sort,reclaim,stat} kernel modules use "enabled" parameter knobs as follows. /sys/module/damon_lru_sort/parameters/enabled /sys/module/damon_reclaim/parameters/enabled /sys/module/damon_stat/parameters/enabled However, other sample modules of damon use "enable" parameter knobs so it'd be better to rename them from "enable" to "enabled" to keep the consistency with other damon modules. Before: /sys/module/damon_sample_wsse/parameters/enable /sys/module/damon_sample_prcl/parameters/enable /sys/module/damon_sample_mtier/parameters/enable After: /sys/module/damon_sample_wsse/parameters/enabled /sys/module/damon_sample_prcl/parameters/enabled /sys/module/damon_sample_mtier/parameters/enabled There is no functional changes in this patch. Signed-off-by: Honggyu Kim --- samples/damon/mtier.c | 22 +++++++++++----------- samples/damon/prcl.c | 22 +++++++++++----------- samples/damon/wsse.c | 22 +++++++++++----------- 3 files changed, 33 insertions(+), 33 deletions(-) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index 5e1988697727..041d614e6423 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -38,14 +38,14 @@ module_param(node0_mem_free_bp, ulong, 0600); static int damon_sample_mtier_enable_store( const char *val, const struct kernel_param *kp); -static const struct kernel_param_ops enable_param_ops = { +static const struct kernel_param_ops enabled_param_ops = { .set = damon_sample_mtier_enable_store, .get = param_get_bool, }; -static bool enable __read_mostly; -module_param_cb(enable, &enable_param_ops, &enable, 0600); -MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); +static bool enabled __read_mostly; +module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); +MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_MTIER"); static struct damon_ctx *ctxs[2]; @@ -167,23 +167,23 @@ static bool init_called; static int damon_sample_mtier_enable_store( const char *val, const struct kernel_param *kp) { - bool enabled = enable; + bool is_enabled = enabled; int err; - err = kstrtobool(val, &enable); + err = kstrtobool(val, &enabled); if (err) return err; - if (enable == enabled) + if (enabled == is_enabled) return 0; if (!init_called) return 0; - if (enable) { + if (enabled) { err = damon_sample_mtier_start(); if (err) - enable = false; + enabled = false; return err; } damon_sample_mtier_stop(); @@ -195,10 +195,10 @@ static int __init damon_sample_mtier_init(void) int err = 0; init_called = true; - if (enable) { + if (enabled) { err = damon_sample_mtier_start(); if (err) - enable = false; + enabled = false; } return 0; } diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index d70f47924720..0ac4407e919a 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -22,14 +22,14 @@ module_param(target_pid, int, 0600); static int damon_sample_prcl_enable_store( const char *val, const struct kernel_param *kp); -static const struct kernel_param_ops enable_param_ops = { +static const struct kernel_param_ops enabled_param_ops = { .set = damon_sample_prcl_enable_store, .get = param_get_bool, }; -static bool enable __read_mostly; -module_param_cb(enable, &enable_param_ops, &enable, 0600); -MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_WSSE"); +static bool enabled __read_mostly; +module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); +MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_PRCL"); static struct damon_ctx *ctx; static struct pid *target_pidp; @@ -119,23 +119,23 @@ static bool init_called; static int damon_sample_prcl_enable_store( const char *val, const struct kernel_param *kp) { - bool enabled = enable; + bool is_enabled = enabled; int err; - err = kstrtobool(val, &enable); + err = kstrtobool(val, &enabled); if (err) return err; - if (enable == enabled) + if (enabled == is_enabled) return 0; if (!init_called) return 0; - if (enable) { + if (enabled) { err = damon_sample_prcl_start(); if (err) - enable = false; + enabled = false; return err; } damon_sample_prcl_stop(); @@ -147,10 +147,10 @@ static int __init damon_sample_prcl_init(void) int err = 0; init_called = true; - if (enable) { + if (enabled) { err = damon_sample_prcl_start(); if (err) - enable = false; + enabled = false; } return 0; } diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index 6037e5f8adf2..b663e206d574 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -23,14 +23,14 @@ module_param(target_pid, int, 0600); static int damon_sample_wsse_enable_store( const char *val, const struct kernel_param *kp); -static const struct kernel_param_ops enable_param_ops = { +static const struct kernel_param_ops enabled_param_ops = { .set = damon_sample_wsse_enable_store, .get = param_get_bool, }; -static bool enable __read_mostly; -module_param_cb(enable, &enable_param_ops, &enable, 0600); -MODULE_PARM_DESC(enable, "Enable or disable DAMON_SAMPLE_WSSE"); +static bool enabled __read_mostly; +module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); +MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_WSSE"); static struct damon_ctx *ctx; static struct pid *target_pidp; @@ -99,23 +99,23 @@ static bool init_called; static int damon_sample_wsse_enable_store( const char *val, const struct kernel_param *kp) { - bool enabled = enable; + bool is_enabled = enabled; int err; - err = kstrtobool(val, &enable); + err = kstrtobool(val, &enabled); if (err) return err; - if (enable == enabled) + if (enabled == is_enabled) return 0; - if (enable) { + if (enabled) { if (!init_called) return 0; err = damon_sample_wsse_start(); if (err) - enable = false; + enabled = false; return err; } damon_sample_wsse_stop(); @@ -127,10 +127,10 @@ static int __init damon_sample_wsse_init(void) int err = 0; init_called = true; - if (enable) { + if (enabled) { err = damon_sample_wsse_start(); if (err) - enable = false; + enabled = false; } return err; } base-commit: e1ca48e53d00b97aee427d2108f6058cd9ab4aee -- 2.34.1