From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E82CC83F09 for ; Sun, 6 Jul 2025 21:48:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B86B68D000C; Sun, 6 Jul 2025 17:48:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B36C08D0002; Sun, 6 Jul 2025 17:48:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4D678D000C; Sun, 6 Jul 2025 17:48:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 913458D0002 for ; Sun, 6 Jul 2025 17:48:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 15F7E127E71 for ; Sun, 6 Jul 2025 21:48:09 +0000 (UTC) X-FDA: 83635178298.19.77105E0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 6FB864000D for ; Sun, 6 Jul 2025 21:48:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EgpjT1Rw; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751838487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gwWt+yygGSDVJc6yFVWVTJZcwM7x7wldPBCt//5yuIE=; b=5WL1cKtyqvI5WOtEXAe+DGvxZsNWWeom701/xkSY5qPfrSM21TuulwD3Q4Jg/SVMyWrHen WfYnSkY40K2rr/TOQShgxQicdF+gtdT8oZb3b3hTjmvPSZLOPPvwMo79UVJ6LF5WrabLZf UhovONwyKQSGGAjEg3huDe7Y2O22IyM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EgpjT1Rw; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751838487; a=rsa-sha256; cv=none; b=7hfMZSnWt2vrRNg+STWJxtL6spJ1u88DlQPcQPz/ocb3Ymr+15q7SxhXU60Dxjb26ZqJdv etkZZ124XVaPTYSpK5toAkuV0FhLRMkRoWflIkXieL9jsaZh/BGmuvAd1Pr74XMyiWjac9 wwmn8kBaLeyL7TFBx/K+qmwP/wrz4qQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 69D8D5C5839; Sun, 6 Jul 2025 21:48:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0FE6C4CEED; Sun, 6 Jul 2025 21:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751838486; bh=hwKHij2hT+j7D7cL+QtR8wgByVkYLZkMpvWNP8v0DXo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EgpjT1RwcOiCmnJQuWHRzBNMEZdKr3SmJ43JmuJ2npnBOnr8HLNcTJ96toR3UftUJ acY5nAywMOdv8lINuVtE+Uf9gT1obmKqAN3+yEd3hInGVbt81CIlxrg86aI0ZcGhRA RDV3mHvxmFhjcLtTlXkQyvLYwYCN7afocfxoGqoK+Q4EqFkvyreywMV/Z05lTZ07jw OUML6woDhrMjNMtggDfmEz1WJIh9ppHIatVYdbBBKDusoTHncdTh7YAhU3seSE3FQv gTPcvUIjOLDG+Az0vQL0gvvAAI9l12YYQk/P5Y/LNJcqElJbboJ8n7UCtqOO7uEiB4 Rytb8hM92mp0A== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 10/14] mm/damon/vaddr: put pid in cleanup_target() Date: Sun, 6 Jul 2025 14:48:03 -0700 Message-Id: <20250706214803.56634-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-11-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 6FB864000D X-Rspamd-Server: rspam09 X-Stat-Signature: nhgx5r7dj7d13ji9xmizuot7cqoz9e4e X-HE-Tag: 1751838487-488196 X-HE-Meta: U2FsdGVkX1/9NGasyfjTmsIe8smPnC+RTVhfjO4szrPOgOMB2ej8M1DlCsnwXdVMIRenQa4poJy/5mjk6bq6Y6vN899/7SmlxIiddf0t6yfPtfl+ogN1Jc5qOE62unYdA8dWeFGVmBZ5FSG6FRVyzPF10dIAu8mVQE2d3JzbRNUjVQFo8Bk+DG0DjukYgFH1cSHqaXlFpF+vOmzUXOGMmL/y5fgOkqkxfc6e9Pye3Q3L9JlkWUosA/oB+IIJ1V+TZUV956dTv7zqAoEx38X0laHIccwxCUeSMrZQyC4/KG06qoXbkVjEZH6ItFUEx5fRFVqujzub5TOtjyxTCXJBaAaEpsu9JvcF13KEr7cH7XAup/6heV3Fwl65+11sp+B0+Rr68qdy/FBG74TGO6Dc3qjWhY9o58faNYkyvh7cZkf5+AW9A1FJh3ewg8O7jFWJ8OfsPYLfih+ZUYxVEQ9Ry8UJ8JQ4AJmdLY0OAFyR39gCbD1DPR2yg6aa5mNGM+kwusveR7eOHfpzMYL9b2Rtnt4ETaeQgj5aEqyjSS4/7Uyk4VkFKyGkewKC9up5zag55GdlE95ie+3TXaLYsfsb8mpeL2usX4LtQqxbNFbK+lJuZlKW0MvV6AcLVHsueijxuIoxa4ATkrUmrHsMBqXdhKypBl2t7Pum/vzRNCi4IoutLxd80SAFipwnzRH+thqu/rbmXsjBZqUr7gU7vtxto4oHmu/NZcEtlnMhWGPQ+CMVyn05+5sHhK+9BOcMpLIg2B68oj3bUTnLGQGENi3EkDdoyUo0ppLH0CredRRFi2sxtU+bhCN+JDMchpy2hC9MKy6LSey5VVYsakVNvmi0QLHny1woliMAMBdiwiLtl6bZtEZTgXiRPe6foWC4Ra2RjeM3TLbMgfrbhiwKil/cKepZD3rHR6hlP/sbXKTmoyFXjksQ0MWc486yjiwzDeiVG5or2ROO+7qyXvI6Rg2 oA3mmpPV iOyeFJdGEHEDjjQ7riZY2/sHrlVzL1z+dGFuHga0dfe06LwbTl9eZrtuPQjpe5xx5n7UtUdedI9HvR0VhaDpN/DjL9GQRNr4Ycsx8co8cff+uGuvnsa1xzHuyZetxqVLADQ9+eCwDDtQoNS7zRuJA0I1lrOnRhUVLNj6Of6ojwzrVUR8W0RITnXBDuKbEMnua0J9M/QGnlJEIK0uYniiOwwz43blhVziTGSI8i4Zpldvmg1pQxOq+YZ1O7e1WZ1g/J6DVTd+sC4PaSunFsvx5SKdpcsnEYiVEcJCdb/uj3Gq2imcR7yTt7z6U7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 6 Jul 2025 13:00:14 -0700 SeongJae Park wrote: > Implement cleanup_target() callback for [f]vaddr, which calls put_pid() > for each target that will be destroyed. Also remove redundant put_pid() > calls in core and sysfs, which was required to be done redundantly due > to the lack of such self cleanup in vaddr. > > Signed-off-by: SeongJae Park > --- > mm/damon/core.c | 2 -- > mm/damon/sysfs.c | 10 ++-------- > mm/damon/vaddr.c | 6 ++++++ > 3 files changed, 8 insertions(+), 10 deletions(-) This patch forgot removing put_pid() from DAMON sample modules. I will add below fixup on the next version. Thanks, SJ [...] ---------------------- >8 -------------------------- diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index d3215699a5f4..60a84fffed57 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -120,8 +120,6 @@ static void damon_sample_prcl_stop(void) damon_stop(&ctx, 1); damon_destroy_ctx(ctx); } - if (target_pidp) - put_pid(target_pidp); } static bool init_called; diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index fb24190d2fc0..82a014c53cec 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -100,8 +100,6 @@ static void damon_sample_wsse_stop(void) damon_stop(&ctx, 1); damon_destroy_ctx(ctx); } - if (target_pidp) - put_pid(target_pidp); } static bool init_called;