From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E2CC83F0A for ; Sun, 6 Jul 2025 20:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C92C96B0402; Sun, 6 Jul 2025 16:00:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C44B76B0403; Sun, 6 Jul 2025 16:00:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9416B0404; Sun, 6 Jul 2025 16:00:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8DF936B0402 for ; Sun, 6 Jul 2025 16:00:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 38D6F127CBC for ; Sun, 6 Jul 2025 20:00:36 +0000 (UTC) X-FDA: 83634907272.04.CB0F6B7 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf22.hostedemail.com (Postfix) with ESMTP id 963AFC0005 for ; Sun, 6 Jul 2025 20:00:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="hTQV/EBd"; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751832034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FyipRkuY9DqxgrNjv1TiQ3/zPQyJsyJLvC3iJCCwr88=; b=THeLO2vnL6dIjrWHuAI390KSNjQxsFpNDFOWeFSqLyalQel7jZXlN3DX5aHywagJmHJUlg kncStkE3Q7vJrKZZocZqqZDTQe6oj3jdeYQ0aJ9zCScn0E4mUgsRyGSUtJpodJqfCwcWnA SYlx+W2WnIMjJ0DxaU4qp45x3mvrEfI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751832034; a=rsa-sha256; cv=none; b=IOoAR/cgmTZNouQpCVejkF6QKd4kHjPI5DeLmX4beSIMAhR6p6qF+2Wx7d6Bt4Gt8OG/vS BPfDSV7iWhHSqLfHtiZQD0YuA+9RQi2cjN7A/j92hBbWsNZrDJmed/gvk9OPYv9LsvMfCU Oe7l8Ojz6DFPS3LR4jmixvCXic1WTd4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="hTQV/EBd"; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AD2C844E80; Sun, 6 Jul 2025 20:00:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6602BC4CEF4; Sun, 6 Jul 2025 20:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751832033; bh=kPaBWHAVnTpt3IhJpZpvKlwnOD5/goIRLdoHL+X/dnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hTQV/EBdZ+FEb4l50CWDcbREHDhLh/y+oEWykVciIUzsu1JlCNLnsCdRI42AKrSaB 5AoQVzIj+ynaCVhdzqLkYtX+rllRieKnOtspV5kiuv3b0xyic544cjrjDDnSlh9ccu yBDGKU6s8nvy4J84g1sMnFKa8hyA9cuLp7zDdceDIlcZJiRGRNlJFyIgEyNa28Te8D aVEWLmBL9VTGimWrb4n3OSPxsTLf1nwdz86LKFZKttgKQlwGGzvOLcALKQpt/WT1Ez iV+5zPllFVf3HIuMpm+9Sqb4RMTrZ1RhAvi31afjOnq9zDudzblqruWEMALbd/dy58 vHmTGvQ/ZMP2g== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 08/14] mm/damon/core: do not call ops.cleanup() when destroying targets Date: Sun, 6 Jul 2025 13:00:12 -0700 Message-Id: <20250706200018.42704-9-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-1-sj@kernel.org> References: <20250706200018.42704-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 963AFC0005 X-Stat-Signature: 6o3f87earqqkb69th5e5d5zkn6t9g1sr X-HE-Tag: 1751832034-25991 X-HE-Meta: U2FsdGVkX189sgDk9wYk9NAvgUY4wZQMouWskWVYDtAbhlJ6dqm71wqlamqbI8Bq0ZvWbOHLez78KIgX9gzrebNbRkQeJEqMCuYZEQAORo3EI938NAP2Hb6Msxd42dxKLdNNuttZdsTd4pPn+E6feSBi6br32msVug4Q7PCKtklPCWNRyjtSTJOtFtLG/QxaktmSbZzydeoZIGeRt0FKb3gaBJXczlK128G8sJITl8pC2Fv8IOEevbAvFCKWl2UicXgKj8ec+/BqEZ55b4Zz9V9gQs3lsqX5+D/KvpcR6fd6uefPseoATX/uYt7K7UX4Z2oCM0okhnlnRX2Qx78BLwxN6Lqh4fv9ziNx87NEISOIwx0ALjTONO6omwEcDGhysWLjUsOkrEpdu5AYjOSrg7JQxlBwEGiQ18TnWYHSebyDB5Xvhblo0i/JI+xCQgOCnZrNjahUKqpXgWyF+TS4ZTepEPX7G1ghbyyihCbc/59GVIjdOVVHMxHwZqaCnuknplsGjMeIOSa0SDwWfCqiwV4H6zFikZEMu+nR764jg43/gT1/ej7aeyih1HSzcOWBCf85J6V40M9x07meS4YQRuvWQdsvNmCd0UEJH7t6B9w8Hu4AWvv01kYapmgnFbyWnn2eBG+rnfAiCAH8DnAupM7BBpl8lxSKEKrx8bH4BNxu2K5RZLm7dpH+7H/pGrT4CXadlBGjdtxGLAMVILSZquszuqV8L/OoYZmrZE3T5ZThjKkP4cvhHFaPysvAegwWk6wnmNxXMAaMi1//wrZTCfv1jyM+/6KEUMEQPAPGu+skM8eQw+GLQk6Wuhiv91NPdAhsMdSdsGiY2vhmAe0KOOLeYLu4Xwr1wmsY6KMyAOeyPtJUVpJXqTU7dKxcxqkKg01iNwchKoqc9pwGQNuvzHecpdpUDFrTwYpj2Qp/SkcnMsWpEPVqstNCCH55JrcCyTdtaswPVGPg3Of31MR BpjbcdQB 69ag9eS5+Qp5kpwSd1mVEfVyzDuknazqd+9F4OukCN4GzzBVVK41vdF3Gd8ImUhBkY1jQ8spMQfo7pm5zmkv8cky0seCKNhi8XRFMqOrdx1ol/VNJ/Mp6vwLp0RAiHieJJblirk7D/x58n8uD5QH6NqhlliAJIHpyCsTej8w/IzRcysqoMKKRqZK9MmN7tZtc3+cuRSa+GArRXDEpXQAwRR5vp3ijDHfYz3BF6CuIlSxu47KlHO/ykV1qWRkiQCpD2WXrhrukSxDKQUc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_operations.cleanup() is documented to be called for kdamond termination, but also being called for targets destruction, which is done for any damon_ctx destruction. Nobody is using the callback for now, though. Remove the cleanup() call under the destruction. Signed-off-by: SeongJae Park --- mm/damon/core.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 7a4dc76dd023..eaa2306ff324 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -550,11 +550,6 @@ static void damon_destroy_targets(struct damon_ctx *ctx) { struct damon_target *t, *next_t; - if (ctx->ops.cleanup) { - ctx->ops.cleanup(ctx); - return; - } - damon_for_each_target_safe(t, next_t, ctx) damon_destroy_target(t); } -- 2.39.5