From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C82C83F09 for ; Sun, 6 Jul 2025 20:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58EF56B03FA; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53D766B03FB; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 407276B03FD; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C39F6B03FA for ; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A2A718022B for ; Sun, 6 Jul 2025 20:00:30 +0000 (UTC) X-FDA: 83634907020.11.FBB40C3 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf30.hostedemail.com (Postfix) with ESMTP id 3725E80006 for ; Sun, 6 Jul 2025 20:00:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=it7NQBAW; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751832029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFkduCscuzqS2cVp7iuMW+eyLg/1OXMXZG7sEaCKTug=; b=bHToOrQTtwyF+WYYjGov9aGGdM3fFz1aegSTU39n48dQrC1x6IZs9iN8zL6mm6M8luSpua 2b1YMbLkRhbwvyaTbR+eak415ke948hLBIS0XlOBnBYyTquCp7v0WSdjyx0uZIXqwSGmpv 3YwvXhcRTedVP6Zx+wSTDjcvZupk2+I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=it7NQBAW; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751832029; a=rsa-sha256; cv=none; b=piRKgMZKXnTxRmYtOSB1CBQHtaZpQVA6LnrSS90sEACOgE/wfUqC6RFTkyCV4L/NrPiRMY 8Nk8uOqLBaBVmO/S3m8l2oX38lgTQM/UHf1mugNHnLwGnm912PY3WbwieuiY8GlISIyz8s rFWVEo8+C3SX/s1ollbyLpEXW4pPEU8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5AB5E45F1B; Sun, 6 Jul 2025 20:00:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C53EC4CEF8; Sun, 6 Jul 2025 20:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751832028; bh=zg5wCAX53+Zaz9D4ii0pAZ1fdfy4NlBPdESVNdjo6HE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=it7NQBAWoPO1aaM9WpLvrXffl0pPOFaII5ba1fwJtcuYoLlKgAlonWs98iz+wwdWP Do0DFn0jT1Q7jPqxaHWU7dhBY4eQ9lDPuA0Sf27Mt4qSANRkV1ub05pW1ZZ46k8Qa/ lzgm5fc314ixUmmp5kxMNPXkakT7xgOXHfeoEXQpuiKbw1Fkspm8hIQ9rqui0OZ45Z XWC8y3/54QuPlziwBdvE0S+wJG8UE8+ivDRG12LtaQiv7w5N8piHpaIQ7vkYK8cZum 1PSun8pa+xGy+MsOsLfA4HVbWmXFh9Kd13a2ZcJnYId61dynFyf32kpccGqo624mpx 21IpiqPIL4SSg== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 03/14] mm/damon/stat: use damon_call() repeat mode instead of damon_callback Date: Sun, 6 Jul 2025 13:00:07 -0700 Message-Id: <20250706200018.42704-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-1-sj@kernel.org> References: <20250706200018.42704-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: dgokbmyuhd6rzsxyfdrh8upb1s3yuxfh X-Rspamd-Queue-Id: 3725E80006 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751832029-499789 X-HE-Meta: U2FsdGVkX1/KqWiOwgIZCOxBGM3nEgP2BnIiaozrN8bDgl6vlYfMLFR40QFSrnMbierwLvAc/j3BVSIlSYng4vrr02Je3qEmRZvJIEA2IPn7snWtZ8NMYYlwv8/eo7NQ/6rYEXsqDjDsODE5/gdPdWSlFTI9XU/PrrfDRjZqj/8KX6pse9Kz/YAidTzivMkC+EeRJxGFXgwLujxWOmtNV6IxSF7z2xnzoea/iiIXcj2IJi2xF/Sn7wCRfAtJbSv9RT2gf/84GJHAYFdPakYx5m7/K2hSRrEujAZDGq3hiDrSuskKmpI4hXCJ4uUekuNL9qVdlkQ0dEntW6xaMIxl+vOHYVQ+mNJelsWHgW1nQumWv9TuOj4/4qu2B/nN0SyZfT0GRszTLiSru5/yJiUyfwSQ83V+zzADjc+FWM4VtK9IwVZOkR4jP+tCOAx6BLn+9PEE/z0u/73oLtgUgTHwHz6dNkF7/q9FE1hsoN/LjdJxd7EK5yoPHPOW8yAHm5dYqU2nLdfFGf4eNFpmhrzWeSJhIe+Iff/wycEpYXJ54V/pqlH2LZoxu1GLWI5npy4upbzeZBjYe/6gvRJCMlWtsrnl6R5i1GpBDTUsgToL8xOAXwnSlpTJCTNxImJIBiLOKqWd2MnkuEXoFQDSD8Fx/sKBXsKsRPmRXOZKbbwRvWrY0/7yEUptA5QEk/mc33+1pL7gMg8j0C59n0O81vHIN2k0GJABK5qPTQccHWPZKLoTl1n1q9Xf23vXcLMMH+4v6HhBrxLDmgl9Vad4lnxhaF+6CW989S4SXS66IMZsv56+fprC9a+mbpP4bBPEOw74tu2iyHNj4GJoO9ds7zA7bOZ52rlZbMg6p6HCzQH5vOYk6Q/5JWzn9Bopz6JKHHDnRd4AMGUct/loFvfhct20F/5gkTl9FEmeOUFJBbnggdSQDRmnBtQJnu6/Ae3kFRXFe/LwKWkr6b2p+ifCRqS IN8PLvE4 HR9pf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON_STAT uses damon_callback for periodically reading DAMON internal data. Use its alternative, damon_call() repeat mode. Signed-off-by: SeongJae Park --- mm/damon/stat.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index b75af871627e..87bcd8866d4b 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -122,8 +122,9 @@ static void damon_stat_set_idletime_percentiles(struct damon_ctx *c) kfree(sorted_regions); } -static int damon_stat_after_aggregation(struct damon_ctx *c) +static int damon_stat_damon_call_fn(void *data) { + struct damon_ctx *c = data; static unsigned long last_refresh_jiffies; /* avoid unnecessarily frequent stat update */ @@ -182,19 +183,29 @@ static struct damon_ctx *damon_stat_build_ctx(void) damon_add_target(ctx, target); if (damon_set_region_biggest_system_ram_default(target, &start, &end)) goto free_out; - ctx->callback.after_aggregation = damon_stat_after_aggregation; return ctx; free_out: damon_destroy_ctx(ctx); return NULL; } +static struct damon_call_control call_control = { + .fn = damon_stat_damon_call_fn, + .repeat = true, +}; + static int damon_stat_start(void) { + int err; + damon_stat_context = damon_stat_build_ctx(); if (!damon_stat_context) return -ENOMEM; - return damon_start(&damon_stat_context, 1, true); + err = damon_start(&damon_stat_context, 1, true); + if (err) + return err; + call_control.data = damon_stat_context; + return damon_call(damon_stat_context, &call_control); } static void damon_stat_stop(void) -- 2.39.5