From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F28C83F0A for ; Sun, 6 Jul 2025 20:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A228D6B0404; Sun, 6 Jul 2025 16:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D2A56B0405; Sun, 6 Jul 2025 16:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C2D96B0406; Sun, 6 Jul 2025 16:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 727F56B0404 for ; Sun, 6 Jul 2025 16:00:38 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 326E7C0211 for ; Sun, 6 Jul 2025 20:00:38 +0000 (UTC) X-FDA: 83634907356.18.769A664 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf20.hostedemail.com (Postfix) with ESMTP id 8F4C31C0012 for ; Sun, 6 Jul 2025 20:00:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ToRJq6fY; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751832036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rIsgJNYbb+slQAEYjpOw8tMBaoQQ6xsiYywvYoWofWc=; b=CMnHJt+ntdl6TKxiIu7kYDzZ0Qpj9gFBVM8ZiQMcrtG4c7nFBA4zTyFoMvMTXEHVTvjUOq 1KZ4LXDSwodliG6b4v/nH5dROSdpFXKSoA5gFqKLHB4bj0OjsRwlwTZ49oiuHJOXy3aJqf 43XttdO8IyJdr5K/dpZT3qU2xX6xCZM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ToRJq6fY; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751832036; a=rsa-sha256; cv=none; b=3spLjRek0hAA/N/AvyuSLSlOcaL8JjIM9aihqY/BMJZ/fC+T5tZvNkvPYFucO1J4+WZRyY rxyw/u5PbyvzmfBxS32+IpwtUG70BQNEfysekDEH5Px7LGTk9rDizdL1gztWx5EvP27jIT V5DhSZxyp9F8yfu8qZIqG/Ek+HCNmCY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 13DC3A53E02; Sun, 6 Jul 2025 20:00:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EC5CC4CEF1; Sun, 6 Jul 2025 20:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751832035; bh=arW9HamBDNLK1yN3sYPk8GcM8z+8LRLU5gO/RN527TA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ToRJq6fY2uHmmSXBV+y5yfAj4+RYgewQgtMYQI9cnh/YJJ35fO8AbtImb2cAiFPbq Y/8O+/vMt3ALjdNk7L3JbN2Qy4NPFrWv2JivT+LctVl+s9nf8LPH1BagIRI8OWz8fK p52tHZYlc4kzP+0S85hV1JtmzuS+PNciFusmjtPyjdCa95I4bVobY2qP0NOD+Mngp+ 01+SEHAufJrEGkFYSGJkQjRTuZr15O+myKC0FcE8ZQxgRX4N1KvAbi5Cdgf92dNTqx P1eD40XDQAWzN8JUv0G2a+GNbUxZLeOCZZDCqXq7rV5bGapONn6ke2Uq0c8Zbr5vkA Q3z+TavRLsyEQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 10/14] mm/damon/vaddr: put pid in cleanup_target() Date: Sun, 6 Jul 2025 13:00:14 -0700 Message-Id: <20250706200018.42704-11-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-1-sj@kernel.org> References: <20250706200018.42704-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8F4C31C0012 X-Rspam-User: X-Stat-Signature: muhhby5ts8eusppi4arrfrunjoa8krqy X-HE-Tag: 1751832036-784999 X-HE-Meta: U2FsdGVkX18OJr0zSnpKSqUsJY18ZTE+j5ZIEAGQpfZZdbqO6S5r1pahA1b4pjmkgg1vbTy5YP0ibpf8xYzUHVJ0qMAeQ0TNsYmWQxf7khIq5JjBCKpDq4/IkN96Jgl0gZ0zRxmHZ0xmVv6t7UnwDT2zmyWff+haJmrfRUirC38zEfGGa2HetG6uDE5oVLG6qDcut6kwaWnNiCWGD01QeWdNIhX+zuiDX6ET3lfDwh0F0MnuxzIBrdR85yoUzwNdoovWTe7cRYmwD5yuzGcOfL1SAKhXEHr+Kb7gQpifYsI2reXORqmoBRPbq+BsS26fv9oogFF0bI1Xkft5MLcDO7Crgr7+NM7pmPfqnXz3CR9DjmGD5yjv7MAobtkLRpGNKTJm2wVwwP1r3EJmkU1KsOd0jE8tTVzKx+K7n21asAHy5KjnA+M9MPk/b+Jsy+hRXQ9bEDI7xjzhEtMcX1A7G/DGYNoZqNDUWsYmHCV8Kvn3mr/xjIrftPfWHQd0qVO4pLLlmV7exAUaWQ19k1+7JD9hI5psQoUdttwILVrRftdCiBW9TIZg+aGg+cUoop79LWzzrORh+XXLAYCXfoBHBOFi7r4QkPT+RxPDI4H4zElfY0A1fDF7C0W2e2A8y+vkHyYK8NU1xDOVP48tx1R4jgK5oF69qoPRG7z5gvtOc2qUx4mONXgZ7pRB5MmTUituhOquwI6schECk/YBR0ocplH3WWSeR99PVte6wyEUxafBhl2oSwIfpI2gi2YMxcCqGqrBXRGsKkt1Muf9Alji03dUjV3h8klOjkHLn/iA5NTYayaX2zSMmQh8LxGtvHQY1ygH1BY446acE0RwPIC4txrXUr1ph5Ma/HCF0vmZqky+ur7inLchZcANiuTZOJ/Igz38kD5gDAyDewsjOLFo2aqgOLytFtZStBZ14kg5JiWgWTxycRw7YEzKMsXiT+qNRG9sFgYWSYj2EhcAlXU XcvvC2Qm u4GBoPyI0NAiFjXn50pEGwQymLggYwhAaCrKeTBFuarYlkqSwaP27IN79mbyuhkjrIq6STpFGUpKgIzEA9wNePNud60UkTIgx7/RUWnVdm25L+U0kxthwxlEBhjfhk2Gyt1Uj9JLvHW+FVIRjHr0Mschdb0JncxE9UW1yiQO9t9mvRjBhrgRb6YUEEEcN1iEaPFa28t+3/11LmyZq1MhaeEbbrRgntbr+FBCBWqTAG3KhRfMKVBUibrRjE/iwIm33HWYebDC/ZQKItV/UMNYneNeWSEjDu10A7FZ1yGq32qS51jfjIJ2db+CCjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement cleanup_target() callback for [f]vaddr, which calls put_pid() for each target that will be destroyed. Also remove redundant put_pid() calls in core and sysfs, which was required to be done redundantly due to the lack of such self cleanup in vaddr. Signed-off-by: SeongJae Park --- mm/damon/core.c | 2 -- mm/damon/sysfs.c | 10 ++-------- mm/damon/vaddr.c | 6 ++++++ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index ce1087b5436f..6d526c5263d3 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1099,8 +1099,6 @@ static int damon_commit_targets( } else { struct damos *s; - if (damon_target_has_pid(dst)) - put_pid(dst_target->pid); damon_destroy_target(dst_target, dst); damon_for_each_scheme(s, dst) { if (s->quota.charge_target_from == dst_target) { diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index f2f9f756f5a2..5eba6ac53939 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1298,13 +1298,9 @@ static int damon_sysfs_set_attrs(struct damon_ctx *ctx, static void damon_sysfs_destroy_targets(struct damon_ctx *ctx) { struct damon_target *t, *next; - bool has_pid = damon_target_has_pid(ctx); - damon_for_each_target_safe(t, next, ctx) { - if (has_pid) - put_pid(t->pid); + damon_for_each_target_safe(t, next, ctx) damon_destroy_target(t, ctx); - } } static int damon_sysfs_set_regions(struct damon_target *t, @@ -1387,10 +1383,8 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) if (!damon_target_has_pid(ctx)) return; - damon_for_each_target_safe(t, next, ctx) { - put_pid(t->pid); + damon_for_each_target_safe(t, next, ctx) damon_destroy_target(t, ctx); - } } /* diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 46554e49a478..5c992317ee4c 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -627,6 +627,11 @@ static bool damon_va_target_valid(struct damon_target *t) return false; } +static void damon_va_cleanup_target(struct damon_target *t) +{ + put_pid(t->pid); +} + #ifndef CONFIG_ADVISE_SYSCALLS static unsigned long damos_madvise(struct damon_target *target, struct damon_region *r, int behavior) @@ -711,6 +716,7 @@ static int __init damon_va_initcall(void) .prepare_access_checks = damon_va_prepare_access_checks, .check_accesses = damon_va_check_accesses, .target_valid = damon_va_target_valid, + .cleanup_target = damon_va_cleanup_target, .cleanup = NULL, .apply_scheme = damon_va_apply_scheme, .get_scheme_score = damon_va_scheme_score, -- 2.39.5