From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600D1C83F03 for ; Sun, 6 Jul 2025 18:47:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FC2D8D0003; Sun, 6 Jul 2025 14:47:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D60B8D0002; Sun, 6 Jul 2025 14:47:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 811318D0003; Sun, 6 Jul 2025 14:47:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 702CC8D0002 for ; Sun, 6 Jul 2025 14:47:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1528D1401F6 for ; Sun, 6 Jul 2025 18:47:56 +0000 (UTC) X-FDA: 83634724152.08.E06D5AB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id 8F8094000F for ; Sun, 6 Jul 2025 18:47:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gi5aF+Bk; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gi5aF+Bk; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751827674; a=rsa-sha256; cv=none; b=u2bc5CKonSurBScD66LtcvZ/6SzzK9jzO0J3FVKvZl+sJwYSHb9ZQep/FMBa0V58lTOx3u AQufOqjjrCzmK5D+NxRSl75jV62XEx4rsg03Il9PRSXorZdc8mKjooB7zFcfl25pVWgByn 3stUbH65L4qajD0LQYMssba4j7hxwR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751827674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=I9V86BV6A72oZfu/a60eHp8JI+sePieYOrKgD5LZWOw=; b=NzN1R1RLgR8v9VwqzIrg0Cr/KKt/tksHzBMdvMmZfBTPRhKzrzVzKeudSxr7rYSdd60Coz 4YwpxkJLHe/XTgrmq7VTMw4yUJAsFWQimGha/ZkHt/Q8NljYLlOBA6MZvuW9og5JQeBUuy MnNeIzr30EfQqiVjdzZTVJMhdsEfTYI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B2402A53D86; Sun, 6 Jul 2025 18:47:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 380C5C4CEED; Sun, 6 Jul 2025 18:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751827673; bh=cLVy1mKDbWXN4aNjEWgP3z3+agHOP3HLGlEBVSPzMo0=; h=From:To:Cc:Subject:Date:From; b=Gi5aF+BkOP3T/VA9JQHYB6C/56PWFLJUd7wtGFlkFdhxYtiem2dv0IfpbK6tJ9AlN HcO8pguoHXH+bsEumkufysd1LM5Uq4WG+9uEYAVyElcohocskWgmym3zAgAR4cV39U 60V3lW6edNbBz5lljCvfgbMVseQt8/EkJZVI6mN9vhVuK7CduwBi5PkMvKW06h5eKQ mglxOOqt9mPhZnUSQWppILgD1eBShf/dOq2p+OswraXym/990tDJu7wV6/M3Lq5r19 LrzAdCV0fdgXZSuoJj8aQCkKcL8wdn7D41d6rlfWg6RQaAzSQZS0wSiwqE2/zdFhIp QqjFsXn+c8Zcw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH mm-unstable] mm/damon/stat: reset enabled when DAMON start failed Date: Sun, 6 Jul 2025 11:47:50 -0700 Message-Id: <20250706184750.36588-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8F8094000F X-Stat-Signature: e5w8fhuhr98hc4nghf8qz4zuh8e5x587 X-Rspam-User: X-HE-Tag: 1751827674-259716 X-HE-Meta: U2FsdGVkX1+QTIbCfk5F5zwILoNUCmcFsqJuFcO3bVk3Ml1tyibasGOPjHb/VhGubOcP5H5uTrqxGLxcX2y45isHf+9W7yLUivMFBQwUp+/14a4Hb6EWqWr6oGyTZpNMm6srIIju08uffT4eid6CGN/lUCLMKSJvp1P7KuP3fe74ETRWcNqulGANhwc+UhNKlqi0NLE1sZaf3NouH20m4A9obRIQ0n/qqvXvB8EvWn0+pn3/msQKlZydpo98fddHG1Ue2YQoNjIFCQEy0U4Ac73Oswi8H8Hqa4irCEQBE3e6iKRp2TZS/bSd6k71t0mZK3cv4BS+iKABGvRiplxfO3Q31ZvbXQIMgIVtfgHzSelsQRacMaW4Xk2jOW3oPeeFFjXlDZv/vbzmUDqeY8zbholDXRRDYxobTWRmcMHcuvWtrUHhRvCyDyuqqJz+TYOm1yZzmPAQ1gPj+kFGidnwOBIE0K1JbK/tVf+GAybARdaxmn6NnzPf0OmwtKEiGblaCgtbs8c8RYLZ0g9tvGCfqRK0tnO9bIBc20vIdeqdhyjdReROcWDjWFC+CPPEYVF+MJQh2hZnqh14bf/hYd8fh93IxnfARkD1d8JWfvjQ25SqSnWkRx36z7C146PqF0OQK1E7sptOZ8hl0Zvg4jo6DlWHhCb9/cfsxmzD/l5T0OuNgVogyyEzKjsQi4jlwpnwBsGFu0ZGTU/BMRVdSciKdNWBc+ibhqtUJ6b1GwMIR1k4JvETPjFG3E66tZRjkteEseiiQBaUSKACJzA4kt4+lxsKmGFzy4uZXzObKMmsRdiNMnhLBO99AVOfyzwbbFKrqwu/tCxkzyHUNa7JlycAr/0+M0THZds/y9hIxgHYa3Bhse+IUHt7Y1YuBdThJ6oreGWTUk5Em8Lmqivxe4cMe5osLv5HkjbZblbpNIxg3U8IpR/Iu5/Y9p6b3g1WfpT/64KwqkkYF1ArpNjq1YX /JdPYkW/ 28EopNgIRSj/ieMckT9J6y1jnc2p2QB3E3U94PO/E1OWFVdWjIzGcnpUsz5cPPM7/7VBgrbnIkbD3Q4Z/C3sx3LcWJ9AjFU7Av4joNkYbSJ1PlCNiOsPc91z4ob60kBKdHwtjBJY9b3Rl5gLRkKaUMI71YY0zCP4wCS2L6OlhKrogqN9uJtvymti/bPkbXNJRw4KyKoKIuw56ZvRn1t5ksCRgj+KJ6kEosnCF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When damon_stat_start() fails, 'enabled' parameter is not reset. As a result, users show the parameter 'Y' while it is not really working. Fix it by resetting 'enabled' to 'false' when damon_stat_start() failed. Fixes: 00e74895aba3 ("mm/damon: introduce DAMON_STAT module") # mm-unstable Signed-off-by: SeongJae Park --- mm/damon/stat.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index c35bd1852f0b..b75af871627e 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -225,8 +225,12 @@ static int damon_stat_enabled_store( */ return 0; - if (enabled) - return damon_stat_start(); + if (enabled) { + err = damon_stat_start(); + if (err) + enabled = false; + return err; + } damon_stat_stop(); return 0; } @@ -240,6 +244,9 @@ static int __init damon_stat_init(void) /* probably set via command line */ if (enabled) err = damon_stat_start(); + + if (err && enabled) + enabled = false; return err; } base-commit: 93a51997eb1dda993197a9f82602b96d56056ce4 -- 2.39.5