From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E01C8303C for ; Sat, 5 Jul 2025 21:05:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 258946B03F7; Sat, 5 Jul 2025 17:05:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E25C6B03F8; Sat, 5 Jul 2025 17:05:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A9CB6B03F9; Sat, 5 Jul 2025 17:05:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E59FB6B03F7 for ; Sat, 5 Jul 2025 17:05:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5A926BE038 for ; Sat, 5 Jul 2025 21:05:45 +0000 (UTC) X-FDA: 83631442650.15.FDB9981 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf20.hostedemail.com (Postfix) with ESMTP id 257ED1C0016 for ; Sat, 5 Jul 2025 21:05:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fu+RrrDh; spf=pass (imf20.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751749543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QNrGEXREXb+VRaOAxlii9StjIrHTh79zxrBn0vyAHzE=; b=rDn6wzXTjwvyJgX/AbpGQin7otEW5E+k8mmm8KeR1nOWaBu2nt0h373OcVXKwHh8noeeZZ ajoX8h6LGtDPkX1tR/6mm8QMekAH5VvWe7raPZ2Bklkt+JJ/cTatnXH5Y78HPmjuCWVfJ/ Szf2LTFA1AXalZQmhT7ndgnk5coRFBk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fu+RrrDh; spf=pass (imf20.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751749543; a=rsa-sha256; cv=none; b=pt9kZT/aOsq+nwxebGRGxXJyYJ3CpMD/B/rEc6nFhRn/6GZoW+RaMQ0V1U1379eDkZvQ5W fKdQUUzWQOKLOTiOObFKT0etxM6Xf+XlmSZIhsYWdRIeJwD/GdXu+8Rw40CuHorpIoh/c6 W/UIV/1ihdx3oEaR7KiTpMVSZV0Z6io= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-454b1d0a115so5435245e9.2 for ; Sat, 05 Jul 2025 14:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751749541; x=1752354341; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QNrGEXREXb+VRaOAxlii9StjIrHTh79zxrBn0vyAHzE=; b=Fu+RrrDheiyq9zVuQ2NasG9pmnk42IJssnWHS9u1icL+DASnL8OtgF4hPsDlM58aBv hM+8+AGkqi88KQ66aiHzG3Uac2UizOHc6Q+W9e5Tr3JAdCmkDQaNDJ6MZ1GgMZYzT1Gg or+cPnL4n9Q3Knq+AoUk/n1mC/A6cLHC5X1i+to5UuGf59X9/s6rqrv0EGrxstMBlwv/ 2WVXvFbQmMOVHd5IIBy2XgyY1hC2i2ueVAIsnbHOoAOhh6TZ0aoCnWZ2AEPW9RIUzfEy chZatL/3Z7fuSEILHLersSlBXJ32Qnd/kS5Co3VWa3cR8zkOPHntv5hVoUir1AtqGjc4 bhzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751749541; x=1752354341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QNrGEXREXb+VRaOAxlii9StjIrHTh79zxrBn0vyAHzE=; b=SVRVKMQdK/4B+TNI04pYCFQ+k+lhKiwI3lrBVFncNHUKTZSxTpAMoz8S6wGqK3dlPu kDT63yMBQ0wa19GfSwnbu981xCILZtWBf60DAZIskCL2B4JuNKcn1/z0RhDIlw43U5ga 10AwkFHUrZ0BbuGfzmMRJBeKbHmKzM2T9bLTwM/iFpxZ8DUvIZY/5gXLwv3Kgt4sfRiw RJlitrJTx/fCDdJ4rFz5hrahtYKmvYdiNhkjC522gir/DULoZBRfuIR4edJqcqGZjSj/ sneeRwieybJ+i+E1ZIe962QVkFtZ30QBG71ScMT++BOVKpSCqnImdzaZqEGMDzFW8V+3 DhPg== X-Forwarded-Encrypted: i=1; AJvYcCXeq/Kwwn0Bq2MfJhgosZq1wg71ufAotYBaAMcyyLyCMm00M8bHrmj0ni1X1EGfYarREuZnHVvqPQ==@kvack.org X-Gm-Message-State: AOJu0Yxr4Hhke6rbVI7bzckaKvv8/JA8in27+b9WGx9IRF1XcGZEWUhs 9dKS4wiUaZqD+uNWcCT0ESktUzu3kkqfeadELijz7tudhshdi0tAcf3r X-Gm-Gg: ASbGncuRMMYDi4+1NAB/73VmPByNDPsReNm6O9+t8YWg0ypt/l3CQJBmKTEy1VxSBrP EgD8AAcSdBSZQGzofSHRUJWJ8pdTWkKrGJG8dQfzdhTPMN7xka8qq6AnSoqkOLNYfHZTzKcMU/Q H4RASIez0fmQbwoVG+5HbuP4rLJ7RS3+QWhVetMxGTYpep4/Uf8jf5JrOHTwpUenoiaAjENK+1c 16Go77BaocmJ8mtsUeJyoBTPwy6ubXsde5UFZq38EZ8CRg252cGCwtlR1iBrVFZ5CSb7h+sBnfG gj/WbdWueqprdOAlAHNHGEpu5DyxJN19ypn98ZR6nzbZb6tLpRKx18oxp7Z7Z9R8RVSbg1ryXxL I2Ny3EArwJ+A/6g6xeCkG3ixISkIr X-Google-Smtp-Source: AGHT+IGT+GFP2/eh/DyGC1nE94xXBDFJpNvsPv3x+Wo4Su4HQLV99sMh/vey3UY2hxRw+Q3uWfEPyA== X-Received: by 2002:a05:600c:3153:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-454b4ea5f53mr76967405e9.16.1751749541160; Sat, 05 Jul 2025 14:05:41 -0700 (PDT) Received: from pumpkin (host-92-21-58-28.as13285.net. [92.21.58.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a1705ed5sm66250775e9.2.2025.07.05.14.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jul 2025 14:05:40 -0700 (PDT) Date: Sat, 5 Jul 2025 22:05:38 +0100 From: David Laight To: Segher Boessenkool Cc: Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , Alexander Viro , Christian Brauner , Jan Kara , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , Andre Almeida , Andrew Morton , Dave Hansen , Linus Torvalds , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/5] powerpc: Implement masked user access Message-ID: <20250705220538.1bbe5195@pumpkin> In-Reply-To: References: <20250622172043.3fb0e54c@pumpkin> <20250624131714.GG17294@gate.crashing.org> <20250624175001.148a768f@pumpkin> <20250624182505.GH17294@gate.crashing.org> <20250624220816.078f960d@pumpkin> <83fb5685-a206-477c-bff3-03e0ebf4c40c@csgroup.eu> <20250626220148.GR17294@gate.crashing.org> <20250705193332.251e0b1f@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: ktf9m6daabtbingb95zgqigz4ori6o73 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 257ED1C0016 X-HE-Tag: 1751749542-131629 X-HE-Meta: U2FsdGVkX187t8K+LgOiLGIYuOmc0EXXKkLg+bHNE8HNE0qRRlyCHDdVuuTy0dJ8assS3ouHW60s71hQZeII7XiBbg0+SVCrgY7QfTXl3Ag6RKGCDeQ40ovO38pHU99JBnygNZ8HZgDUy4cpzdTw+duhg4zuohSl45vTkSLkrbeqsNB2vTUgovys3mkOOflKr4Bff5xyQbll2SxZ5qd+5PdvgtThx+P6Br1poaSHa40lN4/7vayTZRk71BnNgYnJjECPhzTqG3Hd7/DLxzAE54SGJotwduxxCrnCz86FrSmwI7jeVAfOLTVfqI/VTHyfktDgHhwzdKUp/VlLoJn5N072HCdshiv6uT0SQPq7rIuX3dpy6dn9fP5TA3CCz+xN4cNIcBxdUeMZ1bHjjcg8I1ThvctOOJRGVTBk81FtqshwSDjYN9d28t7UTxLMpX8yas2w8keFbeFH6tdfJqxXYkyxFRSGU66VemXLfRly+mb9KyeAQ+hmSXONiv2S7juxMP7IvXO1yWQnY58x8w0wrsrTrtBC4IRDE33hVrL4l8uk2AKeVRfj2DHNqK40mcwnuX6ys+vWeYzt8TT0ICKqgJaeJva73svUKQagcb/KgIYBRF3t+Q5tQH2P2nh10PrxSlCN4ofmF0GKxcJBzG8Rshfnza0DNH+vXaOK9qXAbkqoOfLafxbADMdvjDeYfNPpkn8zJYgCT/gYNQSdRpROX0Cr+Hfc9tM3jtSNriUN/oPOyKu4/f2X+sFdbY7CjRdda+8lb76gOaFWlGc4cBKbawxvbcnHMKvjplvU8ohuSClUsCQVDykLrlY/0uILEq4pUXULw3Ke1io7HXEwKMuxMCOJO1B2lV6aPUZPvmLAdZYaW4NULwGo+dJsjPYHMKrCBihgh3dz9W0QfrK82TLushcnzOPvZQt2IIe5lBzSrLN8m1MRXVbPBPrxK5SR0MYclvig9VgI5HtSN8+G/oi zftZTHtt y3uKZG5qqF3w0rLTiC0zIgM9K01cKE1n0QPkHC28hiI2CzXWMhsOUQyCCHm+deZXcKgvPDpUGOMtHuOJNKCaEl1z+DtBAEAPIkRF0hiu0VaXRRHmg6Jc7LtAZgqsB7z3iCiUZYU0ZXkpAWGzZme7eRKkceN1lErc539NL3jxPv9IsWbbkjFDbl+af/A18zBKzbyR0hZhkX0Z9ouPTkHzglBIX1gFiqTDfb+pf5bIWNXn4fBULs8ZDvvMKfLgkB4d8HN+tJTklQGJ3RvlKbMusyqpXb7sz6DyAwewbX1IFSz8OvKkPPouEB99lxFtZi5dbt8cnLOIg69X6lP0a8Gg3GdcfZq0ru6CvZIdlV9Op+5/oaStzvYL+XoM2TFZkk2wOT1iB7Yc4Qf//4ndnHMWrf0zGOZTYNT6495lISj2Erlpfhb1wDlY4GnbIAdra4otY3YrpNDKb+CrdBcXAhJQgh6QJL7tGsgIY5U7DHOZ4nhTBEmc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 5 Jul 2025 15:15:57 -0500 Segher Boessenkool wrote: ... > The isel machine instruction is super expensive on p8: it is marked as > first in an instruction group, and has latency 5 for the GPR sources, > and 8 for the CR field source. > > On p7 it wasn't great either, it was actually converted to a branch > sequence internally! Ugg... You'd think they'd add instructions that can be implemented. It isn't as though isel is any harder than 'add with carry'. Not that uncommon, IIRC amd added adox/adcx (add carry using the overflow/carry flag and without changing any other flags) as very slow instructions. Intel invented them without making jcxz (dec %cx and jump non-zero) fast - so you can't (easily) put them in a loop. Not to mention all the AVX512 fubars. Conditional move is more of a problem with a mips-like cpu where alu ops read two registers and write a third. You don't want to do a conditional write because it messes up the decision of whether to forward the alu result to the following instruction. So I think you might need to do 'cmov odd/even' and read the LSB from a third copy (or third read port) of the registers indexed by what would normally be the 'output' register number. Then tweak the register numbers early in the pipeline so that the result goes to one of the 'input' registers rather than the normal 'output' one. Not really that hard - could add to the cpu I did in 1/2 a day :-) David