From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E7CC83030 for ; Sat, 5 Jul 2025 17:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925916B8079; Sat, 5 Jul 2025 13:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 839586B8067; Sat, 5 Jul 2025 13:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74FEA6B8079; Sat, 5 Jul 2025 13:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 61C336B8067 for ; Sat, 5 Jul 2025 13:50:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1F7A28021E for ; Sat, 5 Jul 2025 17:50:11 +0000 (UTC) X-FDA: 83630949822.18.26DB70E Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf15.hostedemail.com (Postfix) with ESMTP id 90A88A0007 for ; Sat, 5 Jul 2025 17:50:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=W8nDk0gF; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751737809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Mini/Ab+S4GpeWQjyDlpxVn5wCOQvk0118OQzpd5KU=; b=vtlTmkqcofn1chLASCGZ8fojpOrFeCzCpvlIN68sseeDkTnvR9wjtwknn4ak2iiZBTlAP6 NVtPQ/eKGxz6c6nrF2eKq6vDCZaH+qWyfbWcXBbV7fWw8d+7sHPcgZse99Jnmq27Fs48cS jbOLX5i6Jy9WEi1dwHC2cFfIXjN/pnw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=W8nDk0gF; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751737809; a=rsa-sha256; cv=none; b=aFmJbzBa4s0KX/XZxp9S7CV+UyoZqLwb5vpter7DJnPjCnXHVwPBhNBB9DhjqY+MgVsqvQ HH2x7N5B06O6UFb/KPjdk8ieOJUMhyqV5uT+i/ib2ADGwIFYq6nqCz7j41ky/Zo+mz5VLo 39vq8U0CiU9GyIpc0+Cg/sQ7aO9TBOo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D0DBB61133; Sat, 5 Jul 2025 17:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64686C4CEE7; Sat, 5 Jul 2025 17:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751737808; bh=caVLtvekI2dzKAOKguvjHyIU7EwG2c4nf8nQzeNWT3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W8nDk0gFwQeLCYbtF1Ywc2Mz43fM1+I0QceZxnPvEobJuN90FWckiRruTCUJhwQ0L nAG0r7kprHtPRSZUV+7l8rsFbc4H5MhhN2Oc20WYhG8u3ozv6qLcw/TVQLMGl0lmsN Tm+yNTWMKdrVpYYG/RuCSWKVMbwOfYMbDzae5/wE/mzGbKMvbuWdigABUN2OR7gqJS NKSbboGyZXC8RRISuj0rFhwJxGAyPDpNhc7zN3P3jSV/uuS/Bfso7IE5Ebm4Djkgd6 svBkcm0ZxUvFwvmi8gYZhQw5LOpdkq59Qr47iuu62BzI/LlsV0KXlzJK6HvbxDAQ5l A1hoil7Qvj5Zg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 5/6] mm/damon/sysfs: don't hold kdamond_lock in before_terminate() Date: Sat, 5 Jul 2025 10:49:59 -0700 Message-Id: <20250705175000.56259-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250705175000.56259-1-sj@kernel.org> References: <20250705175000.56259-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: yoqemrjk73j37esrfty1oft7bkrixda8 X-Rspamd-Queue-Id: 90A88A0007 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751737809-870453 X-HE-Meta: U2FsdGVkX1/E5NUx3yb14XVUcycbedJO64bPNzSZeKtuB9tCLlgxf0aP2PS5AB9exyHYGLWYfwLB/MlaXC+HrcTVRg5UtonYRnylsyPDZhJpa1UIo/tzEaOo5TioMTnKQbqp5EKKBN1CLhf2Fn6XgEXBq1/fuLAfRRReVGe3L4peNSmjTQwpMPjvbwD1w95Im0nyKG3VTMMQa0rWv7c9pByFXI+/uqmuNZsqyl5y6u9i6WSm4w/QGJ7tTF6KZcDgdHtpXL7rJ0nmwOPzxaztykdwce9a49uhit/JzyGrnoxj+3Hg6E8jx1x3Hw7Ra/6GzZDbdZcYMZudd93hM+0ZD5AjAVGglBRL01bjOrV2SScmaq2Fa65CZRTX+ybH9fbOuqUTw9fxLroyle3oi2U3ezxWKlSuY+eydaoMuc9GGgZWQFyUXZd1UP0eFGszhL3bj3Z0YnQd6/3p8YaTn+NrjX40EKAuvkfq/fam9eQTX+qHsrNXExa2qTP6ApZrB+lyzUQ6gQEzT6k8Kmt8ACIwYc1I5XvtfTMT6aPbYojFAodTux9v5fczrXa/J4IiSzGR5ef4Lq8T0gDnlQxrQsHrNDCxPmIp7Cyjj1tkyv35fga5KnkwWEB2Lj2+uehuA7dxYwzJVa4/jgqx34xq9K2inaLQqkJxQmvTZ2EBvmx1f7mLWFQ+lUqPBs0j1H+N6NLMPOGGzMozJzDGiskhFn9BaA4InKk7bpQUlK6WkL3lW2OJ906rs4Z6Ub+ihkM0rCweyaYzdgkVVbTeDp3oN1RN7jZ3hbNETwMIrBKMAJm1/cvGsQuhZeHaKZbjW3iQ4Cb8lVM1X1MJhdydEQ3bCVg/MpWsl9fU8Bt5vTA4C1yR1L43XtL7ODegEB8RvoG+TR12Bh+gDUfjxQt/hgX+pKzV0ED8k/6ZpnNZJEvXQQwI9uDcwj0TPc8AwUZvefzoI/WPrSkr+BZT9H3pOkmtvOB lpiyD5X4 tIisac1QL/T9tLllyAi6SGk6kxKP7F/4hRsF0FAQIKNMzM6Pbs/waos7arS5aqgduegl+9RIp1SVKbjB0ZAvACn3bcVUw//+F8vaMe3jfjLeeb7l/CXcRwC4hS/IBxOJYjIEy68v5EOBDUjSLLLy4ryDAeNEyB3S+3Hzhog+psS6iEdX5TDYBhx5J8l4A7SFoDo8eSXa3lkP3Dx3N26ZmpFYjBWSxdxEjHM+3yAsYQj7ydnSFRSKhNb1yignsRGC8PfRVxQgEOiyAR41/gbGiz8jSFjLx1HQw3+wvzlGp93SS4sABX3mtERAsWGLp5wkwTq9kMvry6Rq3MVQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_sysfs_before_terminate() is a DAMON callback that is executed from the kdamond's context. Hence it is safe to access DAMON context internal data. But the function is unnecessarily holding kdamond_lock of the context. It is just unnecessary. Remove the locking code. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 79d65dcc9dd0..c0193de6fb9a 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1387,12 +1387,10 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) if (!damon_target_has_pid(ctx)) return; - mutex_lock(&ctx->kdamond_lock); damon_for_each_target_safe(t, next, ctx) { put_pid(t->pid); damon_destroy_target(t); } - mutex_unlock(&ctx->kdamond_lock); } /* -- 2.39.5