From: Jason Gunthorpe <jgg@ziepe.ca>
To: David Hildenbrand <david@redhat.com>
Cc: lizhe.67@bytedance.com, alex.williamson@redhat.com,
akpm@linux-foundation.org, peterx@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 5/5] vfio/type1: optimize vfio_unpin_pages_remote()
Date: Fri, 4 Jul 2025 14:11:23 -0300 [thread overview]
Message-ID: <20250704171123.GK904431@ziepe.ca> (raw)
In-Reply-To: <77d99da0-10eb-4a4d-8ad9-c6ec83cb4540@redhat.com>
On Fri, Jul 04, 2025 at 10:47:00AM +0200, David Hildenbrand wrote:
> > static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova,
> > unsigned long pfn, unsigned long npage,
> > bool do_accounting)
> > {
> > long unlocked = 0, locked = vpfn_pages(dma, iova, npage);
> > - long i;
> > - for (i = 0; i < npage; i++)
> > - if (put_pfn(pfn++, dma->prot))
> > - unlocked++;
> > + if (dma->has_rsvd) {
> > + long i;
>
> No need to move "long i" here, but also doesn't really matter.
It should also be unsigned long as npage is unsigned
Jason
next prev parent reply other threads:[~2025-07-04 17:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 6:25 [PATCH v2 0/5] vfio/type1: optimize vfio_pin_pages_remote() and vfio_unpin_pages_remote() lizhe.67
2025-07-04 6:25 ` [PATCH v2 1/5] mm: introduce num_pages_contiguous() lizhe.67
2025-07-04 7:56 ` David Hildenbrand
2025-07-04 8:21 ` lizhe.67
2025-07-04 17:10 ` Jason Gunthorpe
2025-07-07 3:38 ` lizhe.67
2025-07-04 21:19 ` kernel test robot
2025-07-07 3:52 ` lizhe.67
2025-07-04 6:25 ` [PATCH v2 2/5] vfio/type1: optimize vfio_pin_pages_remote() lizhe.67
2025-07-04 8:41 ` David Hildenbrand
2025-07-04 6:26 ` [PATCH v2 3/5] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages_remote() lizhe.67
2025-07-04 6:26 ` [PATCH v2 4/5] vfio/type1: introduce a new member has_rsvd for struct vfio_dma lizhe.67
2025-07-04 8:46 ` David Hildenbrand
2025-07-04 6:26 ` [PATCH v2 5/5] vfio/type1: optimize vfio_unpin_pages_remote() lizhe.67
2025-07-04 8:47 ` David Hildenbrand
2025-07-04 17:11 ` Jason Gunthorpe [this message]
2025-07-07 3:44 ` lizhe.67
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704171123.GK904431@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhe.67@bytedance.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox