From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99190C83F03 for ; Fri, 4 Jul 2025 21:14:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DDDA6B806F; Fri, 4 Jul 2025 17:14:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08F8E6B8067; Fri, 4 Jul 2025 17:14:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE6976B806F; Fri, 4 Jul 2025 17:14:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB3146B8067 for ; Fri, 4 Jul 2025 17:14:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7592A1D0E33 for ; Fri, 4 Jul 2025 21:14:27 +0000 (UTC) X-FDA: 83627835774.29.7BF5CA6 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id 9AE81100011 for ; Fri, 4 Jul 2025 21:14:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=P+mguad3; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751663665; a=rsa-sha256; cv=none; b=nK1ebz8ll1Xx8dSEup65JysPGray3yThyQ1r5OE4vTk4dYY/VPhP5r84dQFWb6JQuFve07 yr+LQRX0ExUHdRnSLm3L3FUwd8ug0uyP8kBICp9qt/HuBDv/9HCaLbHghXD3hKwSQeY3hW X/9qF3rA4ChcsJ2FbPw+RpZjVI5SPJk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=P+mguad3; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751663665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwMqMBMUwPcINf97fqLQluv2jPb6H8UQYo/j68VZ728=; b=14ObRNoxwDHPb/8IeYQTp1lhKFXXCXwb/fuEw8XIQf8e9nKGh6z66qqQG+ulwkf+QIPO1z 5SLTjSBVPbjQT1UkW7P1pJksnPvKn049WihJI9r9eqIGfS9FvLJSrf7eyc9hWq8DuMWpVe cszcxlx193k27QI0pnJEwfKzmeIHNZ8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4777C45E55; Fri, 4 Jul 2025 21:14:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE8B8C4CEE3; Fri, 4 Jul 2025 21:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1751663664; bh=4ZXjjIEFeyNziz8nI9hyycb93PeMN+TlTyQFX8ZUBy8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P+mguad3o1QgfcWmYUtbI6/FsgHbbB1PA5+bCjq2nLDTkFt6v2jx4aZiXAWx0pGHX GYiIki4MzU5sYOZthXKw5Qdw3sFPMG9PgFKOFzykAvnsiUDIk7rb95YkqaazLj6zw4 3dbkLeWZtRfOmQ8v6ZKZpz4JUS1oNnQLE+gi45Rw= Date: Fri, 4 Jul 2025 14:14:22 -0700 From: Andrew Morton To: Baolin Wang Cc: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org Subject: Re: [PATCH v8 11/15] khugepaged: allow madvise_collapse to check all anonymous mTHP orders Message-Id: <20250704141422.359c89146ad69512b9be4902@linux-foundation.org> In-Reply-To: <2f6d9541-8083-4d3c-a9c1-cba0d5bf98a0@linux.alibaba.com> References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-12-npache@redhat.com> <2f6d9541-8083-4d3c-a9c1-cba0d5bf98a0@linux.alibaba.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9AE81100011 X-Stat-Signature: hz895yiwrzhpmonyzwesfmzff75jp8ac X-Rspam-User: X-HE-Tag: 1751663665-476453 X-HE-Meta: U2FsdGVkX1+Rm6F6GsA+JFg58BhUjJ2Ew0NWNt4VwEUhHICqmiOZWNkZxsq/XxMJT/2vWr0h7x216fxoKhEaaKLpTxI3MYyetfab24w1RWIzrOmkZPLOU5OJ2p9kmgq8Fb1LtPfJeib2y090nOuU6Y7iHwtXmOYb3G7KwX6AlQNMuGhgFQg5gFXjSUy7YPzuhieybZSsCoh9K75M7Dys8F3vFbsvSBSO6yYn+Drzgz42zT1zvh1DFsgMDdx7hTknMZsSEYg4xi96SHtvdrSCUPcqntUc/J2+flGedFHqGy9VOT0sPTeVU03/fkLfZTVPddCyaAkGhH4uvUoAVegF7VWopk+MEdcTgom/vltlIZilRYEiCBwtEEhxnmrnUKAdowPZI778ivtPrvI7siISXYr5wmyLe75OJrkXPvKv315UgNmEeUEZr9cscPvQEm9wwhy/08lkPntjATwgXna09jKftE/b/liJS7nH5Mbxl9OBa2nBfZVaZWKe1kOo7btLwVtFpCoQnH+UnrB285rcjPOwQO1L23TxjWPdtmu0giACBexmh4gZCp/ScZEIr8Srxw6Q/FfoyP87ZQYUAf2kIErh+AofctmT+57JCKFpuNM600fhJmRU/U/VNbamyh1v47z6dxY9/VzlPAWvQ/6dc6Z3AZPyAztlqHsnPVSXMdUdfv+0r3K5m04WzmKwfr1pyTmidioX1JzMFxt6Msx1W9Y/bn6RXxY7el3vkLYKJSfoA4sD2/HyCEYae9jnbSCGcozrdKvQXBv/Od+oZ8DKxV0xzGTWgEENNRCWOWrXEmKhI74Bqe7yAd6v8HTWc5j3GFSPCZ+8pPmPCQ66bdQitkz24gziFX1QU0Fv8HeL9oPrtIvZEbRlbTp97WtfEDH3UBPlEVa69uCEjFOE50nSYNVi6OuRGyY3sd10DtIkK1s0C9u6hZ/y9Ai/nb0DYikBwbL3E8WBWAof70ETkTB MT6Lf7ep hxZTeK9zm64qhF5doeD0fppjQm4+Z7JUhD09YBoF2Y54otNuzIl6CxJeLboZL5Qb1f4AgkutfALqAP4Mze47/hK8lvJ+Ny+vQGfrTd8XSU+7tzIJOx2VSOi0HX3I1kwwHAweg2fq50l/cbuQzRxMxq2ByQaeRHwikKlBcUfrLNSfVA6DJruzZZg88+2pmDNDKKAAulFN9N8M+bdImCk3MbXxV25FZxaZiaaUT9RnIqgi4c9UmSe2f75SwOEodze40x56RTfr+D5OHDEz8kXcHCmtGk1jFHxQxX4e6RTg6l579B//cvtbF38mTaSheGMmBG4KaXsvzaipO2OUHGV/fnYAwlfiqETTy3s8Yq3IoInot67imgRbu/dqzv9PyEBnEkHHik0Uwaho/qggVEajts4zHc+tmYgzKnWxETLYC0/f3jbKGSwZAuQZMGKwDu6dFVLw+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 4 Jul 2025 14:11:13 +0800 Baolin Wang wrote: > On 2025/7/2 13:57, Nico Pache wrote: > > Allow madvise_collapse to scan/collapse all mTHP orders without the > > strict requirement of needing the PMD-order enabled. > > > > Signed-off-by: Nico Pache > > I am afraid we should drop this patch from the series, since Hugh > explicitly opposed my modification of the madvise_collapse control logic > in this thread[1]. Well it drops easily enough. I don't know if it compiles yet. Nico, can you confirm that you're OK with the droppage and that the series is still good without this patch? > Moreover, since we have not yet clarified how to handle the conflict > between the semantics of madvise_collapse and the THP interfaces, we > should keep the current logic[2] (means madvise_collapse still only > allows PMD collapse). > > If madvise_collapse is to support mTHP collapse, there will be more > semantic conflicts to discuss. > > [1] > https://lore.kernel.org/all/cover.1750815384.git.baolin.wang@linux.alibaba.com/ > [2] > https://lore.kernel.org/all/23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com/