From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3276FC83F03 for ; Fri, 4 Jul 2025 07:06:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C1436B8014; Fri, 4 Jul 2025 03:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94A796B800A; Fri, 4 Jul 2025 03:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 811D76B8014; Fri, 4 Jul 2025 03:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B8F86B800A for ; Fri, 4 Jul 2025 03:06:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1C816109B07 for ; Fri, 4 Jul 2025 07:06:08 +0000 (UTC) X-FDA: 83625698016.01.ADFF52A Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf04.hostedemail.com (Postfix) with ESMTP id B391B40007 for ; Fri, 4 Jul 2025 07:06:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; spf=pass (imf04.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751612766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XXsMybr/ngkKYH5YlmLk5eSfHxWrh1ZqYJb49ebAnRg=; b=EaHbq4hD/PSl0pX//3/QqaSUzmqZEU+J7VV3Dy2SCstOLQYXpeqh9mfwAKLuLusfAmIdSw TRmbVhwJ5wCq6RZIeiC7yjCuOv5CAxUpOy4omL5irot7YeXwZpJgDZ0N5PufR5lPb0FFwh 8p7AUqgmnV+S/ha31UbPrlRbEDni7Fc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751612766; a=rsa-sha256; cv=none; b=pyharw5pgGlirZX2WOvThSC8Ahf/V50MRnNYjEp/EiVoXdgzL7PQU2khfQWdsNYyMy95WL kPUgHdGseKLGI+8T7wumSlcOPfmjTjbEFWKsbwJHbURp/DxI9VWLp/Um1DOGUibEDCMPt0 IYBr7vdw8DUkrZtNkf6BaVZOP+DxeNA= X-AuditID: a67dfc5b-669ff7000002311f-8f-68677d5b45aa From: Yunjeong Mun To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, honggyu.kim@sk.com Subject: Re: [RFC PATCH v2] samples/damon: support automatic node address detection Date: Fri, 4 Jul 2025 16:05:59 +0900 Message-ID: <20250704070600.1786-1-yunjeong.mun@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250703165237.43771-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOLMWRmVeSWpSXmKPExsXC9ZZnoW50bXqGQcs3Vos569ewWTz5/5vV 4vKuOWwW99b8Z7U4/PUNkwOrx6ZVnWwemz5NYvc4MeM3i8eLzTMZPT5vkgtgjeKySUnNySxL LdK3S+DKWDb9GUvBfcWK96vmsDcwHpHqYuTkkBAwkTi44BcbjL36038WEJtNQEPi4KGTzCC2 iICgRP/jGaxdjFwczAJzGSWOnHnPCJIQFgiWONo0G6yBRUBV4vjS3UwgNq+AuUTj5x/sEEM1 JRou3QOLcwoYSzw4Ox+sV0iAR+LVhv2MEPWCEidnPgGbwywgL9G8dTYzyDIJgTlsEl9nbmWE GCQpcXDFDZYJjPyzkPTMQtKzgJFpFaNQZl5ZbmJmjoleRmVeZoVecn7uJkZgcC6r/RO9g/HT heBDjAIcjEo8vBuS0jKEWBPLiitzDzFKcDArifCeFEzPEOJNSaysSi3Kjy8qzUktPsQozcGi JM5r9K08RUggPbEkNTs1tSC1CCbLxMEp1cBo0l0y8Y3zs6bf3J63DM+bXWtYI6TZnHrVc6Op 9sctfxRW5v/9YGY9za2iuXvCpfjy9nBBVuvTy+Y+bRVi8dpyaIXeQuFvkp0GeRdfLL5y+s3c IwYu86/9mOkdl+YV8bz83GQlm0Ml3fV+6pUvP+/xr2jy2Kd0za30896PmY7LJ9/Su7p97uq3 SizFGYmGWsxFxYkA3PmVj0oCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsXCNUNWRzeqNj3DYMZxC4s569ewWTz5/5vV 4vOz18wWh+eeZLW4vGsOm8W9Nf9ZLQ5/fcPkwO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfGsunPWAruK1a8XzWHvYHxiFQXIyeHhICJxOpP /1lAbDYBDYmDh04yg9giAoIS/Y9nsHYxcnEwC8xllDhy5j0jSEJYIFjiaNNssAYWAVWJ40t3 M4HYvALmEo2ff7BDDNWUaLh0DyzOKWAs8eDsfLBeIQEeiVcb9jNC1AtKnJz5BGwOs4C8RPPW 2cwTGHlmIUnNQpJawMi0ilEkM68sNzEzx1SvODujMi+zQi85P3cTIzD4ltX+mbiD8ctl90OM AhyMSjy8G5LSMoRYE8uKK3MPMUpwMCuJ8J4UTM8Q4k1JrKxKLcqPLyrNSS0+xCjNwaIkzusV npogJJCeWJKanZpakFoEk2Xi4JRqYBQ2Z/2Tbvnl9L1Pf8r+1nE5vBSO87iqtkEw+ED9df/V Kve/ztKdvNmualr91BmL+uqU/ou6Z+mxT7gkwzHNbZ2hfO7n3H079C5Mb/e4cdPvzeMlM6dp SRl0vdhYafH+4V3BLx95i58mfX2q4n74/7SqQqHYCr3/WcvEvL4rqt2oND0ipK23gUuJpTgj 0VCLuag4EQAFrRV1OgIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B391B40007 X-Rspam-User: X-Stat-Signature: z1nsdmkr7xadfq9qgjzqymkxjq7a91x6 X-HE-Tag: 1751612765-163202 X-HE-Meta: U2FsdGVkX1+4X5LiabqmZruSCOqExQcygCPSBAFplZeNVK/JvYTl0AKu30vuHqV70aFYIqsiD7nGxUTxylU66YnEqkYbm0v6tdS7d+zyf+wLt0adFRfcd416g5ckDC4mOepHXG1sDIrmkX7wEVCD4HBGWt2SL3IWXh7uqiv+FU9u4nDoknle+Ugf8JybkBrJM/y6VtE5TJfE6q3/DnOmsxjcL51LqsdsgnZxhm2oa4ZFCFLlI2y4BVbenfv2j77O24fAZf0ohQungBu4SiQSWfkhDl3o+8AdvGuMRQWKDWJIKFzbTRY5IXjbmgKrx2/VZMjEFfTHTz1VnNJeKMGNS8zInK1s87WhseN8NHXvXgwljrghYiEroroJt0IApV/KYqdyFMD7V3HUfscMxitaPt+N6pYU8wGqYIDI8jPD/bonPLoYlV10P+pMGw7gxt8jJME+QiPNjF8rGNthAKU6VG1T90DaoY2qJy+GlY2sCJxjZCCGJchfxBXa/t8z3pBA24fSzJvFEwz13U/bsDsGwEepBl3YrL3mofGqwXP3R/nYunRKvHYnvCL1ISQT8lwTA/H8oRQVCE7izjZuaYDJl54ICa1EeMmjft0bM18GH/Rfmqo+HXvXxA/4Vk3tegpNl18VbOSkNJ8zN4gcqy6rhlvf2eIc6L6P4oxtMII+hdSkA/0JqECK6z8bbLYwaIZ6GqFqUqjzLFMcgQ7Yc+BIi31AXOAqs4Ehi618cUHAbByXojTZJYlAXgV7jYIvq+wEFpXvbpWLyVbBjxmRgf0uJqrDLi3Lm0U1wc2N8XHUiFjj2aM+oVHnw0RqF5rkqZkEn5Tk2EEi0Szos4cjoDYi17NjWpgjzaq+uO7H2JwyiQYTTggXY+GqwoGAvoVicSFF0TkFqmR2SuSMJUIjvItz0zkARqvLL2sviJydkn+DV1LEE9/NagZ4sY3YTRwq4D8q9a89NWbGxF9xSwwt+zT oNumBDkd rppWK3+WremvcSdYvbFXajqrUYkg4C7MSD+dptVjmJb9S2PY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Seongjae, On Thu, 3 Jul 2025 09:52:37 -0700 SeongJae Park wrote: > Hello Yunjeong, > > On Thu, 3 Jul 2025 16:44:22 +0900 Yunjeong Mun wrote: > > > This patch adds a new knob `detect_node_addresses`, which determines > > whether the physical address range is set manually using the existing > > knobs or automatically by the mtier module. When `detect_node_addresses` > > set to 'Y', mtier automatically converts node0 and node1 to their > > physical addresses. If set to 'N', it uses the existing > > 'node#_start_addr' and 'node#_end_addr' to define regions as before. > > Thank you for this patch! > > > > > Suggested-by: Honggyu Kim > > Signed-off-by: Yunjeong Mun > > Reviewed-by: SeongJae Park > > > --- > > From next time, please consider adding a summary of what changes have made from > the previous version here, like suggested[1] on the documentation. Ok, I'll add it next time, thanks:) One concern I have about this patch is the requirement to set 'detect_node_addresses=Y' before setting 'enable=Y'. Not following this order causes an error, which makes it difficult for users to use the module. So, how about removing 'detect_node_address'? Instead, we could convert node0,1 to physical address automatically by default, and use existing 'node#_*_addr' values only when those files are explicitly set. The diff is as follows: ```diff diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index 3a6ae78efafe..03e0540611e0 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -42,9 +42,6 @@ static bool enable __read_mostly; module_param_cb(enable, &enable_param_ops, &enable, 0600); MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); -static bool detect_node_addresses __read_mostly; -module_param(detect_node_addresses, bool, 0600); - static struct damon_ctx *ctxs[2]; struct region_range { @@ -110,10 +107,12 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) goto free_out; damon_add_target(ctx, target); - if (detect_node_addresses) { + if (!node0_start_addr && !node0_end_addr + && !node1_start_addr && !node1_end_addr) { ret = promote ? nid_to_phys(1, &addr) : nid_to_phys(0, &addr); if (ret) goto free_out; + } else { addr.start = promote ? node1_start_addr : node0_start_addr; addr.end = promote ? node1_end_addr : node0_end_addr; ``` > > > samples/damon/mtier.c | 42 +++++++++++++++++++++++++++++++++++++++--- > > 1 file changed, 39 insertions(+), 3 deletions(-) > > > > diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c > > index f3220d6e6739..3570ebe10fab 100644 > > --- a/samples/damon/mtier.c > > +++ b/samples/damon/mtier.c > > @@ -42,8 +42,34 @@ static bool enable __read_mostly; > > module_param_cb(enable, &enable_param_ops, &enable, 0600); > > MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); > > > > +static bool detect_node_addresses __read_mostly; > > +module_param(detect_node_addresses, bool, 0600); > > + > > static struct damon_ctx *ctxs[2]; > > > > +struct region_range { > > + phys_addr_t start; > > + phys_addr_t end; > > +}; > > + > > +static int nid_to_phys(int target_node, struct region_range *range) > > +{ > > + > > + if (!node_online(target_node)) { > > + pr_err("NUMA node %d is not online\n", target_node); > > + return -EINVAL; > > + } > > + > > + /* TODO: Do we need to support more accurate region range? */ > > I understand you are saying we might need to remove address ranges in the node > that DAMON will anyway unable to check accesses, e.g., reserved memory. Since > those are uusally only a small portion and this is a sample code, I think we > don't really need to do that, so I think you can drop this TODO comment from > your next version, if you are gonna make it. > Ok, I will drop that comment from next version. Best Regards, Yunjeong Mun ...snip... > > [1] https://docs.kernel.org/process/submitting-patches.html#commentary > > > Thanks, > SJ