From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E1AC8303D for ; Fri, 4 Jul 2025 04:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 478E4440168; Fri, 4 Jul 2025 00:23:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 403CA440169; Fri, 4 Jul 2025 00:23:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14373440168; Fri, 4 Jul 2025 00:23:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F2AC7440154 for ; Fri, 4 Jul 2025 00:23:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CBE7ABF0EE for ; Fri, 4 Jul 2025 04:23:45 +0000 (UTC) X-FDA: 83625288810.01.4B1D79C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf01.hostedemail.com (Postfix) with ESMTP id ACE4840002 for ; Fri, 4 Jul 2025 04:23:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yn79WQXn; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751603023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WQq9hkA8OYAEorkMDUzrmuUGAfpRGl3QvnChpxOeH54=; b=cn0oabzPdNEB3EE0wpIUCTnjV0BWOFF56cVzx7J5MWG8A+NvTplFat7FljgokJPdQ+iy5M BS5CYcGAP6mteCdRya/sciLjRkEJp2i2cutUT+7vqn/WyRDrYKN20LMnX3pPG36QnJ9T5d BhVeUlRWTr7up0qUTFhwii3cRGsDgrI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yn79WQXn; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751603023; a=rsa-sha256; cv=none; b=LuTR6LhIzT6rgaz1tnsXFqM56hiFHAXHUBEplN0K7Z58Stkmc7Rx7jB5WeQq739tUK5wkD 49pG1j1quhlpNBu1fn3aZfm2vNUh3+E3DP+K7l0uvTQFl2qHhsLVl22eoyPRhvvxaI2hAT FyyFW8w6nBpzSxUxvghXJuH9dNGfcIQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751603024; x=1783139024; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pGg9+BuQcNzzvHBWkrmR+YAXBo4WPWN1ABcyBZGemzs=; b=Yn79WQXnQZEBP+EJUbsI45qrw7mCVPzAF193N0qITIMoliKTVTli8LDu pwCVu4Y1GAD/t4LiQT4chxVzAzIGaMpQPZfQ0TLnVS78qsNnJenSa8jTF tm6vXWIr/w+8YQY4LMrHI5E7IV6oDYIccL15GKnRC5sY2+YMxlG8r7XPq lLHl6F+mtbsxbqJspyz1Lfcrpz4EnQ+aNRfi4sJdcQRmrlFOMIVEIgVUb 3+6qQJRWUPKfve3c88sDBimDUbAJUQdf2q07dwQpHEPq5+YI2OQNvLOsB 2WDkZEgyko+88uer7bvlZSgiaqb7c/MYNKwbLH251Ah+IUSYPZ6Y9SYQg w==; X-CSE-ConnectionGUID: AWDIrb6tTqW9m3wp9rcPBQ== X-CSE-MsgGUID: jLHJVn4qRpKS4JoTFiqsjg== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="53909241" X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="53909241" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2025 21:23:28 -0700 X-CSE-ConnectionGUID: PP+XM/OvQOK5i3Ll6zVQQg== X-CSE-MsgGUID: lh8hEO1XRcCv6uzCVG0ZiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="153968728" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 03 Jul 2025 21:23:27 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v10 22/25] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. Date: Thu, 3 Jul 2025 21:23:20 -0700 Message-Id: <20250704042323.10318-23-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> References: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4zbmhzi7g9ihdqnq4th8oxt9gpsbj9no X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ACE4840002 X-HE-Tag: 1751603023-763044 X-HE-Meta: U2FsdGVkX18mfl/dX2e7KfdrzNdhIeajCoc1yYUPCs7FRIBuAQF9VHz7GcqSgXNE87/DZJWB3DG6DxhoIkr1Ub99etrsPMlJRAVk7gBoH+ltKkDhM1xuQJw/qT5zrmbwLBdRY7R/Euze+sn6Gd0YwsoqArR5T08t7GID/amAVcoIn72V++4CGGvT8JJC8OdriCJcor6Q3mk+cybacqY4w286zHcoCyYDu+casOTm3/CDGBAsgvdQ+tJRyiw3iQMuNme/f0uNXbyQ1piS7+cWd7o5l1UeUdUSZJyLR/WomhFAL2pyPiRM+8tmr56y8mzsB0wntrYGhqOSIYJsLiJ/MobTKQaGZ1boE8yFOf191KdiuYLONompsg1CDu4Zsd//VohJa1OkS/ol7DuD18pG/Xjnr7OQm39Win2f7oVdUhpcYt2x5/qA0ADaw+reAt0z9eRN4fwxhNpi8OYZ3zoO0GQ3UPIKQPMhXcUyZHyBz0gzsTc7vOK39/imJAjAvoH6DXzmtqhIri1ymtadWZeLskDtfLMs2iX9hA2eTEpsaEz+dvOI82aAoRmKIcQ17y0+cajyVq1muvYTqkDBwDnAz2NTVtoFGVhMFqggAfTlYkD/QPSX0gNsh5Pm2PJGm/Na4FLxI7JiGjvQQ0wHnhGqu165xM4jtYMNzcjgAeJC9h3PbA83jSgxELVUB40MLh8GV7V7dy1gjpKIu/6zcE/xUiK2Qf7RjucRvCRxP7/YkMgZvkjK2LAM9fM2p77haHXQLzT8O66Ls4gBrO3CveGgmz7J03o0zf5q+hsSgHnXzGbqMJI9IvZnQmx4+QtARprv254LYaiInBvo+epl1+wd1kmcPD2vc57ID0o9xI43PfzvD27b7HkX3t8Uw+Yl02uC/WeCYahi1IWncVCqSKzeGPO6LUDEk9r2pACVUp24RKFjFKQBjEC2OglhNFDxGAKsncLyr8IjkdltecTOs5K kq5ex9pL 9yirs6/QsMUkRlrZhNZjHtZeY5lhaZSdRvlBo9Hybj0aXwii+lB+BFge1b1wnEm3fX8WFC155r2l5rqk4hORP08to+HWVxCq1Vpvr91VH9pnnv5kHdrHcsGjOcjn/2adABNLmwIpimgzIUlTndF4S4XZKfd3Id+gCXo/6rEdqOKFOd26SKsMoOWepVkxjwMQIBg7iJVkpROCUvQyi2oVKiIdvLgLdbVwVLbYB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch uses IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check for valid acomp/req, thereby making it consistent with acomp_ctx_dealloc(). Signed-off-by: Kanchana P Sridhar --- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 3635a7d6cf7b4..688ce7ed39ca8 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -294,7 +294,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) return ret; acomp_ctx->acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu)); - if (IS_ERR(acomp_ctx->acomp)) { + if (IS_ERR_OR_NULL(acomp_ctx->acomp)) { pr_err("could not alloc crypto acomp %s : %ld\n", pool->tfm_name, PTR_ERR(acomp_ctx->acomp)); ret = PTR_ERR(acomp_ctx->acomp); @@ -303,7 +303,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) acomp_ctx->is_sleepable = acomp_is_async(acomp_ctx->acomp); acomp_ctx->req = acomp_request_alloc(acomp_ctx->acomp); - if (!acomp_ctx->req) { + if (IS_ERR_OR_NULL(acomp_ctx->req)) { pr_err("could not alloc crypto acomp_request %s\n", pool->tfm_name); goto fail; -- 2.27.0