From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583A8C83030 for ; Fri, 4 Jul 2025 04:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1446C440166; Fri, 4 Jul 2025 00:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F44C440154; Fri, 4 Jul 2025 00:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8986440166; Fri, 4 Jul 2025 00:23:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D75A1440154 for ; Fri, 4 Jul 2025 00:23:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9A5F814165C for ; Fri, 4 Jul 2025 04:23:43 +0000 (UTC) X-FDA: 83625288726.19.8F0E3EF Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf01.hostedemail.com (Postfix) with ESMTP id 8261240002 for ; Fri, 4 Jul 2025 04:23:41 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ghOapzT3; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751603021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f9U4yMgUu8e5Mvyuojg7399tY2Dwem+bS/o+ARc9I84=; b=L10KEjoR0QMlSulpjheYaT+74bgzCzzsrDdbRehVcBDmfo7/UbfBuNSOfde2ut0xVVxqfL YnBRschG5F48L1e8lFxvTAL/yIVVLnDFO1wnKNcr585IPpDX95QBD/t1fw9xj+Mul/ocGb mS8Hbho2cpXgvYN5VDUx6k3cTvSntsY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ghOapzT3; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751603021; a=rsa-sha256; cv=none; b=jINKK00YtFc6HUCglFmtm069XnDywjAZF5XgSFxzHvvzhhqNmXHmNRp/Pvi5daJkelpE43 8i84PmsGZQSSyb49wnEmWjAbZ0Zi7SAO1KH+FMcxI7kBCe2UrDsL0HWXl1EcEP5Vej9U/c ujrB8kMP5dV07imSX3ljOuIBgpRrv8g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751603022; x=1783139022; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jBYqtIdn2g/qmc5lPRJuQdSpcp+B6gPWEJvQ/KJK+XM=; b=ghOapzT37M9GhNl7Fj8oLPensTngFleg8h4IqqspZAYiRFgKtbcv5sgL tGGXY+fLSNWw9owFtaLO8Ov+MQsfWOpoFs051JJlnl56xZzZrjPm3oKzF C2Lzs1F+3OHpKwNA8D6njra46S3e86fzkoGa9iKhXQ2N31OPDcTsmSw// SgAe/07CUrLzgk+yi8Jrhqat4HSDY1mHyq2wlDnXsPN2hMCTVEZ0Ws5Dr 1kDC1i5FU4Umo6R57jGnBwKQQA1aLXSDd5vwQMGlXgU/l4o2aO+zSHgrx sJGd8rhqb09UelmRqpkYVKxZ3/cwBwquJDrBwlxCfeFbAKT2mMh1INqdS Q==; X-CSE-ConnectionGUID: Rqe59dxpTx+GvDFW9Wb8Dg== X-CSE-MsgGUID: XuzSy9jrQqGjc1L5LmVstg== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="53909185" X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="53909185" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2025 21:23:27 -0700 X-CSE-ConnectionGUID: BvfS0WFSRYe9LZaCzY9dhw== X-CSE-MsgGUID: VuRQ9QxVS76JynlnivYE6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="153968714" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 03 Jul 2025 21:23:26 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v10 18/25] crypto: acomp - Add crypto_acomp_batch_size() to get an algorithm's batch-size. Date: Thu, 3 Jul 2025 21:23:16 -0700 Message-Id: <20250704042323.10318-19-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> References: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: s7kmxuoyi87h4gugjozn4iwz6k56nbts X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8261240002 X-HE-Tag: 1751603021-95439 X-HE-Meta: U2FsdGVkX19B1OcR+XTZcXqBvOiSWT+lqv7rgLctGJH9hwVElXDC6haUgEVBFQ+mJKrqiXKWN8Rv932q8rGpuV0vwjN42VrobGom/k9EFsUo9FVVa0e9fTT0hLm42hU1iqCl/O2t45//vgHDnvluyXQIybxfQZNDUhp0HjOK01zb+9kbBqt9Sg5qNT6AkZYU5wE3kPFR3+qyoFj2Xd4Aaq7VlKMG+SYyQE9Zg/7QRIxXsB5bY1NzXf5Q/I+mpJODKVRlnMcVLfgUaSgJYQdjZA2xQgGH+5DV0xeYsSN6dpZvv7FW+5iG4zzgClW3j1xVcFkEEfAsoKMJGpKENC9412+gPCdC13+Z4Pgll7ljqQEEjcn7rXetiWx6F1PfNT49Qtb3JvJ7M0Lss2kf47NzySqSoDie7Sb96xVRF7HJm3I8JjMN6PKiMTkRPDsCvR8uhqyErVoZvkKX8pgTnCIpzpWc+I2N27MCKSunPfkG1vyHnrBXiX4xwIJ/RrDWJ250AtQ2CVCZ5IUbx8dNB0ALCzTHL8cqOw0mf9k0ludj2HbcmvVb/zMJEUlVv59/hPCRQG8YOaheYmTuUAsqm8dt9J63RuofImxsNYIp6fGOOXRv3cuCwNgii8BkNwQJ+herGTsPpU1yM4dBL9aXeEbfTTsnFfnA+NrSE8MIyvoqpvbkmtFdy5k0hVWcrnNoQUx0ntb4YaV+e6jilOytOctqUnk/12wGktE80xRUGIEf09S5Ri64l8fwBSdwi8IP2IiYk1ramjH28G6pOVXc0fvEtS67A1sY/TFBI/11pcqb48xOUUP21x4zoV7FG0uren2kG/9iIVZFadEkcXCL5+n9/0SJ9/AQUhs+HvySs1WfOM83550NZ0zJI7rArEtoMjhQuXWExhHKKNO8Ng2p6Gn9MfrjVAAR4mORE+7HAYm+Z1/cN6vNXPV8I0RT1DjS4e9kmoggWVmHekUpaHcsBkd 8khFfv50 impBiwzjD4OmyrjtO9gYRmA15tiIHU/hOAYtg5YThzvH51Y6/Mxt8XzSO9yhnt0jalCDWC5JwyhIppOMUG2kV7jqF45j2vgMIhdEnLM3ucl6ODmJgcw6jqWdJfGtSxuRPBFCmCf/od9Y/WuvP9SU6l3C+r0AqMUhq823SLAoOKeKlvd9u47BmuXxU9gA1XzmBuf8Pszs8a+6/3xN3YNkVubArtwdpSvI0nbXq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This commit adds a get_batch_size() interface to: struct acomp_alg struct crypto_acomp A crypto_acomp compression algorithm that supports batching of compressions and decompressions must provide an implementation for this API to return the maximum batch-size that the compressor supports, so that kernel users of crypto_acomp, such as zswap, can allocate resources for submitting multiple compress/decompress jobs that can be batched, and invoke batching of [de]compressions. A new helper function acomp_has_async_batching() can be invoked to query if a crypto_acomp implements get_batch_size(). The new crypto_acomp_batch_size() API uses this helper function to return the batch-size for compressors that implement get_batch_size(). If no implementation is provided by the crypto_acomp, a default of "1" is returned for the batch-size. zswap can invoke crypto_acomp_batch_size() to query the maximum number of requests that can be batch [de]compressed. Based on this, zswap can use the minimum of any zswap-specific upper limits for batch-size and the compressor's max batch-size, to allocate batching resources. Signed-off-by: Kanchana P Sridhar --- crypto/acompress.c | 1 + include/crypto/acompress.h | 27 +++++++++++++++++++++++++++ include/crypto/internal/acompress.h | 3 +++ 3 files changed, 31 insertions(+) diff --git a/crypto/acompress.c b/crypto/acompress.c index be28cbfd22e32..f440724719655 100644 --- a/crypto/acompress.c +++ b/crypto/acompress.c @@ -105,6 +105,7 @@ static int crypto_acomp_init_tfm(struct crypto_tfm *tfm) acomp->compress = alg->compress; acomp->decompress = alg->decompress; + acomp->get_batch_size = alg->get_batch_size; acomp->reqsize = alg->base.cra_reqsize; acomp->base.exit = crypto_acomp_exit_tfm; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index 0312322d2ca03..898104745cd24 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -108,6 +108,8 @@ struct acomp_req { * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. * @reqsize: Context size for (de)compression requests * @fb: Synchronous fallback tfm * @base: Common crypto API algorithm data structure @@ -115,6 +117,7 @@ struct acomp_req { struct crypto_acomp { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); unsigned int reqsize; struct crypto_tfm base; }; @@ -205,6 +208,13 @@ static inline bool acomp_is_async(struct crypto_acomp *tfm) CRYPTO_ALG_ASYNC; } +static inline bool acomp_has_async_batching(struct crypto_acomp *tfm) +{ + return (acomp_is_async(tfm) && + (crypto_comp_alg_common(tfm)->base.cra_flags & CRYPTO_ALG_TYPE_ACOMPRESS) && + tfm->get_batch_size); +} + static inline struct crypto_acomp *crypto_acomp_reqtfm(struct acomp_req *req) { return __crypto_acomp_tfm(req->base.tfm); @@ -545,6 +555,23 @@ int crypto_acomp_compress(struct acomp_req *req); */ int crypto_acomp_decompress(struct acomp_req *req); +/** + * crypto_acomp_batch_size() -- Get the algorithm's batch size + * + * Function returns the algorithm's batch size for batching operations + * + * @tfm: ACOMPRESS tfm handle allocated with crypto_alloc_acomp() + * + * Return: crypto_acomp's batch size. + */ +static inline unsigned int crypto_acomp_batch_size(struct crypto_acomp *tfm) +{ + if (acomp_has_async_batching(tfm)) + return tfm->get_batch_size(); + + return 1; +} + static inline struct acomp_req *acomp_request_on_stack_init( char *buf, struct crypto_acomp *tfm) { diff --git a/include/crypto/internal/acompress.h b/include/crypto/internal/acompress.h index ffffd88bbbad3..2325ee18e7a10 100644 --- a/include/crypto/internal/acompress.h +++ b/include/crypto/internal/acompress.h @@ -28,6 +28,8 @@ * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. * @init: Initialize the cryptographic transformation object. * This function is used to initialize the cryptographic * transformation object. This function is called only once at @@ -46,6 +48,7 @@ struct acomp_alg { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); int (*init)(struct crypto_acomp *tfm); void (*exit)(struct crypto_acomp *tfm); -- 2.27.0