From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 833EEC8303D for ; Fri, 4 Jul 2025 04:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F5D440160; Fri, 4 Jul 2025 00:23:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C671F440154; Fri, 4 Jul 2025 00:23:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B55D9440160; Fri, 4 Jul 2025 00:23:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A3530440154 for ; Fri, 4 Jul 2025 00:23:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7014A81602 for ; Fri, 4 Jul 2025 04:23:41 +0000 (UTC) X-FDA: 83625288642.22.D0A5ADA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf01.hostedemail.com (Postfix) with ESMTP id 5E48F40002 for ; Fri, 4 Jul 2025 04:23:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lGRBKOvG; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751603019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eKhnP7XztWZWaQAFSP+kdh8pz/FW5p6qDjbfLCq+K/E=; b=yhkqOrB5XHTfPZX8ad0SjdzVz3kCagLF4J1fcddqkWO93LYT+nVthiEqkGKYY4KB0De5Cv So6h+/GSXD3853AMAy2yswE/r/obWo0kJfctuiJPw9Wx+Savw8T4St+qKKMrvHLXfapV0w dq3yT5jLVDEJstR3Mo8gUzKEjnh2mmk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lGRBKOvG; spf=pass (imf01.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751603019; a=rsa-sha256; cv=none; b=Kp2zkTAtqm6AzCFOrPl7rAKRx6L5Bojia+ZMlyxz3lRvv+Y7geYT88uDCxRmWEPoQmwUtY JaxjIZ0V7ZWiicprhTj/s4mH9ZJkEqiDqeXZNbxVIjeoV9gnuntH+OgHbJt1nU4uFMRnlz tVXrx2k5py+V/K8fAbhZTUmol1+yTnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751603020; x=1783139020; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=67XBFQJx9vgOGh9HYwd5EPtGelqpXURPeqiAnhwiVtU=; b=lGRBKOvGNS9WBZ+VlC6ELe7BC+2w9TdMBXcm6YzlKcshEPDsf/fqoSDl ZQc95zHc1a8k0BVi7qT6z+Yvi2JkE4vaMyybmhxu3phIltcRaJjhzmBQo UEy5arAd4l9XlZhcJnp+0YSzeoHdNKOhzuJrbBPlaMBpTL25VdVzPRfvg aMvLIDhiBM0lA1RelQ1Wgs59VA4J7UjC2y9O4ez2BaW+DgLL5oeUaVnkg ExPd4+fLhOkZ3W6D6+IN7g976+lEwg7ElYOVketozFpLUz/ihXOWdlTLF 9/VET1pjYOyRfzCOWkXCFj8DZqfx6E62P0eXOvYtGm+JIFNnak7spFVYF w==; X-CSE-ConnectionGUID: /gymvv6bS7ysCP06XzTPug== X-CSE-MsgGUID: 7IiwZ1UYRFaAeRIOb5urfQ== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="53909143" X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="53909143" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2025 21:23:26 -0700 X-CSE-ConnectionGUID: qLyqzMLLQ7iZNvpsrvEsFQ== X-CSE-MsgGUID: RY/Rd+qVQsSf6Lxgr2ABMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="153968705" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 03 Jul 2025 21:23:26 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v10 15/25] crypto: iaa - Disable iaa_verify_compress by default. Date: Thu, 3 Jul 2025 21:23:13 -0700 Message-Id: <20250704042323.10318-16-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> References: <20250704042323.10318-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: rnet3oiuuemb4d9owpczfcyuu7rc5pme X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5E48F40002 X-HE-Tag: 1751603019-376326 X-HE-Meta: U2FsdGVkX1+VeNtQ2vwe9CG18I1h16s27dEvQ3ktyoC+3ITOXWX4+UjFH3zbWhs3m35TrJt4VXtnxp3GHKpZFwdknjvxNHqZRW40z9J+2Lh1KUCDYtwkrEMAzgCnNEvW6bVWSVy5xY9Q17nGJRwrIF4lELn54X4hTvPKluKhAgdRFPil57+B6RNtl/GPqz1iKqYpnN3jB3IVTQIbcNWXS3QcI2Q/dNALsHoMgddlfTvB9cyXHiW1dcX5OW1c2QrDHFcP5fJIr/3AfQP29tDjncTuaNqyrCsxteXpOFotsgFzt6D8GOlXyl9geJC3blQAlkjot36a/3GhZZVD4ylpO3qWq3bFpDI3GCbYYu91S1DQR2P05pvbd1003DBSWEgHxlLNZV85d+NoRiQgd6WVRbe5cM7zMBg6dCmaRWT8yqt/SS7Cx3y2zkUeQ9cocCWH9xjCsMqVHmW6R4oH2gN27sbG9iGvUy8kgEEHwRULf1VwV5lkuclqMgvtQ7FsrAMfMd9WhnYy7LCoKyyznN70A/HAxH58K4Ztf87NxfDAhPp8YaNoGlbrm8wp9AZymJFgwqOwko14bBhfBPLfow0rWjQ87iqUY2msaCf16ey+YNvYLb3peqEpWMheMmcFMtO/TvA1AHsyXObmj3zfWtjb6QrN2rfGvDETJhJgSsONrlwdLLgmjpMljp61OaMxJVggDO3Vy/XRkSv0+0p0fIxh5hj7H5DS8afOczH49Dh0Qk9Qab2JNK9fZZdZwnoOi36sl5WeG8Kxg0qNp72sZy51ybpX4aZ3wXw6lx3iWXetpkTp+GaY2OIGaTPB6aKY1bKrbq0/bNWEuTMVvFV6uJNDDK0A22a2/RBZg6PAeJhAgslKbEjvHpWzeNWIeSfcIetGaxzst/jcdrcZHTn9sv8nDSeEu3B+KXsvzr0J0Ksy56bR9T55LkriFp0FrdtJnucZa5RueR6c5WXxIi8tUur gJ0IDQR/ Wt7vQAlQFgdmgT0QmU3zaZAN/ESQHNVjIGOLFAhJ7I43rEts7/r++X4SZwu58XrnY9jZ1SdUx6z3TbD2rnVGJJYkU96kcdx8JbH2SPWPVFrY3IZHpyNfwP6psMtpQnm8WW6Gt2L5KsikXZKEG7FjLBoEzxMaDzF+fd0+AuZEMrmaVVkksiGd8IQBj9bG9ZbN5dxguoFnvMThCJeUIOFqIPWyr3w3FhVZLtX0s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch makes it easier for IAA hardware acceleration in the iaa_crypto driver to be loaded by default with "iaa_verify_compress" disabled, to facilitate performance comparisons with software compressors (which also do not run compress verification by default). Earlier, iaa_crypto compress verification used to be enabled by default. The iaa_crypto driver documentation has been updated with this change. With this patch, if users want to enable compress verification, they can do so with these steps: 1) disable all the IAA device/wq bindings that happen at boot time 2) rmmod iaa_crypto 3) modprobe iaa_crypto 4) echo 1 > /sys/bus/dsa/drivers/crypto/verify_compress 5) re-run initialization of the IAA devices and wqs Signed-off-by: Kanchana P Sridhar --- Documentation/driver-api/crypto/iaa/iaa-crypto.rst | 2 +- drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst index 8e0e98d509720..bc5912f22ae1f 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -239,7 +239,7 @@ The available attributes are: echo 0 > /sys/bus/dsa/drivers/crypto/verify_compress - The default setting is '1' - verify all compresses. + The default setting is '0' - to not verify compresses. - sync_mode diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c index cf12257f7400d..09d786e85ab66 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -120,7 +120,7 @@ static bool iaa_distribute_decomps; static bool iaa_distribute_comps = true; /* Verify results of IAA compress or not */ -static bool iaa_verify_compress = true; +static bool iaa_verify_compress; /* * The iaa crypto driver supports three 'sync' methods determining how -- 2.27.0