From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B993BC8303D for ; Fri, 4 Jul 2025 04:07:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 569916B0286; Fri, 4 Jul 2025 00:07:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51ACF6B0287; Fri, 4 Jul 2025 00:07:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430396B0289; Fri, 4 Jul 2025 00:07:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3471C6B0286 for ; Fri, 4 Jul 2025 00:07:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 91E2B1DA39A for ; Fri, 4 Jul 2025 04:07:24 +0000 (UTC) X-FDA: 83625247608.19.B2AA9D5 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf25.hostedemail.com (Postfix) with ESMTP id AD1BDA0007 for ; Fri, 4 Jul 2025 04:07:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=cMotMn5T; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751602043; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qMZTfLrtIhEeFtw0lenJoQD3j7hmoeNDJQRqb/truAY=; b=qI1ttVjZxy/Xd3o62WivRLT+Gp4B3vdDOj3kbb7uJXWctngedRBWgO0ohACpexY/dlihwE 8WUg4QOQsdy5sphsrDMBI3PEfueNi7Z3zpaIFDPGnoxx7d+5VQxi9r/RnA7H0tpA8JZnez Lm36dstLO6kopOykMsgpnfiE40UdM4U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=cMotMn5T; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751602043; a=rsa-sha256; cv=none; b=4PsyM5OQwYvMcx3ktYGevc7LYff5IWxaDUYleKFb2aKMwXMB5Eda8VPgnIXN7my5EAcZ1B eyYfbGkTv73NKcKkdk+HPy6zJZcUSfaq6LWcDsr5TywYGXUx55vlwSC5Q+IEd5sP8mrBnh X6Hvwn90s7dsrAOWnMHVL2OOxFDE/co= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qMZTfLrtIhEeFtw0lenJoQD3j7hmoeNDJQRqb/truAY=; b=cMotMn5T9ALaGfL+D42Yq2Es9E d6MDh8KMduFvVKOelAEf+b9PJFVSRBzWmiPwUQUXe1LRFqBJ1z90ZFZ+kz90V+7TRRV2tEu88MSJ/ 5HR8QntXNNa2h5Ip7t/BeW07fgBD80y1L5OXPV82HXVBTH1YfnrKd1mTPPEqxn17v5SUIPZLpMUay OLHNYgb4pzZ+JnoXF2z8AIsj2Kwmwm0zBbZO4knJNhhQ8r9n3J9oWtDJqTdPDGMv6FJBP1ZfjNmzn /e4T7YyQeknN1hBKYLi3PyhxFXiM/qD8hD9SyHknQOV3c64wdyt7K7+MbLaQa7xD2vH13lfkkb7It C5FzTfLA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXXho-0000000913S-0tKf; Fri, 04 Jul 2025 04:07:20 +0000 Date: Fri, 4 Jul 2025 05:07:20 +0100 From: Al Viro To: Matthew Wilcox Cc: Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/11] vmscan: don't bother with debugfs_real_fops() Message-ID: <20250704040720.GP1880847@ZenIV> References: <20250702211305.GE1880847@ZenIV> <20250702211408.GA3406663@ZenIV> <20250702211739.GE3406663@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: chzjoip3k6yzftpbpbbywmdu5mxu4fgy X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AD1BDA0007 X-HE-Tag: 1751602042-899992 X-HE-Meta: U2FsdGVkX1+U+vUDruwkYBYK3ORnZMrGLMItJEItTqXfDxoD4f56tEZPtuykDwh+9JOeP5+CWXP4Ws2QJBI0WN9XEgARcQ1gUxrb079bzeZ87lWfwP728D0gZ0yvvx86nomRmS1U5VmL0bBPzh9zdU4qDo/3CLPHGQFFk/uKsBJsnjxLOL78A5Mf+nrly/sL9Gw0wx5oWm6BstkfC9xOpZFtff8s5AzIPMUeHK57T4+IiKqJj/MjptI0KMzm8mr2o/z4k6S8KFnu+oybrQqfylvC6Ji4jfhlg/ORjBxwNce061lVtB/MThCO5WNlh1ymwCgtzTm0iyYNj3GKd8TYESnK1i1wsqyxQyHqpySB7ByXDB45zbXu50QHrU3zEW3NuVnL+twVYQMuWXWSRVsIX/IeBMJxWnISjRoimBaU1ibkozoajWDU223QqOXZGgAKZDwIAjPHCrvT6Z6+bz9U6vmtM0hWAKIBLYIwRp64LdIfJPIHI40rCL3BYJ+s6S0YWVNBq5SfE0ihQQLzkgBuk+qAPuWTjimfoFWjV4chQFiaCn7T6tb3bz6DFmUWUY1BKshbmaO47USNq5LAHghqbMT2kUIBT6TwFHYAbiHek+7nIpJ44Fz9m0b1LSbCwe8I8yxnM31AS8UHuJLaIAHwEWP9bcCdBJlHB1NNmzRJJzevuTKTN+Ebv/wqYWHMOtCdoDYmrN+Y9pdqjERPz1ojiy3Q/1mHSrQcQkYYzJjXvaZtZFwL2aUiku8EqJ1Unwf/8Y80TfgpugzddQAvHvIJig5FyE6TztVWFVZinoOMoHNzYiTc37Xkz4jFWDLHIaQBmQCg6H9RjgSgZaIVUJmmhsl5Z/CeQrIEjgCww/J8pNNnu0oKatFliw0Nqzfrg3ZiOSd1Jy4kF9Ja6R23FKwTs6ejZ1PQzUCQ/5XZmGuIqHhI0x6YtVxVn9SjBi2gfueawhQdPMKZyydrKg+fC5p /iQaIc31 mCKtV6VXYv7t1om4GxsXB49RHA1qCpD2dOKKtKQRoFG7VlyYvl0s4mwF2C62ql5iqk00VuSXaHnCRNUN62n4tilPxaxXsVuCJJxMOCDdOqdRYnIq1aASb6XlWjY4qTMoQBqtX56bXDFZaLFVTZ3f7Jq49i+AvmxesoyBeq+f9EXYmpwmUQN6EfrXEZABUtKm/ewr3+sww3g2EUdVDJ8cSC1T9YobVTK1iQzotIXwm7n12WpdjWQrapkyOJiUp0Ow34xmZVNoyybRiZp1DcW53qZKMrYigF/+6fDdATL43PuSqdyl1bna3WTpD2RTy4NwYoiHMTL8Gz+xbNn0Lv+coPSzGcKZtd4a0ohdlzBFCPrg4JAbEsrm9zBGFcHlDn0ifocf4rbXcYSFOdxXJKhX1cX4kazDx9M+F9LPKGfeSj4ZHsXxbK9rH8vwAkYXjT/TIsruyvMhE8blsMy7q8mUfJPhfH1IKQmmFBsNs8orSWhIUzY3+AXWAQ/te7yZKl862RFVpAh5zcyLa/gp/EjWhJ9gsgAGQRY3eu6AHSdLv3pI/BeKIQQiR6UFVgM7eb0auDYRgdfSmV24krzHEcLPv+Du4FM9LbDctMAGR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 03, 2025 at 12:51:57PM +0100, Matthew Wilcox wrote: > On Wed, Jul 02, 2025 at 10:17:39PM +0100, Al Viro wrote: > > - bool full = !debugfs_real_fops(m->file)->write; > > + bool full = debugfs_get_aux_num(m->file); > > > + debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, 1, > > + &lru_gen_rw_fops); > > + debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, 0, > > + &lru_gen_ro_fops); > > Looks like you have the polarity inverted there? Right you are. My apologies... Fixed, force-pushed into the same branch, replacement commit below: >From 51d26db0fd00fbd501f9271550667bab6c5fb107 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Wed, 29 Jan 2025 14:43:44 -0500 Subject: [PATCH 05/11] vmscan: don't bother with debugfs_real_fops() ... not when it's used only to check which file is used; debugfs_create_file_aux_num() allows to stash a number into debugfs entry and debugfs_get_aux_num() extracts it. Braino-spotted-by: Matthew Wilcox Signed-off-by: Al Viro --- mm/vmscan.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index f8dfd2864bbf..27c70848c0a0 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5420,7 +5420,7 @@ static void lru_gen_seq_show_full(struct seq_file *m, struct lruvec *lruvec, static int lru_gen_seq_show(struct seq_file *m, void *v) { unsigned long seq; - bool full = !debugfs_real_fops(m->file)->write; + bool full = debugfs_get_aux_num(m->file); struct lruvec *lruvec = v; struct lru_gen_folio *lrugen = &lruvec->lrugen; int nid = lruvec_pgdat(lruvec)->node_id; @@ -5756,8 +5756,10 @@ static int __init init_lru_gen(void) if (sysfs_create_group(mm_kobj, &lru_gen_attr_group)) pr_err("lru_gen: failed to create sysfs group\n"); - debugfs_create_file("lru_gen", 0644, NULL, NULL, &lru_gen_rw_fops); - debugfs_create_file("lru_gen_full", 0444, NULL, NULL, &lru_gen_ro_fops); + debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, false, + &lru_gen_rw_fops); + debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, true, + &lru_gen_ro_fops); return 0; }; -- 2.39.5