From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEADBC83F04 for ; Thu, 3 Jul 2025 14:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61FF46B0199; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 582816B019B; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3566B019C; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2BE3A6B0199 for ; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D18980240 for ; Thu, 3 Jul 2025 14:07:44 +0000 (UTC) X-FDA: 83623131648.20.ED764E2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 79B0B14001E for ; Thu, 3 Jul 2025 14:07:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SsiUUfLD; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of frederic@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751551662; a=rsa-sha256; cv=none; b=lwfKKeS7RQ6ZHuUgQmcsS1C85etNG+od8Zk5DTs5bfRz6d03M6TM44emCa3qkoghEvFr4q UyzmyneEGIxdv+Ac/APU+UYP8OEcDZwa49FajXZ/ZOnGTb287OAPKF1jKfWDfOGzdNjrg/ mnLImZFevEMBiswZqqLLw+JNs7rugqY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SsiUUfLD; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of frederic@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751551662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IpLi+YezzrpRU65P4gc6ppzC09u7baSzsN19K8JV6fc=; b=ktbWiw7wf/Y8UysF72l+K863IoNCcFWvda7Vz9wi2U6+epjpX7wbZWJu3+P1xbTJuorE2o 2vHhMCISPRb6Kzduj0rysLfOTDMOHui2PahGripJcrYr2pWMvdBPfecAJwyj4BZNuY249g XMw9DySkNAkOFU+tD1KjtBsUAdEYtbg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F202AA53887; Thu, 3 Jul 2025 14:07:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F3D0C4CEF0; Thu, 3 Jul 2025 14:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751551661; bh=X/u6N70lmZ7psbV6ssBZolq4F8KRBqL9Apr7baO/45s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SsiUUfLDeoYsY9wMs+o30nMR0v75V/D1vnglMQOtKFWss6tuHhnNlgmShoRGFkng+ RHjCxuqo378saLlIr8EPpAwDFkVdccWdKINtQoE9q/RkFAEB+wvD5e/PhlYG0H2lD+ v5gDiXtwwubU4gVXkvtzNEv8vibqtlec8HRIhegNjBfGIYISqhUbRypCtxqwF8wbuS +Qia0SlBcXD0mamUopfNZm3R8vymX+U1BhYCuq46ggqQcMG4whevkMWIhqiySPysoe AhSwERH3CdtELB7qmA4+yhQb80nRGFrSPcPrNearTIvuTDplZnjEiUYQUhA48YYjR2 hE63GnImtLD2w== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 3/6] sched: Use task_work_queued() on cid_work Date: Thu, 3 Jul 2025 16:07:14 +0200 Message-ID: <20250703140717.25703-4-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703140717.25703-1-frederic@kernel.org> References: <20250703140717.25703-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: zi864qm54jftj6wy13p9ec7p8ndujjyz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 79B0B14001E X-Rspam-User: X-HE-Tag: 1751551662-164366 X-HE-Meta: U2FsdGVkX1/7Bhvf6RLZyZtXv4SI01ZfRO9sebOSpHocI5BJkHzTXfkeI55GFgVuJmAAkJfZ+4Uyv4Wlz4xL8RMunMSsQ/SY41KUZchm0JX6z8yscMuw2MQdq8nXHWfaa3TG9+Rern1pf+6mbv71AqSrIwN96XRFOVsSzYmFM0NZNP8RbiDM9Zklv9SvjQMXWDLr6W5vyKUh4/X9rSE8H0Ow/UH1Mg3DnoyS6yRPaw1uOyiYKF2nrjpfOzSvaUTiOGgcY8nCWcy0/HcUiMd40LlDCNLSSgaCOXKDM8xL8T18NEOcfl6V/KehhDNBEpoVCztY1Eob3XC31xfTQepfFeOAbTxJ1nqIcgkhZLX9vMybuXcFijpq3EAiWmPGgxfHIwqrlzg9uGX4KXGDgExKXj3+mptQyFset7IddSct1VRipeb5FaBqvR1xMoldo5+kiTj4XD3yWl+QMuUZhKHpqdnQ4ty8zkjVeBCxa8vgAfU4WYN62VG+3oH6RpP0hZvD6Rv7CyT/t5UD7h3VqCHv/MR5sjDg4m9t/oekOC9lwzONsPAHs9UXBcyadeIZAqenvU4QnqJ5uW32Wanl4zz19c/jLUEwgGFNbyFAbO8CM6uC2bCM0YOdywhZy9gRjRPnt67RgEmkX4zncZA7zD3gaSv9zqPAjpkTgW7ZLhq4n7wDMRP39mHGT6gkoZbLXvMS5IRzgpnnxlGRG4Xj9RK0q9rxeG0d2aaD2FUTsVGxCYQacAaqyR+Di6yAy5kI83bEQSRyAvhUWN2YTT1/tLTgtHLddBOa7DhRzUXysW8SEHi5IcxjB8ZEkFAerPZtPS1xrORX+e2tCpDFa7S1Dmzj5qnQRtGBeVtNTEIs53X5/YxSzOTq5p6SKDDw0zi4tIoDP6tGuFjP6Gx8FIOXoZ4HRh5ComgGK60uAIFLGXNFG5oAJ8q0lX6du2TBMkXNADd1Y0b+JS+SGq+OuThQUHR xJKEg9Sq kNUb97q3VydJrbIre4e0w3hmEAjcTbqP2DX9ZiUQB05yfBV/19HNtPumkoYK1aQhmn/eU2uXHOl8lqojc5R0t4TUfq6zt2nIls49r5Ygik3lY6ObpLe1CF6MIeknzzyJaCvBMLwIhV9XDHFWCTEp8aevMpfrlVAAC3bqa019fJwaw1vroPlxZ9h/qdNDuXwW3NyAC7X9anreoH0wIc6ZhwdPPIhTC3Owt7cKsTSl0T6seH3ByjRF+uqCdQu8sUZQvtOy5o6G6vbGxgjSO/iPglbGyNkqYkiCoF3GW7Z7cRv8qDnVLhcoqZTZpDJOSa6Uiy2bmWHnVirLbuGgvVJtA87F6EA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove the ad-hoc implementation of task_work_queued() Reviewed-by: Oleg Nesterov Signed-off-by: Frederic Weisbecker --- kernel/sched/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8988d38d46a3..35783a486c28 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -10599,7 +10599,6 @@ static void task_mm_cid_work(struct callback_head *work) WARN_ON_ONCE(t != container_of(work, struct task_struct, cid_work)); - work->next = work; /* Prevent double-add */ if (t->flags & PF_EXITING) return; mm = t->mm; @@ -10643,7 +10642,6 @@ void init_sched_mm_cid(struct task_struct *t) if (mm_users == 1) mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY); } - t->cid_work.next = &t->cid_work; /* Protect against double add */ init_task_work(&t->cid_work, task_mm_cid_work); } @@ -10652,8 +10650,7 @@ void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) struct callback_head *work = &curr->cid_work; unsigned long now = jiffies; - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || - work->next != work) + if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || task_work_queued(work)) return; if (time_before(now, READ_ONCE(curr->mm->mm_cid_next_scan))) return; -- 2.48.1