From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9CFC77B7C for ; Thu, 3 Jul 2025 14:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3BDF6B0198; Thu, 3 Jul 2025 10:07:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC2FF6B0199; Thu, 3 Jul 2025 10:07:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB29F6B019A; Thu, 3 Jul 2025 10:07:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 970236B0198 for ; Thu, 3 Jul 2025 10:07:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9642BB74CE for ; Thu, 3 Jul 2025 14:07:41 +0000 (UTC) X-FDA: 83623131522.21.BD0881C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id D989220002 for ; Thu, 3 Jul 2025 14:07:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jmjUVF8s; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751551660; a=rsa-sha256; cv=none; b=qgcteHHIVBEz4Jh7h0zE2y8qzoQRUkSb7PGyyYXs0Ysn1eyCKVbyjVy4r4iN/wPIfcG1MJ 6tTKvEvZUtInz+SlxjSjdw3E9uxjqhvF8jZhje9Xmnd+rpdtTKPUpRKNc/l/Bx3i5fpd3r B+Z+3p0++J5nNHhY7ARSImi26zng6Y8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jmjUVF8s; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751551660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9VrEGcygcJu6Fcr13ogL7L79+E1GX96OFeqhxnhDpvQ=; b=t8jVApL3GSRzVdkXDZRc68fZZO1GZtaldc269sVvcLHr4HpUM/O/4jWecVBnFib+jo/3gZ y6o54zcfSFu6BcNaOrkHIeHKn9d8uzvdCeEfhcosB/MmB5IgI02ffGYjim0gQYFaWkOxbI 4xWxavX2mRrNronxRXuzmecdxPBhNOM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DCB10452CD; Thu, 3 Jul 2025 14:07:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4717DC4CEE3; Thu, 3 Jul 2025 14:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751551658; bh=pCxc4nxfv0WShg8suY1U89MW7fSVleiCrPCrhGMxvUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jmjUVF8smGiBdaJpDYUBMLyv/HEqgN8HproRARYCC5NsKiL3pETBMB0d2DOK1kU1l 4fPMo6Dr0mhgusJQqqwp3/i5FYuUuhJg1CF4T6qMLkLOgjZPVDvbjrptsXN08cpTcY VHgHigKzeGXXBvCQv/zZjiwjNapHiQA5TVYEWR801QtkTuae6IKmqnxYBtGHEFiU7T K83LlSrd218SLELj+FB8CnWMEur58U/z88FYr2QemwuYcUY6AygcHPo3M3P3n9KPnh b8dR6zUYrlp/Qpbf5yGNrqaJaKSCGeLZ+O/i/GQKjxeUkik7IB7Z49H4yUVrsEtYi1 Ye2VEhjuta9cw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 2/6] sched/fair: Use task_work_queued() on numa_work Date: Thu, 3 Jul 2025 16:07:13 +0200 Message-ID: <20250703140717.25703-3-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703140717.25703-1-frederic@kernel.org> References: <20250703140717.25703-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D989220002 X-Stat-Signature: xcw17r4y7s8954k78e5fehpo17ifssso X-HE-Tag: 1751551659-397013 X-HE-Meta: U2FsdGVkX1/+AcE+M0mwFKezrROKjJJAXaiGCm2mbcCsLxHQPHPtrzxjFLeLwvb26UtirtJ8MK0g0sukCz2pPabZ1SqrR727IV4criV1mmJkrCOg+LJy+v7lpLJ7mb43XVVENUl9ZSLBuf/JbawHVZA3jyGqj1//k3SUoP2ltjh3+7VN9mAMuSrokEjrwtOulx/VgtohYqpA17sXl1MKWGXLxw6djmz+TBwBX+Ou5Y1TeBEhQOCwyr91g25r/T8WPjnG8D1SWftqC/PE+lUDLmA5YqE19LPvvjpSIuvpiQVF1Lf6i/q4k8Cnk9o3tAHwXZVmtS4upZQ71duGG/DM2FP3lTIBDniaoMpYC/TT/l66wFtjba17HqjXQ1BOrARnYLsc/jvp6PPAXbdVJRd+WGhu/rQ0hPSAcQNYgBwY+38JtlymYbCo1Acv7EmMdJX3ADZmqctTXerpY8Ke/MSGxTCjKYawuOnSECj0mP+nn1B2181+bItg8KYMhp8RpMHHYR3l6Aru8TYVOO2anexCqzQwbib/eYTjZCB9U1p8ZRNxiNnrIN1M/jRAuLKg2Narg/G8Yku4a4h56RPiBER3mYVKRyDcG8NsT2tAB5rAOQHK8W5nHcJi3ygVa+PO8JgiAU8ikpUmv5Q+Npr4/5y9H4tLWFrcHJAO3qaeQ2NIBXNEaDXx2u04fnKHOgLGzBcVGINtqFDKnlY9dTX4KarBsHCMD+xCMaFi233oCz2ff1AzAuMi8qsUAdNBf8amVqVz71MMy6ACF20Wz3EsOTFW667fUx7c3QBHTwKqEI13Rz0oW/8IeLDB2VPM72dkMq9DqRClQtZAA12FAKDJdwR0L57I0BAaZNxEwFus3GctUxueptDE2o6Co1tUnVY+tPWncCA/yAZHFRRVYdm4U3i98paq8AmWzbOrcCRVHvLxhM15KfU1HgBZogj3FBqxUqyFjYJ0ZMe4D53LlYzAizA ISO3Jnst RsGBpJH+Bu/1EdF612265mZ3tJlP6rdJwaNDHbuc3yT671SyV7NXcxkLpNn/FBRO7yhH3i69417rZJyyELYUA0hfrxqQX74ra31ZJ9TQWKrGp1fBDBPNTtM8G+cSVb78OPmjBz9O7Est2rNDcHiZlPe048b7vBdD+mwz3wDrYcgCHIQ9EO9GTddkiJ2sGlltKcl4hGqiL4BBYVafMEj6durKhVpUQ90P6/j9QX4wBHlyXQ8S4gISMyNaJGU9ydGqMMduOTBVQ1hLTHMq9uTU3EQg9xoMIRMlQzP5idF27SxcUObyZFVnUhKbioH7sIatFztb9w2f1UkiWWVfpzPtMMKV/Hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove the ad-hoc implementation of task_work_queued(). Reviewed-by: Oleg Nesterov Reviewed-by: Valentin Schneider Signed-off-by: Frederic Weisbecker --- kernel/sched/fair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7a14da5396fb..b350b0f4e7a5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3318,7 +3318,6 @@ static void task_numa_work(struct callback_head *work) WARN_ON_ONCE(p != container_of(work, struct task_struct, numa_work)); - work->next = work; /* * Who cares about NUMA placement when they're dying. * @@ -3575,8 +3574,6 @@ void init_numa_balancing(unsigned long clone_flags, struct task_struct *p) p->numa_scan_seq = mm ? mm->numa_scan_seq : 0; p->numa_scan_period = sysctl_numa_balancing_scan_delay; p->numa_migrate_retry = 0; - /* Protect against double add, see task_tick_numa and task_numa_work */ - p->numa_work.next = &p->numa_work; p->numa_faults = NULL; p->numa_pages_migrated = 0; p->total_numa_faults = 0; @@ -3617,7 +3614,7 @@ static void task_tick_numa(struct rq *rq, struct task_struct *curr) /* * We don't care about NUMA placement if we don't have memory. */ - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || work->next != work) + if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || task_work_queued(work)) return; /* -- 2.48.1