linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Yunjeong Mun <yunjeong.mun@sk.com>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel_team@skhynix.com, honggyu.kim@sk.com
Subject: Re: [RFC PATCH 2/2] samples/damon: add `migrate_hot` and `migrate_cold` knobs
Date: Wed,  2 Jul 2025 22:28:31 -0700	[thread overview]
Message-ID: <20250703052831.39709-1-sj@kernel.org> (raw)
In-Reply-To: <20250703051836.1759-2-yunjeong.mun@sk.com>

On Thu,  3 Jul 2025 14:18:34 +0900 Yunjeong Mun <yunjeong.mun@sk.com> wrote:

> Hello SeongJae,
> 
> On Tue,  1 Jul 2025 17:08:25 -0700 SeongJae Park <sj@kernel.org> wrote:
> > Hello Yunjeong,
> > 
> > On Tue,  1 Jul 2025 17:54:17 +0900 Yunjeong Mun <yunjeong.mun@sk.com> wrote:
[...]
> > Because mtier is a sample code, I think it's primary goal is to help developers
> > know how they can use DAMON API functions for writing kernel code that is
> > required for a situation similar to the sample.  Hence the sample should be
> > clean and simple enough to be understood.
> 
> Thanks for explanation. I understand the intention of mtier module.
> As you mentioned, mtier is helpful for leraning how to configure and 
> run DAMON.

Glad to hear this sample is working for the intended goal!

[...]
> > But, I feel like this change is rather making code too longer and complicated.
> > Hence I would suggest dropping this patch if you agree.  Please let me know if
> > you have different opinions, or I'm missing something.
> > 
> 
> Ok, I will drop this patch in next version RFC. As you mentiond, mtier
> module should be simple and intuitive enough. I will consider this
> kind of tiering module to mm/damon. I'll send you RFC v2 soon.

Thank you for kindly accepting my suggestion.  Looking forward to the next
patches!


Thanks,
SJ

[...]


  reply	other threads:[~2025-07-03  5:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01  8:54 [RFC PATCH 0/2] samples/damon: improve expression of target region in mtier Yunjeong Mun
2025-07-01  8:54 ` [RFC PATCH 1/2] samples/damon: convert node id to physical address Yunjeong Mun
2025-07-01 23:54   ` SeongJae Park
2025-07-03  5:18     ` Yunjeong Mun
2025-07-03  5:24       ` SeongJae Park
2025-07-01  8:54 ` [RFC PATCH 2/2] samples/damon: add `migrate_hot` and `migrate_cold` knobs Yunjeong Mun
2025-07-02  0:08   ` SeongJae Park
2025-07-03  5:18     ` Yunjeong Mun
2025-07-03  5:28       ` SeongJae Park [this message]
2025-07-01 23:45 ` [RFC PATCH 0/2] samples/damon: improve expression of target region in mtier SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703052831.39709-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=honggyu.kim@sk.com \
    --cc=kernel_team@skhynix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yunjeong.mun@sk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox