From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26649C77B7C for ; Thu, 3 Jul 2025 00:10:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FADB8D000B; Wed, 2 Jul 2025 20:10:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884358D0001; Wed, 2 Jul 2025 20:10:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C278D000B; Wed, 2 Jul 2025 20:10:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5ED1F8D0001 for ; Wed, 2 Jul 2025 20:10:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 96FEF1231FB for ; Thu, 3 Jul 2025 00:10:16 +0000 (UTC) X-FDA: 83621021232.25.26BF8F4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id E387AA0012 for ; Thu, 3 Jul 2025 00:10:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlzWbKId; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751501415; a=rsa-sha256; cv=none; b=hPhtPRWJ1Rn0fHdCroU5i9SYfmIistbK3ZmooSTz9mUOVom9jO+SCHX1WYiXP2ytSi8SA1 sXaN3d8/aEICkF6aH6iF1FJKqrhc3lfektnX2OVVSKt7uASo/5eV8x/+yDt1f8hoXcntS2 Dnyl4PyycX84hHGl3Mdi2//lmtF2fgI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlzWbKId; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751501415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9/o3nWDvxcpZgwRprUSBGVMGV5PyCe5+dnHhdoL0mU=; b=WV/a4tSEQLatDapbwBUEQ0Z3c190PgFglSEh6Ux64pvAeExwK/Nh54U2crHyI9IIyz3Mz3 5aZRmgQ1uqsuj+JewOjonHVI+CCdeFnidGLxZuAiGwddAL7dCYy+PsWrLMB7FWN2bmdPml yKlMTWORNyhD4s0dMHPQ+07VEZaT9iE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BAB82462FC; Thu, 3 Jul 2025 00:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79348C4CEE7; Thu, 3 Jul 2025 00:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751501413; bh=I35/uxQ11pllQl6G03JRJP5C/144JsmJcXM+Ub0/ny8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlzWbKIddYZ5+PEPq+LD3JSF+6RpfyjYMm7MENVVI/iMbTCh3hvcyDj1+xWduKC+U mHgHlzDBAOLUP5bgwLI1WMDkIA82qtpZhbY74eLSL2gdmd7xy+YAtfVDzUl3Cna8Tq bWtJbh6tiBkRVCjkKXRA1IL1XAD/49SpaI0oalUo4BOGbFwGFOiN0jBeRSoIB4tmrF /9oRcgSEJPmvh/MzAq3dDzikm8b2u2IHAYUCSOv75w1jQxY/55kNloR3eylIVMVtQC yHGOPAII7rRTgwhcgDqBXMZwSZFUU1tpu2eMddJ+5wBT6f3rQEKoDPJb7MGESmboIp FI2fntK9tdJ+Q== From: SeongJae Park To: SeongJae Park Cc: Bijan Tabatabai , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, joshua.hahnjy@gmail.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com, Ravi Shankar Jonnalagadda Subject: Re: [RFC PATCH v3 09/13] mm/damon/vaddr: Add vaddr versions of migrate_{hot,cold} Date: Wed, 2 Jul 2025 17:10:11 -0700 Message-Id: <20250703001011.57220-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250702235138.56720-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E387AA0012 X-Stat-Signature: owc8g8ffuk1p4mb8y7ocehyj3cwuau84 X-Rspam-User: X-HE-Tag: 1751501414-161879 X-HE-Meta: U2FsdGVkX1/6wbUBJ0bvTVx6E9muH8aPh0sgxVybceR46t7ld2UVRNg28ZI+XlExZjD47pAgSWUlXDV3O7/JhEx63moBzFj8Ry39QFTBkXPFG1AFCEDxsKTJOkhNDMGL3TIORc2PJQuTYy0X7K+JYqQL+syhEKUM+A/6Y9ne8Q+GFX1/d70LB49vo8pdr4TFwsqDVgimbgs4rCyVJ/O52Tb4pDCk5r/LNJ2ktw5R0ziIsN23wKoo7169wyMaXceF3bXx7vyS1KpCd82uOoJeRHNivDak78J5U6eUpMCkEprqj56hpoof2+jCPqGK+9GJUt6uhdhOdZbnLBZziqVrKrn5U2g9fwnxpWENsnxhQQ2VwyrYu/MF/bcPBTIbFLfQtE+PQIBGZl/VhaiI9lHrLsfDjmEipzpuHCfLxmMvRshXxECTAsx4Vz2YJhglg579y2PRCGGSNqYMrEdo/bvJVZ/cbqQjFohoctQTCN9P8VhtKOnTrMoXUNq84T4QnOneBOzhXHGdzwUClqEx4f8xrsGn2B9kA21BrQfsrbKK8XH1jgADPEEoi/v2T5WT2k/rna3xrKcWCjhIRQSbwxdRLVUjmmGQStIO+jDhjYQ/Z09umEjtcJJNDwfXozORnuF0KHT2170N2sHn84at7mm3F2mtIm5Chz2R7fJyc3Lk1aNKuSc2DibdfvxobkWC5yf8hhQ+eHqx6gl5zuGCn37VlHYlMyZP95GqxDYTIvcxDwcUK+gzSrxLXJmk0iPm4M17cpxO9agwrq7tqGUWXpuqDFVBmiWVslBRHI4HvebdNgiHK47BbaFuLJGB7xKfiNPQSN+RO+r+DznAC6LYL3EAcnJoyaRsX3OACl6Iw/JxnspkUhRdJ/c0YSonPr9VYo62PY2lOnyYSRneLnBOX+P62SQdWhsvGrgztMJA5d5nu3hRq4VriWJHb+Z/KIyWlyxkTZ0SkyL8aJpOVeeWsNV 18DbGtFl QNvGKkT1mg/F2uEg2eOQZPrBSfmwEdqs8zf/cazVersPE9+M1QYfJvpSQRCb6ii/wvTpZ/vgDFn44RpE+P3CljtRBsWoMPp3BFU7b20ANTYF/cG0pyy4onFoWlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Jul 2025 16:51:38 -0700 SeongJae Park wrote: > On Wed, 2 Jul 2025 15:13:32 -0500 Bijan Tabatabai wrote: > > > From: Bijan Tabatabai > > > > migrate_{hot,cold} are paddr schemes that are used to migrate hot/cold > > data to a specified node. However, these schemes are only available when > > doing physical address monitoring. This patch adds an implementation for > > them virtual address monitoring as well. > > > > Co-developed-by: Ravi Shankar Jonnalagadda > > Signed-off-by: Ravi Shankar Jonnalagadda > > Signed-off-by: Bijan Tabatabai > > --- > > mm/damon/vaddr.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 102 insertions(+) > > > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > > index 46554e49a478..5cdfdc47c5ff 100644 > > --- a/mm/damon/vaddr.c > > +++ b/mm/damon/vaddr.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > > > +#include "../internal.h" > > #include "ops-common.h" > > > > #ifdef CONFIG_DAMON_VADDR_KUNIT_TEST > > @@ -610,6 +611,65 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) > > return max_nr_accesses; > > } > > > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +static int damos_va_migrate_pmd_entry(pmd_t *pmd, unsigned long addr, > > + unsigned long next, struct mm_walk *walk) > > I'd suggest to put CONFIG_TRANSPARENT_HUGEPAGE check into the body of this > function and handle both pmd and pte here, consistent to > damon_young_pmd_entry(). Ah, unlike damon_young_pmd_entry() which is for a single address, this is for walking the range of a given DAMON region, and hence should have a separate pte entry function. Please ignore the above comment. [...] > > +static int damos_va_migrate_pte_entry(pte_t *pte, unsigned long addr, > > + unsigned long enxt, struct mm_walk *walk) > > Nit. s/enxt/next/ ? > > > +{ > > + struct list_head *migration_list = walk->private; > > + struct folio *folio; > > + pte_t ptent; > > + > > + ptent = ptep_get(pte); > > + if (pte_none(*pte) || !pte_present(*pte)) > > + return 0; > > Shouldn't we use cached pte value (ptent) instad of *pte? I'd suggest merging > this into damos_va_migrate_pmd_entry() consistent to damon_young_pmd_entry(). Again, I overlooked the fact that this is for walking not only single address point but a range. Please ignore the latter suggestion. Thanks, SJ [...]