From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F73C77B7C for ; Wed, 2 Jul 2025 21:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEAB96B00BE; Wed, 2 Jul 2025 17:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9A116B00C6; Wed, 2 Jul 2025 17:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAF746B00C7; Wed, 2 Jul 2025 17:17:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AAAA16B00BE for ; Wed, 2 Jul 2025 17:17:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 52E79160428 for ; Wed, 2 Jul 2025 21:17:45 +0000 (UTC) X-FDA: 83620586490.03.D3616AA Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf05.hostedemail.com (Postfix) with ESMTP id 29AE5100004 for ; Wed, 2 Jul 2025 21:17:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VnNrgdqs; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf05.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751491063; a=rsa-sha256; cv=none; b=xZLeLlV0r4+7tuV+lIKhFm7hYGsi80tWguWyXkG9nNZerAPg8YyiZG5eodJ8bqK2oEGbr4 c5F1P0M24rxGV2c9stLQ9Tzy0/fW2xsRQAFwnzEb0TSVUhrgu/ClgABRbyOefPqIC2QJMR 8Jut7qHVJC7Q0+pmAzn5oixGyqL8MiQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VnNrgdqs; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf05.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751491063; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZJCP+2UZQwzSfBgsZZNvcBirXP6VoVDGCDx7eUFErg=; b=L4++5ow1Uq5DuErVKMD+6tBmL1ZP5Eej1gP3ftRE7xkfIoGKlm2v3xiVkAKv18j/a/+8oN tK9OsQcvwlaAJ3Bn4HYuujSPqqTsnuTlQjC+MVo8HRoEcaAS7XVqJO/O7F55teFIy9Uz3c KddvtI20XxIWcCrPCdJs1k+osK7mKqQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yZJCP+2UZQwzSfBgsZZNvcBirXP6VoVDGCDx7eUFErg=; b=VnNrgdqsPoyFYkoQLksjdWhHfF v992R3gFxzkRm3cDelvJVyBXRObAoFpvbbbBAKbvy4xjQglKW5D1OvWDkrWRqODrUQvgBpnq1eHL0 r/l5e9I71vLC/t+Fl9JTkB8GR8AE6q8OmTB6KujZnVKmuG3mooVKpC2Mkwc+S6sWsxkFeIPtJSTHG 5JWdWK5L1zgLNsSEyXwynue9SfuhXnSdfxTGLtGyirCSi6/yM87KXUn/qsbJBTBd44rkqqv5OOt6h BsxS8H6am9ZyZJtfgYh2p0ezHn8S3qXTCx6LAAOstf7wfbPQj4JSQt9pmuWKepwhQPGUtr0s6zRQR yUGgFcgg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uX4pn-0000000EKV3-3pTK; Wed, 02 Jul 2025 21:17:40 +0000 Date: Wed, 2 Jul 2025 22:17:39 +0100 From: Al Viro To: Greg Kroah-Hartman Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 05/11] vmscan: don't bother with debugfs_real_fops() Message-ID: <20250702211739.GE3406663@ZenIV> References: <20250702211305.GE1880847@ZenIV> <20250702211408.GA3406663@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702211408.GA3406663@ZenIV> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 29AE5100004 X-Stat-Signature: ngas8ozp6r7n5p66a474o4hb9kj7mnps X-HE-Tag: 1751491062-47441 X-HE-Meta: U2FsdGVkX19yaib+wKOWptcxW1vPi3aOBMh767CeUOTtZ9Le6RAVSFJYvbaPi7Ug6G7vOYAl/BTBO4k8L4bau8Ud4HN9mHlaDC8SGd8AvkreMXnoXPQ4QTwws2O9au7WG0jg4UsF0he42VTN5DLmvxy+bTxOVq7VIzE11wpXfOP3Nku/TfHD3tGYS2HFF9KHmaL8C8XOyBon7EEz4ekE7CThkalGoKXI+H4PLRwlc6k1CXKHuhJvoW5OOuHmqxfzn7kfW5QYOBbho4Q2/GIOhNOZCAaKOQ9XXRlTyfnuApD7t2A9i9zbsLhPdvaYLR8+zzqmcvcx73t8vlso3jeLwfWMdor7dYZQE4P9DtBtkxs7UeSIQgklx3oBdCqD6LpHnD6ue7anqQ7mgOqC7IVI5wbJvq3ekt2MhYt03ff1f5Ty1i1j6b3zAnYKqDHxtypl39v2O94LQWejBoChe6B8lPn7Mj2dawfyoTp9xIdBcC1Gdvr8MP0P/ZALUzvp3dDokvPpgGYI4mny3Rk9fXkN80D4V90BSq1h8Tpyc9XkRoTHxDP/v45L3I/61AzhZXYr+AlOcwdC1oQQpX6XxdGd8BuKy4WQ2W/sNMmTM56eHvqW6zU0Vvh7CXix0kXZRGfZwaX91wDCRHL4ErsTpcO80uDNYtCQGtYsNSUG06GEdjYPWjeOeKfi/FhT5sQE6oPPY1TbZEcxHvD/nhGFkgN8m/ukDcctcFMzPCLvYhwup3GWIMfjMoHuvDAmFL4yZsgWU66hShHepyX/Au9BiwY65tRydjGH4KC2XZKdYng4YEKHENZcrejGfoS09NioGc0ZALDp8bp4x3oERUa5RVMDDsGXnblly3tZv9iBRR9k3b60cwrm78+jpasnIFOFN89nouZpW8eDXyS73YMJcmsnKUOwIgm5fKVZ38UvPC8MfRy6baSiiCX00Z7XRzH1unMOCerEmCfYDuKQSHw20pz lKKyQic9 OZQDKvhcgkGUhb5uAZqweDeDbIUN6X4NdFSJtUat2WYNnjgnzwKp+XCE46Y8fETgPSQgK5BLSodbKaq1/wKkB5Z0677Csk3HB8v1zQv5sjcBwc9wzoKOFHowM8IQGPtTGj9njcvs5ELXW5F/ddUwFuZfAZvUSLurPQTXY9ojycY7Pl1ZAadA1wKF0t4WFZNfDZ8txKvOCsF+D5dxMoD1GPAVhCRif3tYezMrLgdHKDPexDKt5Z7XXxJsDFdjTBRT65CNvGFNNk/Ske4/TKfLohJuIvaZ7xKW4hXeNqexDikBelpahkk1CD6Z+6DA/jLuYVX2YJ+Pa4FedjcdFn0T19t0I0HltN/WqoACN2V0iB8mTOnOtSCcFLHaZysxsfdoxqsAx3Fo96VQM/MBERUbwwvpT0F3dpNs4ZL28r7IT/9vVYf2rtPZigQ2YAiCnObuMYnSqwT6RHo+hRg2jO66pW4oAP2yadU8SKLpn7TKyzVqgZVV+q/TbNugYygXZZBZZwt5/On5zp+9zuKqU+XIPNS0JSmkxa4nilX3H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ... not when it's used only to check which file is used; debugfs_create_file_aux_num() allows to stash a number into debugfs entry and debugfs_get_aux_num() extracts it. Signed-off-by: Al Viro --- mm/vmscan.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index f8dfd2864bbf..0e661672cbb9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5420,7 +5420,7 @@ static void lru_gen_seq_show_full(struct seq_file *m, struct lruvec *lruvec, static int lru_gen_seq_show(struct seq_file *m, void *v) { unsigned long seq; - bool full = !debugfs_real_fops(m->file)->write; + bool full = debugfs_get_aux_num(m->file); struct lruvec *lruvec = v; struct lru_gen_folio *lrugen = &lruvec->lrugen; int nid = lruvec_pgdat(lruvec)->node_id; @@ -5756,8 +5756,10 @@ static int __init init_lru_gen(void) if (sysfs_create_group(mm_kobj, &lru_gen_attr_group)) pr_err("lru_gen: failed to create sysfs group\n"); - debugfs_create_file("lru_gen", 0644, NULL, NULL, &lru_gen_rw_fops); - debugfs_create_file("lru_gen_full", 0444, NULL, NULL, &lru_gen_ro_fops); + debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, 1, + &lru_gen_rw_fops); + debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, 0, + &lru_gen_ro_fops); return 0; }; -- 2.39.5