From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA10FC8303F for ; Wed, 2 Jul 2025 11:29:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0518E000B; Wed, 2 Jul 2025 07:29:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7607A8E0001; Wed, 2 Jul 2025 07:29:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655D88E000B; Wed, 2 Jul 2025 07:29:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 522A28E0001 for ; Wed, 2 Jul 2025 07:29:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B36D9104898 for ; Wed, 2 Jul 2025 11:29:22 +0000 (UTC) X-FDA: 83619103764.23.E82A70F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf13.hostedemail.com (Postfix) with ESMTP id 5472720011 for ; Wed, 2 Jul 2025 11:29:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pBo3l1Dz; spf=pass (imf13.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751455760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=p/YBTsHarJnrR0kdVvkZX9N74PaI8WBrZluviimBlYo=; b=NicdMHCv0FjsDfikHMAtCZXTgl4/s1tDYHgrw/aevGiTIrvQvtvj1+yCLukJunrNyGkI+q ZcuqIOygllrJWQn/otnb+UKbGUIJdGwIDm/nrJHTGAtMAZRpzoqH6l9I8UnZMWxtLZ2+Ha NxpgsnGSXutkW+z/ob5G+3ZerfQ90uQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751455760; a=rsa-sha256; cv=none; b=iVrmKr+v1C3WXzyZBW179GYcxlCL6RSfkm9DvmPhQjhhNReTQUJkNHl9TynRIbP7OLFZfS +CqVVBARdMwBPQdC15SYn+DOWmb8oSTFp1J5LJ0MucQZba5o0xq5Kwq/zR/Wr9azewQW7a fsDz21Kx5HjmMkBzSc6+70oNZXpeTgo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pBo3l1Dz; spf=pass (imf13.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5624VR2W008074; Wed, 2 Jul 2025 11:29:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=p/YBTsHarJnrR0kdVvkZX9N74PaI8WBrZluviimBl Yo=; b=pBo3l1DzSXJS4N2dhr2KEfSliVsCb5Vy/3hUHJUoxTuMCsaQavmf+xMBc iXOFJA4Mpfj7Y/lClpWLX24oBNWlyyC1mqyLNA2hYsq7ceBEhXU3HbS2naZNeVKr jG8iQWSbAQ+OfavYAvf/4DxFNvyX0idNxnpRmY/saJvtLWfJYQAWKg/NNxpoeBU5 VCeU8pMlgyZYdiEbjdDxaYwOCxZrKSAwQIYSgGDQS2AZRTWkIR+HdwvyCHH+Vj1+ dBoH1T1tJTGdcPS8jdetleeMYOOe7ABGGg0etjyGhCURZQG9VUjGjP5AAVFvcJar Lq8TEbUI6lz0Xi9kJk/o7Nbo7xqEQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wrn4g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Jul 2025 11:29:10 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 562B6f0n012548; Wed, 2 Jul 2025 11:29:09 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wrn4g4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Jul 2025 11:29:09 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 562AfvpQ012054; Wed, 2 Jul 2025 11:29:08 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47jv7my4qs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Jul 2025 11:29:08 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 562BT6M751970374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Jul 2025 11:29:06 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A8AA20049; Wed, 2 Jul 2025 11:29:06 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D335820040; Wed, 2 Jul 2025 11:29:03 +0000 (GMT) Received: from ltczz402-lp1.aus.stglabs.ibm.com (unknown [9.40.194.31]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 2 Jul 2025 11:29:03 +0000 (GMT) From: Donet Tom To: David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Greg Kroah-Hartman Cc: Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , KAMEZAWA Hiroyuki , Donet Tom Subject: [PATCH] drivers/base/node: Handle error properly in register_one_node() Date: Wed, 2 Jul 2025 06:28:56 -0500 Message-ID: <20250702112856.295176-1-donettom@linux.ibm.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E/PNpbdl c=1 sm=1 tr=0 ts=68651806 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=VrXgkTA_NDOggtd2K6IA:9 X-Proofpoint-GUID: RSfRXe1pJUfoStl0RtYoKOyEq5Zpp2lP X-Proofpoint-ORIG-GUID: AXXZW-3Kuz0pGuqr65ZFqcOPMRIsj9Vf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAyMDA5MSBTYWx0ZWRfX1ev3hEi+ylHe yiNfqCrt3gKXzzEZzKqJkV/jwwjFVSD8xwrLTgR1D4tmdNv7B0CQzk2SXj41dT+Jmp5P1U0lJS5 aRrwUAMtfFmHBieZtAxXIQh6TjjoPt6yqQw9Gqf3PFJS1Oj2YTrpEL0XvM0qIRXtmvUTiflRgU+ fFGyBi/n7ndAt7aPUPO++z6ysIq7H5SyTnBN5bixY7SzW3D8iLatwDN4Wy6Il6wj/zWGBlTecJ8 Osl7b3TbQJ5RcdtdCYleNWtqjo8O6OPbOucX/cZfM5IIGZyCAjJ+NnWBQrTeDqrzsbggEeXjYmt fKYHrE1xpn0boSvrT8NmVYmhvZjb0WS1klcyUKL3cVll3dv3ALhlY4Pk1PZh2RDfRvTOtn+m3vv 5kcQRNonSu/q9bRfYarUpouEF7edpSofRT2aamfthN8GXsZVt2aLDnoD3gVxokD3lMa1gOyh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-02_01,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=953 lowpriorityscore=0 mlxscore=0 clxscore=1011 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507020091 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5472720011 X-Stat-Signature: m7r8k9sbcqyu3xehprrp9m516oaig3ox X-HE-Tag: 1751455760-999912 X-HE-Meta: U2FsdGVkX1/l26grQnx/fuxOmnjRRzpfyPkSZkJN33BEIoJeVnKSUorRnW98jVRhy9qUBBpXS3PfLf5WQWzcJzicQzouO5GBPlPju9jh4AeUQdZoGAD/wRJIvQNuswRB61xzYZEKCnVgEYVrEY1hYW9JOVRYt09e5dT78ZagBZW2TVbn23BwHJf0JjtSTZwAC5PwybDX0jd/bQ1SUoie79GzKxIn4gXtjwAEp5l1huUGf8qtJuoLsg4HdHV2MCG7YhxS3oP3NhUPslSBJhSwx1nENPG/mqwPcf0P1M6MrCyfptJ0i6boro0rQtThdfy89/IhL0J6NzmUJQL/S2VsoVj8nJg6osuHKl1NglmLbY/dUOZU7VWFxSZAK9uo+5EveaV4YKFAwrfk0PzROzfWv5hmdirZOHSu6JjTohmlzGTsjuzzXwIq2yFIFWuQu4/JgIKa7ecYA07MNAnRvm2uLNobPHwGrl/fygA7wb+Ut5o4D3NWFDt2uhzbMS0Ai0uVQJqDhBA/9vrgyRO3+MZqI6gmPi55DMHW7UtJIIa1SWmos6pqxSRiEQUc75ZEiPEf2ic/Pjqu3w2Pl/thD1GFthUxkZUV0x0gYRKWLbdX6Es40txKSZlUU5WrrCe1jiuoaqvJp7YyewFKUSUcLkT/oQjsMCWqouwNouQyJDEqfnubNEE+ohhNcVASfvEt0MQe3a/wSI8C1oXKKxN6zIcqR+wL+W4MYQMnZb2ZihdmXSlhDwcKpoILztN/r1fAQbs7dTw0JrKN63+LtfSg72KSnAIPLQLjwfGBbk4GmR+GY+r4Ohnnc4hgCDbcoNaZfi2gPk7hZ4jcwk8QDWX7WoRjmIKGwiUL/MGrx0iyDI6DNhvl5Is77SNiVR2XnneJedQWyPFjhzmkfs6VL6Lt3jE5y3I/kV/a4NeHCMnfSL6Lz1iqfK8RYuyRmh3hxmVf1rPW9/p1wnx5ctT2UWiQ65d JclhAW5X KmjsLX38SzSUcp8KerLdFtp91tqCkD6UtVsjC7Z3o7msSbaWC6WX0/Ju/b2illzrE5dcPzO+tZrycLBVu0VkkHi4L/l5m55P4F0V1/1vzqKNsoulJkc/bTEZFwbMoNIxfO+3coTNBDoyQnbcehr6da4UrFqSA9WPNaC7iE12zppnG29gcqp4q9G70Bh7jcPI5rlDomxlgaBSzfRp00DL24eQr1aYhO4hHysV0GXxMUNecryyZgaZTmSvDXHmh4kizr8obpxGeYRPCHShwUmTV3fhhCP6HeqJTlMmisH+l9+AM6+rHjKgMmolmgv2AJjwj024n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If register_node() returns an error, it is not handled correctly. The function will proceed further and try to register CPUs under the node, which is not correct. So, in this patch, if register_node() returns an error, we return immediately from the function. Signed-off-by: Donet Tom --- This patch is based on the mm-unstable branch. Fixes: 76b67ed9dce6 ("[PATCH] node hotplug: register cpu: remove node struct") The issue has been present since the above commit, which is quite old. Should I add a Fixes: tag and backport it to all kernels that have this commit? --- drivers/base/node.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/node.c b/drivers/base/node.c index bef84f01712f..aec991b4c0b2 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -885,6 +885,8 @@ int register_one_node(int nid) node_devices[nid] = node; error = register_node(node_devices[nid], nid); + if (error) + return error; /* link cpu under this node */ for_each_present_cpu(cpu) { -- 2.47.1