From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9F2C83013 for ; Wed, 2 Jul 2025 05:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CFC26B00B8; Wed, 2 Jul 2025 01:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 958B16B00B9; Wed, 2 Jul 2025 01:33:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 820F46B00BA; Wed, 2 Jul 2025 01:33:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 692A66B00B8 for ; Wed, 2 Jul 2025 01:33:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E043140742 for ; Wed, 2 Jul 2025 05:33:17 +0000 (UTC) X-FDA: 83618206434.09.6B7F2AF Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf05.hostedemail.com (Postfix) with ESMTP id 30841100004 for ; Wed, 2 Jul 2025 05:33:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751434395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqQTdtmJfIpNPJKYwBk0X5UjY+30Zte8xXVtxC4VkSU=; b=qOeAv5eSmYBpaX0tooGdSuNG9iJCeGIAYC1Qdx7rrUlXvywH0f4xqqybgtgtOJCitYT8rf 2jKR5zVnyC6jQqmDgsHRILeVN7o0PSRb0Faxg1RjDdBXSrPv3vbvrgtBDek+lZSGmAeyGf QbBiJYDk0YbFTVjrSyoDjJexDH7lGo8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751434395; a=rsa-sha256; cv=none; b=xlQtv39vy0HI8LRg0gnu8dIYhyw3gQBWlOehOlk8E7rsPKkuZRHlWJXzgTudZynu7w2l+T l3B0madIELZuTyo3k/E1+DFjR1UWq9o6n3I0wXiRLPHzCzu2KXTgk5vgWDT61xsDlZiYcR USkjUexPjCt3kD696I+GRkZvd9VTE/I= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com X-AuditID: a67dfc5b-669ff7000002311f-34-6864c492dad2 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: [PATCH net-next v8 5/5] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Wed, 2 Jul 2025 14:32:56 +0900 Message-Id: <20250702053256.4594-6-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250702053256.4594-1-byungchul@sk.com> References: <20250702053256.4594-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SW0hTcRzH+Z9zds5xtDieok5GBKuQJM3K4FeUCfVwHhS6UuRDDXdqo6lr M9MiWGWZ4iw0oV2qVVi2Kct5m7ak5vIeiWUtzUvL6iErUxteytoUybcPv9/v+/m+/GicNYjC aGVKmqBJkamkpJgQf1twN7LQI1dE57TQYLaXkmAbz4AHA04RmK3VCMYmeigY9TSRcO+OHwfz yywCftkncfjU6KPA5kiA/vufCXBl1+Dgu9pMgj5rCocnE98puOAswaCjOl8E1yeLcajRDVDw qs5MQl/pXxF8dusJaDE+JKA/Pw4aLUvA3zaEwGOvwcCfd5OEwk4LCR+z+hF0NvgIMJ3PR2Cv 94pgajzgMD3vo+JW8w1DP3C+8uE7jK819lK8xXGKryiJ4HO9nTjvsOaQvGOkgOLfv3GRfPON KYKvdY5ivP7id5L/+amb4H/Ud5G8vbKL4NstHmp36GHxNrmgUqYLmvWxR8UK0/BbTJ0vznBP gw710rkohOaYGO6d7TyaY7P+MR5kkgnnvN6JGV7MbOBGfU1ELhLTOFNGcp7SHiq4WMRouffF rpkwwazhely3sSBLAqK2r3WiWelKzvbo6YwohNnM1Tc2k0FmAzcfr3jI2ftQrsUwGCigAwXh nP0WGxzjgejFKhMe7OWYSporLL5LzjqXcc9KvMQ1xBjnxY3/48Z5cQvCrYhVpqQny5SqmChF ZooyIyopNdmBAg9z/9zvRCca6djnRgyNpAskza+TFKxIlq7NTHYjjsaliyULVwRGErks84yg ST2iOaUStG60nCakSyUb/aflLHNcliacEAS1oJnbYnRImA5d6d55tk19UsAiX2Pscuuk6tcW dXjBk3XHbg+PXXbmTBY82tulLGAPRKg2NURuT0hrX8tkt1vL7qBdLQfL6RUfiv5khprVt5Kq WltRrEERHRPfMbgj8YvO0BvWdHP4ktcSLS86urU0yaIYQvvFg9Wu0elDq154hk6Xx7sqdHl7 pIRWIdsQgWu0sn9PaqIwLAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTcRSH+997d3cdLW43qYsV0aIXtDdD6ZQRUkQXoahPgYQ52qUt57St yQwCS6GStsoMcpu1Ek2dsVq1admKbfmCmGFUW1bWUulFNp1tadrLpkR9e/id5/zOl0PhzCSR RClUR3m1SqqUkCJCtDujdE2FVyZf7x9IA7OtiQTruA5uvG8WgLnRgeDbRJ8QxrztJNRci+Jg 7ikjIGL7gcNgW0AIVvsu6K8bIqD1lBOHwLkOEvRlkzg8nAgK4WRzPQae6k4BPHMYBFD5oxYH Z8l7ITy/bybhXdNvAQy59QR0GhsI6DdkQptlPkS7hhF4bU4MomerSbjYayHhY1k/gl5PgADT CQMCm8sngMnxWIfpyTth5nLOMxzCubsNfoxrMb4Vcha7lrtTn8yV+3pxzt54huTs4Qoh9+Zl K8l1XJ4kuJbmMYzTlwZJbnTwNcGFXC9IrubTCMbZ7r4g9jDZoi0yXqko4tXrtuaK5KaRV1ih QaRz/4IS9JYqRwkUS6exZv0DPM4kvZL1+SamOZFOZccC7UQ5ElE4fZNkvU19wvhgHq1h39S2 ojgT9HK2r/UqFmdxrKjr633BTOkS1nrr8XRRAp3Outo6yDgzMefjaS85489lO6sGYgeo2IGV rO0KE4/x2GrpPRN+HomN/1nGf5bxP8uC8EaUqFAV5UsVyvS1mjx5sUqhW3uwIN+OYi9Rd3zq QjP69nynG9EUkswWP+4+KGcE0iJNcb4bsRQuSRTPWRyLxDJp8TFeXXBArVXyGjdaSBGSBeKs fXwuQx+SHuXzeL6QV/+dYlRCUgl6pB0KV34J9Uf9VRH/Jp236PqFaHCvuWVDm4kZBU/2eO3n nMP1Gfe6rYu2jzA+hc7p9zZtjGQVTmVNpB9ybUthVs8KHpHv+PmhSutISVtlkF0PDUoylhna n1YEwo7zytt5338u3Zwy66KVUadGLKtOXerpDO1PzlkhkN0Kw6CE0Milqcm4WiP9A08AsP0O AwAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 30841100004 X-Stat-Signature: p7no87wj3krk719dkxmuykm7gug8s4md X-HE-Tag: 1751434394-335190 X-HE-Meta: U2FsdGVkX18pH2pebKEvqYzjqrauGNOZjtNO1hje6hIaSgvkYtHaypv+bK8j2dtZZsDUZqFj1R90omJ0lHkLKIN+EdP2KGq17lMG+GDBsiwT+udBTJoKhpW2qI5vmxQwVpmfSeYyqjW4wMOM3H2eyYRvX+EiiI5qTFEhr4rXWyzDCQJv2GSDeqVJJ4Eh3lm4tD2VMlgtKy0bzL2gdIfYsR6R5IkWSPY3xKAz87wOqBHH/uF+3ZKejTwvXL8hYVRHplHlr/U41kftO0LNz/e9VXY1no/TxzX5msHTLvu83Woa7ueLeaH4nk0gi1sxkxim/Hl9g8/O8Yo6Rk9ewB5c53dxNd7N8GAOx9QWbpqU4zrU8Up7VUBF8NP0/ys/hSNLjGmWQtvYWhAitdGSgf3znPReJDG0/v2UoBmyl+O9wpxkp3SpcHva0Lq+zAiCDLhE3nwYc+7MhIkwMR44vlY7KVf7Ejs4OqUd0jVX5Cpx8sUb6rwucta7STFtUyBXZIFlYDPi9K/qGLGLhXkHFiwWRzYBcEqjmtGZAIYWpYrNoi1CGnQJOr5EpZ4hygNpdcXej/GYZ+HjJdjPIUsOmsYWvWkWhGcxYiDjdqr3SwaAN6gpSoE84DCyujWYvVamnauWTEwJUCxhLPFLdnJcdG7rSs0Icfz13KQ1vaWd4KpAPJon6pyr3SVsVb5TtfGLbVqqb59Q67Om0o+1/Z2l2mwUk8HfV5Cdul3sIRf/ycbzzaB0qROPOe/aLVHMkDcmm+vfp+zrrKbA1Xt3N3UZMCZPG8b8N0udiFBIS24r84Q/sFFf9wVrZ6WTaky+a4hYX7wM5wjNNSxVlTmnAJv+1Ibq7AbYsq5lHpFt2Khw347OLtH98DKrvafa6LpIPGX0YS8YqIRmf+FbijcHXUlbjtxPNdfzFfWT8U0o02cTm+j0/CiMTwSXGf2YbgNeZ62J+9NyDdSkzKVQMMxrbh39GD2 LgWsoeh+ NPRmzn5iOyRKjK1MJQzEFUUdLoJlbErIxwwQQOwxgOHdiiGnpPPAaRRzbMjd5JXz1lv0/W2jVz/SnKfBM595HILVZGON2jBFFDMcdMn+mZsoHLCQ3edIreZ2C8oqEDXQH5Y3KNwyjRkpilMEF89b3R6GYPznH2wg740HOJOjxbNVzdokU3wew7D42h9nyshJzodvqTQd/Pg8PLPp0KTCK7KtIbTvBwzFCHMasqmrRAX7ddp0IGLyHFDRHaYYpdFSBdKDXs8qBDsKVOAS2jFv1D8nrpEiCELZtTWB6mAKJ5aVTQHE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas Reviewed-by: Toke Høiland-Jørgensen Reviewed-by: Pavel Begunkov --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 773fc65780b5..db180626be06 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -444,12 +444,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1