From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC7DC83013 for ; Wed, 2 Jul 2025 05:23:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529506B00BB; Wed, 2 Jul 2025 01:23:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 501226B00BE; Wed, 2 Jul 2025 01:23:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43E076B00BF; Wed, 2 Jul 2025 01:23:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 343776B00BB for ; Wed, 2 Jul 2025 01:23:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DD0141245BE for ; Wed, 2 Jul 2025 05:23:47 +0000 (UTC) X-FDA: 83618182494.06.0E58ED1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 44233180006 for ; Wed, 2 Jul 2025 05:23:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kD5rO6Fg; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751433826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MGK20rD0bpAlzooacwUA6jN65pz3i/ownJMzoI7Y/MI=; b=xnw6X444adVHIoMQClVEHEagLaXX6+yeJr+9+knXTd+shEi2PJWuX5DX32elk5XoQeh077 yQVhWRpbt2GYEpU6iD2yvdf6fhdsPk45DpY2hIDLPQhhVbJuEQRpXWFiaeRIxwm8v0NmRE cKiOEIT5YIQs7fLROig9cmwFGtYp9tE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kD5rO6Fg; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751433826; a=rsa-sha256; cv=none; b=iIYNFS+CADbS+vHM0szlPDaG5r6962YQrzJGXwOj7AWmF9S2KNZh7+Fj8Pf0sHC7SaF4IU vcP2rrWbgw7Pw61XioWN0zmvxwHwAm2extP1QPX9wk4HlvFpfCpmzSA8dd0f0nCKf1jjn0 yMZ9bhHx1cT64Av1N1DQpInR3ZwkNMs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5CECB5C61DD; Wed, 2 Jul 2025 05:23:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1987C4CEEE; Wed, 2 Jul 2025 05:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751433825; bh=y61RM2CZLTlPVFVJqIH6LbDQqTpJ/f7eA4CyIMT9MBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kD5rO6Fgl5n5OQ70/HCQbU58LVDC5YmnhjnsHg/wWrDItFOo/cqp4zKYOEYcWfiZ4 Q1yWAz/ffQ4azvj+4+P3/A78FqV6daelnWyHc2EYYlP1DJUeMrRHXqgWsgLFcAnNKY dTHQ19lFeGS2p6fCKJDFefLaLG9LwnmMJ+lS1GK4TwtwwkXAHh3mD5Z29WG4XdunEn VTEzVzf1ApQqAcXt+Pm1MDwLVvoOhQn0KPI7hrJAGHRHAgvcRu6j81S316EM/X/BSV Hfjt7D1aldbQtcCTSeIeNgHuqJTPAK6Wt21+lP/BPbiJkeQTSY+pXDQSbBuAH7kTrs XXslgqmaIfC+A== From: SeongJae Park To: SeongJae Park Cc: Bijan Tabatabai , Andrew Morton , Bijan Tabatabai , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 0/4] mm/damon: add DAMOS_MIGRATE_{HOT,COLD} destination nodes and weights Date: Tue, 1 Jul 2025 22:23:41 -0700 Message-Id: <20250702052341.54336-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250702002316.1139-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 44233180006 X-Stat-Signature: xr57jf63puaz6pmn1een1ywecz9czk9q X-HE-Tag: 1751433826-783636 X-HE-Meta: U2FsdGVkX1+3flZf7/IbfSFhIvfAdK10SFiXrUiul9SMpnKeH/vGeIwp0hyh6d07YcCcd3U52rQXWTEX30XU5UXDmVTtrejs0bjxZMjAyXPrPhws0pqyNJ4SggK8E2z9eC2cdW8xUfJ7ycEIQjZuCP0S555Z895LejhEq5O0dekgd8okB4f96RX1UUNj2QV/W8fng+d4EYVcQmT8GIUKQgyH0apfnz2ee8UBathZYuh/4veTV/n5lMmKKcfxLXV3ysU5OxlhwuRbpSCz+K8pwZira4qw34Rok1i7c5KusQ8RecuqleoXl83+MrS7t0sbC8NnKDS4IGF7sll6SCLv1UR5txYqJ2llyTzav3lEjXqJUdJPQ14mzSqn9p4zSnKJmSovovKluzIhVkjWxhYjm8tT79Wh1Ph6gTTYsqH+WZGb0L070udst2pZYoLVOhL9ntkCw+FpkBhbYIyy0ahS8jMwjlmdfCvyBHdgj2fjamrjs2iURnDv1nZNV+/1vpscozX0jDUraKbOC/fFduJlxAIgjphhGxjqmQmR06uXwtF1Na5JcCPY1CC1caT16YXoASBPqaZQ9RmkyWurRjuhLpkUYtYpIQ0KsJq6T9rSES5KgSvKrW48irY74pK6gpaD+pjY297KdzUY854mFR8IgosjJFPvoR+PGBvlbd16fvAv7Y9Bg1S0xGFySlFKoTgMQMBoeEXImCHGhubPC1gTZGhkE0alYmIbkKqe5r/lOyZGxzAuih3P49LpEm6Apdx+Rojl34sBqMiJuLvcrwOVA3v5BpTTEJX05V/qkrLwAOF7Oc4YEsTk+KOhqUhh186tObAIf/u4psmJ+lotkijJBklegbJnIhbniqhZIkz2A+ynzg+FyFSPpnSGZ5JyN9HRkPFyKuIK7eKmGgffKcQelGoDi0/7Y6mXirckBJvUX4f8/X8xy0oZGYRVvxdTwrCrJoSq3dXW4NnPz0Z3XXn 1NCAO+S8 OcCN4nVPSenjxga2HxctiXZKJxgf+NY89NAKNLOTmHbg9qLIgjV9bzPy0U9cPJxstv62TlvVEun1j5MygTrtqvZLNk2XPoDwiqmZtWn9RAgb/GbSXxmzKmMopBgpb1E4XhHxdOIVkvJUD9FDbB8Z/QbcWAiM2E6ODs/W/R4CnaBWBgf2Pl43SFI2e5/8ZP9aQZEMfagqbqa42l31FpkfHWmxRGOvDRSte+t4uRgptMo5n0vLwpkyoyuLgNUWZt0rrY5b73ytiqKS8Ur0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 1 Jul 2025 17:23:16 -0700 SeongJae Park wrote: > On Tue, 1 Jul 2025 17:39:37 -0500 Bijan Tabatabai wrote: > > > On Sat, 21 Jun 2025 10:31:27 -0700 SeongJae Park wrote: [...] > > I am finishing up V3 of the interleave patchset using these patches. It > > has mostly worked great, but I noticed that damos->migrate_dest was not > > being updated in damos_commit(), so new weights would not be applied. This > > meant that you could not update the interleave weights by committing the > > damon state. I also saw that damos->target_nid was also not being updated > > here. I will will have a patch fixing > > Nice catch, thank you for finding the bug and making the fix! > > > this with the V3 of the interleave > > patchset that I will hopefully send out tomorrow. > > I cannot wait, but please take your time! :) I just realized this series is missing documentation updates. So I just posted[1] RFC v2 of this series with two documentation update patches and trivial commit messages wordsmithing. Note that other parts are same to RFC v1, including the damos_commit() bug and damos_migrate_dest name. Please pick the version to your v3 of interleave patch series if possible. [1] https://lore.kernel.org/20250702051558.54138-1-sj@kernel.org Thanks, SJ [...]