From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: Bijan Tabatabai <bijan311@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Bijan Tabatabai <bijantabatab@micron.com>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH 0/4] mm/damon: add DAMOS_MIGRATE_{HOT,COLD} destination nodes and weights
Date: Tue, 1 Jul 2025 22:23:41 -0700 [thread overview]
Message-ID: <20250702052341.54336-1-sj@kernel.org> (raw)
In-Reply-To: <20250702002316.1139-1-sj@kernel.org>
On Tue, 1 Jul 2025 17:23:16 -0700 SeongJae Park <sj@kernel.org> wrote:
> On Tue, 1 Jul 2025 17:39:37 -0500 Bijan Tabatabai <bijan311@gmail.com> wrote:
>
> > On Sat, 21 Jun 2025 10:31:27 -0700 SeongJae Park <sj@kernel.org> wrote:
[...]
> > I am finishing up V3 of the interleave patchset using these patches. It
> > has mostly worked great, but I noticed that damos->migrate_dest was not
> > being updated in damos_commit(), so new weights would not be applied. This
> > meant that you could not update the interleave weights by committing the
> > damon state. I also saw that damos->target_nid was also not being updated
> > here. I will will have a patch fixing
>
> Nice catch, thank you for finding the bug and making the fix!
>
> > this with the V3 of the interleave
> > patchset that I will hopefully send out tomorrow.
>
> I cannot wait, but please take your time! :)
I just realized this series is missing documentation updates. So I just
posted[1] RFC v2 of this series with two documentation update patches and
trivial commit messages wordsmithing. Note that other parts are same to RFC
v1, including the damos_commit() bug and damos_migrate_dest name.
Please pick the version to your v3 of interleave patch series if possible.
[1] https://lore.kernel.org/20250702051558.54138-1-sj@kernel.org
Thanks,
SJ
[...]
prev parent reply other threads:[~2025-07-02 5:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 17:31 SeongJae Park
2025-06-21 17:31 ` [RFC PATCH 1/4] mm/damon: add struct damos_migrate_dest SeongJae Park
2025-07-01 22:43 ` Bijan Tabatabai
2025-07-02 0:25 ` SeongJae Park
2025-07-02 1:43 ` Bijan Tabatabai
2025-07-02 3:02 ` SeongJae Park
2025-06-21 17:31 ` [RFC PATCH 2/4] mm/damon/core: add damos->migrate_dest field SeongJae Park
2025-06-21 17:31 ` [RFC PATCH 3/4] mm/damon/sysfs-schemes: implement DAMOS action destinations directory SeongJae Park
2025-06-21 17:31 ` [RFC PATCH 4/4] mm/damon/sysfs-schemes: set damos->migrate_dest SeongJae Park
2025-07-01 22:39 ` [RFC PATCH 0/4] mm/damon: add DAMOS_MIGRATE_{HOT,COLD} destination nodes and weights Bijan Tabatabai
2025-07-02 0:23 ` SeongJae Park
2025-07-02 5:23 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702052341.54336-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bijan311@gmail.com \
--cc=bijantabatab@micron.com \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox