From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 815B5C83038 for ; Wed, 2 Jul 2025 00:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36B508E0007; Tue, 1 Jul 2025 20:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3442D8E0001; Tue, 1 Jul 2025 20:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232158E0007; Tue, 1 Jul 2025 20:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 06C7F8E0001 for ; Tue, 1 Jul 2025 20:02:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A4095B8977 for ; Wed, 2 Jul 2025 00:02:19 +0000 (UTC) X-FDA: 83617372398.19.185621A Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf29.hostedemail.com (Postfix) with ESMTP id A530312000D for ; Wed, 2 Jul 2025 00:02:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; spf=pass (imf29.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751414538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yN37BMPFW/J/jKWWorwBq2Hnf2yo7V8vyiHAxmC+f1k=; b=Jk8FvCmEKO/JF7xbKg088SOdri5CWFtFrMf6e6Q3ZToUurryxx/OhqMxwcFgR+KoikCTwm AToQFwgEEivGmC1YMRuETRpCbKmEpx3+1dMVclrgX6xIpQTWl7l/+j5FpCf/WSwDqKTVLk yrd/WERq5fH+KIlz/ANqbJWGSlJwOSM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751414538; a=rsa-sha256; cv=none; b=KA+lTS6lcMz443h5oHR30xaje3/mcoIVlJSbOQjFFEM3YWPg2ftZWsC6rhATQmmfmivUer jcUe0iru2AT4z4GzIE3EPn5aWyHfwijm518f5hBadUpTV6igMvPA5bApmUvtWfGUi25uyV 46NIWcmYZ7EyF0UlOHxLp6JNWnQ3hRg= X-AuditID: a67dfc5b-681ff7000002311f-a9-68647702b276 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim , stable@vger.kernel.org Subject: [PATCH v3 4/4] mm/damon: fix divide by zero in damon_get_intervals_score() Date: Wed, 2 Jul 2025 09:02:04 +0900 Message-ID: <20250702000205.1921-5-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250702000205.1921-1-honggyu.kim@sk.com> References: <20250702000205.1921-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMLMWRmVeSWpSXmKPExsXC9ZZnoS5TeUqGwdUGKYs569ewWTz5/5vV 4t6a/6wWh7++YbJYsPERowOrx6ZVnWwemz5NYvc4MeM3i8eLzTMZPT5vkgtgjeKySUnNySxL LdK3S+DKuNqbWbCJs+LOg4nsDYx32LsYOTkkBEwkJk//ytbFyAFmfzvECxJmE1CTuPJyEhNI WETASmLajtguRi4OZoE5jBLf3u1iBqkRFgiWWPvsNyOIzSKgKnFt/Rp2kHpeATOJXbOiIaZr Sjze/hNsE6eAucTH5tVsILYQUMm8w+/A4rwCghInZz5hAbGZBeQlmrfOZgbZJSEwh01i0upN bBCDJCUOrrjBMoGRfxaSnllIehYwMq1iFMrMK8tNzMwx0cuozMus0EvOz93ECAzKZbV/oncw froQfIhRgINRiYf3xJXkDCHWxLLiytxDjBIczEoivHyyQCHelMTKqtSi/Pii0pzU4kOM0hws SuK8Rt/KU4QE0hNLUrNTUwtSi2CyTBycUg2MYV1lsbwqMj38P21fRXk8Fs6KsBbeel5KsKVh Podg/xfe6q1rf87/qnl5i9ABd7Eq3Y5vaeWH77huy+aasf9XxIqX+3n3mme1+c/8kX4k594e rSRm07wTDeLd3H6ya7fY3bmvlXhAevX9TemqqQcnhbAfeXDqMt8tZQbXPf0f9p4v8XXLTWNQ YinOSDTUYi4qTgQAoII9iEYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsXCNUNLT5epPCXD4PhrIYs569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YLBZsfMTowO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfG1d7Mgk2cFXceTGRvYLzD3sXIwSEhYCLx7RBv FyMnB5uAmsSVl5OYQMIiAlYS03bEdjFycTALzGGU+PZuFzNIjbBAsMTaZ78ZQWwWAVWJa+vX gI3hFTCT2DUrGiQsIaAp8Xj7T3YQm1PAXOJj82o2EFsIqGTe4XdgcV4BQYmTM5+wgNjMAvIS zVtnM09g5JmFJDULSWoBI9MqRpHMvLLcxMwcU73i7IzKvMwKveT83E2MwKBbVvtn4g7GL5fd DzEKcDAq8fAeOJucIcSaWFZcmXuIUYKDWUmEl08WKMSbklhZlVqUH19UmpNafIhRmoNFSZzX Kzw1QUggPbEkNTs1tSC1CCbLxMEp1cB490jdxO0rXd4UrclKrvyx6KiQ7ZbTiasStDnflTJv q51wvCR0/gwBVYHP/4rkd/S9l9/QcEDhNi+Ts5LnmTbe6SI/gtiZ1JMLH+251btjz5qQbdec 2Y2an12btP55TU2n+i2LB7z7ZglxXmcydq3suTHjtO9n6ywZ5Zb6RZMWXykyu3h3qjerEktx RqKhFnNRcSIAUn7B+TYCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A530312000D X-Stat-Signature: 54nywtzmmyghc5yuty5rrd995h37phs9 X-HE-Tag: 1751414537-307842 X-HE-Meta: U2FsdGVkX182XnbKT4QPj++mih51cJDnaqcPqOmxFnV8JUiOVFvO7rm3dQ/SFKI/53fpVXtLCGvVZi1XOUSILcfjVnBW+kJcfNo0W9YHk7qukYRzlSLr/04sAgdVYBa0tKUA0siiZiqFV5zdzfu3Bsq8Gq9IkXL8ltNVOEIDlHoqRVZA8SFJ/6Q7ucA0t2XrYmDX5OumJt86LW9sQRkL9Ay/RoXXq+QNQu7x5vqt9hBB7g92VVSwItWuFEBlQwhYZBdaQ7eoFikzA2Uut8+6PH2CYTCKC6m/pZiI7yR+LclHlF8Acf32XPXxcUimbjM9s+hlV9mL4PaRKd5JYuOzd8GEQQ9vNaYpIzRA9HIQ21eFoOfUO4LvBS6EfmJYW/L2jSdSyKeuETuNQWqxEk8XKQq6bWRD2H+/KK/AwM2IElmmkbfYaWBeMAuJG1a4zQtJ+231dNMtCATOxWB6/+HhSGKfkne36AHDQbRVTcKip0t5CQFiUEfiHfIGJuHnbjVkgy2rbLVTvRS4b+uyvE6adC/Wp5rELoUwOxo6DsJ8IM5hogOmrUFVPdqlGdcqizcv/zyvX6b9sEpOcYfIo65aCWcxqbl+clh8rF+SKtymTwGj0qlEmkV/xq7sEiM4yfOPmidf/Y0VXS0azOf94+h8CjXxG26XVvLipd+iqroe35tmEM1s1Lc3WR868xiuPx8NdM7IbTjsWNXsAOqTvW22zz1KpiZecApIIyoEoW4FuE6Bit3sYFLMFKGWVPAld7yCoEUdlb8f/YWfU1xmTAn2QQjvtMBA+3m7D3Xwr9fqdbCvgF/HJTmLVKg/EPYVGFwBi4oxtF8mI6kgCCDHD5i/I/AzWStXJBme2rwb5w+Qg0OAupUpReXldwZhqDFVfS2Uqv5yeTYEKo26N6mVOi7PwOorvaZwdxJSI8EsEcnRykZ3uDjBfFtxIoCbbjh/pE4shuLmSkn2hb0NHjvSkuE XQe+Hdiq OLHIMTmL4t++Vz8X1mgY7+nRQja0PTnNog5eauNoBBIaVb7ujdRTWjcjza9vrz1rtm23gQ5TEDMj5Kv4I1jqP1XskVZQbhldxzHWQRXBcBbB1rO4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The current implementation allows having zero size regions with no special reasons, but damon_get_intervals_score() gets crashed by divide by zero when the region size is zero. [ 29.403950] Oops: divide error: 0000 [#1] SMP NOPTI This patch fixes the bug, but does not disallow zero size regions to keep the backward compatibility since disallowing zero size regions might be a breaking change for some users. In addition, the same crash can happen when intervals_goal.access_bp is zero so this should be fixed in stable trees as well. Fixes: f04b0fedbe71 ("mm/damon/core: implement intervals auto-tuning") Signed-off-by: Honggyu Kim Cc: stable@vger.kernel.org --- mm/damon/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/damon/core.c b/mm/damon/core.c index b217e0120e09..2a6b8d1c2c9e 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1449,6 +1449,7 @@ static unsigned long damon_get_intervals_score(struct damon_ctx *c) } } target_access_events = max_access_events * goal_bp / 10000; + target_access_events = target_access_events ? : 1; return access_events * 10000 / target_access_events; } -- 2.34.1