From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD58C7EE30 for ; Wed, 2 Jul 2025 00:02:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2CF88E0006; Tue, 1 Jul 2025 20:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDC048E0001; Tue, 1 Jul 2025 20:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCA448E0006; Tue, 1 Jul 2025 20:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C618F8E0001 for ; Tue, 1 Jul 2025 20:02:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9929F1606B0 for ; Wed, 2 Jul 2025 00:02:18 +0000 (UTC) X-FDA: 83617372356.24.A524F2D Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id A3B7310000C for ; Wed, 2 Jul 2025 00:02:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751414537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JcHU3lcJb0adAv7P0AKNCptLSEj4bV+QB8MgKk4GsXE=; b=v4ZZkgLWmRtbD28N4NjadFsWEmyKIeG+jpzktve2jK4TEidIIOsLAqj8GUtlhYv6TOQZN5 FUWqTEm+aArWPF2Y1RJ6K/C4xyaZvp7Lm2a9/Imuz2BCe0R6CwiItJs8QJkIRlIQ/x9kuE aQm9DV3vjTdV2sX2YbGcO0nLoOIZvQ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751414537; a=rsa-sha256; cv=none; b=74tAlJU5IMZTP0AGpoC+cSE63YQOpX3keRyBCK8Dxm1aADPIowklhO5LmLGT9JvvkjVlY1 edjtx+lzIKTx3T8SEJSL4NaZq4s0Od+kp1FlfEDwxVIfGG7oL4ByR2pSyRQVizg9v60RAN 1XHzpC8CtP26rKefnr1QSUZ/KvjG5ck= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com X-AuditID: a67dfc5b-681ff7000002311f-a6-686477017b1c From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim , stable@vger.kernel.org Subject: [PATCH v3 3/4] samples/damon: fix damon sample mtier for start failure Date: Wed, 2 Jul 2025 09:02:03 +0900 Message-ID: <20250702000205.1921-4-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250702000205.1921-1-honggyu.kim@sk.com> References: <20250702000205.1921-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrELMWRmVeSWpSXmKPExsXC9ZZnoS5TeUqGwUUHiznr17BZPPn/m9Xi 3pr/rBaHv75hsliw8RGjA6vHplWdbB6bPk1i9zgx4zeLx4vNMxk9Pm+SC2CN4rJJSc3JLEst 0rdL4MrYsr+qYAVHxa9HrxgbGF+wdTFyckgImEjM2j4Jzt7V94ERxGYTUJO48nISUxcjB4eI gJXEtB2xXYxcHMwCcxglvr3bxQwSFxbwlzi3KQKknEVAVWLytu1sIGFeATOJ/uvBEBM1JR5v /8kOYnMKmEt8bF4NtkkIqGTe4XdgcV4BQYmTM5+wgNjMAvISzVtnM4OskhCYwybx//sCJohB khIHV9xgmcDIPwtJzywkPQsYmVYxCmXmleUmZuaY6GVU5mVW6CXn525iBIbksto/0TsYP10I PsQowMGoxMN74kpyhhBrYllxZe4hRgkOZiURXj5ZoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFe o2/lKUIC6YklqdmpqQWpRTBZJg5OqQbGfral+yZsvT03TZYnmunao+xLMec7vnB3KVy20M1U O2+Rzh4TEWmneWIpP98NUfdbLZFSFwx7j613u8rlF6pp+eQ3++eEk87Vq4239N32CIrUa3ph tVv3WTZDvH1umdXuujvbplQzsl8ulKpZe9zb8WbZG6metU+ZFr/fsDNh4nNj4zQd1n1KLMUZ iYZazEXFiQBjxiXLRQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsXCNUNLT5exPCXDYNkmY4s569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YLBZsfMTowO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfGlv1VBSs4Kn49esXYwPiCrYuRk0NCwERiV98H RhCbTUBN4srLSUxdjBwcIgJWEtN2xHYxcnEwC8xhlPj2bhczSFxYwF/i3KYIkHIWAVWJydu2 s4GEeQXMJPqvB0NM1JR4vP0nO4jNKWAu8bF5NdgmIaCSeYffgcV5BQQlTs58wgJiMwvISzRv nc08gZFnFpLULCSpBYxMqxhFMvPKchMzc0z1irMzKvMyK/SS83M3MQKDblntn4k7GL9cdj/E KMDBqMTDe+BscoYQa2JZcWXuIUYJDmYlEV4+WaAQb0piZVVqUX58UWlOavEhRmkOFiVxXq/w 1AQhgfTEktTs1NSC1CKYLBMHp1QDo/7lg+xvnmy68u5RTJBqYU5SUJ3+Mf+pGx96uevean/t 8ONnUmKfoCfztf38T1c/cPwT9O/0pzkL/1/479E06wlHssIO4wUSq9Q27OloC9quKPCuxSh3 V/bUtXumXjZZJvB1l8Lueh3X08vbeD89bftZ97BQcuPZC92HzstuX/DY6qW246+luxcqsRRn JBpqMRcVJwIAe7oD9jYCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A3B7310000C X-Stat-Signature: drn4sea66h5hmadrjwpztmtwwzam91ce X-HE-Tag: 1751414536-266804 X-HE-Meta: U2FsdGVkX19C1TnsY1wDhHHZzrM1LhlW1ORcsYy/KPgnTpuC5a5xPdpbds9zoDR3uLpf+tSnvvwrOpnQQewzre/JT9yG3F4WA10Nh7Pg27SAUF8kEO/KWNXuldPVcFRXiQsVWw6BVt9TCviiFmqy8Uq1uw65KzBLPgZHW+vK8UDxcbxVSsXW0mjyKxqau9JQk8YimEfqHCmpKgmozGLpmBAlAumJZaGhEqR1gtsaqYGPgvU6OW756N3R/jgT9UUNzbaEoffJBftkcJ3DxJgCITZGvco4dOxuvlsO2gK8ebWAkkn1/MPU9hm6BFnPWCnGN66DCRQo5UCaQW6G0GwY79xiQ6gPFADMemxPCz2tTNIOKGmqxeC8KOlr2O+v5wkNu23JB0oVJLzYTJID2CdJVmfRnM8PStVR47jRNa0sxd1NI1FwWr2Kv4jtb50ooQRzTkTIuljExMB+ncvq6MDYll6BsWAbXf4MQGT93g3HLRz30Y4DaDZUOZv4g4Z/62ymgamebA0MXHou+7AM7IpE0I/kFdSaxef43oKKskA4ZSP4HjjjgdPZLWEELjg79N5fh83vtzgIJjARwqNCicY9UvU99pJ6a/7aAEkiLmH9S09jyZTBu8u1qirJcljB1lRSRfjOLoaX5GMAMuiXTC23KotvHlMITrMyoWhUTTZXjyzrzSWPTOAlpSRLZyXpJlNpBOMufHPZ2RefG9hM19F0aaIUBowWdCt6fdOF4xjGZjJtD8ilLD1LD6UWWfAneDm3FeKVGtcETpVsylSv/ZduCsf5eWqnJDt8aXJYBt/xzBZlke3a3fIlbAMEh2wEMncHAO/Hblt3V7Xx0WrsJB8+2U6Ya7ePYiPvb8cRbfvUBqcoR+OrGfF0RtCulzAC5Ye945/xFzjImY9WKX6uhMXUfYhG2TufjTwRN+HP2DQ6hkETrU0E+drfTX4IuzkjGJXugZHNIhORH9VzFC999af cQsVRO38 tjDW96e19zR80bjwzLuZYPmkGCqAN8fYqrMJtwWknFH7Lnh+3yCXqwu/g/yKcYBXd+Wqm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_mtier_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the similar crash with mtier because damon sample start failed but the "enable" stays as Y. Fixes: 82a08bde3cf7 ("samples/damon: implement a DAMON module for memory tiering") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park Cc: stable@vger.kernel.org --- samples/damon/mtier.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index 36d2cd933f5a..c94254b77fc9 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -164,8 +164,12 @@ static int damon_sample_mtier_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_mtier_start(); + if (enable) { + err = damon_sample_mtier_start(); + if (err) + enable = false; + return err; + } damon_sample_mtier_stop(); return 0; } -- 2.34.1