From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DB9C83038 for ; Wed, 2 Jul 2025 00:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 036CD8E0005; Tue, 1 Jul 2025 20:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00F2A8E0001; Tue, 1 Jul 2025 20:02:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E408A8E0005; Tue, 1 Jul 2025 20:02:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C5E2C8E0001 for ; Tue, 1 Jul 2025 20:02:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 546D4C0628 for ; Wed, 2 Jul 2025 00:02:17 +0000 (UTC) X-FDA: 83617372314.22.8E3A8E0 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf29.hostedemail.com (Postfix) with ESMTP id 58B1512000E for ; Wed, 2 Jul 2025 00:02:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; spf=pass (imf29.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751414535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dt8Qx7G4V9VP7x7GwNZE4pz2KGFsDo0WyeBIokJUryM=; b=eYzNlGhLEETjpUaIhfxNYzS3cdQ9gvuxH5TDvQP/S7IkRqiCOMtTS66yFk2NPllRRFykB4 2wQgACce7LrqSQyvsd8xPM2MGzMJTBWL+uPhh6bkla9DeSeiKy6W2NT398Uj8LuZ1DWuSW qMSuCSSe2hwho472EadVgb/lduSCN7Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751414535; a=rsa-sha256; cv=none; b=NiIiRyWrIjtsAwMtoL+/JypvZauAs3qs19IgX+28Tm/qUvLN034C6xwufMlTseTxJ5M/9m KzlQGFy+IXT2gB8doFQBu63t3VM5yFkGFVNmOmDWcxWk2m4bVHWQWIE4qg1eUioPt1HRWT owMpvQ22Y/efd404KAZnmOiOa3gb3tE= X-AuditID: a67dfc5b-681ff7000002311f-a3-686477016087 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim , stable@vger.kernel.org Subject: [PATCH v3 2/4] samples/damon: fix damon sample wsse for start failure Date: Wed, 2 Jul 2025 09:02:02 +0900 Message-ID: <20250702000205.1921-3-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250702000205.1921-1-honggyu.kim@sk.com> References: <20250702000205.1921-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMLMWRmVeSWpSXmKPExsXC9ZZnoS5jeUqGwYYf0hZz1q9hs3jy/zer xb01/1ktDn99w2SxYOMjRgdWj02rOtk8Nn2axO5xYsZvFo8Xm2cyenzeJBfAGsVlk5Kak1mW WqRvl8CVMe18VsECjorte+4yNjDeZ+ti5OCQEDCReDM5r4uRE8ycv3UBC4jNJqAmceXlJCaQ EhEBK4lpO2K7GLk4mAXmMEp8e7eLGSQuLOAnMfdeOEg5i4CqxLZlnWwgNq+AmcT9PdPYIEZq Sjze/pMdxOYUMJf42LwaLC4EVDPv8Dt2iHpBiZMzn4CtZRaQl2jeOpsZZJeEwAw2iT1zWqAG SUocXHGDZQIj/ywkPbOQ9CxgZFrFKJSZV5abmJljopdRmZdZoZecn7uJERiUy2r/RO9g/HQh +BCjAAejEg/viSvJGUKsiWXFlbmHGCU4mJVEePlkgUK8KYmVValF+fFFpTmpxYcYpTlYlMR5 jb6VpwgJpCeWpGanphakFsFkmTg4pRoYHff8SM6cfieSb7WoasgULvfdT18J7PgWJmDtNyfg xrwJPxmYrhV0/fpVavzlscjz16Vzbvw+vTtpUfCRipUnYjqf9U49+eW79Ax9nfJ/lx69sPea 0pd6fk6TRNPvW0ZhghNev54nkrqePfxQnlSwx6Ff0/XForbkOMsq+yl0VZrxftz480nucSWW 4oxEQy3mouJEAF0t+BFGAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCLMWRmVeSWpSXmKPExsXCNUNLT5exPCXDYMVXUYs569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YLBZsfMTowO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfGtPNZBQs4KrbvucvYwHifrYuRk0NCwERi/tYF LCA2m4CaxJWXk5i6GDk4RASsJKbtiO1i5OJgFpjDKPHt3S5mkLiwgJ/E3HvhIOUsAqoS25Z1 go3hFTCTuL9nGtRITYnH23+yg9icAuYSH5tXg8WFgGrmHX7HDlEvKHFy5hOwtcwC8hLNW2cz T2DkmYUkNQtJagEj0ypGkcy8stzEzBxTveLsjMq8zAq95PzcTYzAsFtW+2fiDsYvl90PMQpw MCrx8B44m5whxJpYVlyZe4hRgoNZSYSXTxYoxJuSWFmVWpQfX1Sak1p8iFGag0VJnNcrPDVB SCA9sSQ1OzW1ILUIJsvEwSnVwJjJZ2L7vbjhsvL8Rz/mOQf90pD0WSfvvlBO/tgKcYvHh3q8 prg83RD1f7f0Iq7H76+4/52YVtudtChB12J9Ja/h5otaHDttpcrFHtTtuCmhVFa/L/q+elzq PAeOtcLr+Lcv2f123vW1NY763m37jmh06Dhavk6+vMtIg+9EvMT9jDW2kxl3ciuxFGckGmox FxUnAgAGfouzNwIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 58B1512000E X-Stat-Signature: 85uu1k5h4zsf5kw8x148dz7myxw6pqne X-HE-Tag: 1751414535-130449 X-HE-Meta: U2FsdGVkX1+Vteo6h/A0DAGjE1KkvK0itc4zULRBHdJcazWM9sd0k1dwGyO6T1A66mjCU4iP5a+KvH8ZNkgJqL37u4X9Hmpof0dp7DGdx0JzMMELgi4+nZy5QWBEFAVpmgBOWifCC+y9wEL0xTnqGuEUetcivmLSWreyD6LfHRCrsA6K63ukx+Sn+byYL9gb+UMBPLSLz8CwK7UwBtLz8FTqxzJVDbyxvRBZUDjyLZuNpTj+ijvSJDFWLqMEIV0+nRJLMjilAVLCMn62lTaHaoOop0uLZZ/Eg5zE0gBje495+4c/ysN490XlI/C4Zg2qTO0U9yymjNNw4v/iOol51A8E4xSGGt5yObOnYmPHSnd1rBVPQ2eLamWqNVPxjB/sHoMo8KWPUMvalimo/MrrxcWwnaIY1sjfVthNzypBUIiIF7Hj71tSVB4wvZF/50EUPD2kHbLce7KXwrVHKc1CamX0ARX44C909HU9VN9Stue5rVI9Sm+0Vyl8/W5Ai0BnNp1pOOQ9jlUTOhgklRm7m1s9JMexGZjB2kCTawYmqztRJ/O55aoh+kQqAPI/JK+5jE3KzyuN06BZuWk7DFnDIokyt6x47QUD635JASk4QCSmOm/OQvwQ/fUOjOTYR+PrBs1Iktl+aDZ0J7u647Z/88WjuSc6bqIdWFSpJUmJEYu3lNeS+aOEjtjCPE8+z6u/4eifHBpn5EB/RLDRY+h9g5DIys0uYnoY6RK8efr2vb5gpLMpAIrrJ4PFK8feVdPyumgRT9IET/dGUaHoDnoSD445119RYWm3ahntjeB9sLwAvlVX/wiAZiNiuGhfDQ0lSVIEbPUlSvc8VQlRo6SFWmS83uzldmrAoqFcY0FtnrzYHBXekMOaaFe4s/AcodSdVpkzoWEUyLFG5aXxZaObpQpZrF8OXZcKctUjmosiZ4GbBU7lxxVRYHob8di+dPQv7DTterT4gpCGPuqIJyU 8bNS+pYg 7BVqq3u7iREts5H/wsyg53I34m28SKA9zQDogeQzTCetGQRaM9zjxVZNKm5ewhFl5q1Ix X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_wsse_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the similar crash with wsse because damon sample start failed but the "enable" stays as Y. Fixes: b757c6cfc696 ("samples/damon/wsse: start and stop DAMON as the user requests") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park Cc: stable@vger.kernel.org --- samples/damon/wsse.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index 11be25803274..e20238a249e7 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -102,8 +102,12 @@ static int damon_sample_wsse_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_wsse_start(); + if (enable) { + err = damon_sample_wsse_start(); + if (err) + enable = false; + return err; + } damon_sample_wsse_stop(); return 0; } -- 2.34.1