From: Honggyu Kim <honggyu.kim@sk.com>
To: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel_team@skhynix.com,
Honggyu Kim <honggyu.kim@sk.com>,
stable@vger.kernel.org
Subject: [PATCH v3 2/4] samples/damon: fix damon sample wsse for start failure
Date: Wed, 2 Jul 2025 09:02:02 +0900 [thread overview]
Message-ID: <20250702000205.1921-3-honggyu.kim@sk.com> (raw)
In-Reply-To: <20250702000205.1921-1-honggyu.kim@sk.com>
The damon_sample_wsse_start() can fail so we must reset the "enable"
parameter to "false" again for proper rollback.
In such cases, setting Y to "enable" then N triggers the similar crash
with wsse because damon sample start failed but the "enable" stays as Y.
Fixes: b757c6cfc696 ("samples/damon/wsse: start and stop DAMON as the user requests")
Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: stable@vger.kernel.org
---
samples/damon/wsse.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c
index 11be25803274..e20238a249e7 100644
--- a/samples/damon/wsse.c
+++ b/samples/damon/wsse.c
@@ -102,8 +102,12 @@ static int damon_sample_wsse_enable_store(
if (enable == enabled)
return 0;
- if (enable)
- return damon_sample_wsse_start();
+ if (enable) {
+ err = damon_sample_wsse_start();
+ if (err)
+ enable = false;
+ return err;
+ }
damon_sample_wsse_stop();
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2025-07-02 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 0:02 [PATCH v3 0/4] mm/damon: fix divide by zero and its samples Honggyu Kim
2025-07-02 0:02 ` [PATCH v3 1/4] samples/damon: fix damon sample prcl for start failure Honggyu Kim
2025-07-02 0:02 ` Honggyu Kim [this message]
2025-07-02 0:02 ` [PATCH v3 3/4] samples/damon: fix damon sample mtier " Honggyu Kim
2025-07-02 0:02 ` [PATCH v3 4/4] mm/damon: fix divide by zero in damon_get_intervals_score() Honggyu Kim
2025-07-02 0:19 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702000205.1921-3-honggyu.kim@sk.com \
--to=honggyu.kim@sk.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel_team@skhynix.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox