From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B4AC7EE30 for ; Wed, 2 Jul 2025 00:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B1378E0003; Tue, 1 Jul 2025 20:02:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 761B98E0001; Tue, 1 Jul 2025 20:02:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 602EA8E0003; Tue, 1 Jul 2025 20:02:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4E1D18E0001 for ; Tue, 1 Jul 2025 20:02:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1BD301245FD for ; Wed, 2 Jul 2025 00:02:16 +0000 (UTC) X-FDA: 83617372272.26.66822C6 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id 1DA0810000A for ; Wed, 2 Jul 2025 00:02:13 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751414534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjv6LLuxQ0x/12iLQhb5dtf52IRYEOEmLFoa9ajq33E=; b=ICU4Jn+oPHrBze/aJzAJMleJO8NREbhFMBWIMiwGMVNf48SvgxM7mHxWISUEW2avuc6+fv HBY6hMJSYFwVjDBm4TWXawDGwgQUmoMpGnDd7ZceFlo76qXWJ5Lr+//4OPN//tIPK32zTT 727T/kelW0Ww4oWR2riGs79ZJFZfOfU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751414534; a=rsa-sha256; cv=none; b=70dP7fSuO/YZu38b6eW1He6Q+YevCfbYIP4ERTjM1px+YU8e3eNq2HnWieu8xUoJWDOMnF RCrRkaqxRXLODw/9BticmYQf/cV7+H0ecU5qpEnI8RuXMg4oaT8Bl0xOzFTzbqv5gfAiJa n7e5Tgmm9IrJWyTpSdWLwvGYgvFUu0U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com X-AuditID: a67dfc5b-681ff7000002311f-a0-686477002f7a From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim , stable@vger.kernel.org Subject: [PATCH v3 1/4] samples/damon: fix damon sample prcl for start failure Date: Wed, 2 Jul 2025 09:02:01 +0900 Message-ID: <20250702000205.1921-2-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250702000205.1921-1-honggyu.kim@sk.com> References: <20250702000205.1921-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsXC9ZZnoS5jeUqGwTELiznr17BZPPn/m9Xi 3pr/rBaHv75hsliw8RGjA6vHplWdbB6bPk1i9zgx4zeLx4vNMxk9Pm+SC2CN4rJJSc3JLEst 0rdL4MqY1zSDvWCPQMXv3vWsDYxnebsYOTkkBEwk1m8+xwpjr+lezgxiswmoSVx5OYmpi5GD Q0TASmLajtguRi4OZoE5jBLf3u0CqxEW8JNon9sAZrMIqEpsmtPCBGLzCphJXNnexwIxU1Pi 8faf7CA2p4C5xMfm1WwgthBQzbzD79gh6gUlTs58AlbPLCAv0bx1NjPIMgmBGWwS7e0fGCEG SUocXHGDZQIj/ywkPbOQ9CxgZFrFKJSZV5abmJljopdRmZdZoZecn7uJERiYy2r/RO9g/HQh +BCjAAejEg/viSvJGUKsiWXFlbmHGCU4mJVEePlkgUK8KYmVValF+fFFpTmpxYcYpTlYlMR5 jb6VpwgJpCeWpGanphakFsFkmTg4pRoYna9XR+zdf3Nd0exffUzOnYWPL93TLdvs8mCq6EMB 9wNKxy6cruGQfHmj5JxlkNmhy5PMyxa/2PP5RphOD+eSrzsnt5zw+Nh2c829fW8nvNIRcRO8 Off5/t7KzzdfcbPvb2g5b7g75MSShZU7pe57B5uwvLioUpNfHyosuvlAzemy9NdTI1b62Cmx FGckGmoxFxUnAgA++TfTSAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsXCNUNLT5ehPCXD4NUsU4s569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YLBZsfMTowO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfGvKYZ7AV7BCp+965nbWA8y9vFyMkhIWAisaZ7 OTOIzSagJnHl5SSmLkYODhEBK4lpO2K7GLk4mAXmMEp8e7cLrEZYwE+ifW4DmM0ioCqxaU4L E4jNK2AmcWV7HwvETE2Jx9t/soPYnALmEh+bV7OB2EJANfMOv2OHqBeUODnzCVg9s4C8RPPW 2cwTGHlmIUnNQpJawMi0ilEkM68sNzEzx1SvODujMi+zQi85P3cTIzD0ltX+mbiD8ctl90OM AhyMSjy8B84mZwixJpYVV+YeYpTgYFYS4eWTBQrxpiRWVqUW5ccXleakFh9ilOZgURLn9QpP TRASSE8sSc1OTS1ILYLJMnFwSjUwnk/ck/tOKv7ZFFUPv+AU1ZirC6T/vG5QvWcly2nMz7OG 1fDa+eKFG3dFvHZ+q/35s+BPqd2du1fnuM5bHhlQe3OOLlv/9XzVFSfrpnpu5hD7/t3xtWLL zsTD8196syqz9vUaaHRfKeDwidOS+JR9t/mFyx/N5S1Sq61rJWdN7pRiUM1W3LZKiaU4I9FQ i7moOBEAgwaSxTkCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1DA0810000A X-Stat-Signature: omd9okctgbicte7szk3j15o84b9rzpdd X-HE-Tag: 1751414533-809050 X-HE-Meta: U2FsdGVkX1/zaXfe6HntxnGBU8rjyaE4eSEhaUYMR87OoUc+rpzkQbxmXeL2zzI6dSJ4rmZb5vWjXQN2oOM6HTBzqGyrbRECiUVVp94v6Csttrc3P9K471MPzs4APzvQSk8CaqmAKUCcfn8ux6IAqFaZPZsboWb2MJvbxWL7+78SmP9pc0ZawBc1AYXemBkQwziJnverLJEBvyQafUWd9/FmgFbeIcRg3E7558HWYm3dskegkvur81ygCIrMd0RIMRJkMjbNmvXq7Vj4ndSvcWTFTl4a8JuEMozvXTnAhrTrgwG0O9VmG9yE4/y6EvrCmiqhAiON+J67+EpWBfFukSSbPBsmwH3FgvJyitwuHW79ZJQf71pBDf1Pr7vLqc3yg9L3hkT/IZKExdPEpBCVEk7SIFdAYDimfm9/er3bhVAliUv/O3bscI90Jl4j8UcucIpcDTOvnOFlJimi2VmhiI65gvpZa2JNKQRPDHEtu6ZUdWPSs3Jre3TBVF0M5BbgqrUILMYSKpbXgx6eU/29CdC7ng06+MZ5dPUZs4keC74KHvgciJpCUkhOH/wKc2WQFxg2ElJAerZOGALOAP6pXNdHZzaTxrFyG7eJAe8sCvYH0ZDX2phTbYcA5MZhRK9IF+Rox2x6iDsLHikL4L4mnFFSbPhpjPkz5iapTFR6SXebkPqrCN65I4s6qBu+6bAGMmpdVeSnEzmdkMHTiLjTu51WSauLjQM5qHhWcEiTb6dCWqjluyG7m+ko0jSfY2eEoWLNtoYhVBDTUg+HWWATed9EW4Z1iA6rG/boijgR7r7bXGgsZQW6FbgkkeXE7USM3URh6PmYqsVXNgkr9AFdBPoX6E4kOjk7nW4zxHoFpiLwzQ9ckz/YKbyagPZYpUuJ5EiONbAgj+iJAlTocEpB381qRkL0B5xdfBrMXf1X3uyqo4+geiwgi9QHNWZZAZsIkB9yGmm1oBxaAfbChxB 2D0Qy39s uITI5cRJggDo5cSbbb1hTEZEPYSrEtfWfIVUnzS41c8FPYfFkzsfchzq9rI5Z2kUCcJ90 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_prcl_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the following crash because damon sample start failed but the "enable" stays as Y. [ 2441.419649] damon_sample_prcl: start [ 2454.146817] damon_sample_prcl: stop [ 2454.146862] ------------[ cut here ]------------ [ 2454.146865] kernel BUG at mm/slub.c:546! [ 2454.148183] Oops: invalid opcode: 0000 [#1] SMP NOPTI ... [ 2454.167555] Call Trace: [ 2454.167822] [ 2454.168061] damon_destroy_ctx+0x78/0x140 [ 2454.168454] damon_sample_prcl_enable_store+0x8d/0xd0 [ 2454.168932] param_attr_store+0xa1/0x120 [ 2454.169315] module_attr_store+0x20/0x50 [ 2454.169695] sysfs_kf_write+0x72/0x90 [ 2454.170065] kernfs_fop_write_iter+0x150/0x1e0 [ 2454.170491] vfs_write+0x315/0x440 [ 2454.170833] ksys_write+0x69/0xf0 [ 2454.171162] __x64_sys_write+0x19/0x30 [ 2454.171525] x64_sys_call+0x18b2/0x2700 [ 2454.171900] do_syscall_64+0x7f/0x680 [ 2454.172258] ? exit_to_user_mode_loop+0xf6/0x180 [ 2454.172694] ? clear_bhb_loop+0x30/0x80 [ 2454.173067] ? clear_bhb_loop+0x30/0x80 [ 2454.173439] entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: 2aca254620a8 ("samples/damon: introduce a skeleton of a smaple DAMON module for proactive reclamation") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park Cc: stable@vger.kernel.org --- samples/damon/prcl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index 056b1b21a0fe..5597e6a08ab2 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -122,8 +122,12 @@ static int damon_sample_prcl_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_prcl_start(); + if (enable) { + err = damon_sample_prcl_start(); + if (err) + enable = false; + return err; + } damon_sample_prcl_stop(); return 0; } -- 2.34.1