From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846B1C7EE30 for ; Tue, 1 Jul 2025 23:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FC736B00C9; Tue, 1 Jul 2025 19:54:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AD1A6B00CA; Tue, 1 Jul 2025 19:54:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C756B00CB; Tue, 1 Jul 2025 19:54:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E833C6B00C9 for ; Tue, 1 Jul 2025 19:54:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 665881606AE for ; Tue, 1 Jul 2025 23:54:13 +0000 (UTC) X-FDA: 83617351986.02.12EDA38 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf16.hostedemail.com (Postfix) with ESMTP id C595818000A for ; Tue, 1 Jul 2025 23:54:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AMeXLc9C; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751414052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y6y8Sx36pRP++Lx9gqEYZJiXnVxnoqXpFUn4UCJp7BA=; b=FRHQBxDupAjADjJzsi3o9ouYiK1I2gPwTMDC8axXBycKtE8h4neZftGlkHLfwRAIf4OOhG 8Yxj05dQDTVQVnoGrrCzU04l+5O/fUjgenlTw3NQow6cXIDYKWZ8qVZiQ3LcLJa6BS+m/m MO+G0u9c7b25vCCKA1MNeoYi5LryWiU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AMeXLc9C; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751414052; a=rsa-sha256; cv=none; b=oGrgc/hcA72CvOyxO2mkE0XzAlGPtu4ap8v8MWWCeFYJ/C0sWw8i0fMJD8S3UQVTPxN1to 7xxBz8mW6H3j43tQH6OfF2edDWyvs3H5+7c+FyX2xJtxx4iakAjQD3doKtlJi2HbWcdVb5 YNMpBZhIWqaILxvrAQqcaz09D4gbD4I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9A58945741; Tue, 1 Jul 2025 23:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 559B6C4CEEB; Tue, 1 Jul 2025 23:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751414050; bh=mbFhslX3DVOk0S3Kn1dLLJTRL/+V1bf1gxONJ/aQqy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AMeXLc9CCOO8jp0Dy15eQaB5zHy3dytlFXsMVCQ9uwlEwJKJ9Q6NMuvC+mOgXLzA6 gRr964c4PlkIFgsfL+K3Bx2OQGKkqduaVSEEs1nui7PXJ57mAIHsBnQio4WP3UA5UW mKZ9950aMjT8UZKJ4HhB0oxQQxyoylLedYDkIwaOflDNnKvXE/GkAEm2OR6HnBnZxb Bq3qQ+o53sJ1cKQJBO6YDeOIZxc0VTvyYHTJvySLZAMvdb7aPmnMw5l2uS9VjOIdHq uI9mYKtU4N/f13lQoj1DF+530c1nAJBiNKL1HBtiRLBrlIY3E2DbFc7dAkA3TInfQK BAI6oMzRMwUIQ== From: SeongJae Park To: Yunjeong Mun Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, honggyu.kim@sk.com Subject: Re: [RFC PATCH 1/2] samples/damon: convert node id to physical address Date: Tue, 1 Jul 2025 16:54:07 -0700 Message-Id: <20250701235407.57420-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250701085417.1734-2-yunjeong.mun@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C595818000A X-Stat-Signature: b6umn6bf9zgdury65m1fqs88mmxc4uqj X-HE-Tag: 1751414051-486497 X-HE-Meta: U2FsdGVkX19n9Ae15li5HO6QHSQIhslwGm4wItqlZL8Cjjls5coGBiYLwLC25SjD3cCsYFKgNs8bDO9hINl34uQWzoGDoI9nbwqMWSUzOshMBBwqx55TdmJdUVq4VxxZHBDja0WduY12SHSiCtgzJyCbMVgVekp0r7vWGKXTH8/GDCvJa7qQNqql1lpdY0bUms7POxOAtTokYGJdwmsJ/HnCahJPygaqL1pLjESzq0URlbkpYL+Q1cAimipZWYUuoJxn6OwajuC5jTDRalxdZAtSEWUNh57zu2ddtxedQGRrQo3TJ/Qbg94GJzHAkUXFFO7IBf6sd0wD6dcUhYR80tctRkRUXb8ch7i6QB14dvPaZA0biRVm219FY2Wa0HaDvEBRUQrKWeMLQVmIrw7T1+7ataSdX15gGbNObGLLes6S4Jtb288J9wFG8A/xFxLDrsfYl3B+ALOUD82iFYORYJVgrDJzBdhauTw7hrnSnK47WrpWXmSP0cH7AKwJ6dueZawzH/FYDX+4bjkk4OgZA0CmVz2Z+95rrpjk+acKtK3JvpB2FDTMWiTYsOykUYBjY51mDECHT+5lAiSzScCiBMk+/5gfcw844MGs3ii8JPTO6lH/BwaOWoYHb2oUkK7aOKO1h+evMyNM4poKNA5H2BSiRNQo15VMqA3YtMGz8SCxw9S24keIAWWmFHcQuYEJ3JXqc+fBFH+LtJ/mZfw+FUFlm/eHQi0YjNgPGAG8QsoU009g7+jWdT5KhMV9vzYOrvXyajt01i+iFH9ZN76iaLtppDnY87SFfqyD/qOXZNok1jkzo/HXLDPHzC6IIToetLv56MM3veng9LnH77sYRbXdMJCdY9UUObeYaoagmqyYWCsblhUixfcZo6n27i/PLcM0Ndv5VdOXwrN0ubigToRk1R4S0fHRa0OhLoeJp0FCM5jpHPazmFpyzw3iAz9wGt0O6cQuFwBFv2YGbOA how== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yunjeong, On Tue, 1 Jul 2025 17:54:16 +0900 Yunjeong Mun wrote: > This patch removes the `node#_start_addr` and `node#_end_addr` knobs, > and introduces logic for converting numa node id to physical address. > It only checks whether a numa node is online and calculates the > start and end addresses of the node. It does not verify whether each > memory block within the numa node is `usable` or part of `System RAM`, > as performed by `damo` [1],[2]. This is just a sample module, but I'd like to avoid making unnecessary user-breaking changes. How about keeping the existing knobs but adding yet another knob for the automatic detection, say, 'detect_node_addresses'? > > [1] > https://github.com/damonitor/damo/blob/v2.8.5/src/damo_pa_layout.py#L72-L90 > [2] > https://github.com/damonitor/damo/blob/v2.8.5/src/damo_pa_layout.py#L92-L10 > > Suggested-by: Honggyu Kim > Signed-off-by: Yunjeong Mun > --- > samples/damon/mtier.c | 44 ++++++++++++++++++++++++++++--------------- > 1 file changed, 29 insertions(+), 15 deletions(-) > > diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c > index f3220d6e6739..ba6938a89c21 100644 > --- a/samples/damon/mtier.c > +++ b/samples/damon/mtier.c > @@ -12,18 +12,6 @@ > #include > #include > > -static unsigned long node0_start_addr __read_mostly; > -module_param(node0_start_addr, ulong, 0600); > - > -static unsigned long node0_end_addr __read_mostly; > -module_param(node0_end_addr, ulong, 0600); > - > -static unsigned long node1_start_addr __read_mostly; > -module_param(node1_start_addr, ulong, 0600); > - > -static unsigned long node1_end_addr __read_mostly; > -module_param(node1_end_addr, ulong, 0600); > - > static unsigned long node0_mem_used_bp __read_mostly = 9970; > module_param(node0_mem_used_bp, ulong, 0600); > > @@ -44,6 +32,28 @@ MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); > > static struct damon_ctx *ctxs[2]; > > +struct region_range { > + phys_addr_t start; > + phys_addr_t end; > +}; > + > +static int numa_info_init(int target_node, struct region_range *range) { > + checkpatch.pl complaints as below. ERROR: open brace '{' following function definitions go on the next line #82: FILE: samples/damon/mtier.c:40: +static int numa_info_init(int target_node, struct region_range *range) { > + if (!node_online(target_node)) { > + pr_err("NUMA node %d is not online\n", target_node); > + return -EINVAL; > + } > + > + /* TODO: Do we need to support more accurate region range? */ > + unsigned long start_pfn = node_start_pfn(target_node); > + unsigned long end_pfn = node_end_pfn(target_node); > + > + range->start = (phys_addr_t)start_pfn << PAGE_SHIFT; > + range->end = (phys_addr_t)end_pfn << PAGE_SHIFT; Let's use PHYS_PFN() instead. > + > + return 0; > +} > + > static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) > { > struct damon_ctx *ctx; > @@ -53,6 +63,7 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) > struct damos *scheme; > struct damos_quota_goal *quota_goal; > struct damos_filter *filter; > + struct region_range addr; > > ctx = damon_new_ctx(); > if (!ctx) > @@ -82,9 +93,12 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) > if (!target) > goto free_out; > damon_add_target(ctx, target); > - region = damon_new_region( > - promote ? node1_start_addr : node0_start_addr, > - promote ? node1_end_addr : node0_end_addr); > + > + int ret = promote ? numa_info_init(1, &addr) : numa_info_init(0, &addr); > + if (ret) > + goto free_out; Yet another checkpatch.pl complain. WARNING: Missing a blank line after declarations #119: FILE: samples/damon/mtier.c:98: + int ret = promote ? numa_info_init(1, &addr) : numa_info_init(0, &addr); + if (ret) > + > + region = damon_new_region(addr.start, addr.end); > if (!region) > goto free_out; > damon_add_region(region, target); > -- > 2.34.1 Thanks, SJ