From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E665FC7EE30 for ; Tue, 1 Jul 2025 21:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 364F86B00B4; Tue, 1 Jul 2025 17:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 315F56B00B7; Tue, 1 Jul 2025 17:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22B256B00B8; Tue, 1 Jul 2025 17:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 109216B00B4 for ; Tue, 1 Jul 2025 17:32:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9D2D31D72C2 for ; Tue, 1 Jul 2025 21:32:49 +0000 (UTC) X-FDA: 83616995658.29.F6440FE Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id CFEF8100002 for ; Tue, 1 Jul 2025 21:32:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CEIM4AnP; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751405568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=60WI/K78QXGy6JB9LE3cyKyvmEBT1lFhqPplymrPTck=; b=fI5dvTYN7A44kvjKdkuB9JbPCZvXNxRJzd9E4GiNv6s1j5BBXkGAedMoczlyLnlIvg/Mjj jUetlF0XIBAPYEbO/30ZCblOgT7y76Vhua8d0NWqzNmrGeM+2UBKqIsKROCAwFgziXAS03 MjlQvXPi2PhKssmEPbvCJtMHJbcpfio= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CEIM4AnP; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751405568; a=rsa-sha256; cv=none; b=yMFt8hdQ0N4Q0TDGxVgm5ljvlQkczRSMj6NkgxlzAiHeIoHewCde2EhKwjOjy7EeRhOZ5v 8toCvvvsSUdI3loQ98352LFGAg0/3fpxKcMoLjYHxC0TCvBD9CfT7dFYX7ALlvFg4oHA1T hIhwmIPij4qJ7adIizbTCxGs/ZCtDlw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6A6E845053; Tue, 1 Jul 2025 21:32:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21905C4CEEB; Tue, 1 Jul 2025 21:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1751405566; bh=tHofUx9bTwpHmb+Zpkg0R90p/JL1R36qcc5bKk4Q3ww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CEIM4AnP85zEAKs1pfZ7h5ofu6yEgYwzM1NPdaup3olCG8VKtygPuYtMPdhuOOgIH +dW7BypSA5BPAfL957Cfu3UDRbB2dl2alxgFb5lD3JSMDtqaxfX9ZG6RqVFAxk8LH2 guaEqyygbJtGQzi2qTCl1NHcB1CiBNdK5iXDYxmk= Date: Tue, 1 Jul 2025 14:32:45 -0700 From: Andrew Morton To: Bhaskar Chowdhury Cc: Christoph Berg , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools: mm: Added modern version of shell quote and a stranza for required command check Message-Id: <20250701143245.771205665a349b02929e9290@linux-foundation.org> In-Reply-To: References: <20250701094603.23933-1-unixbhaskar@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: znkqnrqqiqzrjyeybeofp3n6eiym4gbp X-Rspamd-Queue-Id: CFEF8100002 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751405567-169030 X-HE-Meta: U2FsdGVkX1+IAOHWDMnmd38geEY0YX8jLCA+uhM+l8rksKRPn6mfTyNJqyrPOLbqtjGRLqY4dX5yE/GZ3NxxMSDD9fSMJwHj+glvmmPzRpW2zAWU9iVx+uM+JGnpyhwmYNiRB96jlpNQSNntKM5gvC/ykenFv9c7kujlheiuEep4m17uhncJa9ebYa/Mgx0oZ3BmTkGLc5UufijNYIkPJgOT7ya6iZaXpyWEUuCJXPUKyhovtF7J7ilMUJrRuEDrVQuQQIyAufgr8opU3i7YYz9N1jfOW2s1O87fa09yK4Nr4I2g0/er9Hs3AVL0WfUysZHHxt5pE8ETh6516JwaueUrLoEAPCMK0YYNtDep5X++HyiB+fDGz8LqRliJ6Jmbl+2OwTIt0as9qV3EOCOawWU5+vaGaLVXFLBcEIhuU6xDVsJ4eWO4rkYVU9mZmby9lISbDhsyWvaRKYlh2CO+ugENpEBO4iNbiOjxuc3rXLASpOZvx7IZcPo56EQMPIWNjtJsZP3DqoozZDAHo+77SZ2YXFJS+Yf7DdoyijBgyaUqkBQpNLtyQGX0caCbOqEYEabu+0SEDiACwGGxrEjKvKCb/b1idlSBRkgle4xp6nsp7jHLjAW0/c4mUdBW0pkWC/7RqmjbZEYhc1K3U2nvOqyfbGEnZk1vDlz7051lC3QM63ZQt0VdQ2m6VzUcfMoKlRWJVI/uQQmr1L6Eyk/BOnu9AI9cgq2eS9OS6/rFaCwykfvwu1KsiyW5dWg/b1TUe8Zj6ejyHk1SAoexeEtKTI7riT9cpuAXkRYLQWpCke0cYoUPy8aAPzOb8+y56BRZH+D7ulIer6rTSm/cIiM8xxm40hSv92+C27eFdvS5KrJ245iH4JoCZozka3gDrQh3WwQ7rQQlv3oed/9c2ygty1DcqRhD9TjYDcq5+a6y/gcltLjenITeg3l6vadYyVc4GNGnAhFllgCtjAmrxU6 spz0zc8H mb5aqMOcA0Qn96H2FIcaCQXBSDAyqL1pl0HOn1raH2PoB6P9/6TuPtw+axv9y3C9cIJGm3inEv3GatFtjv5ypzKgnjbQ5Qen+kIC8FrV4Ii6MLek0bOsOgJXFSb9DUg9BTGdRYItGoYGAzZWCL9SNsIvlvmygn8HgDQNVaDFyk3nnVvoPGq9hqSayH60Nd0HTY/g1fGQ7rG5kZ5CrpoLkMGXcwOTWDmDNTK4FiIikuzkaaeMN2bzXWDKYaaBx0DLdBNC0IS0x4Zy9Q2irp/M2owaU+ZZuRJrym6FudR6Oi8WL3A0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 1 Jul 2025 16:49:27 +0530 Bhaskar Chowdhury wrote: > On 12:57 Tue 01 Jul 2025, Christoph Berg wrote: > >> -gnuplot -p << EOF > >> +$(command -v gnuplot) -p << EOF > > > >Why would you delegate PATH searching to `command -v` when you can > >just invoke the command directly? > > > > Because, for the two reasons, > > One posix compliant behavior of the command > > Second, the binary could be reside other places than the PATH. And this damn > thing make sure, the binary in the path should execute only. I still don't think I understand that :( Can you please have another pass through the changelog, explain things more fully and resend? Thanks. Also, > +missing_counter=0 > > ... > > +if ((missing_counter > 0)); then I'd have used $missing_counter here, but what you have appears to work. I don't know why :( > + printf "Minimum %d commands are missing in PATH, aborting\n" "$missing_counter" >&2 > + exit 1 > +fi