linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Cc: Christoph Berg <cb@df7cb.de>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: mm: Added modern version of shell quote and a stranza for required command check
Date: Tue, 1 Jul 2025 14:32:45 -0700	[thread overview]
Message-ID: <20250701143245.771205665a349b02929e9290@linux-foundation.org> (raw)
In-Reply-To: <aGPEPxNkvtK3xRgk@Gentoo>

On Tue, 1 Jul 2025 16:49:27 +0530 Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:

> On 12:57 Tue 01 Jul 2025, Christoph Berg wrote:
> >> -gnuplot -p << EOF
> >> +$(command -v gnuplot) -p << EOF
> >
> >Why would you delegate PATH searching to `command -v` when you can
> >just invoke the command directly?
> >
> 
> Because, for the two reasons,
> 
> One posix compliant behavior of the command
> 
> Second, the binary could be reside other places than the PATH. And this damn
> thing make sure, the binary in the path should execute only.

I still don't think I understand that :(

Can you please have another pass through the changelog, explain things
more fully and resend?

Thanks.


Also,

> +missing_counter=0
>
> ...
>
> +if ((missing_counter > 0)); then

I'd have used $missing_counter here, but what you have appears to work.
I don't know why :(


> +  printf "Minimum %d commands are missing in PATH, aborting\n" "$missing_counter" >&2
> +  exit 1
> +fi
 


      parent reply	other threads:[~2025-07-01 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01  9:37 Bhaskar Chowdhury
2025-07-01 10:57 ` Christoph Berg
     [not found]   ` <aGPEPxNkvtK3xRgk@Gentoo>
2025-07-01 21:32     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250701143245.771205665a349b02929e9290@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cb@df7cb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=unixbhaskar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox