From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B7CC8302F for ; Tue, 1 Jul 2025 08:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247266B00A4; Tue, 1 Jul 2025 04:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CFD56B00A7; Tue, 1 Jul 2025 04:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0974C6B00A8; Tue, 1 Jul 2025 04:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9E8E6B00A4 for ; Tue, 1 Jul 2025 04:54:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B589E1A0330 for ; Tue, 1 Jul 2025 08:54:26 +0000 (UTC) X-FDA: 83615084532.30.4CDCD0D Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf05.hostedemail.com (Postfix) with ESMTP id C7780100002 for ; Tue, 1 Jul 2025 08:54:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; spf=pass (imf05.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751360065; a=rsa-sha256; cv=none; b=pDtnCyp2GRCai2UU4uX8ccRxGtPAU4gW5wM7eqqWYdeRnSwwploncayiRB75v8AVg3sBQ7 epfiEXuYNORY0fGbMsjB3oN7X96I9cfLKB1LtHTdPyQfxvoRY2awbmp6Q+nayLprph/kEm 5HhpopMG0q3MbSispQJLaIs8iktCRDA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751360065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Lpuh5vBcambXDr2Ah/zQDZp8b95zmF/v+KAMgKo7fY=; b=fYrHMdnRL0PNKj20N7PX+W+Q2P56qtPxORvlptovzXkbPosAopDDXUJtDURpVZsZZxqOxM miWpJRV4Bdo9qSHd9oogdGEkgVIJOsp/vzM/mVq5CEA4r9Y6bWrUpaHXeBHEl6pRkZW4Xj dOpGJQZIuEyBZpmnOgKA7Szk5jelkZI= X-AuditID: a67dfc5b-681ff7000002311f-77-6863a23d4bd5 From: Yunjeong Mun To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, honggyu.kim@sk.com Subject: [RFC PATCH 1/2] samples/damon: convert node id to physical address Date: Tue, 1 Jul 2025 17:54:16 +0900 Message-ID: <20250701085417.1734-2-yunjeong.mun@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250701085417.1734-1-yunjeong.mun@sk.com> References: <20250701085417.1734-1-yunjeong.mun@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsXC9ZZnka7touQMgzWd0hZz1q9hs3jy/zer xeVdc9gs7q35z2px+OsbJgdWj02rOtk8Nn2axO5xYsZvFo8Xm2cyenzeJBfAGsVlk5Kak1mW WqRvl8CVcWn/JcaCKxIVe48uYWlgvCvSxcjBISFgIjF9g3QXIyeYuXzNHUYQm01AQ+LgoZPM ILaIgKBE/+MZrF2MXBzMAnMZJY6ceQ9WJCzgLXHm8j0mEJtFQFViQ9NPZpCZvALmEjOuSkHM 1JRouARRwilgIXFi5jOwViGgkvt/57OD2LxA80/OfMICYjMLyEs0b53NDLJLQmAGm8SlPXvZ IQZJShxccYNlAiP/LCQ9s5D0LGBkWsUolJlXlpuYmWOil1GZl1mhl5yfu4kRGJjLav9E72D8 dCH4EKMAB6MSD++Mk0kZQqyJZcWVuYcYJTiYlUR4+WSTM4R4UxIrq1KL8uOLSnNSiw8xSnOw KInzGn0rTxESSE8sSc1OTS1ILYLJMnFwSjUw5mxrd3mjeZ17gmUMS/q2Cxu2OvjvViyY5fCZ +90eZw3ju/wbPK8K1YqsY6xr5Pdpumy8TOEfe0hMXyC3yPLQfxwnnuf+mK/8Qrzzkthtr+9F /t0Lbv0R339+kXT2ZPYllSVpfxsfBD0+8VZUxuKE2PJ3HIx9p6bqtqa6dPzeI9/Fm/PYcmOe EktxRqKhFnNRcSIAeg4lF0gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsXCNUNWR9dmUXKGwZIOC4s569ewWTz5/5vV 4vOz18wWh+eeZLW4vGsOm8W9Nf9ZLQ5/fcPkwO6xaVUnm8emT5PYPU7M+M3i8WLzTEaPb7c9 PBa/+MDk8XmTXAB7FJdNSmpOZllqkb5dAlfGpf2XGAuuSFTsPbqEpYHxrkgXIyeHhICJxPI1 dxhBbDYBDYmDh04yg9giAoIS/Y9nsHYxcnEwC8xllDhy5j1YkbCAt8SZy/eYQGwWAVWJDU0/ gRo4OHgFzCVmXJWCmKkp0XAJooRTwELixMxnYK1CQCX3/85nB7F5geafnPmEBcRmFpCXaN46 m3kCI88sJKlZSFILGJlWMYpk5pXlJmbmmOoVZ2dU5mVW6CXn525iBIbesto/E3cwfrnsfohR gINRiYfXIC8pQ4g1say4MvcQowQHs5IIL59scoYQb0piZVVqUX58UWlOavEhRmkOFiVxXq/w 1AQhgfTEktTs1NSC1CKYLBMHp1QDo/LsG0uFvXTzv5a3Kt67enHD547zS2aVJM1PmNCdrhgw 69qqyHB+C4EHeR7bNSZ1xnlfd7k6+eXnktMOhX5y7oynvkQc+y2SdH03x1ThWRp7nquG8Vvw P/40u+zatL5bMmq2b7Mnxa049LHDQIPbirlFd5YQp+pjs4RqhnavsGWftXJclA6oKbEUZyQa ajEXFScCAFC0k705AgAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C7780100002 X-Stat-Signature: bjaykjwemjm1j617i6wezcx3u4sgkuis X-HE-Tag: 1751360064-600095 X-HE-Meta: U2FsdGVkX1+xv7C0DnV3f2KAcC77YmrAyvt8JNU90JDDUmGhE/R6vba3n6oQZGF++kTLiszVok6Dp6AeJmKqkKRDy6Nz/zpQse9x8EcoZ1mNL8HBDXVk/loHLS5NdXhqAGurs3kzq7VnjYujCNPc5csTrqwDWFL3NNa6uFH+AlkjPcoyZLJRMs3WNVwF5fhc5w80JXBeHNsyW2xUbnCWUyoWqPoyVlxaxoFxUeSCsbIWEhfLTA1S83T1y+8AMpY7Dx44Is5ozpinwWCZrLKYCms35A/8f8OQdmR52C0qb/+v2Vp7NuKQbR/kAXsY3UQwv7/tYxyz+H8E9L3hWoPara0d2qN/gr/U/GIxG9E3gr7TEmN/vk1Litnm71/UMX15LpIXr07wJcdu883wnN4SUTbbJH28nhlyysEsmbJS12vIrUI25SzzUzgMDBDbHWUNhVez9VG6PRbtmVVFQmGRkbqFxF7EXgAwvRtLMWkIHBbwwzuZcvFVqSTHNQ9PgYgwh1QTqwQxXnhv40Pw37netQssvtb+9F0Anv4GQ2Y7EebEF3dqBPuT4h2fPMj2GG/oNaYZQYjLHoTb44DzLa3Fie30rBxxnBHgf2w4yK5AK0Y7goZZJtQ+qCMcoZCsnE2vJJ5rZ4IBadPmpf2f/h8691JP1AItNE7s7F+8LwVwZrvlWfrzCwUqMffPMf0aRZ30SrOOlkuq/TS+flMnzDn3IwiOlqPoMBM6aw5oKrQEewh92Ki7zaODjy9m7AwVNUP0grNb9Z161rFfNksIuaIhfBib8YQyFpc492XMuS6VzWzqRiya3jBGHdN7G1TgPBqipnIwetMifuOVjOEvfh6aT3XVBlludU41P9d1Hur2F1odq5/vvpqEnrkF45Ka5Brs0Y+oTbPnQqKDCg1Ll7A/v5mkYaJJT1H25eleSVIOiNRTIwneR0ytN0y6iGOSOX74Sm7HSCowqovRhilvhg8 lV70d5o7 6GakX8djk/8NOwuamHZfGJYY3f83Logc62UED4N2lF5ElgWZTgxP1Yd9SGSPU4Kh9oByK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch removes the `node#_start_addr` and `node#_end_addr` knobs, and introduces logic for converting numa node id to physical address. It only checks whether a numa node is online and calculates the start and end addresses of the node. It does not verify whether each memory block within the numa node is `usable` or part of `System RAM`, as performed by `damo` [1],[2]. [1] https://github.com/damonitor/damo/blob/v2.8.5/src/damo_pa_layout.py#L72-L90 [2] https://github.com/damonitor/damo/blob/v2.8.5/src/damo_pa_layout.py#L92-L10 Suggested-by: Honggyu Kim Signed-off-by: Yunjeong Mun --- samples/damon/mtier.c | 44 ++++++++++++++++++++++++++++--------------- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index f3220d6e6739..ba6938a89c21 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -12,18 +12,6 @@ #include #include -static unsigned long node0_start_addr __read_mostly; -module_param(node0_start_addr, ulong, 0600); - -static unsigned long node0_end_addr __read_mostly; -module_param(node0_end_addr, ulong, 0600); - -static unsigned long node1_start_addr __read_mostly; -module_param(node1_start_addr, ulong, 0600); - -static unsigned long node1_end_addr __read_mostly; -module_param(node1_end_addr, ulong, 0600); - static unsigned long node0_mem_used_bp __read_mostly = 9970; module_param(node0_mem_used_bp, ulong, 0600); @@ -44,6 +32,28 @@ MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); static struct damon_ctx *ctxs[2]; +struct region_range { + phys_addr_t start; + phys_addr_t end; +}; + +static int numa_info_init(int target_node, struct region_range *range) { + + if (!node_online(target_node)) { + pr_err("NUMA node %d is not online\n", target_node); + return -EINVAL; + } + + /* TODO: Do we need to support more accurate region range? */ + unsigned long start_pfn = node_start_pfn(target_node); + unsigned long end_pfn = node_end_pfn(target_node); + + range->start = (phys_addr_t)start_pfn << PAGE_SHIFT; + range->end = (phys_addr_t)end_pfn << PAGE_SHIFT; + + return 0; +} + static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) { struct damon_ctx *ctx; @@ -53,6 +63,7 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) struct damos *scheme; struct damos_quota_goal *quota_goal; struct damos_filter *filter; + struct region_range addr; ctx = damon_new_ctx(); if (!ctx) @@ -82,9 +93,12 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote) if (!target) goto free_out; damon_add_target(ctx, target); - region = damon_new_region( - promote ? node1_start_addr : node0_start_addr, - promote ? node1_end_addr : node0_end_addr); + + int ret = promote ? numa_info_init(1, &addr) : numa_info_init(0, &addr); + if (ret) + goto free_out; + + region = damon_new_region(addr.start, addr.end); if (!region) goto free_out; damon_add_region(region, target); -- 2.34.1