From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC8EC7EE30 for ; Tue, 1 Jul 2025 08:19:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92F926B00A9; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 843296B00AB; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A696B00AC; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B7396B00A9 for ; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BCB8016035F for ; Tue, 1 Jul 2025 08:19:38 +0000 (UTC) X-FDA: 83614996836.04.7170E8F Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf19.hostedemail.com (Postfix) with ESMTP id CB1EE1A0003 for ; Tue, 1 Jul 2025 08:19:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; spf=pass (imf19.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751357977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sIasva69G7izrZKPJfXCNvZwvNUlkzVQ2guRGq2J4ZA=; b=M7U6ASL0NXEYY5oisS2CjuvTDhglIyObp4psOb4K/2TMc++EfVc++cmeRovoGe7LQwvtrr cElkuUTh/hiAB5SQQSliVdx5xgnLMKItHY67Q/tVSlKsEbkB+DF0UAm/IU5Nupguzx5yIN ePfSH0Wjf9POybmqAGKl/tC9WQizIaQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751357977; a=rsa-sha256; cv=none; b=FRR7gC/gzrLNNXYgc7FVPXXfLb9R5X8Ae02ZbFyxvyWT/P7OmzOA0X7mf9rxKnrDOpMnVK jpmafvmN+ibm7fAPBxZ6nYpXe0lVE5oHl9GDroVzZbjNUR+QFyUIp9tEv8yiQ9V/1vZ1cJ PFpAx8FeOy81jXRhvbQ/q4IX4oZEC4E= X-AuditID: a67dfc5b-669ff7000002311f-ce-68639a14f4a2 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim Subject: [PATCH v2 3/4] samples/damon: fix damon sample mtier for start failure Date: Tue, 1 Jul 2025 17:19:25 +0900 Message-ID: <20250701081927.1873-4-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250701081927.1873-1-honggyu.kim@sk.com> References: <20250701081927.1873-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDLMWRmVeSWpSXmKPExsXC9ZZnoa7IrOQMg0071SzmrF/DZvHk/29W i3tr/rNaHP76hsmBxWPTqk42j02fJrF7nJjxm8XjxeaZjAEsUVw2Kak5mWWpRfp2CVwZkx7d Yizo4ajYu3AeYwPjebYuRk4OCQETiQ/L7rHD2G9nX2QEsdkE1CSuvJzE1MXIwSEiYCUxbUds FyMXB7NAE6PExl+dYL3CAv4Snc+ug9WzCKhKHGtdD2bzCphJdE2dywgxU1Pi8faf7CBzOAXM JVbdAVslBFQy78ENFohyQYmTM5+A2cwC8hLNW2czg+ySEOhhkzjTNhfqNkmJgytusExg5J+F pGcWkp4FjEyrGIUy88pyEzNzTPQyKvMyK/SS83M3MQLDcFntn+gdjJ8uBB9iFOBgVOLhnXEy KUOINbGsuDL3EKMEB7OSCC+fbHKGEG9KYmVValF+fFFpTmrxIUZpDhYlcV6jb+UpQgLpiSWp 2ampBalFMFkmDk6pBkalzY9vmdnOT/+T46417YXkjY9sjSZV35ZEFC6/XflI/2e8+P9iv3es 7zrtP+0Ms9175AZTa9lasymLeScbKcmpCjkW/11Sp2o3W0d3zQYVH1u+hZejWldz2JacnVLP 9lU022LVFM5pHBOSXl1z5rZ6nLn0oEzOokXf7t+Kishe/H1K/r2kzKVKLMUZiYZazEXFiQCz iYXDPwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsXCNUNLT1dkVnKGwcUPChZz1q9hs3jy/zer xednr5ktDs89yWpxb81/VovDX98wObB5bFrVCSQ+TWL3ODHjN4vHi80zGT2+3fbwWPziA1MA WxSXTUpqTmZZapG+XQJXxqRHtxgLejgq9i6cx9jAeJ6ti5GTQ0LAROLt7IuMIDabgJrElZeT mLoYOThEBKwkpu2I7WLk4mAWaGKU2PirE6xeWMBfovPZdbB6FgFViWOt68FsXgEzia6pcxkh ZmpKPN7+kx1kDqeAucSqO+wgYSGgknkPbrBAlAtKnJz5BMxmFpCXaN46m3kCI88sJKlZSFIL GJlWMYpk5pXlJmbmmOoVZ2dU5mVW6CXn525iBIbZsto/E3cwfrnsfohRgINRiYfXIC8pQ4g1 say4MvcQowQHs5IIL59scoYQb0piZVVqUX58UWlOavEhRmkOFiVxXq/w1AQhgfTEktTs1NSC 1CKYLBMHp1QD4xYTsYe+SgcYe+KWaRVNYjgnmJk/5eKOiZ4130tSa95MObXw+5u17Re7ljXU tPnYvXqXcf3GxYyN226q3ljeytNqULPqUqfjjA83ej7l/7ht+KL2JpeKjvX0o+sXTW//frrx u2TFwb3h1qeY5P/a1m9WeFzRfW5j73fLjL7k3U9/FCX6dX517FBiKc5INNRiLipOBADDxOO7 LwIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CB1EE1A0003 X-Stat-Signature: b7zncumc3uf54qxp7ji4n6ao176o5pb6 X-HE-Tag: 1751357976-377053 X-HE-Meta: U2FsdGVkX19I/AipmVs9MoNintmw3M5MsH95/PKqEfWmRlGvy0Tgg4H7fA9hlKxiwjBZ7XnxjIelsNY25y/u0JQHM1oBPPd/7aycvTkbhDBCXJOwQvKd8vwqAmUGJASXdvAGh9kgYNkMdOKXYP1vJf+P6adTg5ASKs73VcNM6/WId6mtU/+LLkt1Wy/CvthD35X1IsWvaTo7lh3MoRj/tKEJmItyV2mSfaRyjEx+e2AQMoqhmpkAUyT0oUbFXWStXCsaF/nEVPutVRLCV2PIZTbNKmgUoyd1WwHyD+UB+0yYIaLlG0cUkiuP6GQwVp3x8fLi+Gm5nqhEV6vJPQlBgnpeYLstez5mI1UPBFkMtcR5RrBproL/aYDJ0ijSeuUWah44KPdEq5E2PkgPLnTcmXD/gbkBO5x/Bsh8adfZ/gHD2yQr9Bqi6LuWn+Jv7TD0gQNnmd7i+HLh91XZixbj0IBPLotXIX0I4Z9DqABI+PkSIJDSRLtnLz6BqsSnVl4q+4Y6JZDvdA93rFYaTeJw3IXS6Hx4n6wfoq0IeTazbuPi0GhJaj094vMMnuVOuYt5137ro9v+/e4aSmyFTKBB4P4R8hvNHTChaaOefn2b8+oV85FX6qJgMrfW+GH6UBmGB1/E8BhZC2CxrfZcNTK91Bl7oIt27poC3V+7MDJBTFjg9lYu7wfgaFCxCH6N1CNDW05lcT+6Gl5JHwXmzt14ITyQtqhYq9JaOIiP3EbdVIoyjOb61CodGJzA/Vl9o476wDF0SCnlVj4S3aMtyXfwKXAvDEq05QakAy6F92QUIkc0T8UG44/FU6Tn0sscM0N4kwqVd6d1L58PR5n3+R0PtGBUG/21wIzl/oUeQtMxZ0xoP+jup5T3xcaNyhEH9pNBsMiiu9oI0aikhfdMfC/9ySPJ0zx44JGPuanNKBw79AD+keU9Nx/ylHT2s3b+YaxnQoD1z0xQTEwfXVJycU8 tyJp9xlY QykYGdoZ7f9a2hrvDXOo7ABVd8zU4sSE7Sp74CIlNw4Zqp7pf3naPNxObTsReU1gjOwXV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_mtier_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the similar crash with mtier because damon sample start failed but the "enable" stays as Y. Fixes: 82a08bde3cf7 ("samples/damon: implement a DAMON module for memory tiering") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park --- samples/damon/mtier.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c index 36d2cd933f5a..c94254b77fc9 100644 --- a/samples/damon/mtier.c +++ b/samples/damon/mtier.c @@ -164,8 +164,12 @@ static int damon_sample_mtier_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_mtier_start(); + if (enable) { + err = damon_sample_mtier_start(); + if (err) + enable = false; + return err; + } damon_sample_mtier_stop(); return 0; } -- 2.34.1