From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58D2C83039 for ; Tue, 1 Jul 2025 08:19:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A0586B00A2; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B3DB6B00A9; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A3626B00AB; Tue, 1 Jul 2025 04:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EDE7A6B00A2 for ; Tue, 1 Jul 2025 04:19:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE217105F0B for ; Tue, 1 Jul 2025 08:19:38 +0000 (UTC) X-FDA: 83614996836.03.AAE66E7 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf23.hostedemail.com (Postfix) with ESMTP id D4CEF140006 for ; Tue, 1 Jul 2025 08:19:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; spf=pass (imf23.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751357977; a=rsa-sha256; cv=none; b=eBdv2u5TF8RIpF9yM2HDbShhiYpt+BQFqUbbEeHMGKVdEFLfFJiWXJaeL4ZFzLeOr3TwyO KjaUKvnXn3GqGo+RCp8FxdJQ159+U71hyDAId9be2x+h7mgrF6xtfCXrYg+02UJhwL7oN2 HwtXfwaQ+qGKF8Twcd/ohsUM5tqlOQc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751357977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uSQpYu3ZUENLZK7IRLPp+4XUdCNA40pUjgZWHDdImr4=; b=h/bRCMs1nUUtjp2CLY1owe2tw6pCVHDCMw+nl8XUmBdncAAJeW2Rn4RGf3rVnZBtfKeKd4 oCZNLo4E34uJqpdOPD+VfXJ3//MafB6FrediYZsb07SRNfJkoYPd+bx09DgcVcZHhRk7KT 9K9YHoB9qStgafRnZEZGrm8axVED1Is= X-AuditID: a67dfc5b-669ff7000002311f-cb-68639a144534 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim Subject: [PATCH v2 2/4] samples/damon: fix damon sample wsse for start failure Date: Tue, 1 Jul 2025 17:19:24 +0900 Message-ID: <20250701081927.1873-3-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250701081927.1873-1-honggyu.kim@sk.com> References: <20250701081927.1873-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDLMWRmVeSWpSXmKPExsXC9ZZnoa7IrOQMgzUPhCzmrF/DZvHk/29W i3tr/rNaHP76hsmBxWPTqk42j02fJrF7nJjxm8XjxeaZjAEsUVw2Kak5mWWpRfp2CVwZu+9f Zipo4aiYuOoUWwPjMbYuRk4OCQETiV/n1zDD2B+ubmYHsdkE1CSuvJzE1MXIwSEiYCUxbUds FyMXB7NAE6PExl+dYL3CAn4Sfx72sILYLAKqEks3/gabwytgJjF9zhx2iJmaEo+3/2QHmcMp YC6x6g5YWAioZN6DGywQ5YISJ2c+AbOZBeQlmrfOZgbZJSHQwyaxdsJrqDmSEgdX3GCZwMg/ C0nPLCQ9CxiZVjEKZeaV5SZm5pjoZVTmZVboJefnbmIEhuGy2j/ROxg/XQg+xCjAwajEwzvj ZFKGEGtiWXFl7iFGCQ5mJRFePtnkDCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8Rt/KU4QE0hNL UrNTUwtSi2CyTBycUg2MDdE64hPFq71ChC/s4xd8ac1+wmJTI3vxgaVnA675Mjcfv3LF1b7j +4dZ25MlLgQayR/4eyhng+T5fRJvzp91Ytz3/9LsKKPkxeuVerwKOTVEF6cd+WE4y3A2i4Cu iNbye0wn7Q1Tu5U+tbdMfLNNjG9q6BrX2z6dGvvSE3xCPxtuudsY9+muEktxRqKhFnNRcSIA IZpz3j8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsXCNUNLT1dkVnKGwcWprBZz1q9hs3jy/zer xednr5ktDs89yWpxb81/VovDX98wObB5bFrVCSQ+TWL3ODHjN4vHi80zGT2+3fbwWPziA1MA WxSXTUpqTmZZapG+XQJXxu77l5kKWjgqJq46xdbAeIyti5GTQ0LAROLD1c3sIDabgJrElZeT mLoYOThEBKwkpu2I7WLk4mAWaGKU2PirE6xeWMBP4s/DHlYQm0VAVWLpxt/MIDavgJnE9Dlz 2CFmako83v6THWQOp4C5xKo7YGEhoJJ5D26wQJQLSpyc+QTMZhaQl2jeOpt5AiPPLCSpWUhS CxiZVjGKZOaV5SZm5pjqFWdnVOZlVugl5+duYgSG2bLaPxN3MH657H6IUYCDUYmH1yAvKUOI NbGsuDL3EKMEB7OSCC+fbHKGEG9KYmVValF+fFFpTmrxIUZpDhYlcV6v8NQEIYH0xJLU7NTU gtQimCwTB6dUA2N33+3jlywEa/9J15R7GG22kFuwiKvje+6Ru133mXK1n9qtzK3Um+9wMfzb eadZU44nb/0ef7FnbsiBBw/+Cp60+uy9/9i/K/kS960FdvhdKnY8PPFARnEvQ9Zi8bDr8Z+e y4b9DWrhuX7hdvGfh0stTc6ov4740TubV8ou/0XeJqe9J/vmhX1WYinOSDTUYi4qTgQAtb8G oi8CAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D4CEF140006 X-Stat-Signature: z3sbwxto7pr7bq7rg4ffxr3oaw3ymgr6 X-HE-Tag: 1751357976-957029 X-HE-Meta: U2FsdGVkX19VIKO4nKHNrj0viuiKCR4PHYbZINbYq3VCGJ9uLQv5is5DLvEl66jRr6fU50NLQ8Gz3AlKjkR4XJUJn35R3M3TO4heMVE9hYKjpZcwjFhWjEa9QGFg1Z8CzksNCIBKTZ8fIbutEs5ER5lWEL9xyiXOYemthKNQcAziF/Rb/xtM2VIQ9ap9X2+vrpngQSjHbe1ZtErzywlqMjUWlMRMkXuZNHgGdvCVrTRAidCVTp7il4zTGbPfbSTPCC/XYRx9mksYwr8NS4gB84zeVzm9GgVN71pMtzGZCpV5x/2AfvgCI8PoI0tW3QLg1XHHn6cd7H2WrRJ/XO7+QlVdVpdkZJV8nNU4q1tZvWW8XSmkkC5VM9iGudq16DgEo0kf+pbbhbetBD397Yce0CqRT5EExBIhLHPu3SmGbAPh51e73juUHHt+sGSJwViDx/yk77JAwFJBO1GNmA8Ugs05ukZy5AiypeAa4aMI/Pn20ka5qsSunQmaZIFja8K0N9HgDRIfcx4E5YWQalVrjRXL2OaAJzLuJK05Yx7grYX+rxDRfrsdBRHVB4sUEzlmHsMTdR67g00FldHn/TvUT8updCaXO+QDlp39Ws5FZ93Gb8L7YtgNljW26VKyRdwPe9KITTGEJoosCVB6wxt8itXeYJv0LPZfgAnzyHh7akHkHkp+0hsIehPEqCA/xn96NzNTsN7B1ZDJ2FAWzktzcuoF7Kt6B7/asFieLm0R5pHfw3ojWCAO64lq4DUoIgjNdeUrCe/FZrN7dqp2vXC4Uy53+xLCoMEZRCtoTdNqml3DIfsM0TYWcv6zmsLTgRV0V1Lrr60Lo+Tn2Id71501R3ShQ6gy+f8pRlbbi2d9QpUAaTuNafPJPo+L4XO7A3l/d00ueE/c4ENCWhfAOug5dkP5ZJCoTE/5pm3lHDOvQfUaT5LULYSnYYSk9F5Nu1MDnP+GRYeNaX2MmzekLxU 4IbkITQJ 5ChI5Byt+vY4/d+LnxLz+Tkt7iCAsZtrR/OBCKYebN7/8yRSP1VuSITgiPCVTtSztLDfg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_wsse_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the similar crash with wsse because damon sample start failed but the "enable" stays as Y. Fixes: b757c6cfc696 ("samples/damon/wsse: start and stop DAMON as the user requests") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park --- samples/damon/wsse.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index 11be25803274..e20238a249e7 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -102,8 +102,12 @@ static int damon_sample_wsse_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_wsse_start(); + if (enable) { + err = damon_sample_wsse_start(); + if (err) + enable = false; + return err; + } damon_sample_wsse_stop(); return 0; } -- 2.34.1