From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375E7C83038 for ; Tue, 1 Jul 2025 08:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13EAB6B009C; Tue, 1 Jul 2025 04:19:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A11A6B00A2; Tue, 1 Jul 2025 04:19:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED1C96B00A9; Tue, 1 Jul 2025 04:19:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D87976B009C for ; Tue, 1 Jul 2025 04:19:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7F78C105E16 for ; Tue, 1 Jul 2025 08:19:36 +0000 (UTC) X-FDA: 83614996752.29.E626F44 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C52F1A000B for ; Tue, 1 Jul 2025 08:19:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; spf=pass (imf19.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751357974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPXayHM7RiUYdDKuYrg2jxpXo0IumD+Cn0T/GYVny0Y=; b=SXSijJBlHu7PyaiPVVVcsUn+9h1b1WMAORPcraaNoTNBCSo7B6QylAuw0hcUwGmAIAqaF4 vELGqkVnBy2zKBAw8iHzUehJrEVXzngMc4cwj41VxthlHuq+Ui8D/SyGkOx6GCjqsjGtjK N7eh04wC6bgKA62QlgEeG2BmH5CTVQ4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751357974; a=rsa-sha256; cv=none; b=DphNx31prvhHPyK8grTc/sKKDz+UyVICSEghrcQWputJUO0++/dsXCiUL1tcrQF7LZxgSr fNM/F+ktwx/3HvHcX9oJHeAxAWS77ssBMOW6ZnB1O1F42B+0fNfgJwwoOeCnSijdDdbcL6 mTK0cI4hGGjPDkUEm3STbt/GbrteKX0= X-AuditID: a67dfc5b-669ff7000002311f-c9-68639a132d92 From: Honggyu Kim To: SeongJae Park , damon@lists.linux.dev Cc: Andrew Morton , linux-mm@kvack.org, kernel_team@skhynix.com, Honggyu Kim Subject: [PATCH v2 1/4] samples/damon: fix damon sample prcl for start failure Date: Tue, 1 Jul 2025 17:19:23 +0900 Message-ID: <20250701081927.1873-2-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20250701081927.1873-1-honggyu.kim@sk.com> References: <20250701081927.1873-1-honggyu.kim@sk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsXC9ZZnoa7wrOQMgxPbdSzmrF/DZvHk/29W i3tr/rNaHP76hsmBxWPTqk42j02fJrF7nJjxm8XjxeaZjAEsUVw2Kak5mWWpRfp2CVwZq++s YypYIFBx+f951gbGLbxdjJwcEgImEhv/TWWGsb/+aWADsdkE1CSuvJzE1MXIwSEiYCUxbUds FyMXB7NAE6PExl+dbCBxYQE/iW2z4kHKWQRUJSZeO8YOYvMKmElcf/uTBWKkpsTj7T/ZQco5 BcwlVt0BKxECKpn34AYLRLmgxMmZT8BsZgF5ieats5lBVkkI9LBJvNvzEGqOpMTBFTdYJjDy z0LSMwtJzwJGplWMQpl5ZbmJmTkmehmVeZkVesn5uZsYgUG4rPZP9A7GTxeCDzEKcDAq8fDO OJmUIcSaWFZcmXuIUYKDWUmEl082OUOINyWxsiq1KD++qDQntfgQozQHi5I4r9G38hQhgfTE ktTs1NSC1CKYLBMHp1QDo5ugwW3dEzebbMq+XWphS4qMPOe54enm7meFm0+6JS9InVVv+Vao 98TLh77Hu+Tn8nJOv+c4q/v1D6OP/9Se8K5x/cL6PfdL3IyI0NP90U1VMxfsE7sdkZclvuNk 5zLV6N8iThudP9llfZ576E+TuE2B84abMsv8nE+utDjhGN74aNkkVclLy5VYijMSDbWYi4oT AQibBLQ+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNLMWRmVeSWpSXmKPExsXCNUNLT1d4VnKGQed6dYs569ewWTz5/5vV 4vOz18wWh+eeZLW4t+Y/q8Xhr2+YHNg8Nq3qBBKfJrF7nJjxm8XjxeaZjB7fbnt4LH7xgSmA LYrLJiU1J7MstUjfLoErY/WddUwFCwQqLv8/z9rAuIW3i5GTQ0LAROLrnwY2EJtNQE3iystJ TF2MHBwiAlYS03bEdjFycTALNDFKbPzVyQYSFxbwk9g2Kx6knEVAVWLitWPsIDavgJnE9bc/ WSBGako83v6THaScU8BcYtUdsBIhoJJ5D26wQJQLSpyc+QTMZhaQl2jeOpt5AiPPLCSpWUhS CxiZVjGKZOaV5SZm5pjqFWdnVOZlVugl5+duYgQG2bLaPxN3MH657H6IUYCDUYmH1yAvKUOI NbGsuDL3EKMEB7OSCC+fbHKGEG9KYmVValF+fFFpTmrxIUZpDhYlcV6v8NQEIYH0xJLU7NTU gtQimCwTB6dUA6P2usuP1k3wk3gjo7vLJsm+xLvzGyfTi/P2a32XXDcqv+0Qnrmg/NwEfR95 t+Ld1zXXvNrM/OfI23b+zXEB1/YmOfHqeSy+Un/WzTT2gYvjl9DrrZvYVzh0fA//toXVPfXe jqW75yaa5N09oVL83DNg3oGm9l+cbdGfTh1+qjFbKcha+GDzo8VKLMUZiYZazEXFiQBX7YBA LgIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C52F1A000B X-Stat-Signature: jih7jwdhsgh9s69kxk74pwinjy1fsx4q X-HE-Tag: 1751357974-76157 X-HE-Meta: U2FsdGVkX1+BCV4/gA/AZqO2ihE26ZjRCrMx8uda00I1nt77r0GvXWGveYYcyC6nc8q+nXf7neuofIvizcg6tqmdmWGBMGR6Ftp3L+nAy//L8L5/V4BWZX8lIkplHLEV0Acw4fPXRVOe4Mu7LXEFtzb0MfRcZ1m3FntAoTuVeVDLYtrINZaCw1R6J3mgsJWvTYMHhtG8DUJZGyXfgYvPOYF32BlUbHOUKdBY9R+el7Ldgc3vu3Y2CZ1UM+WnEQ80bSXuH4sANeDVepYhzlMgr95O+UfBGk8H/Qxu2FCy+B+zDSLLsJ3K9mjYBot7Yrjcr7Qmdq1a60et7E2wqw5I0Z6/nzvN9z/ebRaxLZtE7DmwWXiRWSPun3TuadWCO/zubnw4u0Cj471vXdvCWnPICU6vEapRtESwxHGKH+PYFPQWwkmv0+PhP3XOYO/0/N+ylWRXIKb29nLHYn02EBtWYovGIu9HXdeZQkg7QO0rmA9cxy/97VH9RhOIbhk6hs3IvK7d0mxH41/wjLaIRnZ0V2RypX8P//efKvb6yEKk5e+i9oHFCHn7k4DYbR773gBwi486rYj+60n2NyIqFtz/bOAulQmpipmFuTJjciRNrrD9Z/QdCfUfZNPqOYjcGV+J8e15NpccsvxAFkkipzvVQCYv9c1aZZjhJltTKi6AyopsiwqORz1+PY8XBOklQcfyk+HJvNzAKuaNi6KGXrRth7JB5srTOS141PppXGJzJGg9/wRfCg8rAf8yMm138BoxxzA+T9yk9K67kDFhAEHu5GQ71FAdnXofQoc33yHG7sMH5Rdb9FKCPB34nzNZohF5t5AUyy8mK7k0+JivmroaciGMINzqLv2ZjDenjcehShFotxMzX+A5IJmhrJjj29VoQ3pIXZApRtnuBcUQwUc3A9nAxI4H/movVL2unwiCpPqdn/zXTrDndXFt9Y6nyriYeYIiKY0KdxhwYZJeZbI 8NK4bQRL ox+Q4RvbVki5DCZG3CAiKliGV/aBjKOCJvVBgLUh4nyRmV3XY64SXC0vW0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The damon_sample_prcl_start() can fail so we must reset the "enable" parameter to "false" again for proper rollback. In such cases, setting Y to "enable" then N triggers the following crash because damon sample start failed but the "enable" stays as Y. [ 2441.419649] damon_sample_prcl: start [ 2454.146817] damon_sample_prcl: stop [ 2454.146862] ------------[ cut here ]------------ [ 2454.146865] kernel BUG at mm/slub.c:546! [ 2454.148183] Oops: invalid opcode: 0000 [#1] SMP NOPTI ... [ 2454.167555] Call Trace: [ 2454.167822] [ 2454.168061] damon_destroy_ctx+0x78/0x140 [ 2454.168454] damon_sample_prcl_enable_store+0x8d/0xd0 [ 2454.168932] param_attr_store+0xa1/0x120 [ 2454.169315] module_attr_store+0x20/0x50 [ 2454.169695] sysfs_kf_write+0x72/0x90 [ 2454.170065] kernfs_fop_write_iter+0x150/0x1e0 [ 2454.170491] vfs_write+0x315/0x440 [ 2454.170833] ksys_write+0x69/0xf0 [ 2454.171162] __x64_sys_write+0x19/0x30 [ 2454.171525] x64_sys_call+0x18b2/0x2700 [ 2454.171900] do_syscall_64+0x7f/0x680 [ 2454.172258] ? exit_to_user_mode_loop+0xf6/0x180 [ 2454.172694] ? clear_bhb_loop+0x30/0x80 [ 2454.173067] ? clear_bhb_loop+0x30/0x80 [ 2454.173439] entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: 2aca254620a8 ("samples/damon: introduce a skeleton of a smaple DAMON module for proactive reclamation") Signed-off-by: Honggyu Kim Reviewed-by: SeongJae Park --- samples/damon/prcl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index 056b1b21a0fe..5597e6a08ab2 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -122,8 +122,12 @@ static int damon_sample_prcl_enable_store( if (enable == enabled) return 0; - if (enable) - return damon_sample_prcl_start(); + if (enable) { + err = damon_sample_prcl_start(); + if (err) + enable = false; + return err; + } damon_sample_prcl_stop(); return 0; } -- 2.34.1