From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3714EC8302B for ; Mon, 30 Jun 2025 14:40:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 933436B00D3; Mon, 30 Jun 2025 10:40:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E1786B00D4; Mon, 30 Jun 2025 10:40:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A97E6B00D5; Mon, 30 Jun 2025 10:40:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A2CB6B00D3 for ; Mon, 30 Jun 2025 10:40:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 24DB280471 for ; Mon, 30 Jun 2025 14:40:22 +0000 (UTC) X-FDA: 83612327484.01.40936A9 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf23.hostedemail.com (Postfix) with ESMTP id 9EE73140014 for ; Mon, 30 Jun 2025 14:40:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LvjN75Dc; spf=pass (imf23.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751294419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZVMGl4ViErQo4fFQ8VUnT+LNcHK9FWrYiT4XPKoVoU=; b=W11c+uTNJ17lozeclwwoKRLuqAM76WHccdig8Y2znui0uo6o5ZWj1lUJERNT6EBeW8eENl yzbqCmuB+5IaWl4oy5BBxKVQmEOoV1tGguk9MInMxnAR+3UR5dGRLa4ArvO+3CWzLKlQQi hD8wbpzUo0YLZMLrZ69Da4HfmwPUvak= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LvjN75Dc; spf=pass (imf23.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751294419; a=rsa-sha256; cv=none; b=NTTnrb/3gTaGGP6pdq8h6ehB0fdx/bSrGZEOeeAwQJ5kcStlBkA1jQqmUQJwppTs31mVBk lLZY0+XuBSPE+0UPCtuaZlZ3JNezRwILb23rUXnIpQxQzzqhIldwybv8UrT+ZUiFoRupjS MjGr5X0M8YzjzpIzzsgDuuMho55DCjM= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55U8xoVD015498; Mon, 30 Jun 2025 14:39:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=dZVMGl4ViErQo4fFQ8VUnT+LNcHK9F WrYiT4XPKoVoU=; b=LvjN75Dcyo3Mg6vi1nvhrVHjbLsaMQ+4ridZrQWrM5H+m4 T8k7nKbVNZ4P7K7v/YGFuTeD2t7rOEw9IaJObFYMGeSqzJW7/zUSRGhEe0/hx5KT b8vcmp1YHBa9oTnPU4DF8grkhIf/VLHFHTcE08pIbZzxWZUGXKBIDZwvbNF9G5nz UcjjbUZ0QbBD7OtNYaaavGW0IqlsOhQZVwtNTtYOQn3JEOk5FOBKJ7yZEoSATva+ VqslOGK+1/R7RzXo65jlAXvy/+RPaXenkxiJffflbZSg9xEnWzdPg4gZSgEZKbtZ n6Cby79kZ59Mh8Ypp+uc1phO9exlUyIpDaSLPKsA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wra0bv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 14:39:45 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55UEX7fk002972; Mon, 30 Jun 2025 14:39:44 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wra0br-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 14:39:44 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55UE1gX6021934; Mon, 30 Jun 2025 14:39:43 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47juqpe8ck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 14:39:42 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55UEdc3544761382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Jun 2025 14:39:38 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7DE0A20043; Mon, 30 Jun 2025 14:39:38 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8161D20040; Mon, 30 Jun 2025 14:39:35 +0000 (GMT) Received: from osiris (unknown [9.111.82.77]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 30 Jun 2025 14:39:35 +0000 (GMT) Date: Mon, 30 Jun 2025 16:39:34 +0200 From: Heiko Carstens To: Alexander Gordeev , Vasily Gorbik Cc: Sabyrzhan Tasbolatov , ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, gor@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com, arnd@arndb.de, rppt@kernel.org, geert@linux-m68k.org, mcgrof@kernel.org, guoweikang.kernel@gmail.com, tiwei.btw@antgroup.com, kevin.brodsky@arm.com, benjamin.berg@intel.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 01/11] kasan: unify static kasan_flag_enabled across modes Message-ID: <20250630143934.15284Caf-hca@linux.ibm.com> References: <20250626153147.145312-1-snovitoll@gmail.com> <20250626153147.145312-2-snovitoll@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E/PNpbdl c=1 sm=1 tr=0 ts=6862a1b1 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=AeL96baZ9YmIqE4yH0MA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: 2hwphgPZI837FabFeudLVjFicIoSmhXG X-Proofpoint-ORIG-GUID: FiHtpeYVQCPMFgF1X9Rek_sDm6f0w0qN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjMwMDExNyBTYWx0ZWRfXydsoblXBR0ze E9HvMeQ14kc+Woe5xd/SFPBcu0vlwEb2rfyIotIQPVlF4ubkEgP5011gPNTSWqTF2yHh0XA+4Ys YtUR6UrKRuqNmHUZHfVrDRMN52XXJ8jmaoDUHFwngVMl/S0kuPwOX0KnQ08i7W5uZum6/pQlsxH PSRM68qtAJ+io/RlKpS8hVyp8JhMgoeN7tOOZYNJa4YzA3PSVAQzl1PZ5jjF5v+hYU4evHZAXNO 9IYq4VHNT7cT81dC5A7Z/s9IYQVPzNtDhaXj0Dc9jHPz9/phE/B/idozZZjcYiqY6iFL3AYGZq0 UJK05i7AMCYmP5WJn4xDjjygHxdSbNqoEBEmoYZebnEX4uBv0r9o5LI1Se2/L8pc7bQ8CW0e8qY COnK5bFnlwiVLGEKcvd+kJLxqLtFo59nsnoiQfRh0QLr6h7E4OxTno1X7/1yF98bvPZMX5sU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-30_03,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 clxscore=1011 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506300117 X-Stat-Signature: xhuu4qw8u577k9rufyjpsi4fwwpsnq9b X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9EE73140014 X-Rspam-User: X-HE-Tag: 1751294419-347391 X-HE-Meta: U2FsdGVkX1/W2+ky1ia/OCnABjfv0nxtz4Tg5KxcOAIl36w7IuSDQZnrS/6jWqCTl7wFjDKFUTEyl123phnEkfaCRVmmPp9JDiFAr2fHuJpXiSGyiIxzFSllG7maN1Txz9YpLnZXLnV6bUQarho0akSivjNoqxobIdNODtP7xUJgSodl50mtW+hSSiNUP1Djn/hW8oZSLwpEA9kHhm5yBC/1wCpwZJtlONiotXd0FXjavR0eqtoquaY7kTD6anOy7PnABJT1ulAQAWTlFHVFxaCcOK8jH7Qg0A4vF4lXw7MlOpc2xpcrL32Ak9TZjybei4WQJxZkyyOEowKQN36Qr+gu+Zoa+sKcCwSg7N0pNX9zr8B8GjuKyr5qFXm7AeWZTEozQbfljfb977iHMvUyIZORnlZ6Z3Txjtl34dhUnDOuRpo2xPAFzMmIa3i6VmizaZmDFYxS6SH0hBQI0OvDbTlkx8ZUifK/AMFcP/A7OC2Aw+5YHInIhQlQJVFlHgXPWpj8QaZpN+AoMlf1/DWupMDhSdM7zL2+2GAyt8D/7w/y6S+2OUN1PUKrAlIzVmR8l0xcvufZr5vwA9pYL7hRF9+2kizPrW3gm6Z7VjkmxWBJGUM1VEQ+Nxib7Ks0T75gFsEIEaBKaI/Bidk8QGYKMPj6DM7asGY+sDC5yH4dvb/HEPJeOP+Uiekl599lHDfyjvF+R8RktRqUaSMHzn+v/tjGVKkZuLXaR97ham2pIVL1RC5K3edmVP1uSzyMLEsFBU6ygj87shNsKs7meUn869kMmLIXxnN03bX9lWwgTseuyMhFIG6xtqdidK80t3l0ERjBqURUDA7bCRt8DkB12iCbtH2I/bVgvECmXRi5DkcizA5v6qLqggMxAcQswzsox94Sc7S7FW4Q10BB9twknrfZtgFVjZNft21jVzAwP8oO1/cTVU2QoraosykmyMAIKNp6Cpvnv9eKVglt9M0 gu1WRSna 9ovlyyA8orO13SAqSzuSBJl43naO7IdEvga3YwUgYs1zG3/NsvVK0MwOh0rih0nA5RDbe+JNyVfgIolwchDqBQuReWhY2XXSq6D2JlIMJXNL79SAxh7cCrnm4ozmxULScIefkvOa89mElX4og5irTUAfgwlyWlhzdiuhpq0Ml+mGSYu4VQt67fvqql07AVqOrg/1jlcSJRrfha78NbBaADY0rok0b1vpS6PXOXqOW+Si9/SWSm4ADKoHZgCkR0SCi0vJ/9vSxCIabSQ/GA5MPJXOHPR+SSIvMsaFymUcOQg9W5SFL1FdVwJvvXtjhLHVXxS3Ng0FBgGZdSTr4+3n+fPG0tKJoF5XJGx6ZFPysjTWFY0R5G1ydKAksfOu1TH6LzD7N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 02:31:00PM +0200, Alexander Gordeev wrote: > On Thu, Jun 26, 2025 at 08:31:37PM +0500, Sabyrzhan Tasbolatov wrote: > > Hi Sabyrzhan, > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > index d54e89f8c3e..32c432df24a 100644 > > --- a/mm/kasan/generic.c > > +++ b/mm/kasan/generic.c > > @@ -36,6 +36,17 @@ > > #include "kasan.h" > > #include "../slab.h" > > > > +/* > > + * Initialize Generic KASAN and enable runtime checks. > > + * This should be called from arch kasan_init() once shadow memory is ready. > > + */ > > +void __init kasan_init_generic(void) > > +{ > > + static_branch_enable(&kasan_flag_enabled); > > s390 crashes at this line, when the whole series is applied. > > FWIW, it looks like kasan is called while its state is not yet finalized. > E.g. whether calling __asan_report_store4_noabort() before kasan_init_generic() > is expected? It crashes because with this conversion a call to static_branch_enable() is introduced. This one get's called way before jump_label_init() init has been called. Therefore the STATIC_KEY_CHECK_USE() in static_key_enable_cpuslocked() triggers. This again tries to emit a warning. Due to lack of console support that early the kernel crashes. One possible solution would be to move the kasan init function to arch/s390/kernel/setup.c, after jump_label_init() has been called. If we want this, is a different question. It seems to work, so I see no reason for not doing that. Vasily, since you did nearly all of the KASAN work for s390, do you have any opinion about this?