From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6A6C8302F for ; Mon, 30 Jun 2025 13:00:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD46A6B00AB; Mon, 30 Jun 2025 09:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B84DC6B00AD; Mon, 30 Jun 2025 09:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A53166B00AB; Mon, 30 Jun 2025 09:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 94DA26B00AB for ; Mon, 30 Jun 2025 09:00:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D90380514 for ; Mon, 30 Jun 2025 13:00:30 +0000 (UTC) X-FDA: 83612075820.27.6D1F379 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 0512BC0017 for ; Mon, 30 Jun 2025 13:00:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XLSoorcB; spf=pass (imf28.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/UC4605AtCeOAEiQnGvC6ua/uaOm0pT0/PRnxSFzekI=; b=eXmfo/5juQlqFoytwijky6W7QNjtssf6E2irGgIjwJ+kdflRvK3Wr0FcpboGVxME+5tY8g zKsAO7nL2eElpDnLK3rc4jwb02GhyVRPjIaH1eUJt6gJPJ2XW/1/SMCGFBPZ7HYwLgVW3K ZVe721eRu6wGy00LkkZakjRT6y8C8T4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XLSoorcB; spf=pass (imf28.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288428; a=rsa-sha256; cv=none; b=lwxnGBgcouv0GCvzZF6d4mpjNzBUujLLTGViHOGmbA9SnHspKNxS1YSsxsmQiqR9K4XZPC mfh6LK8sI1cECEJ00VP3Ih2VOZxP5jRnqwTrVwlYMabtc+lzu6K8Hvw5QLkbQv91h8GjFT g/zIZqzshuNpLOkE2DqWgoi4/XsPeGI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/UC4605AtCeOAEiQnGvC6ua/uaOm0pT0/PRnxSFzekI=; b=XLSoorcB5Bu1C8mBoDiAACANv3M/b8UOaqAsc6ODLGzhZttOmoyMfnZ9wMfz+8OxT1crlH XdDkmw8NVj/h4UbYMPYzppLLK7xdyi5kD7DMLJMA8LNVVzdNKHKfQ/iwf342bagHLx4rkb slkPrmfhbQ3/ab2gSJK9jnqpU7b3AwE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-VtmdT9U4NhCkzaqz2l3q1Q-1; Mon, 30 Jun 2025 09:00:25 -0400 X-MC-Unique: VtmdT9U4NhCkzaqz2l3q1Q-1 X-Mimecast-MFC-AGG-ID: VtmdT9U4NhCkzaqz2l3q1Q_1751288424 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4539b44e7b1so9205445e9.1 for ; Mon, 30 Jun 2025 06:00:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288424; x=1751893224; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/UC4605AtCeOAEiQnGvC6ua/uaOm0pT0/PRnxSFzekI=; b=TK1ypCM1gs4q5Uu0919SF7jnC8nDzo+mh7g6tkimpIEUWcL6rgPalzN5hO8D2m7Y2Z 224ZgTU8RKTQ0bGdWtC7MqjJ+eBK+ZAcKy/oZ+BaFrRVkhPMWd0nD7vyYXUjs7nOBhby +8J8pvr/4rwvTZQ2r9HCjD6K0bd0s3iZMRO/DXZLFbRJIazPzT4HOdln7A4NhOgZkEu6 k4EsAz9mXQH5Hrj0ikYsb5nMxinO+CIpQ+9p5xUnm/lb2f/tK40beDmB4HZR2ZU7gkV1 +hVqnqEUcmd4RcWmnnjfzf0sH/g0OSoTlT/Kzcfgo8JjU61245RfW4K08jkH0pOooT1b ucFQ== X-Gm-Message-State: AOJu0YxA6bBL5albchnsHAIX/stDQqaMNqT4GqwtcNUwDdg0RTgB9uJ+ xKGoDv1E1RsweFRUDONmCiXZl5ffneRmuDehWpIBsU7keAuU4dvYC0ONyseEd2mz7JOA6bTVLJ2 zC0L9GAIMCiYGuAaLGziqxWhFS599wXvQJxryyE2M7bvtCTUAdMx9 X-Gm-Gg: ASbGncvUzCPjL5QqvcmUG6FDnthWoRg7njCFNvHubBVRF2l/tkkKs3nHg2IIPJrSRrQ ufO2STq5Mwto54Omu6WWJWwrGlD1ThfHkdeLa7yBsjSUEPjm3mimRCHWtFLvix78aLkRSQH/SoF KlS8Gp2J9WioM0ytCv8heYkMm1Fd+2STtfJ1H+jnsrhh7H86shu6ADhdG7GStyTVb5fpxPwGC9z ct1Adg7onyFJyZRZ7ha5hKT6v2Ai6rpqiZDsuFAJ+hzMMs8K/nNt/wUM/BIv8HYKj+ijgzMe4Wa HynSLL6wGMGekz9mlbw5KUEXWjV5rUKuYDNlCXolFiAMX4nIgKFOR3NoH3RLyToQn5UXw3uGYs8 wGyfg5bI= X-Received: by 2002:a05:6000:1786:b0:3a4:dc93:1e87 with SMTP id ffacd0b85a97d-3a8f577fdf7mr11727513f8f.1.1751288423736; Mon, 30 Jun 2025 06:00:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLO9PGgybCCYgBv54Fac4lQzN8FKYTlkGjVWntSI86PNTFg8laDwfPxXxOTUUP76xSqnQLIw== X-Received: by 2002:a05:6000:1786:b0:3a4:dc93:1e87 with SMTP id ffacd0b85a97d-3a8f577fdf7mr11727461f8f.1.1751288423060; Mon, 30 Jun 2025 06:00:23 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e595c6sm10642847f8f.66.2025.06.30.06.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:00:22 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 03/29] mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs Date: Mon, 30 Jun 2025 14:59:44 +0200 Message-ID: <20250630130011.330477-4-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DJFZd-DC2zV7p9TrUvlwvf0ABCTiw6I2h85Au7B3Q5w_1751288424 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0512BC0017 X-Stat-Signature: 574a7swdycmo896aux1s1y9r3geq858n X-HE-Tag: 1751288427-833000 X-HE-Meta: U2FsdGVkX19PFe2/N1OSu5sV4F907YNHt3Zx98TgWrTS2Pggy2OjbuNjsrryqkMyqlQo51AkH3LKgUDOmOV27pamTX6xWLi+7BpVd6BA5FUbjHit5PgokVjKHTlz+JZOyqfuY7h+VhxQPh9JamALn9bMDPGVWbYJnlR3MqnA2EBEBqWkwPTkeiZMaHrqRsbOTlxmQEYupTXNs+ZpN/lgwVotDiEe03vNPIcfsV/PDbqLz8edpFID1XIa2SEFwrltZeSWnLaMtMXrxDDC80AKzQVgnzyGk8b14GRmH1bwPvn8XOIYeXIJOoWQx4r455c27WEha7zmCPTB4TuEeOXbXvgAJyvKhCgsevr+cChTKIkJbUGj4KTYqnTnWsZNns3HQ9IGpuLmA2uW789FI+FSrBywWqRbfWg1YylggXgt0krxYcqsZzRKW56BfWOqGNEbp4WHA5dQZ++073OYb218NIe7DcOdFQVDUU+FsQWVoY5kdJ/1Sp0kI2kGMQfRff8R8vkZ2HPScW6sP7PBLen/WGpxY//rGjVnu5BCblnyjbS9ukMd4mW30Cy+wsoQR6NO2beAV9yt5bNauRY8z67qcNL3NtzPueTbZ7rKMROhNMLsjjyCF2XvhQkavSx2hCwLYkEFZ9sXfOj8zGx/UjU8XpHIxvkMEWrOz7ZGxChOaCuaPm9VDJozr55tp3GnT23vvWokWyp3llWCtwPGr5MWjFnIkejV63bq84IEHsZ2c/xVxbcZwkZ8THDu+ZJ8hrJD+wA3bP5Q1rcnxMZQx1xRHOug8xQGNEEvAA4zbOqV4QdzegwvM4Duc+gzMSFN9c1Ybr44kkl2xJBU2DvZb7NQD0mmWsP4bp3k1q1DWcVyTDNjbevdGwrZsAmRpo+HOclWaJBF9rt87gAoNkoHzZeUK/FhjPi3ERKlSrX7uONATOHqIfDJ+7/2w7jE+voYoZQBSF/DJZD3Lgn/HXNhfQT dfsERI5q nuVMirqH2V8w9zb1ca2uazobtJalwuSIj6YYW0DNMUPE0l2HpCMjmNIugA1e/tJsNh7IRYD6SP60EnlZ4mVU7IxzxcLjFRyUEx1br/HWuvEEgGbwRkfdm8qcL6FLOYHeVy8PDtckHKjwm8v72e6l+TILFgnh/sijyWM4eyLT2rTQ4jSMoQKWBLbNpRHuVHVnML0hu/4Dxrnm4QPV+6v/eng+shq+bmwwaYTGhUtln3Xqj2bqgx6G1S/QNI6OtFGj1+ayQON8OhyKWMwVyBto/djuUexqiGMZybbfK/M5OaH+WyzIU6TTO2MbWcbrhA9A8HZg+261dLCtTU/iVKCy/nCcCQDjoyVkUdEi2iEE7v9HWpt1qHpow9Vr8oH/E83LCK6x5OgPRp/MuatgFmQAkddkOKvlLBOlb20dxuyDAfqWpeUTGRefT8VyPMXPqook6+ou9eyEMXYQOakTWXwXVDmmSnIbYD8rXohMyTRYmdosCwjgNgFKYsYhbHyhSTEyTfTOa//h3oml5OE2L2ApNrK2mE1LJmrfVGaqL2/nkv+oP3RJa5Zj7a92BuXQ1/XPOlWc/myFMGLrfCl6ouuWQvr0V38e2bKQ5DCt3P9fId15MtZRgMKTiZWzbUMJv2zRPIMLSltvavJbyqhfAJLXlH1Gpp5Cr65LN70qbCSkSQHwdBIQ/pHTNiBXzxdATlyy7uHqsa9DunkpVxrOoBgAyZKX42qJCADoa8iqk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's drop these checks; these are conditions the core migration code must make sure will hold either way, no need to double check. Acked-by: Zi Yan Reviewed-by: Sergey Senozhatsky Acked-by: Harry Yoo Signed-off-by: David Hildenbrand --- mm/zpdesc.h | 5 ----- mm/zsmalloc.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/mm/zpdesc.h b/mm/zpdesc.h index d3df316e5bb7b..5cb7e3de43952 100644 --- a/mm/zpdesc.h +++ b/mm/zpdesc.h @@ -168,11 +168,6 @@ static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) __ClearPageZsmalloc(zpdesc_page(zpdesc)); } -static inline bool zpdesc_is_isolated(struct zpdesc *zpdesc) -{ - return PageIsolated(zpdesc_page(zpdesc)); -} - static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) { return page_zone(zpdesc_page(zpdesc)); diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 999b513c7fdff..7f1431f2be98f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1719,8 +1719,6 @@ static bool zs_page_isolate(struct page *page, isolate_mode_t mode) * Page is locked so zspage couldn't be destroyed. For detail, look at * lock_zspage in free_zspage. */ - VM_BUG_ON_PAGE(PageIsolated(page), page); - return true; } @@ -1739,8 +1737,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, unsigned long old_obj, new_obj; unsigned int obj_idx; - VM_BUG_ON_PAGE(!zpdesc_is_isolated(zpdesc), zpdesc_page(zpdesc)); - /* The page is locked, so this pointer must remain valid */ zspage = get_zspage(zpdesc); pool = zspage->pool; @@ -1811,7 +1807,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, static void zs_page_putback(struct page *page) { - VM_BUG_ON_PAGE(!PageIsolated(page), page); } static const struct movable_operations zsmalloc_mops = { -- 2.49.0