From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B8CCC8302D for ; Mon, 30 Jun 2025 13:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93F906B00CA; Mon, 30 Jun 2025 09:01:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917B86B00CB; Mon, 30 Jun 2025 09:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82CE86B00CC; Mon, 30 Jun 2025 09:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72E916B00CA for ; Mon, 30 Jun 2025 09:01:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2FDFC1A0513 for ; Mon, 30 Jun 2025 13:01:51 +0000 (UTC) X-FDA: 83612079222.04.4855B93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 1576A40015 for ; Mon, 30 Jun 2025 13:01:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpCRsdjL; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288508; a=rsa-sha256; cv=none; b=VGP1CRpL2sSgBTlWgklp07YAFGH3LqCN9MZ3K+yfDXgDFsKeMocyJM0/sOsdWfb0ssebJn rCHyfA6Z1VH/VelwClQhk980kL7tWenPeVdbxK4IP0dthAmtNn/BFO+A3kZwuyYlZZ58oi DWRBAZlNqZBKlqWvuR6sj0RS4nss/nM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpCRsdjL; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=yGqE1gz1nSfuiiZRwLg6L+aSo9NLwtF1n/xxzfYx0H7TunW4NWFnOAvlfX4P6JgZHx+5ko gmO+mE2xxwWaeY1ma9NaScCRx2hmqIx3pUuygMtuOXqjCsM+vu0Pp8dZkfZJR8Bukm8UbO xbNuad8L+B0tGSOb8Kzu4ggw5MnrZwM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=EpCRsdjL688FjkLwDbNkJrCWC2P0TZq2eB1L5izz2A7Ggi/XmFlzoUIqwFKUVKzCTNz5Xx tNIX4I1xhrzVvaGbvf13Q+C+8ThXGBcExEPAxJIWzmQfTn5lWUiWQUx3TQZFTIISaeTQ7G Vuplc3SI4zH6gINkpCNmk4SZHR+Jzqk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-lQ3s2L7_NxC1Mf9chf0IAQ-1; Mon, 30 Jun 2025 09:01:40 -0400 X-MC-Unique: lQ3s2L7_NxC1Mf9chf0IAQ-1 X-Mimecast-MFC-AGG-ID: lQ3s2L7_NxC1Mf9chf0IAQ_1751288500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a6df0c67a6so1310266f8f.3 for ; Mon, 30 Jun 2025 06:01:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288499; x=1751893299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=oGopBYtifX4D3hl0CZ3D14Ime2twFDWM+H89ycUW6A6CYr1wJ12+z7iVTsjyDkCUYT 1aTgHSZmdD9KisLX9PHJZCM2PNUGsweODwCBgfwtgWrPRTQ5RLeOPUj6GSxehVwleF4q y8YPvjMyGYNENcaykpnGWvineQOWAxnJvO45u3n2kpSxd032CQuR1TXnZVAoje5RWAAF C5+Wq/xc8QRpWtF1vA63nfNgBq6QrVe3XJ3J78ELO+G+CJ/9+e6vxlz5fIIR+TvY3aaq wfHqp+9T84SJ/037BodghFmjsy0L2MjgHHYsA84w2msUglaG9aPlA3W6YtsWoGTNR/31 zy/g== X-Gm-Message-State: AOJu0YzALQmVDEIRrCdef+wPgkYlbz9Pd+VCVJMrhXSM3Sj+y2NFBK5H nmWh1sF406voACq6bo5RfgKCAfJxmJq2eH3YFfxe2HX3YKNI+YUGdHSSUc5HlOIL0ijSaF++uGU RAJaZPawPbewci7rnBJ/fPO6BYu+6UHPCvDbL+1KVdNlw9YtwV2sg X-Gm-Gg: ASbGncub+TPODy10kNSlZ8SAe1DQ7iUf66GuG78N1DYQY7tP5IpAPlu6KqStx1qdfQN JH5GR/4N2rOUXCcjYPFmJpM1UPQm9awgZq+jTtpn29K3k6fyyuhtk4u+uuNbwknNoYP5SHiVdrF SRjWGnL2upWwGEpmyP4SrtPqlz+D3LMRg+jT8F+MCI/b1GVZxFJ1kc0fJm0ZpNm7/v/03+Q79mv A/pL81aErUZ5tnUAw4nyBC/4bCaHY34+BERi6ZH6C07y+5YgLkjyQQtxNEG7ImvDucNUzsMV6/s wgftsFPy1Mda5HSaHqoS/j2SIQ6rW6Ec9pBpe+a4lzTcM7Mu5mpGzwKeyHn2UPkjZA51IFvEVkT pcP6nFq4= X-Received: by 2002:a5d:5849:0:b0:3a5:8934:4940 with SMTP id ffacd0b85a97d-3a8feb70269mr11468354f8f.50.1751288499120; Mon, 30 Jun 2025 06:01:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFU/EidvqQvGX4HPGBQwVJZ7hXZfY7F5Qe2rCBAm3bwMmXiBwrV5rV1e++rVLkevEN+RDkRKg== X-Received: by 2002:a5d:5849:0:b0:3a5:8934:4940 with SMTP id ffacd0b85a97d-3a8feb70269mr11468280f8f.50.1751288498410; Mon, 30 Jun 2025 06:01:38 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e5f92esm10485904f8f.90.2025.06.30.06.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:01:37 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 28/29] mm/balloon_compaction: "movable_ops" doc updates Date: Mon, 30 Jun 2025 15:00:09 +0200 Message-ID: <20250630130011.330477-29-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wXMGTNq39bzqX_G9lNCFmz3i7ReSIFaT3fQs8z8R4TQ_1751288500 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: 55e181uq5behqhzemm1rfkc7zg6uwmo4 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1576A40015 X-Rspam-User: X-HE-Tag: 1751288506-974947 X-HE-Meta: U2FsdGVkX19fKHK43/AETiONpobIQaxUvzrvEXe1MEYos7A0ZEiXDnOKUqLz3c8T3hCpO3kOpgYs7f4eUQAHyrAq68mccwXye1hAwbYvF94frDM75uyTJDmhk2xf2pwKMmKb9wTs+elWYgqKSHQEhWSCQq0KZKz4d/MmwAMwrU/HdNjw08e9O2qNaqg6knDjcSuniopWShKbWbZ9O1r2OP2WfxTlfEqGowbqipgOVsHAcDKckKpfvtHdBajnJTY5BqmFwGqAMnjnzbze9Q5vsuyB537Ty1oICizDxiZux3S95KiNT9KS0EhbXgS1u+K+qeGRbcD7PdObKeimurdwIdGSX1BWBsZsA09WUhs0l1JalqhmUYQIYAcv/lRiGs0LNlbw6n+ylnn8HOJdhAk7Yef9FmPdTY/deg/b22XvLXYFGM8FeMoc45bcHhQoBs//ptZGPArF56exIpNYCsgZABbT4Men9ea+g3PV5am16XoEsvDt5e6vlRF43FmTNsyLymuM+KOBTJj+nGcixk/I5iDld2GHA7C1E/HaZ6hLL1i/q4HFJR5szAGQvDFoXI3MskTb1Ed3g5O6vaI5I4NpWspQeAXLgl77Mo3HrKTLN1HjX4KRvI7jENmu8g0z0HSHNVg3FOsJartJzAQDv9Zs1USERSgygzHsTUlIF16gh2xMSmrNMe9ItJKRuWKDwHv3jIYjci/CQuf4qYgJG5lC8/0o/EO0Z+NHapzG/TOUmFnuXbEJH1/VhlU7qjreT0JKI6Umi04AO/iRf9mxkWBI5zQ8IuK1aEoZBZYn23+r+CaFml7D/eh2yB2D2LuxoRT9OGqE2tscl8It6A7uRcTU5eCJ8EjlvjC6gg6X0YXgLLVch40HSeLNYGEK3keUr+cFqfvq1cajVcsXwz8Y2Ct8fitt75a1MSNj2DQSRJoWBOCfV0tb/9leZNgECZp5dGf10VlLOXnlcmP6DP0fnWZ 1xylP9c2 lQ5+0yVP4XOO4JBTICj/MzX8jb0kVqnhNjHanF8GYVnx9jb6eUR16SAhRUF/cs5VYfuAbzp6PIkgcoZowncsMmvEVPcCQPpMmUEx/2EIP4SDSGujPPhSEYVvKbxeSi/FN2l/d7VJwNoTb9GuVf5jqXVChnHxYKB+3vkOqR5JTGPjTsdczLMe7ywCW6gel0pQDPpUZroJQm3t1i29OsIYgFES5L12S/E0KgRp6s0Mrw7M9sQnUYdzOExhY1BA42xNwBil/ECbcEXqikg9wZ+Q+oaaXxll13MJRv5Tt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's bring the docs up-to-date. Setting PG_movable_ops + page->private very likely still requires to be performed under documented locks: it's complicated. We will rework this in the future, as we will try avoiding using the page lock. Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index b222b0737c466..2fecfead91d26 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -4,12 +4,13 @@ * * Common interface definitions for making balloon pages movable by compaction. * - * Balloon page migration makes use of the general non-lru movable page + * Balloon page migration makes use of the general "movable_ops page migration" * feature. * * page->private is used to reference the responsible balloon device. - * page->mapping is used in context of non-lru page migration to reference - * the address space operations for page isolation/migration/compaction. + * That these pages have movable_ops, and which movable_ops apply, + * is derived from the page type (PageOffline()) combined with the + * PG_movable_ops flag (PageMovableOps()). * * As the page isolation scanning step a compaction thread does is a lockless * procedure (from a page standpoint), it might bring some racy situations while @@ -17,12 +18,10 @@ * and safely perform balloon's page compaction and migration we must, always, * ensure following these simple rules: * - * i. when updating a balloon's page ->mapping element, strictly do it under - * the following lock order, independently of the far superior - * locking scheme (lru_lock, balloon_lock): + * i. Setting the PG_movable_ops flag and page->private with the following + * lock order * +-page_lock(page); * +--spin_lock_irq(&b_dev_info->pages_lock); - * ... page->mapping updates here ... * * ii. isolation or dequeueing procedure must remove the page from balloon * device page list under b_dev_info->pages_lock. -- 2.49.0