From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F56BC7EE2A for ; Mon, 30 Jun 2025 04:51:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B27DD8D0009; Mon, 30 Jun 2025 00:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7998D0001; Mon, 30 Jun 2025 00:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6DA8D0009; Mon, 30 Jun 2025 00:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 88C908D0001 for ; Mon, 30 Jun 2025 00:51:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4927E140318 for ; Mon, 30 Jun 2025 04:51:43 +0000 (UTC) X-FDA: 83610844086.18.FCE639A Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [207.211.30.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 6EE13180003 for ; Mon, 30 Jun 2025 04:51:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=softfail (imf06.hostedemail.com: 207.211.30.44 is neither permitted nor denied by domain of airlied@gmail.com) smtp.mailfrom=airlied@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751259101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=giNRDi0lmpErqspvndI6T2TcyeyiPiFfxqqgbtDbHz4=; b=3YHGh6sZ8qSj3qX5CwwUdTlCEB02UiDhyKT9GPoHtAKM1HwcKUbJ5XPUb/zqiSCFwoKT4d auMoZyp9faCgLiKANex0QHxIFamAjG4DC9zdYVnDnihu8zBrXNvNTSCAtzq4bdw8lijq8P X7l2TU0KgBZ7RiG3e4EJMGwLIj13nwA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=softfail (imf06.hostedemail.com: 207.211.30.44 is neither permitted nor denied by domain of airlied@gmail.com) smtp.mailfrom=airlied@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751259101; a=rsa-sha256; cv=none; b=plwKCS2nBVkKrDXePapbyLbp3AxPidJ1ECpJPCqx5pejK71FNr/IpsVlaIeWMr08QMMhRo Cd2paIaj11vR9dsGfHAbqwaTbgLZond8gKlDdJT3e12ZcyYPphVcR1dfkGB2tJOLwH7LqE 9sI94eCyXgaLTenSD5GJkic1NLkxGKA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-rHOpLh1YNL2IDpUFXtRk7A-1; Mon, 30 Jun 2025 00:51:39 -0400 X-MC-Unique: rHOpLh1YNL2IDpUFXtRk7A-1 X-Mimecast-MFC-AGG-ID: rHOpLh1YNL2IDpUFXtRk7A_1751259097 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2D2C1808993; Mon, 30 Jun 2025 04:51:37 +0000 (UTC) Received: from dreadlord.redhat.com (unknown [10.67.24.96]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 94FD81956095; Mon, 30 Jun 2025 04:51:32 +0000 (UTC) From: Dave Airlie To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig Cc: Dave Chinner , Kairui Song , Dave Airlie Subject: [PATCH 11/17] ttm/pool: initialise the shrinker earlier Date: Mon, 30 Jun 2025 14:49:30 +1000 Message-ID: <20250630045005.1337339-12-airlied@gmail.com> In-Reply-To: <20250630045005.1337339-1-airlied@gmail.com> References: <20250630045005.1337339-1-airlied@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Y4vO4FxMOZJ67un1AghzuTdRXQqgp9xotVpYyD0KE-A_1751259097 X-Mimecast-Originator: gmail.com Content-Transfer-Encoding: quoted-printable content-type: text/plain; charset=WINDOWS-1252; x-default=true X-Stat-Signature: 7fg5xbmoxicoe557d1ggcrjpqndg7gt3 X-Rspamd-Queue-Id: 6EE13180003 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751259101-201796 X-HE-Meta: U2FsdGVkX1/IP8qmhkmtpTHXeId/1qQcVWMKDZWv8SfJQUY5gV8xG9N/AM4X2TVMjwfW5onzmcsPO16Dy0eelg1jvmp2nAcKoMsjqtqC4/GAQC0hQ8zdIgh2P5mer3/L0nqVLDo04DA1o4Ycgr9OsPbm/W5B1iGf+f+a8I9/aiPWPfcp1FxA9mxJGB3M4gaf3F50ABq3BlLlhMguHSUjE5HHghl7b8B80iLtxLBYM/0/Kxgu0/Ahdvbo06hyrVkk0bWHJid7OSuZxrbkcL3Lm556c0GHI8alf960QQv6j/yIZinDzAUigeswaQ/VULPBnnESIeES2uNpn40fg8Ucf2Y020eWckraVq56sewwTxjJHQf6HiFTUGkyBRVaUDzNW/xBTqqTUpgFLT5NoUZbMmoCYyU0zjt3jA1TLIymbDhs9kYO0PBFdDd9agx4d/2xvBOmTJQNzE0uz/0zSfALm9tl1O0jJ9vo2/3rLUTZuHaIfF353euvR/1cUpLQEU3oxCS31GPfzCBeukgOQgi2Q6Cwcy5YTOIibmDwt7wVVOQX5Ee5g5M93h873Sm1EhjfYgqj0Hh9tAXllnVTVbb708TX4cJe7jYT+9b6PNLkTi+gIvHMpqIzgzbFPt2g2Qf89PbhxGrsKVr8wfff2+fq0Cg9QGi0Ljy7WGVCKaMiUd1sXBqEelCZMXQjddZKj50EtPX0GsUzSx/XpdOqlGQjq7d/XN0QfKFqVXjjHjJVBoqVsxDEEAiMd4VHuTSt3J+Vg5QBSUyzBPeuecRo+GUCh+OIsl6PW8ewGiRzP0+MSv/an1LNoiRZAcNf1Ob8zkwSxKqLSOZoK9cyU3k3x98pyk7Y7c0IU5RhxbrEmwjDxzjWzEhsvmayiGrZ2N7l/lo28klZTZKuI6+rbhawEac5xU5lDsYr9eFBU+SLMk8T4Or8zCGN2YDCt0kgwkG/EQRk7wN8lLbZf1wQp0fJv0G BNsGTIqs 2z1RjLjQ9DVsVSgOitQ7qmpMI9OcNwneyiUVVIsrinknriTUtLQ5oCj8GcJFmhxREmtW/6we6YJ7z4C0qvQyozfBwRxeQ5Oo/hqlNAs/3DvTlE3pATdJMOmrBAfYcQT1Xvz4n3wE027I4C+4icfFCDZKm42lmiO9F013pjpv2olGzwPMWvdDxdR1TSNmM/NASpqnxO9Q/qWAkfEdZ1q/BxMsemwxR2iv9pkrt0E8k7NPKBXIk14S7OHg8Ep6HjgKeVoBjLUjsr4d/mYjKy40VXw1d+wjOWI7F0hoaH4rom0foxpuJ9PcWLZ8qO2ogYzKHVzOXPp1kyEB9t+9QchjSg4m3iBh4Q/OXzDcRYPOZwj2FZ91302Zd6njRrl0N5RDkOb1wB6Qb169Ma/PIHuUvXXpuaP+LAtA3BdPkjA+mwaKZEI0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Dave Airlie Later memcg enablement needs the shrinker initialised before the list lru, Just move it for now. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_pool.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.= c index 0526900366e5..210f4ac4de67 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1388,6 +1388,17 @@ int ttm_pool_mgr_init(unsigned long num_pages) =09spin_lock_init(&shrinker_lock); =09INIT_LIST_HEAD(&shrinker_list); =20 +=09mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); +=09if (!mm_shrinker) +=09=09return -ENOMEM; + +=09mm_shrinker->count_objects =3D ttm_pool_shrinker_count; +=09mm_shrinker->scan_objects =3D ttm_pool_shrinker_scan; +=09mm_shrinker->batch =3D TTM_SHRINKER_BATCH; +=09mm_shrinker->seeks =3D 1; + +=09shrinker_register(mm_shrinker); + =09for (i =3D 0; i < NR_PAGE_ORDERS; ++i) { =09=09ttm_pool_type_init(&global_write_combined[i], NULL, =09=09=09=09 ttm_write_combined, i); @@ -1410,17 +1421,6 @@ int ttm_pool_mgr_init(unsigned long num_pages) #endif #endif =20 -=09mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); -=09if (!mm_shrinker) -=09=09return -ENOMEM; - -=09mm_shrinker->count_objects =3D ttm_pool_shrinker_count; -=09mm_shrinker->scan_objects =3D ttm_pool_shrinker_scan; -=09mm_shrinker->batch =3D TTM_SHRINKER_BATCH; -=09mm_shrinker->seeks =3D 1; - -=09shrinker_register(mm_shrinker); - =09return 0; } =20 --=20 2.49.0