From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 988A4C7EE30 for ; Sun, 29 Jun 2025 23:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7C876B008C; Sun, 29 Jun 2025 19:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D7C6B0093; Sun, 29 Jun 2025 19:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43386B0095; Sun, 29 Jun 2025 19:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C02456B008C for ; Sun, 29 Jun 2025 19:17:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B92AA58232 for ; Sun, 29 Jun 2025 23:17:00 +0000 (UTC) X-FDA: 83610000600.12.3AEC7A7 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf06.hostedemail.com (Postfix) with ESMTP id B3F71180004 for ; Sun, 29 Jun 2025 23:16:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="TFAY2o/I"; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751239018; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kALrTDBo8YeEwW0KkVu6Bm3OeB7IvDGQQSLJ58v0dDo=; b=LvygHyAMhl6Jho9fPYL4ScAZR9uUucv2aurayFasJ4efRc0BMm59eDn2LP3W2RpyZzEue4 ms3ITXS2YN3WLeMlvN9o+QJGiGrxyQUZiJj+1Nu+Nsds0m4lNvbSG3aFKpTInYHdumcUl0 H3OYOFOqk5xycmRTpa5/08fPCrPLKZM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="TFAY2o/I"; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751239018; a=rsa-sha256; cv=none; b=Q8gFSqpx6ZLspxXs7zFRsKLr744T3pPnHmW4QEYsLi9E7ZWoyisjoJhGO1NEXBUTt8hgDG o8VF8LnrOU0tlFCm2/9VJ98oQs3QBUQD+DrDeFNmOttfhzFWOpfWpeC5Xel+7HqldsX5eT 05IJdDQ99OfgiBgz6AzeiMIv/dlLWVU= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-adfb562266cso637564766b.0 for ; Sun, 29 Jun 2025 16:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751239017; x=1751843817; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kALrTDBo8YeEwW0KkVu6Bm3OeB7IvDGQQSLJ58v0dDo=; b=TFAY2o/I1hp24sNXg+X/2F5Esyz3VCsNqOIHSlQjQEjTIRfTJs5cVKqR08U3oT/1bW jjSSiJ7go+zZ/4mQ14XGi2ACaxESjtNJOjkNjTpoYMV22M6y6jnxhJljMZh8K/XE095g qQjCmIBhHBTbkWOA9DQtnQl3cZy59vKTwQ8Ofy7apZjtE+5pT/cr6T3tS6DevJtMxtJA qxK+fiv5eMzNFU7e08BFGj/n9sYd87wDnzn4/gGqs4xns7tshtLoxl5r0ybDrQ4zVzoY uIiXzBJQoQWPdaJFcw4rAxHCgv06V2E5lJojuKjBNpB+79atEvhYd6c0+Sb+ITUGe6NF ScBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751239017; x=1751843817; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kALrTDBo8YeEwW0KkVu6Bm3OeB7IvDGQQSLJ58v0dDo=; b=LAmGAJKLyKfPApiWoOXDD9VP80RrBWqAoKoEKuJ5sCXbcitx4yqKhhr2GTwa5jtCJq 431AeGiKa4I862B7i4G+yhCyff8hx6xFizOEAZd04nGlY2235O/3aZo0fqq4xvUj44q5 XbFxoDYIn4q6+CcpASfBVcd9v3IXTxpjDTvgrbNNvvqvvWK6zgi3z9KAReHtDeYhjONe mMBuz9mtnro6bwh8ZMibhcrS/vsZJVXWbq/M5/x97wcneHUwdRo6jmLnQyokqC7UoA3C WyTNeEWYogvXe2RxGAZojTFxi3xcsXmDP00VJmbfBVCcVzUrQBaK0xarHsZHF2VTnpJR i1Cg== X-Forwarded-Encrypted: i=1; AJvYcCXEyw2uC1rXp9aLVo14mjt6gYoRoHz+2OdPAnNlBLExclgnCA3nrZUFcR9bSCu8/9xgKQkANHMzbA==@kvack.org X-Gm-Message-State: AOJu0YwX8PMfSg0cBPzbMU+P/QVX4OtXp9h/hI+iQgAkDQczHoaT02Ic dMSKcxYiiA2IEgQn9A5umLpw2tsFN79PSrawKK5mgc9zDvwOhnYdfZ6f X-Gm-Gg: ASbGnctx1hX3lfvlqa3ireFDPbXIWsLFo39O01/xE8txy22myGBDble/1ooP2RJZxaj JZ1sGFhcxgMuV8t8xG6MxSJiUX5plrx6X2d5jtWo0s86I23Na76HnTmo36XsGh8Hex2igk5sg89 EtoQYx7gYFyztA06uzIX3emNDClLZgw98vZg9GfTu572UQFafKPiWtO7on+6jWXPjIY9g23WCCI 4V/Y25FCng+snBYsq7/0kM5HatyQpuGMQPbXAyhC5e+cURsFezaVOPMc1u/tHHbAQPgceDxq8wn 5XdAOkVicF+BnxRFRgWLVXt86+Rbkd1nixPhIsyUtAiVj2oNYLR+nbF/BwdQmw== X-Google-Smtp-Source: AGHT+IHL0PEhHhgGy3McRpzy+oEsHDxMILZecgX569B7Y0zoYT9MeEa6msfcawxFu+XQXNXUv6qItg== X-Received: by 2002:a17:907:6d17:b0:ae0:d73e:eea0 with SMTP id a640c23a62f3a-ae34fd13222mr1030763566b.12.1751239016899; Sun, 29 Jun 2025 16:16:56 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae35363b0f9sm560998366b.5.2025.06.29.16.16.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jun 2025 16:16:56 -0700 (PDT) Date: Sun, 29 Jun 2025 23:16:55 +0000 From: Wei Yang To: Dev Jain Cc: "Liam R. Howlett" , akpm@linux-foundation.org, richard.weiyang@gmail.com, maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] maple tree: Add and fix some comments Message-ID: <20250629231655.4qyiututsi4vutsx@master> Reply-To: Wei Yang References: <20250626171918.17261-1-dev.jain@arm.com> <20250626171918.17261-2-dev.jain@arm.com> <2d55c06a-f4a5-4728-b692-60d88a5fe692@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d55c06a-f4a5-4728-b692-60d88a5fe692@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B3F71180004 X-Stat-Signature: i8aopcnhxipt8gpcj15ipakdcfpw76td X-HE-Tag: 1751239018-355771 X-HE-Meta: U2FsdGVkX1/DwDXpGR7O/WKkExm4TyeJhcR6yz/zACgJ4okXyxdAeEbKnlG7kK9a488ROd4Zls5Mt6mCAxjmcIk5Te+QmX9eG7+UzkytfEeEgCl/j+HgZlHtmSO9Xw7KCd6rdSTQqDwjZDCV80H+nk7VzYJ0tdPNzxfkMxBDmFDN/nKhL55S8Cy7tvqxBsMUH6nKt4F9WcG0NkEKg5RX0ef7x9CzWoJYLBzIj+Art7+nvJk1i1Fu0eipDwyJoPz7JmkSMeNv4o63maF+iq0hONnlyWtGG5IlpxsqJ5i2zpiWJNrOPzWdGiOsQ7W757m8JQkhfPvx8DMZsOhkwS51KnQFgDDGodsGx3tgM+fPN8jFPKW1YGkTi2F81bZBxgtdspmH0O+fwOfXn6gxcC3MYAlBI8I6axcdxxMNO0h4a4A43WkXT02oCWDrhdu7GggXbwdEgedl9VBZOvleG3yyxk9eixXzXTy3ZaoOmpc4OjGozD1oiZZP5OYc72nZ7EhBdshPi33jlSsrEleuycyYNmyasOktl4EMkjiFq9M3LFjlzAPJ/kJP4yp1UV7A+Be/JMGuvhuGmlgw7ZVPwIUtrguSxP2Wb7jGvz1mESJUReo5QbtkSShrcb/rkiLzaDU3H8ja5ED9S+ltLS4I8q58kOSipr5FM9V5cEcfFEpWnAFOwrtwqE0EVl7LpbXXZo347w12esCK4owz9lqRX2aYWCpdpAKjT7wdseLl8DlEgvz4BN3k5nxiGv7ZaKb46gvECzbnQRZiJm+kffwTHvI0Z5s1gyOHyy3wcE9rjVC3N6aSlDoB5Dmrpz3QFeLcKSl896J+kV7XHu+oB8IDcasu8vNUkIyWbIV5k3JeY28ngde9PEg0mysUDBX5vQWd4pr5RONyH9oHsm5oevQkpvV8QN8BVndBge5m9mOQ59tVGZsLyFO/nphMk6xFjFx6yIl42V7+xxu5+1ZXgkOjW4T HSq3MTCV ENMWe60dUJCHyCzaxkZoRcU+kml/R2lS0bu/lEcZbJ89wZsAWV4QQ72sZm/yvvhEBoHz6iDIkN0+TsA/G2nZRjnmb+cvL4SpIFD5sKxqrlbMJdnfM22+dtYMF4ZP9WluBj8ov8JGRGs2Nw9As2G0AWAn2c9O4nc3V1WPBG7F7S3su3IqhxDs67yeLte+Bw7l9ANyOq2e5ZgmRPcSPQhYrqYicdw+8N4Mi7+wymvYddBuQ2xL4tzKT6mIhAgcqNvlH4PaSS3uJu7tMt8bvFd6UexRTUyLsES5QHrBaRqssVRcwfG5tgVgOsopHy0yiiHyIfN3hVI5iYjGY9Tq5QkBaAVLTMregqplizuKe3Hl4wbPy1qD5wE4lyKMwxg/XkCIY4KveGh9ux+BD+G3tGEL8Db9wvjzC6PtcjrtUpvBXegbYCvmY07+/y+RQ1ia22ZdXjDqp20g/cqCGIsM/YuuAwp+fRcm7EDJN1DwCXl6cxz6X/CF5HieykRzEK4byzpwCLB1X0qmHtZOeXaQ9W8vnhC3jx4ambGtuuXzga/yYObL2At8g4pc9rRH3hO9/URZSezTdVEfSWo43CdaJ0dzM5FI871JvLeepnYk35z3PEiV06x6lEoRMiya5fP24nWVToOnw/Dn8oaoj8wiwZGq8yPCq5uLDg1SaEOED7eCdrLlIYWwiJAsMfQ4xVnfddFpBXviT68LQcKckLlqR2PbucbOUz7XpemoN9WYOeQyt1frR9mHjAP2JUo/CMTvHMHLJ/CbRJ1CXa/Z5n0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 28, 2025 at 05:26:18PM +0530, Dev Jain wrote: > >On 27/06/25 1:34 am, Liam R. Howlett wrote: >> * Dev Jain [250626 13:19]: >> > Add comments explaining the fields for maple_metadata, since "end" is >> > ambiguous and "gap" can be confused as the largest gap, whereas it >> > is actually the offset of the largest gap. >> > >> > MAPLE_ROOT_NODE is used for mt_mk_root() and mt_safe_root(), indicating >> > that it is used to mark the node as root. So fix the comment. >> That's not quite the entire story here. >> >> The first pointer in the tree may not be a node at all, and may be an >> entry. So having that bit set tells us the root of the tree is a node, >> so the comment is correct but maybe you have a better way of expressing >> this information? > >Hmm. Can you please correct me on my understanding - when we have an >empty tree, then we insert a root and can store a value there. Now when >we store the second entry, we allocate a node and make the root a node, >the root points to that node, and we store the values at offsets 0 and 1. > Per my understanding, generally it is correct. You may take a look at tools/testing/radix-tree/maple.c and use mt_dump() to see how the tree changes. >I am reading more to answer my own question. > -- Wei Yang Help you, Help me